[GitHub] [dubbo] Johnson-Jia commented on issue #11310: Dubbo3.1.2经常找不到服务的提供者

Johnson-Jia commented on issue #11310: URL: https://github.com/apache/dubbo/issues/11310#issuecomment-1385025919 使用k8s 容器，内部启动docker服务， 生产者重启后ip变成新的了， 但是消费者还是使用旧的生产者ip连接，造成找不到生产者。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [dubbo-go] ZLBer commented on issue #2178: 不支持 version+group 调用

ZLBer commented on issue #2178: URL: https://github.com/apache/dubbo-go/issues/2178#issuecomment-1385034237 @CodingAdai hi,我这边跑了dubbo-go-samples里的一个例子，发现是可以用group+version进行调用的，具体地址在：https://github.com/apache/dubbo-go-samples/tree/master/rpc/dubbo java服务端的配置： https://user-images.

[GitHub] [dubbo] marcingrzejszczak commented on pull request #11021: Added support for Micrometer Observation API

marcingrzejszczak commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1385038819 Yup, I will, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071927912 ## dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/observation/ObservationSenderFilterTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071941307 ## dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter: ## @@ -0,0 +1,2 @@ +observationreceive

[GitHub] [dubbo-go] justxuewei commented on pull request #2186: Support Servicemapping Listener

justxuewei commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1385100857 Hi @bobtthp, thanks for your contribution! Please rebase the latest 3.0 branch before this pull request steps forward. -- This is an automated message from the Apache Git Service. T

[GitHub] [dubbo] schneiderlin commented on issue #11311: support register custom metadata

schneiderlin commented on issue #11311: URL: https://github.com/apache/dubbo/issues/11311#issuecomment-1385189271 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [dubbo] schneiderlin closed issue #11311: support register custom metadata

schneiderlin closed issue #11311: support register custom metadata URL: https://github.com/apache/dubbo/issues/11311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [dubbo-go] binbin0325 commented on a diff in pull request #2186: Support Servicemapping Listener

binbin0325 commented on code in PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#discussion_r1072095040 ## registry/event/service_mapping_change_listener_impl.go: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] [dubbo-go] mark4z commented on issue #2176: the msg size of provider is invalid

mark4z commented on issue #2176: URL: https://github.com/apache/dubbo-go/issues/2176#issuecomment-1385465053 provider和consumer必须都做对应配置，参考以下配置： Provider: dubbo: provider: services: # you may refer to `Reference()` method defined in `protobuf/triple/helloworl

[GitHub] [dubbo] AlbumenJ opened a new pull request, #11319: Make xds router run

AlbumenJ opened a new pull request, #11319: URL: https://github.com/apache/dubbo/pull/11319 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.c

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11319: Make xds router run

sonarcloud[bot] commented on PR #11319: URL: https://github.com/apache/dubbo/pull/11319#issuecomment-1385536892 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gat

[GitHub] [dubbo] gsralex opened a new pull request, #11320: Added metrics for avg response time (#11278)

gsralex opened a new pull request, #11320: URL: https://github.com/apache/dubbo/pull/11320 ## What is the purpose of the change https://github.com/apache/dubbo/issues/11278 ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure

[GitHub] [dubbo-go] berndverst commented on pull request #2181: [`dapr-support` Branch] Security: Address CVE by using `google/uuid` instead

berndverst commented on PR #2181: URL: https://github.com/apache/dubbo-go/pull/2181#issuecomment-1385994340 @AlexStocks do you know anyone who can get this approved and merged? This is a quick fix to address a CVE. I'm one of the maintainers of Dapr (github.com/dapr) who uses th

[GitHub] [dubbo] songxiaosheng commented on pull request #11320: Added metrics for avg response time (#11278)

songxiaosheng commented on PR #11320: URL: https://github.com/apache/dubbo/pull/11320#issuecomment-1386333618 平均值可能会有误差，是否可以改成直方图的形式将时间分段之后再平均 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [dubbo] fomeiherz opened a new issue, #11321: Add metrics naming convention

fomeiherz opened a new issue, #11321: URL: https://github.com/apache/dubbo/issues/11321 ## Describe the proposal [Prometheus naming](https://prometheus.io/docs/practices/naming/) ### Step 1: add [base-units](https://prometheus.io/docs/practices/naming/#base-units) - Time: su

[GitHub] [dubbo] songxiaosheng commented on issue #11321: Add metrics naming convention

songxiaosheng commented on issue #11321: URL: https://github.com/apache/dubbo/issues/11321#issuecomment-1386351610 It can be distinguished between the lower dubbo buried point specification and the Prometheus buried point specification, such as the second -- This is an automated message f

[GitHub] [dubbo] fomeiherz commented on issue #11321: Add metrics naming convention for prometheus

fomeiherz commented on issue #11321: URL: https://github.com/apache/dubbo/issues/11321#issuecomment-1386355215 I change title "for prometheus". 我修改了标题加上了 prometheus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [dubbo] jojocodeX commented on issue #11321: Add metrics naming convention for prometheus

jojocodeX commented on issue #11321: URL: https://github.com/apache/dubbo/issues/11321#issuecomment-1386381922 可以区分下场景，比如dubbo.registry. , dubbo.thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [dubbo] AlbumenJ merged pull request #11319: Make xds router run

AlbumenJ merged PR #11319: URL: https://github.com/apache/dubbo/pull/11319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

[GitHub] [dubbo] CrazyHZM closed issue #11124: 运行mvn clean install报错了

CrazyHZM closed issue #11124: 运行mvn clean install报错了 URL: https://github.com/apache/dubbo/issues/11124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: n

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11319: Make xds router run

sonarcloud[bot] commented on PR #11319: URL: https://github.com/apache/dubbo/pull/11319#issuecomment-1386434179 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gat

[GitHub] [dubbo-go] AlexStocks commented on pull request #2181: [`dapr-support` Branch] Security: Address CVE by using `google/uuid` instead

AlexStocks commented on PR #2181: URL: https://github.com/apache/dubbo-go/pull/2181#issuecomment-1386442470 > @AlexStocks do you know anyone who can get this approved and merged? > > This is a quick fix to address a CVE. > > I'm one of the maintainers of Dapr (github.com/dapr) w

[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #489: add application-level service discovery generic call's README

AlexStocks commented on code in PR #489: URL: https://github.com/apache/dubbo-go-samples/pull/489#discussion_r1073069003 ## generic/README.md: ## @@ -50,3 +50,47 @@ Using command line tool. The `$ProjectRootDir` is the root directory of the dubb cd $ProjectRootDir/generic/defa

[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #489: add application-level service discovery generic call's README

AlexStocks commented on code in PR #489: URL: https://github.com/apache/dubbo-go-samples/pull/489#discussion_r1073069140 ## generic/README.md: ## @@ -50,3 +50,47 @@ Using command line tool. The `$ProjectRootDir` is the root directory of the dubb cd $ProjectRootDir/generic/defa

[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #489: add application-level service discovery generic call's README

AlexStocks commented on code in PR #489: URL: https://github.com/apache/dubbo-go-samples/pull/489#discussion_r1073069226 ## generic/README.md: ## @@ -50,3 +50,47 @@ Using command line tool. The `$ProjectRootDir` is the root directory of the dubb cd $ProjectRootDir/generic/defa

[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #489: add application-level service discovery generic call's README

AlexStocks commented on code in PR #489: URL: https://github.com/apache/dubbo-go-samples/pull/489#discussion_r1073069226 ## generic/README.md: ## @@ -50,3 +50,47 @@ Using command line tool. The `$ProjectRootDir` is the root directory of the dubb cd $ProjectRootDir/generic/defa

[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #489: add application-level service discovery generic call's README

AlexStocks commented on code in PR #489: URL: https://github.com/apache/dubbo-go-samples/pull/489#discussion_r1073069486 ## generic/README_zh.md: ## @@ -50,3 +50,47 @@ cd $ProjectRootDir/generic/default/go-server/cmd \ cd $ProjectRootDir/generic/default/go-client/cmd \ && go

[GitHub] [dubbo] fomeiherz commented on issue #11321: Add metrics naming convention for prometheus

fomeiherz commented on issue #11321: URL: https://github.com/apache/dubbo/issues/11321#issuecomment-1386448008 > 可以区分下场景，比如dubbo.registry. , dubbo.thread. dubbo.thread 这个使用在哪个场景？我补充到文档上 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [dubbo] jojocodeX opened a new pull request, #11322: metrics 修复普通指标和聚合指标key重复

jojocodeX opened a new pull request, #11322: URL: https://github.com/apache/dubbo/pull/11322 修复普通指标和聚合指标key重复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [dubbo-go] AlexStocks commented on pull request #2181: [`dapr-support` Branch] Security: Address CVE by using `google/uuid` instead

AlexStocks commented on PR #2181: URL: https://github.com/apache/dubbo-go/pull/2181#issuecomment-1386467216 > @AlexStocks do you know anyone who can get this approved and merged? > > This is a quick fix to address a CVE. > > I'm one of the maintainers of Dapr (github.com/dapr) w

[GitHub] [dubbo-go] AlexStocks merged pull request #2181: [`dapr-support` Branch] Security: Address CVE by using `google/uuid` instead

AlexStocks merged PR #2181: URL: https://github.com/apache/dubbo-go/pull/2181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [dubbo-go-samples] justxuewei commented on pull request #489: add application-level service discovery generic call's README

justxuewei commented on PR #489: URL: https://github.com/apache/dubbo-go-samples/pull/489#issuecomment-1386471943 Lgtm, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [dubbo] fomeiherz commented on issue #11296: Change the type of metrics(dubbo.provider.requests.xxx) to counter.

fomeiherz commented on issue #11296: URL: https://github.com/apache/dubbo/issues/11296#issuecomment-1386485875 尝试新增一个 CounterMetricSample，然后修改类 AbstractMetricsReporter#scheduleMetricsCollectorSyncJob() 方法时，发现 `COUNTER` 类型无法设置值进去，因为 io.micrometer.core.instrument.Counter 并没有直接设置值的方法，只有 increm

[GitHub] [dubbo] jojocodeX commented on issue #11321: Add metrics naming convention for prometheus

jojocodeX commented on issue #11321: URL: https://github.com/apache/dubbo/issues/11321#issuecomment-1386524727 > 可以区分下场景，比如dubbo.registry. , dubbo.thread. > I change title "for prometheus". > > 我修改了标题加上了 prometheus > > 可以区分下场景，比如dubbo.registry. , dubbo.thr

[GitHub] [dubbo] AlbumenJ opened a new pull request, #11323: Skip mapping retry if metadata config is invalid

AlbumenJ opened a new pull request, #11323: URL: https://github.com/apache/dubbo/pull/11323 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.c

[GitHub] [dubbo] hebrd commented on issue #11310: Dubbo3.1.2经常找不到服务的提供者

hebrd commented on issue #11310: URL: https://github.com/apache/dubbo/issues/11310#issuecomment-1386559633 猜测是开启了推空保护引起的，可尝试关闭推空保护，具体查看[文档](https://www.bookstack.cn/read/dubbo-3.1-zh/4a2641af52b3c42f.md#5.%20%E9%BB%98%E8%AE%A4%E5%85%B3%E9%97%AD%E6%8E%A8%E7%A9%BA%E4%BF%9D%E6%8A%A4) -- This

[GitHub] [dubbo] schneiderlin opened a new pull request, #11324: don't delete lock file when lock is held by other

schneiderlin opened a new pull request, #11324: URL: https://github.com/apache/dubbo/pull/11324 ## What is the purpose of the change when two servers started on the same machine. the first one can acquire the lock, and the second one failed. but when the second server shutdown, the loc

[GitHub] [dubbo] wxbty commented on issue #11146: Observability task: registration center related index data improvement investigation and improvement（可观测性任务注册中心相关指标数据完善调研与完善)

wxbty commented on issue #11146: URL: https://github.com/apache/dubbo/issues/11146#issuecomment-1386582608 Referring to Google's 4 golden indicators, for the registration center, I think the following indicators are needed. - dubbo_registry_duration_seconds Interaction delay, int

[GitHub] [dubbo] songxiaosheng commented on issue #11146: Observability task: registration center related index data improvement investigation and improvement（可观测性任务注册中心相关指标数据完善调研与完善)

songxiaosheng commented on issue #11146: URL: https://github.com/apache/dubbo/issues/11146#issuecomment-1386622070 可以的，正常的服务订阅，服务注册，接收通知，查询服务几个场景 指标类型可以处理下次数，耗时，错误次数 另外可以还有服务迁移过程显示的服务注册类型看看是否可以显示出来当前接口的服务注册类型比如当前是应用级别注册还是接口级别，订阅者当前是接口级别还是应用级别比较有利于观察dubbo升级迁移过程 -- This is an automate