[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-18 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1073552298 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/DefaultDubboServerObservationConvention.java: ## @@ -0,0 +1,45 @@ +/* + *

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-18 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1073549865 ## dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter: ## @@ -0,0 +1,2 @@

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-17 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071941307 ## dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter: ## @@ -0,0 +1,2 @@

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-17 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071927912 ## dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/observation/ObservationSenderFilterTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-13 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1070206904 ## dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter: ## @@ -0,0 +1,2 @@

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-11 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1066901359 ## dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter: ## @@ -0,0 +1,2 @@

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-10 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1066569087 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/ObservationSenderFilter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-10 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1066536270 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/ObservationSenderFilter.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-10 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1064138275 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/DefaultDubboServerObservationConvention.java: ## @@ -0,0 +1,45 @@ +/* + *