Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-26 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1540516941 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-26 Thread via GitHub
walklown closed pull request #1110: Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 URL: https://github.com/apache/dubbo-samples/pull/1110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-24 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1537001318 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-24 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536997259 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-24 Thread via GitHub
chickenlj commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536772943 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-22 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535259906 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-22 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535252138 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-22 Thread via GitHub
chickenlj commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1535240050 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-22 Thread via GitHub
walklown closed pull request #1096: bump apache parent to 31, jdk to 17 and springboot to 3.2.3 URL: https://github.com/apache/dubbo-samples/pull/1096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-22 Thread via GitHub
walklown commented on PR #1096: URL: https://github.com/apache/dubbo-samples/pull/1096#issuecomment-2014526037 > 117 file changes included, there must have some thing wrong withi this pull request, please submit a new one. OK -- This is an automated message from the Apache Git Serv

Re: [PR] bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-22 Thread via GitHub
chickenlj commented on PR #1096: URL: https://github.com/apache/dubbo-samples/pull/1096#issuecomment-2014516132 117 file changes included, there must have some thing wrong withi this pull request, please submit a new one. -- This is an automated message from the Apache Git Service. To res

Re: [PR] bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-21 Thread via GitHub
walklown commented on PR #1096: URL: https://github.com/apache/dubbo-samples/pull/1096#issuecomment-2011739395 Thanks for @chickenlj 's help ! All test cases have passed, and I have rolled back the conflicting changes. -- This is an automated message from the Apache Git Service. To respon