Re: [PR] Fix netty memory leak [dubbo]

2024-05-07 Thread via GitHub
AlbumenJ merged PR #14127: URL: https://github.com/apache/dubbo/pull/14127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dub

Re: [PR] Fix netty memory leak [dubbo]

2024-05-07 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2099690812 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix netty memory leak [dubbo]

2024-05-07 Thread via GitHub
AlbumenJ commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2099664657 @finefuture Please ping me once all the test cases pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Fix netty memory leak [dubbo]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2097379931 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix netty memory leak [dubbo]

2024-04-30 Thread via GitHub
finefuture commented on code in PR #14127: URL: https://github.com/apache/dubbo/pull/14127#discussion_r1584753409 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java: ## @@ -164,7 +165,7 @@ protected vo

Re: [PR] Fix netty memory leak [dubbo]

2024-04-29 Thread via GitHub
oxsean commented on code in PR #14127: URL: https://github.com/apache/dubbo/pull/14127#discussion_r1583086955 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http2/GenericHttp2ServerTransportListener.java: ## @@ -164,7 +165,7 @@ protected void o

Re: [PR] Fix netty memory leak [dubbo]

2024-04-29 Thread via GitHub
oxsean commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2082719092 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix netty memory leak [dubbo]

2024-04-27 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2080846921 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix netty memory leak [dubbo]

2024-04-27 Thread via GitHub
finefuture commented on code in PR #14127: URL: https://github.com/apache/dubbo/pull/14127#discussion_r1581838112 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java: ## @@ -82,6 +83,15 @@ protected Ht

Re: [PR] Fix netty memory leak [dubbo]

2024-04-27 Thread via GitHub
finefuture commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2080751859 ![image](https://github.com/apache/dubbo/assets/18413695/6b409c31-329d-40b9-a201-c151513c3a78) Failure to close the decoder when using the grpc protocol causes netty memory leaks. T

Re: [PR] Fix netty memory leak [dubbo]

2024-04-27 Thread via GitHub
finefuture commented on code in PR #14127: URL: https://github.com/apache/dubbo/pull/14127#discussion_r1581836609 ## dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpOutputMessage.java: ## @@ -29,6 +29,11 @@ public interface HttpOutputMessa

Re: [PR] Fix netty memory leak [dubbo]

2024-04-24 Thread via GitHub
oxsean commented on code in PR #14127: URL: https://github.com/apache/dubbo/pull/14127#discussion_r1577996697 ## dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/HttpOutputMessage.java: ## @@ -29,6 +29,11 @@ public interface HttpOutputMessage {

Re: [PR] Fix netty memory leak [dubbo]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074480062 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix netty memory leak [dubbo]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074424326 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Fix netty memory leak [dubbo]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #14127: URL: https://github.com/apache/dubbo/pull/14127#issuecomment-2074379860 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo