[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015245978 ## modules/api/pom.xml: ## @@ -46,8 +46,8 @@ test - org.slf4j - slf4j-log4j12 + org.apache.logging.log4j + log4j-slf4j2-impl R

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015690500 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range; imp

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015794843 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range;

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015795999 ## modules/distribution/src/main/config/log4j2.properties: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor lice

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015797320 ## modules/distribution/src/main/config/fluo-env.sh: ## @@ -37,7 +37,7 @@ export FLUO_TMP="${FLUO_TMP:-/tmp}" ## Fluo log4j configuration export FLUO_LOG4J_CONFIG="

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015798556 ## modules/integration-tests/pom.xml: ## @@ -77,6 +77,19 @@ org.apache.hadoop hadoop-client-api + + + org.apache.logging.log4j +

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015798556 ## modules/integration-tests/pom.xml: ## @@ -77,6 +77,19 @@ org.apache.hadoop hadoop-client-api + + + org.apache.logging.log4j +

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015801943 ## pom.xml: ## @@ -384,7 +391,7 @@ true -log4j:log4j:jar:* + org.apache.logging.log4j:*

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015800584 ## .github/workflows/maven.yaml: ## @@ -48,7 +48,7 @@ jobs: key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} restore-keys: ${{ runner.os }}-m

[GitHub] [fluo] keith-turner commented on pull request #1122: Get fluo building and running against Accumulo 2.1.0

keith-turner commented on PR #1122: URL: https://github.com/apache/fluo/pull/1122#issuecomment-1306067921 > except I noticed the accumulo2-maven-plugin seems to want log4j1.2. @ctubbsii this is not something I noticed. What did you see that made you notice this? Is it causing any p

[GitHub] [fluo] ctubbsii commented on pull request #1122: Get fluo building and running against Accumulo 2.1.0

ctubbsii commented on PR #1122: URL: https://github.com/apache/fluo/pull/1122#issuecomment-1306072192 > > except I noticed the accumulo2-maven-plugin seems to want log4j1.2. > > @ctubbsii this is not something I noticed. What did you see that made you notice this? Is it causing any

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015807212 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range; imp

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015807929 ## modules/distribution/src/main/config/log4j2.properties: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1016009661 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range; imp