[GitHub] [fluo] keith-turner commented on pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2023-01-14 Thread GitBox
keith-turner commented on PR #1120: URL: https://github.com/apache/fluo/pull/1120#issuecomment-1383051349 @wjsl I ran the build locally and took another look at this, looks good. Thanks for the contribution. If you would like to add yourself as a contributor please submit a PR to update

[GitHub] [fluo] keith-turner merged pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2023-01-14 Thread GitBox
keith-turner merged PR #1120: URL: https://github.com/apache/fluo/pull/1120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo-uno] ctubbsii merged pull request #290: Update required Java version

2023-01-03 Thread GitBox
ctubbsii merged PR #290: URL: https://github.com/apache/fluo-uno/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-30 Thread GitBox
ctubbsii commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059479860 ## modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java: ## @@ -242,6 +243,27 @@ public void setProperty(String key, String value) {

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059231874 ## modules/core/src/main/java/org/apache/fluo/core/impl/TransactionImpl.java: ## @@ -1571,6 +1579,20 @@ private void beginCommitAsyncTest(CommitData cd) { }

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059230134 ## modules/api/src/main/java/org/apache/fluo/api/config/SimpleConfiguration.java: ## @@ -242,6 +243,27 @@ public void setProperty(String key, String value) {

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059229937 ## modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java: ## @@ -510,6 +514,19 @@ public String getAccumuloPassword() { throw new

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r1059229771 ## modules/api/src/main/java/org/apache/fluo/api/client/FluoClient.java: ## @@ -15,6 +15,8 @@ package org.apache.fluo.api.client; +import java.util.Collection;

[GitHub] [fluo] keith-turner commented on pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-29 Thread GitBox
keith-turner commented on PR #1120: URL: https://github.com/apache/fluo/pull/1120#issuecomment-1367705887 @wjsl I was looking at this. The API returned a Snapshot which gave me the feel that maybe it would not change the current snapshot object, but would create a new one with the auths

[GitHub] [fluo] wjsl commented on pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-03 Thread GitBox
wjsl commented on PR #1120: URL: https://github.com/apache/fluo/pull/1120#issuecomment-1336251047 I do. I have some changes we needed while integrating that I need to push. Will have it early next week. On Sat, Dec 3, 2022 at 9:26 AM Keith Turner ***@***.***> wrote: > @wjsl

[GitHub] [fluo] keith-turner commented on pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-12-03 Thread GitBox
keith-turner commented on PR #1120: URL: https://github.com/apache/fluo/pull/1120#issuecomment-1336170938 @wjsl I was thinking of spinning a Fluo release. Is this something you would like to see in the next release? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [fluo] keith-turner merged pull request #1128: Use assertThrows in place of deprecated Exception.none()

2022-12-03 Thread GitBox
keith-turner merged PR #1128: URL: https://github.com/apache/fluo/pull/1128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] keith-turner commented on a diff in pull request #1128: Use assertThrows in place of deprecated Exception.none()

2022-12-03 Thread GitBox
keith-turner commented on code in PR #1128: URL: https://github.com/apache/fluo/pull/1128#discussion_r1038782741 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java: ## @@ -132,8 +129,7 @@ private void testRollbackManyImpl(boolean

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1128: Use assertThrows in place of deprecated Exception.none()

2022-12-02 Thread GitBox
ctubbsii commented on code in PR #1128: URL: https://github.com/apache/fluo/pull/1128#discussion_r1038607240 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java: ## @@ -132,8 +129,7 @@ private void testRollbackManyImpl(boolean

[GitHub] [fluo] keith-turner commented on a diff in pull request #1128: Use assertThrows in place of deprecated Exception.none()

2022-12-02 Thread GitBox
keith-turner commented on code in PR #1128: URL: https://github.com/apache/fluo/pull/1128#discussion_r1038521224 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java: ## @@ -132,8 +129,7 @@ private void testRollbackManyImpl(boolean

[GitHub] [fluo] DomGarguilo opened a new pull request, #1128: Use assertThrows in place of deprecated Exception.none()

2022-12-02 Thread GitBox
DomGarguilo opened a new pull request, #1128: URL: https://github.com/apache/fluo/pull/1128 This should have been included in #1127 but was overlooked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fluo] ctubbsii merged pull request #1127: Remove use of deprecated ExpectedException.none() in TransactorIT

2022-12-01 Thread GitBox
ctubbsii merged PR #1127: URL: https://github.com/apache/fluo/pull/1127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] DomGarguilo commented on a diff in pull request #1127: Remove use of deprecated ExpectedException.none() in TransactorIT

2022-12-01 Thread GitBox
DomGarguilo commented on code in PR #1127: URL: https://github.com/apache/fluo/pull/1127#discussion_r1037402658 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/TransactorIT.java: ## @@ -111,9 +107,7 @@ public void testFailures() throws Exception {

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1127: Remove use of deprecated ExpectedException.none() in TransactorIT

2022-12-01 Thread GitBox
ctubbsii commented on code in PR #1127: URL: https://github.com/apache/fluo/pull/1127#discussion_r1037376036 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/TransactorIT.java: ## @@ -111,9 +107,7 @@ public void testFailures() throws Exception {

[GitHub] [fluo] keith-turner merged pull request #1126: Removes use of most deprecated code.

2022-11-28 Thread GitBox
keith-turner merged PR #1126: URL: https://github.com/apache/fluo/pull/1126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] keith-turner merged pull request #1125: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2022-11-19 Thread GitBox
keith-turner merged PR #1125: URL: https://github.com/apache/fluo/pull/1125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] JLLeitschuh opened a new pull request, #1125: [SECURITY] Fix Temporary File Information Disclosure Vulnerability

2022-11-18 Thread GitBox
JLLeitschuh opened a new pull request, #1125: URL: https://github.com/apache/fluo/pull/1125 # Security Vulnerability Fix This pull request fixes a Temporary File Information Disclosure Vulnerability, which existed in this project. ## Preamble The system temporary

[GitHub] [fluo] ctubbsii commented on issue #1124: TestTransaction should implement Transaction instead of TransactionBase

2022-11-16 Thread GitBox
ctubbsii commented on issue #1124: URL: https://github.com/apache/fluo/issues/1124#issuecomment-1318015520 Note to potential contributors: this could be done in two smaller steps, as separate PRs. 1. inline all instances of `TestTransaction.done()` (and remove the method), and

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
ctubbsii commented on code in PR #1123: URL: https://github.com/apache/fluo/pull/1123#discussion_r1024511529 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java: ## @@ -652,4 +655,40 @@ private boolean wasRolledBackPrimary(long startTs,

[GitHub] [fluo] ctubbsii opened a new issue, #1124: TestTransaction should implement Transaction instead of TransactionBase

2022-11-16 Thread GitBox
ctubbsii opened a new issue, #1124: URL: https://github.com/apache/fluo/issues/1124 Currently, `TestTransaction` implements TransactionBase, but still has a `commit()` and `close()` method with the same signature as the `Transaction` interface, which itself extends `AutoCloseable`. It

[GitHub] [fluo] keith-turner commented on issue #660: Lock resolution failed

2022-11-16 Thread GitBox
keith-turner commented on issue #660: URL: https://github.com/apache/fluo/issues/660#issuecomment-1317133361 I think we tracked down the problem in #1123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fluo] keith-turner closed issue #660: Lock resolution failed

2022-11-16 Thread GitBox
keith-turner closed issue #660: Lock resolution failed URL: https://github.com/apache/fluo/issues/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] keith-turner merged pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
keith-turner merged PR #1123: URL: https://github.com/apache/fluo/pull/1123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] keith-turner commented on a diff in pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
keith-turner commented on code in PR #1123: URL: https://github.com/apache/fluo/pull/1123#discussion_r1024090838 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java: ## @@ -652,4 +655,40 @@ private boolean wasRolledBackPrimary(long

[GitHub] [fluo] keith-turner commented on a diff in pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
keith-turner commented on code in PR #1123: URL: https://github.com/apache/fluo/pull/1123#discussion_r1024089177 ## modules/api/src/main/java/org/apache/fluo/api/data/Column.java: ## @@ -28,26 +28,42 @@ public final class Column implements Comparable, Serializable {

[GitHub] [fluo] wjsl commented on a diff in pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
wjsl commented on code in PR #1123: URL: https://github.com/apache/fluo/pull/1123#discussion_r1024081999 ## modules/api/src/main/java/org/apache/fluo/api/data/Column.java: ## @@ -28,26 +28,42 @@ public final class Column implements Comparable, Serializable { private

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
ctubbsii commented on code in PR #1123: URL: https://github.com/apache/fluo/pull/1123#discussion_r1024056223 ## modules/integration-tests/src/main/java/org/apache/fluo/integration/impl/FailureIT.java: ## @@ -652,4 +655,40 @@ private boolean wasRolledBackPrimary(long startTs,

[GitHub] [fluo] keith-turner commented on pull request #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
keith-turner commented on PR #1123: URL: https://github.com/apache/fluo/pull/1123#issuecomment-1317079540 All ITs pass for ee51445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [fluo] keith-turner opened a new pull request, #1123: Fixes bug resolving lock w/ empty col fam. Reported in #660

2022-11-16 Thread GitBox
keith-turner opened a new pull request, #1123: URL: https://github.com/apache/fluo/pull/1123 There was a bug where if a column family was empty and the qual was not empty this would cause lock recovery to fail. The underlying cause was a bug in the Column class. This class has an

[GitHub] [fluo] keith-turner merged pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-08 Thread GitBox
keith-turner merged PR #1122: URL: https://github.com/apache/fluo/pull/1122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1016009661 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range;

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015807929 ## modules/distribution/src/main/config/log4j2.properties: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor license

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015807212 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range;

[GitHub] [fluo] ctubbsii commented on pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
ctubbsii commented on PR #1122: URL: https://github.com/apache/fluo/pull/1122#issuecomment-1306072192 > > except I noticed the accumulo2-maven-plugin seems to want log4j1.2. > > @ctubbsii this is not something I noticed. What did you see that made you notice this? Is it causing

[GitHub] [fluo] keith-turner commented on pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on PR #1122: URL: https://github.com/apache/fluo/pull/1122#issuecomment-1306067921 > except I noticed the accumulo2-maven-plugin seems to want log4j1.2. @ctubbsii this is not something I noticed. What did you see that made you notice this? Is it causing any

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015800584 ## .github/workflows/maven.yaml: ## @@ -48,7 +48,7 @@ jobs: key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} restore-keys: ${{ runner.os

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015801943 ## pom.xml: ## @@ -384,7 +391,7 @@ true -log4j:log4j:jar:* + org.apache.logging.log4j:*

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015798556 ## modules/integration-tests/pom.xml: ## @@ -77,6 +77,19 @@ org.apache.hadoop hadoop-client-api + + + org.apache.logging.log4j +

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015798556 ## modules/integration-tests/pom.xml: ## @@ -77,6 +77,19 @@ org.apache.hadoop hadoop-client-api + + + org.apache.logging.log4j +

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015797320 ## modules/distribution/src/main/config/fluo-env.sh: ## @@ -37,7 +37,7 @@ export FLUO_TMP="${FLUO_TMP:-/tmp}" ## Fluo log4j configuration export

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015795999 ## modules/distribution/src/main/config/log4j2.properties: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015794843 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range;

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015690500 ## modules/accumulo/src/test/java/org/apache/fluo/accumulo/iterators/TimeSkippingIteratorTest.java: ## @@ -25,7 +25,7 @@ import org.apache.accumulo.core.data.Range;

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: Get fluo building and running against Accumulo 2.1.0

2022-11-07 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1015245978 ## modules/api/pom.xml: ## @@ -46,8 +46,8 @@ test - org.slf4j - slf4j-log4j12 + org.apache.logging.log4j + log4j-slf4j2-impl

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014751576 ## modules/api/pom.xml: ## @@ -46,8 +46,8 @@ test - org.slf4j - slf4j-log4j12 + org.apache.logging.log4j + log4j-slf4j2-impl

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014729226 ## modules/api/pom.xml: ## @@ -46,8 +46,8 @@ test - org.slf4j - slf4j-log4j12 + org.apache.logging.log4j + log4j-slf4j2-impl

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014726441 ## modules/api/pom.xml: ## @@ -46,8 +46,8 @@ test - org.slf4j - slf4j-log4j12 + org.apache.logging.log4j + log4j-slf4j2-impl

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014669295 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: > I would

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014667748 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: The next

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014667748 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: The next

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014667606 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: in 3121103

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014652337 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: I think your

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-05 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014625935 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: Thanks

[GitHub] [fluo] ctubbsii commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-04 Thread GitBox
ctubbsii commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014560212 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: You have to

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-04 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014534537 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: @ctubbsii

[GitHub] [fluo] keith-turner commented on a diff in pull request #1122: WIP getting fluo to build against Accumulo 2.1.0

2022-11-04 Thread GitBox
keith-turner commented on code in PR #1122: URL: https://github.com/apache/fluo/pull/1122#discussion_r1014534537 ## pom.xml: ## @@ -308,6 +313,11 @@ hadoop-client-runtime ${hadoop.version} + Review Comment: @ctubbsii

[GitHub] [fluo-uno] ctubbsii merged pull request #289: Add updated versions and checksums for accumulo 2.1.0

2022-11-01 Thread GitBox
ctubbsii merged PR #289: URL: https://github.com/apache/fluo-uno/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo-uno] ctubbsii commented on a diff in pull request #289: Add updated versions and checksums for accumulo 2.1.0

2022-11-01 Thread GitBox
ctubbsii commented on code in PR #289: URL: https://github.com/apache/fluo-uno/pull/289#discussion_r1010776361 ## conf/checksums: ## @@ -1,6 +1,7 @@

[GitHub] [fluo-uno] ctubbsii commented on a diff in pull request #289: Add updated versions and checksums for accumulo 2.1.0

2022-11-01 Thread GitBox
ctubbsii commented on code in PR #289: URL: https://github.com/apache/fluo-uno/pull/289#discussion_r1010774130 ## conf/checksums: ## @@ -1,6 +1,7 @@

[GitHub] [fluo-uno] ctubbsii commented on a diff in pull request #289: Add updated versions and checksums for accumulo 2.1.0

2022-11-01 Thread GitBox
ctubbsii commented on code in PR #289: URL: https://github.com/apache/fluo-uno/pull/289#discussion_r1010771430 ## conf/checksums: ## @@ -1,5 +1,7 @@

[GitHub] [fluo-uno] DomGarguilo opened a new pull request, #289: WIP - update for 2.1.0 release

2022-10-24 Thread GitBox
DomGarguilo opened a new pull request, #289: URL: https://github.com/apache/fluo-uno/pull/289 This PR aims to update fluo-uno to work with 2.1.0 when it is released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [fluo-uno] ctubbsii commented on issue #286: tserver logging lost on restart

2022-09-29 Thread GitBox
ctubbsii commented on issue #286: URL: https://github.com/apache/fluo-uno/issues/286#issuecomment-1262623491 Okay, I see. I was able to reproduce this with only one server, and I saw the same thing for all services, not just tserver. If I used `uno accumulo start` instead of

[GitHub] [fluo-uno] milleruntime commented on issue #286: tserver logging lost on restart

2022-09-29 Thread GitBox
milleruntime commented on issue #286: URL: https://github.com/apache/fluo-uno/issues/286#issuecomment-1262550649 The problem isn't the logs get overridden, the problem is that there is no logging for a restarted tserver. For example: I start a cluster with 2 tservers: 12:46:25

[GitHub] [fluo-uno] ctubbsii commented on issue #286: tserver logging lost on restart

2022-09-29 Thread GitBox
ctubbsii commented on issue #286: URL: https://github.com/apache/fluo-uno/issues/286#issuecomment-1262496514 I'm not sure this is a problem. If you need the logs for the previous run separate, then you can just copy them before you restart, right? Uno should keep things pretty simple, so

[GitHub] [fluo-uno] milleruntime opened a new issue, #286: tserver logging lost on restart

2022-09-28 Thread GitBox
milleruntime opened a new issue, #286: URL: https://github.com/apache/fluo-uno/issues/286 I have multiple tservers running on the same instance. If I kill one of them (kill -9 PID) and restart using the Accumulo scripts (accumulo-cluster or accumulo-service) then the logging for the

[GitHub] [fluo-uno] milleruntime opened a new issue, #285: Update encryption plugin

2022-09-16 Thread GitBox
milleruntime opened a new issue, #285: URL: https://github.com/apache/fluo-uno/issues/285 With the changes in https://github.com/apache/accumulo/pull/2197 the encryption plugin (`plugins/accumulo-encryption.sh`) will need to be updated. The script will need to generate the new properties

[GitHub] [fluo-examples] dependabot[bot] commented on pull request #32: Bump jsoup from 1.14.2 to 1.15.3 in /webindex

2022-09-02 Thread GitBox
dependabot[bot] commented on PR #32: URL: https://github.com/apache/fluo-examples/pull/32#issuecomment-1235681890 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [fluo-examples] ctubbsii commented on pull request #32: Bump jsoup from 1.14.2 to 1.15.3 in /webindex

2022-09-02 Thread GitBox
ctubbsii commented on PR #32: URL: https://github.com/apache/fluo-examples/pull/32#issuecomment-1235681849 jsoup made breaking changes. This example hasn't been updated in awhile. This change is more likely to break things than help. -- This is an automated message from the Apache Git

[GitHub] [fluo-examples] ctubbsii closed pull request #32: Bump jsoup from 1.14.2 to 1.15.3 in /webindex

2022-09-02 Thread GitBox
ctubbsii closed pull request #32: Bump jsoup from 1.14.2 to 1.15.3 in /webindex URL: https://github.com/apache/fluo-examples/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [fluo-examples] dependabot[bot] opened a new pull request, #32: Bump jsoup from 1.14.2 to 1.15.3 in /webindex

2022-09-01 Thread GitBox
dependabot[bot] opened a new pull request, #32: URL: https://github.com/apache/fluo-examples/pull/32 Bumps [jsoup](https://github.com/jhy/jsoup) from 1.14.2 to 1.15.3. Release notes Sourced from https://github.com/jhy/jsoup/releases;>jsoup's releases. jsoup 1.15.3 jsoup

[GitHub] [fluo-uno] ctubbsii merged pull request #284: Fix typo in performance profile in uno.conf

2022-08-31 Thread GitBox
ctubbsii merged PR #284: URL: https://github.com/apache/fluo-uno/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo-uno] DomGarguilo opened a new pull request, #284: Fix typo in performance profile in uno.conf

2022-08-31 Thread GitBox
DomGarguilo opened a new pull request, #284: URL: https://github.com/apache/fluo-uno/pull/284 in #283, I fixed some typos but also ended up introducing another one. This PR fixes the mistake I made in the performance profile name. -- This is an automated message from the Apache Git

[GitHub] [fluo-uno] DomGarguilo commented on pull request #283: Fix typos in uno.conf

2022-08-31 Thread GitBox
DomGarguilo commented on PR #283: URL: https://github.com/apache/fluo-uno/pull/283#issuecomment-1232891742 > I think this broke one of the scripts... I am now getting this error when trying to run `uno env`: `Unknown performance profile` Whoops, I messed up the profile name. I'll

[GitHub] [fluo-uno] milleruntime commented on pull request #283: Fix typos in uno.conf

2022-08-31 Thread GitBox
milleruntime commented on PR #283: URL: https://github.com/apache/fluo-uno/pull/283#issuecomment-1232809517 I think this broke one of the scripts... I am now getting this error when trying to run `uno env`: `Unknown performance profile` -- This is an automated message from the Apache

[GitHub] [fluo-uno] ctubbsii merged pull request #283: Fix typos in uno.conf

2022-08-30 Thread GitBox
ctubbsii merged PR #283: URL: https://github.com/apache/fluo-uno/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] ITSKATYMABYBABY commented on issue #758: Return type does not match parameter type for get(Collection)

2022-08-04 Thread GitBox
ITSKATYMABYBABY commented on issue #758: URL: https://github.com/apache/fluo/issues/758#issuecomment-1205479906 I AM THE 183 CONTRIBUTIONS IN.&.OF LAST YEAR, NO DISRESPECT SIR. SINCERELY, .KATELYN.MABY.BURSON. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [fluo] ctubbsii merged pull request #1121: Bump commons-configuration2 from 2.7 to 2.8.0

2022-07-13 Thread GitBox
ctubbsii merged PR #1121: URL: https://github.com/apache/fluo/pull/1121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo-examples] ctubbsii merged pull request #31: Bump hadoop-client from 2.6.3 to 2.7.0 in /webindex

2022-07-13 Thread GitBox
ctubbsii merged PR #31: URL: https://github.com/apache/fluo-examples/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo] dependabot[bot] opened a new pull request, #1121: Bump commons-configuration2 from 2.7 to 2.8.0

2022-07-07 Thread GitBox
dependabot[bot] opened a new pull request, #1121: URL: https://github.com/apache/fluo/pull/1121 Bumps commons-configuration2 from 2.7 to 2.8.0. [![Dependabot compatibility

[GitHub] [fluo-examples] dependabot[bot] opened a new pull request, #31: Bump hadoop-client from 2.6.3 to 2.7.0 in /webindex

2022-07-01 Thread GitBox
dependabot[bot] opened a new pull request, #31: URL: https://github.com/apache/fluo-examples/pull/31 Bumps hadoop-client from 2.6.3 to 2.7.0. [![Dependabot compatibility

[GitHub] [fluo-uno] ctubbsii merged pull request #282: Update Hadoop and ZooKeeper versions

2022-06-09 Thread GitBox
ctubbsii merged PR #282: URL: https://github.com/apache/fluo-uno/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fluo-uno] ctubbsii opened a new pull request, #282: Update Hadoop and ZooKeeper versions

2022-06-08 Thread GitBox
ctubbsii opened a new pull request, #282: URL: https://github.com/apache/fluo-uno/pull/282 * Change default Hadoop version to 3.3.3 * Change default ZooKeeper version to 3.7.1 * Replace Hadoop and ZooKeeper checksums with latest patch release for each minor release line -- This

[GitHub] [fluo] keith-turner commented on a diff in pull request #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-06-08 Thread GitBox
keith-turner commented on code in PR #1120: URL: https://github.com/apache/fluo/pull/1120#discussion_r892872914 ## modules/core/src/main/java/org/apache/fluo/core/impl/TransactionImpl.java: ## @@ -1571,6 +1579,20 @@ private void beginCommitAsyncTest(CommitData cd) { }

[GitHub] [fluo] wjsl opened a new pull request, #1120: First pass at adding scan time authorizations to transactions/snapshots

2022-06-06 Thread GitBox
wjsl opened a new pull request, #1120: URL: https://github.com/apache/fluo/pull/1120 Rough cut of this. Needs to fix documentation, and add assertion to the tests. Open to suggestions on better test cases. This PR adds support for the following: 1. Specifying authentication

[GitHub] [fluo-uno] EdColeman commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
EdColeman commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1144111888 The may be other ways to address this - update pgrep or change the way the classpath is passed to commands to shorten command length. -- This is an automated message from the Apache

[GitHub] [fluo-uno] EdColeman closed pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
EdColeman closed pull request #281: Update kill cmd for ZooKeeper URL: https://github.com/apache/fluo-uno/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fluo-uno] ctubbsii commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
ctubbsii commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1144008442 See also #243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fluo-uno] ctubbsii commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
ctubbsii commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1144005886 This is a bug in that older version. It was fixed in 3.3.16. See my comment for Fedora 31 at https://bugzilla.redhat.com/show_bug.cgi?id=1782309#c3 I don't think we should fix this

[GitHub] [fluo-uno] EdColeman commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
EdColeman commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1143876458 pgrep version: `$ pgrep from procps-ng 3.3.15` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fluo-uno] milleruntime commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
milleruntime commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1143853441 Different version of `pgrep`? What does `prep --version` print? I am running: pgrep from procps-ng 3.3.12 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [fluo-uno] EdColeman commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
EdColeman commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1143742833 I can see the process with jps and ps, however grep does not return anything. ``` [fluo-uno]$ jps -m 22965 QuorumPeerMain

[GitHub] [fluo-uno] milleruntime commented on pull request #281: Update kill cmd for ZooKeeper

2022-06-01 Thread GitBox
milleruntime commented on PR #281: URL: https://github.com/apache/fluo-uno/pull/281#issuecomment-1143552571 I just tried: `pgrep -f "[Q]uorumPeerMain"` and that worked on Ubuntu. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fluo-uno] EdColeman opened a new pull request, #281: Update kill cmd for ZooKeeper

2022-05-31 Thread GitBox
EdColeman opened a new pull request, #281: URL: https://github.com/apache/fluo-uno/pull/281 The current script is using pgrep, looking for QuorumPeerMain to find the ZooKeeper pid - this does not seem to work when checking ZooKeeper status or when trying to stop ZooKeeper. Update the

[GitHub] [fluo-uno] ctubbsii opened a new issue, #280: Setup classpath items for OpenTelemetry with Accumulo 2.1 and later

2022-05-23 Thread GitBox
ctubbsii opened a new issue, #280: URL: https://github.com/apache/fluo-uno/issues/280 Running Accumulo 2.1.0-SNAPSHOT, I expected to be able to see trace information printed to the console or something, when I ran `trace on` in the Accumulo shell (launched with `uno ashell`). This didn't

[GitHub] [fluo-uno] ctubbsii closed issue #277: Accumulo setup fails on version 1.10.1

2022-05-23 Thread GitBox
ctubbsii closed issue #277: Accumulo setup fails on version 1.10.1 URL: https://github.com/apache/fluo-uno/issues/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   3   4   5   6   7   8   9   10   >