[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1001: IGNITE-17469 cli profile commands unification

PakhomovAlexander commented on code in PR #1001: URL: https://github.com/apache/ignite-3/pull/1001#discussion_r944820904 ## modules/cli/src/main/java/org/apache/ignite/cli/call/cliconfig/profile/CliConfigProfileCreateCallInput.java: ## @@ -50,35 +53,4 @@ public String getCopyFro

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1001: IGNITE-17469 cli profile commands unification

PakhomovAlexander commented on code in PR #1001: URL: https://github.com/apache/ignite-3/pull/1001#discussion_r944801903 ## modules/cli/src/main/java/org/apache/ignite/cli/commands/cliconfig/CliConfigGetReplCommand.java: ## @@ -24,27 +24,23 @@ import org.apache.ignite.cli.comma

[GitHub] [ignite-3] rpuch commented on a diff in pull request #939: IGNITE-17334 Basic volatile RAFT log storage

rpuch commented on code in PR #939: URL: https://github.com/apache/ignite-3/pull/939#discussion_r944761133 ## modules/api/src/main/java/org/apache/ignite/configuration/schemas/table/TableConfigurationSchema.java: ## @@ -61,4 +61,8 @@ public class TableConfigurationSchema {

[GitHub] [ignite] artnaseef commented on pull request #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replac…

artnaseef commented on PR #10196: URL: https://github.com/apache/ignite/pull/10196#issuecomment-1213362348 The changes are similar to those of IGNITE-17274. A new map is added to track the registered service-names mapped to the service-info structure. The lookup is changed from a linear l

[GitHub] [ignite] artnaseef commented on pull request #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replac…

artnaseef commented on PR #10196: URL: https://github.com/apache/ignite/pull/10196#issuecomment-1213363328 The purpose (WHY) of this change is to improve service shutdown performance (in local testing 60,000 services, shutdown time dropped from around 60 seconds to around 1 second). -- T

[GitHub] [ignite] artnaseef opened a new pull request, #10196: IGNITE-17524 Improve lookup of deployed services UUID by name: replac…

artnaseef opened a new pull request, #10196: URL: https://github.com/apache/ignite/pull/10196 …e list lookup with map lookup. Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the follow

[GitHub] [ignite] timoninmaxim merged pull request #10188: IGNITE-17511 Java ThinClient supports IndexQuery

timoninmaxim merged PR #10188: URL: https://github.com/apache/ignite/pull/10188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944485731 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java: ## @@ -140,21 +173,32 @@ public void stop()

[GitHub] [ignite] NSAmelchev merged pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

NSAmelchev merged PR #10189: URL: https://github.com/apache/ignite/pull/10189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944465768 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryDataRegion.java: ## @@ -35,6 +36,19 @@ * Implementatio

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944464715 ## modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflowTest.java: ## @@ -492,6 +526,81 @@ void testParalle

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944458619 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointManager.java: ## @@ -123,10 +123,12 @@ public CheckpointMan

[GitHub] [ignite-3] asfgit closed pull request #977: IGNITE-17286 Add missed busy locks to get rid of resources leaking during table creation

asfgit closed pull request #977: IGNITE-17286 Add missed busy locks to get rid of resources leaking during table creation URL: https://github.com/apache/ignite-3/pull/977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [ignite] asfgit closed pull request #10187: IGNITE-17507 Fixed an issue that could lead to unexpected partition m…

asfgit closed pull request #10187: IGNITE-17507 Fixed an issue that could lead to unexpected partition m… URL: https://github.com/apache/ignite/pull/10187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [ignite] skorotkov commented on pull request #10178: IGNITE-17457 Fix cluster lock after tx recovery

skorotkov commented on PR #10178: URL: https://github.com/apache/ignite/pull/10178#issuecomment-1213053537 Also added guarantee that both pools are blocked in backup node before killing the primary one. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [ignite] skorotkov commented on a diff in pull request #10178: IGNITE-17457 Fix cluster lock after tx recovery

skorotkov commented on code in PR #10178: URL: https://github.com/apache/ignite/pull/10178#discussion_r944405331 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxRecoveryConcurrentOnPrimaryFailTest.java: ## @@ -0,0 +1,164 @@ +/* + * Licens

[GitHub] [ignite-3] rpuch commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

rpuch commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944374211 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java: ## @@ -29,9 +31,10 @@ public interface Checkpoint

[GitHub] [ignite-3] rpuch commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

rpuch commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944382561 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java: ## @@ -29,9 +31,10 @@ public interface Checkpoint

[GitHub] [ignite-3] valepakh commented on a diff in pull request #986: IGNITE-17349 Add common UI components

valepakh commented on code in PR #986: URL: https://github.com/apache/ignite-3/pull/986#discussion_r944373042 ## modules/cli/src/main/java/org/apache/ignite/cli/core/style/component/MessageUiComponent.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [ignite-3] rpuch commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

rpuch commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944374211 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java: ## @@ -29,9 +31,10 @@ public interface Checkpoint

[GitHub] [ignite-3] rpuch commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

rpuch commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944373912 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/AwaitTasksCompletionExecutor.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944372606 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java: ## @@ -140,21 +173,32 @@ public void stop()

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944370584 ## modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflowTest.java: ## @@ -492,6 +526,81 @@ void testParalle

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944362320 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java: ## @@ -29,9 +31,10 @@ public interface Check

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944370068 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryDataRegion.java: ## @@ -35,6 +36,19 @@ * Implementatio

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944367599 ## modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflowTest.java: ## @@ -492,6 +526,81 @@ void testParalle

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944365835 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointReadWriteLock.java: ## @@ -17,15 +17,20 @@ package org.a

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944364708 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java: ## @@ -29,9 +31,10 @@ public interface Check

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944363054 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/AwaitTasksCompletionExecutor.java: ## @@ -0,0 +1,80 @@ +/* + * Licens

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

tkalkirill commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944362320 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java: ## @@ -29,9 +31,10 @@ public interface Check

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

NSAmelchev commented on code in PR #10189: URL: https://github.com/apache/ignite/pull/10189#discussion_r944343519 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotResponseRemoteFutureTask.java: ## @@ -72,70 +74,65 @@ public S

[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

NSAmelchev commented on code in PR #10189: URL: https://github.com/apache/ignite/pull/10189#discussion_r944343283 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFilesRequestMessage.java: ## @@ -91,9 +92,10 @@ public Map> pa

[GitHub] [ignite-3] isapego commented on a diff in pull request #988: IGNITE-17400 Basic C++ binary tuple support

isapego commented on code in PR #988: URL: https://github.com/apache/ignite-3/pull/988#discussion_r943215905 ## modules/platforms/cpp/schema/BinaryTupleBuilder.h: ## @@ -0,0 +1,397 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lice

[GitHub] [ignite] ivandasch commented on a diff in pull request #10028: IGNITE-17029 PITR: Consistent Cut

ivandasch commented on code in PR #10028: URL: https://github.com/apache/ignite/pull/10028#discussion_r944301859 ## modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/record/ConsistentCutFinishRecord.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [ignite] xtern commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

xtern commented on code in PR #10189: URL: https://github.com/apache/ignite/pull/10189#discussion_r944281616 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotResponseRemoteFutureTask.java: ## @@ -72,70 +74,65 @@ public Snapsh

[GitHub] [ignite] xtern commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

xtern commented on code in PR #10189: URL: https://github.com/apache/ignite/pull/10189#discussion_r944280285 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotResponseRemoteFutureTask.java: ## @@ -72,70 +74,65 @@ public Snapsh

[GitHub] [ignite-3] ibessonov opened a new pull request, #1003: IGNITE-17076 Common RowId implementation introduced

ibessonov opened a new pull request, #1003: URL: https://github.com/apache/ignite-3/pull/1003 https://issues.apache.org/jira/browse/IGNITE-17076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] rpuch commented on a diff in pull request #995: IGNITE-17475 FreeList metadata is not stored on the checkpoint

rpuch commented on code in PR #995: URL: https://github.com/apache/ignite-3/pull/995#discussion_r944164632 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/AwaitTasksCompletionExecutor.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to

[GitHub] [ignite] xtern commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

xtern commented on code in PR #10189: URL: https://github.com/apache/ignite/pull/10189#discussion_r944210268 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFilesRequestMessage.java: ## @@ -91,9 +92,10 @@ public Map> parts()

[GitHub] [ignite] xtern commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

xtern commented on code in PR #10189: URL: https://github.com/apache/ignite/pull/10189#discussion_r944210268 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFilesRequestMessage.java: ## @@ -91,9 +92,10 @@ public Map> parts()