[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #1538: IGNITE-18525 Introduce new PlacementDriver Ignite component

2023-01-17 Thread GitBox
denis-chudov commented on code in PR #1538: URL: https://github.com/apache/ignite-3/pull/1538#discussion_r1073169189 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdrive/PlacementDriverManager.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apach

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1073145119 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite] skorotkov opened a new pull request, #10486: IGNITE-18568 [ducktests] Add explicit filelock package dependency

2023-01-17 Thread GitBox
skorotkov opened a new pull request, #10486: URL: https://github.com/apache/ignite/pull/10486 ducktape 0.11.x do not depend on 'filelock' any more, so 'filelock' dependency should be specified explicitely. -- Thank you for submitting the pull request to

[GitHub] [ignite-3] ademakov commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
ademakov commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072993260 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite-3] ademakov commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
ademakov commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072993260 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite-3] ademakov commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
ademakov commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072993260 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite-3] ademakov commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
ademakov commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072993260 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1532: IGNITE-18540 Fixed processing of the default distribution zone.

2023-01-17 Thread GitBox
sergeyuttsel commented on code in PR #1532: URL: https://github.com/apache/ignite-3/pull/1532#discussion_r1072749064 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -590,6 +584,32 @@ private void update

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1532: IGNITE-18540 Fixed processing of the default distribution zone.

2023-01-17 Thread GitBox
sergeyuttsel commented on code in PR #1532: URL: https://github.com/apache/ignite-3/pull/1532#discussion_r1072748804 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -791,9 +813,19 @@ public boolean onUp

[GitHub] [ignite-3] sashapolo opened a new pull request, #1542: IGNITE-18554 Remove MetaStorage learners on topology events @sashapolo

2023-01-17 Thread GitBox
sashapolo opened a new pull request, #1542: URL: https://github.com/apache/ignite-3/pull/1542 https://issues.apache.org/jira/browse/IGNITE-18554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] ibessonov opened a new pull request, #1541: IGNITE-18567 Configuration validators code refactored.

2023-01-17 Thread GitBox
ibessonov opened a new pull request, #1541: URL: https://github.com/apache/ignite-3/pull/1541 https://issues.apache.org/jira/browse/IGNITE-18567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite] Vladsz83 closed pull request #10480: IGNITE-18226 : [IEP-80] Remove CacheGroupMetricsMXBean legacy JMX metrics bean , v2 : remove the management too

2023-01-17 Thread GitBox
Vladsz83 closed pull request #10480: IGNITE-18226 : [IEP-80] Remove CacheGroupMetricsMXBean legacy JMX metrics bean , v2 : remove the management too URL: https://github.com/apache/ignite/pull/10480 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [ignite] Vladsz83 commented on pull request #10480: IGNITE-18226 : [IEP-80] Remove CacheGroupMetricsMXBean legacy JMX metrics bean , v2 : remove the management too

2023-01-17 Thread GitBox
Vladsz83 commented on PR #10480: URL: https://github.com/apache/ignite/pull/10480#issuecomment-1385873454 impl: https://github.com/apache/ignite/pull/10485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ignite] Vladsz83 commented on pull request #10477: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean

2023-01-17 Thread GitBox
Vladsz83 commented on PR #10477: URL: https://github.com/apache/ignite/pull/10477#issuecomment-1385872698 Impl: https://github.com/apache/ignite/pull/10485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ignite] Vladsz83 closed pull request #10477: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean

2023-01-17 Thread GitBox
Vladsz83 closed pull request #10477: IGNITE-18232 : [IEP-80] Remove of CacheMetricsMXBean legacy JMX bean URL: https://github.com/apache/ignite/pull/10477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [ignite] Vladsz83 opened a new pull request, #10485: IGNITE-18232 : [IEP-80] Remove DataRegionMetricsMXBean legacy JMX bean, v3 : keep JCache beans

2023-01-17 Thread GitBox
Vladsz83 opened a new pull request, #10485: URL: https://github.com/apache/ignite/pull/10485 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1538: IGNITE-18525 Introduce new PlacementDriver Ignite component

2023-01-17 Thread GitBox
sanpwc commented on code in PR #1538: URL: https://github.com/apache/ignite-3/pull/1538#discussion_r1072555675 ## modules/placement-driver/build.gradle: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreeme

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072580281 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PageMemoryStorageUtils.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #1532: IGNITE-18540 Fixed processing of the default distribution zone.

2023-01-17 Thread GitBox
alievmirza commented on code in PR #1532: URL: https://github.com/apache/ignite-3/pull/1532#discussion_r1072283593 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -590,6 +584,32 @@ private void updateMe

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1532: IGNITE-18540 Fixed processing of the default distribution zone.

2023-01-17 Thread GitBox
sanpwc commented on code in PR #1532: URL: https://github.com/apache/ignite-3/pull/1532#discussion_r1072526295 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -791,9 +813,19 @@ public boolean onUpdate(@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072512178 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072510827 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -396,4 +372,56 @@ p

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072480981 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java: ## @@ -365,4 +315,70 @@ p

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072480105 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -396,4 +372,56 @@ p

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072470190 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -203,19 +187,68 @@ publ

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072447536 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java: ## @@ -987,24 +909,174 @@ p

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072431782 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] SammyVimes merged pull request #1531: IGNITE-18505 Thread pool for components start

2023-01-17 Thread GitBox
SammyVimes merged PR #1531: URL: https://github.com/apache/ignite-3/pull/1531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072415322 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072414034 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072407243 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void startStopNode

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072406356 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void startStopNode

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072405813 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void startStopNode

[GitHub] [ignite-3] Flaugh24 commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-17 Thread GitBox
Flaugh24 commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1072405500 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void startStopNode

[GitHub] [ignite] ivandasch opened a new pull request, #10484: IGNITE-18438 .NET: Fix marshalling of nested binarizable structures with different schemas.

2023-01-17 Thread GitBox
ivandasch opened a new pull request, #10484: URL: https://github.com/apache/ignite/pull/10484 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T

[GitHub] [ignite-extensions] shishkovilja closed pull request #199: IGNITE-18209 Add check of a lag in a metadata topic

2023-01-17 Thread GitBox
shishkovilja closed pull request #199: IGNITE-18209 Add check of a lag in a metadata topic URL: https://github.com/apache/ignite-extensions/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072346248 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -96,49 +98,22 @@ public bool

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072334426 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072329420 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072329420 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -405,42 +373,148 @@ private

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072328103 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java: ## @@ -210,7 +177,8 @@ private Fil

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072279893 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java: ## @@ -216,51 +197,41 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072276069 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java: ## @@ -800,67 +732,65 @@ pu

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072275714 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java: ## @@ -157,35 +141,31 @@ pr

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072257607 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -298,76 +276,74 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072257176 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -298,76 +276,74 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072256909 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -247,28 +233,20 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072251321 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -247,28 +233,20 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072251321 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -247,28 +233,20 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072249467 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -97,100 +93,88 @@ publi

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072249794 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -105,71 +102,65 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072250057 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/PageMemorySortedIndexStorage.java: ## @@ -105,71 +102,65 @@

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072249213 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -97,100 +93,88 @@ publi

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072247433 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite-3] ibessonov opened a new pull request, #1540: IGNITE-18516 "Change closure" semantic fixed when it comes to concurr…

2023-01-17 Thread GitBox
ibessonov opened a new pull request, #1540: URL: https://github.com/apache/ignite-3/pull/1540 …ent access to "external" configuration. New "change" API introduced bot in registry and in generated Change interfaces. https://issues.apache.org/jira/browse/IGNITE-18516 -- This is an au

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072225481 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -268,12 +377,52 @@ private voi

[GitHub] [ignite-3] ptupitsyn merged pull request #1535: Rename Gradle project from ignite-parent to Apache Ignite 3

2023-01-17 Thread GitBox
ptupitsyn merged PR #1535: URL: https://github.com/apache/ignite-3/pull/1535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072202522 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -268,12 +377,52 @@ private voi

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072201651 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -167,86 +203,79 @@ public Comp

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072175125 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r107218 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -18,61 +18,89 @@ package org.

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072185181 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/AbstractPageMemoryTableStorage.java: ## @@ -18,61 +18,89 @@ package org.

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072184092 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -811,8 +885,8 @@ private void checkForPresenc

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072181314 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -548,6 +573,51 @@ public void testDestroyTabl

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072180599 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -88,25 +92,46 @@ public abstract class Abstra

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
ibessonov commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1072141988 ## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/hash/PageMemoryHashIndexStorage.java: ## @@ -97,100 +93,88 @@ public

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1506: IGNITE-18029 Implementation of a full rebalance for PersistentPageMemoryMvPartitionStorage on receiver

2023-01-17 Thread GitBox
ibessonov commented on code in PR #1506: URL: https://github.com/apache/ignite-3/pull/1506#discussion_r1071208048 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java: ## @@ -548,6 +573,51 @@ public void testDestroyTable

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072139004 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-17 Thread GitBox
AMashenkov commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1072138375 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -36,49 +35,52 @@ * * Merges multiple concurrent

[GitHub] [ignite] timoninmaxim opened a new pull request, #10483: DistributedProcess can await client node results

2023-01-17 Thread GitBox
timoninmaxim opened a new pull request, #10483: URL: https://github.com/apache/ignite/pull/10483 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ##

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072122879 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java: ## @@ -151,7 +151,7 @@ public interface MvPartitionStorage extends M

[GitHub] [ignite-3] ibessonov merged pull request #1534: IGNITE-18563 Reduce the list of duplicated jar dependencies

2023-01-17 Thread GitBox
ibessonov merged PR #1534: URL: https://github.com/apache/ignite-3/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1534: IGNITE-18563 Reduce the list of duplicated jar dependencies

2023-01-17 Thread GitBox
rpuch commented on code in PR #1534: URL: https://github.com/apache/ignite-3/pull/1534#discussion_r1072114151 ## modules/sql-engine/build.gradle: ## @@ -45,7 +45,11 @@ dependencies { implementation libs.jackson.core implementation libs.jackson.databind implementat

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
tkalkirill commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072106772 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072072004 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072072004 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072066793 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072065179 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlAlterZoneRenameTo.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [ignite-3] xtern merged pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-17 Thread GitBox
xtern merged PR #1511: URL: https://github.com/apache/ignite-3/pull/1511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[GitHub] [ignite-3] ptupitsyn closed pull request #1523: IGNITE-18509 .NET: Remove unused CompileMemberReader logic

2023-01-17 Thread GitBox
ptupitsyn closed pull request #1523: IGNITE-18509 .NET: Remove unused CompileMemberReader logic URL: https://github.com/apache/ignite-3/pull/1523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] ptupitsyn merged pull request #1533: IGNITE-18215 .NET: LINQ: Fix GroupBy with complex expression

2023-01-17 Thread GitBox
ptupitsyn merged PR #1533: URL: https://github.com/apache/ignite-3/pull/1533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1071959373 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/TableRowAndRowId.java: ## @@ -18,31 +18,32 @@ package org.apache.ignite.internal.storage;

[GitHub] [ignite] petrov-mg opened a new pull request, #10482: wip

2023-01-17 Thread GitBox
petrov-mg opened a new pull request, #10482: URL: https://github.com/apache/ignite/pull/10482 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T