Re: [PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
sashapolo commented on code in PR #3116: URL: https://github.com/apache/ignite-3/pull/3116#discussion_r1470727019 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogSortedIndexDescriptor.java: ## @@ -45,9 +46,10 @@ public CatalogSortedIndexDes

Re: [PR] IGNITE-21336 Handle ClosedChannelException gracefully [ignite-3]

2024-01-29 Thread via GitHub
sashapolo merged PR #3103: URL: https://github.com/apache/ignite-3/pull/3103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470721773 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterTask.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1470699518 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -203,6 +203,9 @@ public static class Client { /** Client handshake header erro

Re: [PR] IGNITE-20894 Add tests for ensuring transactional guarantees [ignite-3]

2024-01-29 Thread via GitHub
sanpwc commented on code in PR #3092: URL: https://github.com/apache/ignite-3/pull/3092#discussion_r1470662339 ## modules/table/src/testFixtures/java/org/apache/ignite/internal/table/TxAbstractTest.java: ## @@ -2151,12 +2157,150 @@ public void testYoungerTransactionThrowsExcept

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470674677 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingManager.java: ## @@ -79,16 +80,45 @@ public IndexBuildingManager( IndexMan

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
zstan commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1470658375 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningMetadataExtractor.java: ## @@ -0,0 +1,560 @@ +/* + * Licensed t

[PR] IGNITE-21047: Sql. Avoid spamming execution tasks when possible [ignite-3]

2024-01-29 Thread via GitHub
lowka opened a new pull request, #3119: URL: https://github.com/apache/ignite-3/pull/3119 --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the followi

[PR] IGNITE-21132 I0 [ignite]

2024-01-29 Thread via GitHub
yurinaryshkin opened a new pull request, #11207: URL: https://github.com/apache/ignite/pull/11207 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: #

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470652077 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterController.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470645194 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexBuildingStarterTaskTest.java: ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470637942 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterTask.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470637264 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterController.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470631531 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterTask.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470630864 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterTask.java: ## @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470629983 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingStarterController.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1470629299 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java: ## @@ -495,4 +496,18 @@ public static Collection collectIndexes(

Re: [PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3116: URL: https://github.com/apache/ignite-3/pull/3116#discussion_r1470608419 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -2266,17 +2272,65 @@ void testStartBuildingIndexEvent() {

Re: [PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3116: URL: https://github.com/apache/ignite-3/pull/3116#discussion_r1470607636 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -99,6 +101,27 @@ void testRecoveryCatalogVersionTimestamp

Re: [PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3116: URL: https://github.com/apache/ignite-3/pull/3116#discussion_r1470604914 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogIndexDescriptor.java: ## @@ -35,11 +35,15 @@ public abstract class CatalogInd

Re: [PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill commented on code in PR #3116: URL: https://github.com/apache/ignite-3/pull/3116#discussion_r1470604914 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogIndexDescriptor.java: ## @@ -35,11 +35,15 @@ public abstract class CatalogInd

Re: [PR] IGNITE-15889 Add 'contains' method to Record API [ignite-3]

2024-01-29 Thread via GitHub
SammyVimes commented on code in PR #3118: URL: https://github.com/apache/ignite-3/pull/3118#discussion_r1470189204 ## modules/client/src/test/java/org/apache/ignite/client/ClientRecordViewTest.java: ## @@ -37,6 +37,7 @@ import java.util.BitSet; import java.util.Collection; im

Re: [PR] IGNITE-15889 Add 'contains' method to Record API [ignite-3]

2024-01-29 Thread via GitHub
SammyVimes commented on code in PR #3118: URL: https://github.com/apache/ignite-3/pull/3118#discussion_r1470173168 ## modules/api/src/main/java/org/apache/ignite/table/RecordView.java: ## @@ -20,6 +20,8 @@ import java.util.Collection; import java.util.List; import java.util.c

[PR] IGNITE-15889 Add 'contains' method to Record API [ignite-3]

2024-01-29 Thread via GitHub
JAkutenshi opened a new pull request, #3118: URL: https://github.com/apache/ignite-3/pull/3118 https://issues.apache.org/jira/browse/IGNITE-15889 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1470091980 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningMetadataExtractor.java: ## @@ -0,0 +1,560 @@ +/* + * Licensed t

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1470090495 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningMetadataExtractor.java: ## @@ -0,0 +1,560 @@ +/* + * Licensed t

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1470089439 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningColumns.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apach

Re: [PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
sashapolo commented on code in PR #3116: URL: https://github.com/apache/ignite-3/pull/3116#discussion_r1470077648 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -99,6 +101,27 @@ void testRecoveryCatalogVersionTimestamps

Re: [PR] IGNITE-21336 Handle ClosedChannelException gracefully [ignite-3]

2024-01-29 Thread via GitHub
rpuch commented on code in PR #3103: URL: https://github.com/apache/ignite-3/pull/3103#discussion_r1469975389 ## modules/network/src/main/java/org/apache/ignite/internal/network/recovery/RecoveryServerHandshakeManager.java: ## @@ -98,6 +102,8 @@ public class RecoveryServerHandsh

Re: [PR] IGNITE-21336 Handle ClosedChannelException gracefully [ignite-3]

2024-01-29 Thread via GitHub
rpuch commented on code in PR #3103: URL: https://github.com/apache/ignite-3/pull/3103#discussion_r1469953327 ## modules/network/src/main/java/org/apache/ignite/network/DefaultMessagingService.java: ## @@ -310,7 +311,14 @@ private CompletableFuture sendViaNetwork( }

[PR] IGNITE-21132 I1 [ignite]

2024-01-29 Thread via GitHub
yurinaryshkin opened a new pull request, #11206: URL: https://github.com/apache/ignite/pull/11206 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: #

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469862917 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -203,6 +203,9 @@ public static class Client { /** Client handshake header error

Re: [PR] IGNITE-21381 disable flaky testChangeLeaderForce tests [ignite-3]

2024-01-29 Thread via GitHub
sanpwc merged PR #3117: URL: https://github.com/apache/ignite-3/pull/3117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[PR] IGNITE-21381 disable flaky testChangeLeaderForce tests [ignite-3]

2024-01-29 Thread via GitHub
alievmirza opened a new pull request, #3117: URL: https://github.com/apache/ignite-3/pull/3117 https://issues.apache.org/jira/browse/IGNITE-21381 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469790556 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java: ## @@ -50,29 +56,82 @@ public class Clien

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
xtern commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1468925037 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/serialization/CatalogEntrySerializationCompatibilityTest.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469783713 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -203,6 +203,9 @@ public static class Client { /** Client handshake header erro

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469780669 ## modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java: ## @@ -271,28 +274,36 @@ private CompletableFuture executeOnOneNode(

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469780669 ## modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java: ## @@ -271,28 +274,36 @@ private CompletableFuture executeOnOneNode(

Re: [PR] IGNITE-21017 Tracking RW transaction update operations [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill merged PR #3111: URL: https://github.com/apache/ignite-3/pull/3111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469753889 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -203,6 +203,9 @@ public static class Client { /** Client handshake header error

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469749130 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java: ## @@ -50,29 +53,39 @@ public class Clien

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469748037 ## modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java: ## @@ -203,6 +203,9 @@ public static class Client { /** Client handshake header erro

Re: [PR] IGNITE-20491 .NET: Add configurable operation timeout [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn merged PR #3113: URL: https://github.com/apache/ignite-3/pull/3113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-21376 Add the catalog version in which the index was created [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill opened a new pull request, #3116: URL: https://github.com/apache/ignite-3/pull/3116 https://issues.apache.org/jira/browse/IGNITE-21376 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
xtern commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1469677071 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogTableDescriptor.java: ## @@ -219,4 +221,53 @@ public void updateToken(long updateT

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
xtern commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1469676353 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/serialization/CatalogEntrySerializationCompatibilityTest.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed

[PR] IGNITE-21306 Sql. Optimize way to execute simple select [ignite-3]

2024-01-29 Thread via GitHub
korlov42 opened a new pull request, #3115: URL: https://github.com/apache/ignite-3/pull/3115 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: #

[PR] IGNITE-21340 Allow removing data with DataStreamer [DRAFT] [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn opened a new pull request, #3114: URL: https://github.com/apache/ignite-3/pull/3114 https://issues.apache.org/jira/browse/IGNITE-21340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
xtern commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1469640591 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/serialization/CatalogEntrySerializationCompatibilityTest.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed

Re: [PR] IGNITE-21278 Add FORCE_INDEX/NO_INDEX hints for calcite engine [ignite-3]

2024-01-29 Thread via GitHub
nva commented on code in PR #3071: URL: https://github.com/apache/ignite-3/pull/3071#discussion_r1469628103 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/logical/ExposeIndexRule.java: ## @@ -71,18 +87,68 @@ public void onMatch(RelOptRuleCall call

Re: [PR] IGNITE-21278 Add FORCE_INDEX/NO_INDEX hints for calcite engine [ignite-3]

2024-01-29 Thread via GitHub
nva commented on code in PR #3071: URL: https://github.com/apache/ignite-3/pull/3071#discussion_r1469627370 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/logical/ExposeIndexRule.java: ## @@ -71,18 +87,68 @@ public void onMatch(RelOptRuleCall call

Re: [PR] IGNITE-21278 Add FORCE_INDEX/NO_INDEX hints for calcite engine [ignite-3]

2024-01-29 Thread via GitHub
zstan commented on code in PR #3071: URL: https://github.com/apache/ignite-3/pull/3071#discussion_r1469627007 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/logical/ExposeIndexRule.java: ## @@ -71,18 +87,68 @@ public void onMatch(RelOptRuleCall ca

Re: [PR] IGNITE-21115 Wait for completion of transactions started before index appearance [ignite-3]

2024-01-29 Thread via GitHub
rpuch commented on code in PR #3095: URL: https://github.com/apache/ignite-3/pull/3095#discussion_r1469146301 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java: ## @@ -495,4 +496,18 @@ public static Collection collectIndexes(

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1469610978 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/serialization/CatalogEntrySerializationCompatibilityTest.java: ## @@ -0,0 +1,429 @@ +/* + * Lice

Re: [PR] IGNITE-21377 Remove redundant tests [ignite-3]

2024-01-29 Thread via GitHub
PakhomovAlexander merged PR #3112: URL: https://github.com/apache/ignite-3/pull/3112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1469600730 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/serialization/CatalogEntrySerializationCompatibilityTest.java: ## @@ -0,0 +1,429 @@ +/* + * Lice

Re: [PR] IGNITE-14823 Session abbrevation [ignite]

2024-01-29 Thread via GitHub
anton-vinogradov commented on code in PR #11205: URL: https://github.com/apache/ignite/pull/11205#discussion_r1469581763 ## modules/web/src/test/java/org/apache/ignite/internal/websession/WebSessionSelfTest.java: ## @@ -1085,9 +1085,9 @@ private String getSessionIdFromCookie(URL

[PR] IGNITE-20491 .NET: Add configurable operation timeout [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn opened a new pull request, #3113: URL: https://github.com/apache/ignite-3/pull/3113 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

[PR] IGNITE-21377 Remove redundant tests [ignite-3]

2024-01-29 Thread via GitHub
valepakh opened a new pull request, #3112: URL: https://github.com/apache/ignite-3/pull/3112 https://issues.apache.org/jira/browse/IGNITE-21377 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1469556183 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningMetadataExtractor.java: ## @@ -0,0 +1,560 @@ +/* + * Licen

[PR] IGNITE-14823 Session abbrevation [ignite]

2024-01-29 Thread via GitHub
nizhikov opened a new pull request, #11205: URL: https://github.com/apache/ignite/pull/11205 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[PR] IGNITE-21017 Tracking RW transaction update operations [ignite-3]

2024-01-29 Thread via GitHub
tkalkirill opened a new pull request, #3111: URL: https://github.com/apache/ignite-3/pull/3111 https://issues.apache.org/jira/browse/IGNITE-21017 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-14823 Service abbrevation [ignite]

2024-01-29 Thread via GitHub
nizhikov merged PR #11195: URL: https://github.com/apache/ignite/pull/11195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1469507139 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningMetadataExtractor.java: ## @@ -0,0 +1,560 @@ +/* + * Licen

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1469503234 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningMetadataExtractor.java: ## @@ -0,0 +1,560 @@ +/* + * Licen

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1469493219 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningColumns.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the

Re: [PR] IGNITE-21277: Sql. Partition pruning. Port partitionExtractor from AI2. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3105: URL: https://github.com/apache/ignite-3/pull/3105#discussion_r1469493219 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningColumns.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the

Re: [PR] IGNITE-21310 Sql. Introduce partition provider for further pruning usage [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3102: URL: https://github.com/apache/ignite-3/pull/3102#discussion_r1469436861 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/AssignmentsResolver.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softw

[PR] IGNITE-21247 Log enhancements for LeaseUpdater [ignite-3]

2024-01-29 Thread via GitHub
denis-chudov opened a new pull request, #3109: URL: https://github.com/apache/ignite-3/pull/3109 https://issues.apache.org/jira/browse/IGNITE-21247 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask b

Re: [PR] IGNITE-21310 Sql. Introduce partition provider for further pruning usage [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3102: URL: https://github.com/apache/ignite-3/pull/3102#discussion_r1469436059 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/AssignmentResolverImpl.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache So

Re: [PR] IGNITE-21310 Sql. Introduce partition provider for further pruning usage [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3102: URL: https://github.com/apache/ignite-3/pull/3102#discussion_r1469434312 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/AssignmentsResolver.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softw

Re: [PR] IGNITE-21310 Sql. Introduce partition provider for further pruning usage [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3102: URL: https://github.com/apache/ignite-3/pull/3102#discussion_r1469434312 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/AssignmentsResolver.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softw

Re: [PR] IGNITE-21310 Sql. Introduce partition provider for further pruning usage [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3102: URL: https://github.com/apache/ignite-3/pull/3102#discussion_r1469431167 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/PartitionResolverImpl.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache So

Re: [PR] IGNITE-21310 Sql. Introduce partition provider for further pruning usage [ignite-3]

2024-01-29 Thread via GitHub
lowka commented on code in PR #3102: URL: https://github.com/apache/ignite-3/pull/3102#discussion_r1469431167 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/PartitionResolverImpl.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache So

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469420017 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java: ## @@ -50,29 +56,82 @@ public class Client

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469414361 ## modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java: ## @@ -261,8 +263,9 @@ public Map> broadcastAsync( return map

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469396180 ## modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java: ## @@ -261,8 +263,9 @@ public Map> broadcastAsync( return map;

Re: [PR] IGNITE-21230 Custom serialization of catalog commands. [ignite-3]

2024-01-29 Thread via GitHub
AMashenkov commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1469389829 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogTableDescriptor.java: ## @@ -219,4 +221,53 @@ public void updateToken(long up

Re: [PR] IGNITE-21146 Error handling in Criteria queries [ignite-3]

2024-01-29 Thread via GitHub
nva commented on code in PR #2989: URL: https://github.com/apache/ignite-3/pull/2989#discussion_r1469385962 ## modules/api/src/main/java/org/apache/ignite/lang/NoMorePagesException.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] IGNITE-21336 Handle ClosedChannelException gracefully [ignite-3]

2024-01-29 Thread via GitHub
sashapolo commented on code in PR #3103: URL: https://github.com/apache/ignite-3/pull/3103#discussion_r1469380024 ## modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettySender.java: ## @@ -41,31 +48,131 @@ public class NettySender { private final s

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469336422 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java: ## @@ -50,29 +56,82 @@ public class Clien

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469336422 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java: ## @@ -50,29 +56,82 @@ public class Clien

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469334828 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/IgniteComputeInternal.java: ## @@ -17,16 +17,45 @@ package org.apache.ignite.internal.compute;

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469323177 ## modules/compute/src/main/java/org/apache/ignite/internal/compute/IgniteComputeInternal.java: ## @@ -17,16 +17,45 @@ package org.apache.ignite.internal.compute;

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469309991 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecuteRequest.java: ## @@ -50,29 +56,82 @@ public class Client

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469285153 ## modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java: ## @@ -261,8 +263,9 @@ public Map> broadcastAsync( return map

Re: [PR] IGNITE-21102 Cluster activated flag replaced with cluster state for --baseline command output [ignite]

2024-01-29 Thread via GitHub
oleg-vlsk commented on code in PR #11138: URL: https://github.com/apache/ignite/pull/11138#discussion_r1469284092 ## modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java: ## @@ -903,7 +908,7 @@ public void testState() throws Exception {

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469282473 ## modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItThinClientWorkerShutdownTest.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apach

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469263365 ## modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java: ## @@ -261,8 +263,9 @@ public Map> broadcastAsync( return map;

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
valepakh commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469256125 ## modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItThinClientWorkerShutdownTest.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#issuecomment-1914221927 @valepakh I'll help with the .NET part once we finalize the protocol changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] IGNITE-21250 Client compute should pass all candidate nodes [ignite-3]

2024-01-29 Thread via GitHub
ptupitsyn commented on code in PR #3104: URL: https://github.com/apache/ignite-3/pull/3104#discussion_r1469205439 ## modules/compute/src/integrationTest/java/org/apache/ignite/internal/compute/ItEmbeddedWorkerShutdownTest.java: ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-20574 Sql. Do not permit to create tables in reserved system schemas [ignite-3]

2024-01-29 Thread via GitHub
zstan merged PR #3081: URL: https://github.com/apache/ignite-3/pull/3081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit