Re: [PR] IGNITE-21435: Sql. Catalog DefaultValue should not depend on Serializable. [ignite-3]

2024-04-23 Thread via GitHub
zstan merged PR #3627: URL: https://github.com/apache/ignite-3/pull/3627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-21937 Sql. Cover SQL F041-05 feature by tests [ignite-3]

2024-04-23 Thread via GitHub
zstan merged PR #3643: URL: https://github.com/apache/ignite-3/pull/3643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-22079 Upgrade spring data extension to spring 6. [ignite-extensions]

2024-04-23 Thread via GitHub
shnus opened a new pull request, #264: URL: https://github.com/apache/ignite-extensions/pull/264 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576570458 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +99,16 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576566401 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +179,26 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576566038 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -239,9 +239,9 @@ public void testNoInteractionsAfterStop() throws

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576565805 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java: ## @@ -191,16 +191,18 @@ public CompletableFuture start() { upda

[PR] IGNITE-22078 Upgrade spring tx extension to spring 6. [ignite-extensions]

2024-04-23 Thread via GitHub
shnus opened a new pull request, #263: URL: https://github.com/apache/ignite-extensions/pull/263 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] IGNITE-22095 Remove compute job jars from the repo [ignite-3]

2024-04-23 Thread via GitHub
valepakh opened a new pull request, #3655: URL: https://github.com/apache/ignite-3/pull/3655 https://issues.apache.org/jira/browse/IGNITE-22095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.rocksdb:rocksdbjni from 8.11.3 to 9.0.1 [ignite-3]

2024-04-23 Thread via GitHub
dependabot[bot] closed pull request #3649: Bump org.rocksdb:rocksdbjni from 8.11.3 to 9.0.1 URL: https://github.com/apache/ignite-3/pull/3649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Bump org.rocksdb:rocksdbjni from 8.11.3 to 9.0.1 [ignite-3]

2024-04-23 Thread via GitHub
dependabot[bot] commented on PR #3649: URL: https://github.com/apache/ignite-3/pull/3649#issuecomment-2072648500 Superseded by #3654. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump org.rocksdb:rocksdbjni from 8.11.3 to 9.1.1 [ignite-3]

2024-04-23 Thread via GitHub
dependabot[bot] opened a new pull request, #3654: URL: https://github.com/apache/ignite-3/pull/3654 Bumps [org.rocksdb:rocksdbjni](https://github.com/facebook/rocksdb) from 8.11.3 to 9.1.1. Release notes Sourced from https://github.com/facebook/rocksdb/releases";>org.rocksdb:rocksd

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-23 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1576438409 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java: ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Founda

Re: [I] IBinarizable : Mapping complex objects [ignite]

2024-04-23 Thread via GitHub
satishviswanathan commented on issue #11325: URL: https://github.com/apache/ignite/issues/11325#issuecomment-2072605768 @ptupitsyn Thank you for your response. This is what I have been trying to do. DDL statement. I have created the following table by executing the DDL statement from

[PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-23 Thread via GitHub
korlov42 opened a new pull request, #3653: URL: https://github.com/apache/ignite-3/pull/3653 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: #

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-23 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1576276569 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java: ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-23 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1576276053 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java: ## @@ -0,0 +1,623 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-23 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1576268912 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItJoinTest.java: ## @@ -843,6 +1067,7 @@ private static Stream joinTypes() {

Re: [PR] [IGNITE-21999] Merge partition free-lists into one [ignite-3]

2024-04-23 Thread via GitHub
ibessonov commented on code in PR #3615: URL: https://github.com/apache/ignite-3/pull/3615#discussion_r1576172447 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/Storable.java: ## @@ -59,5 +67,27 @@ public interface Storable { /** * Returns

[PR] IGNITE-22093: Sql. Rename PlannerPhase::HEP_DECORRELATE [ignite-3]

2024-04-23 Thread via GitHub
lowka opened a new pull request, #3652: URL: https://github.com/apache/ignite-3/pull/3652 https://issues.apache.org/jira/browse/IGNITE-22093 --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask b

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576130991 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +99,16 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576119948 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +179,26 @@ public CompletableFuture start(

Re: [PR] IGNITE-22024 Fixed ItSqlClientSynchronousApiTest#runtimeErrorInDmlCausesTransactionToFail [ignite-3]

2024-04-23 Thread via GitHub
vldpyatkov merged PR #3651: URL: https://github.com/apache/ignite-3/pull/3651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-21805 Refactor TableManager and move all RAFT related pieces to Replica [ignite-3]

2024-04-23 Thread via GitHub
alievmirza commented on code in PR #3633: URL: https://github.com/apache/ignite-3/pull/3633#discussion_r1576080458 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -493,45 +612,92 @@ public CompletableFuture startReplica(

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ptupitsyn merged PR #3640: URL: https://github.com/apache/ignite-3/pull/3640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] IGNITE-22024 Fixed ItSqlClientSynchronousApiTest#runtimeErrorInDmlCausesTransactionToFail [ignite-3]

2024-04-23 Thread via GitHub
denis-chudov opened a new pull request, #3651: URL: https://github.com/apache/ignite-3/pull/3651 https://issues.apache.org/jira/browse/IGNITE-22024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576029691 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogTestUtilsTest.java: ## @@ -80,7 +80,7 @@ void testManagerWorksAsExpected() throws Exception {

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ptupitsyn commented on code in PR #3640: URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1576029209 ## modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java: ## @@ -242,7 +243,17 @@ public CompletableFuture> executeAsync( if (

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ptupitsyn commented on code in PR #3640: URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1576026972 ## modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java: ## @@ -242,7 +243,17 @@ public CompletableFuture> executeAsync( if (

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-23 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576010330 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java: ## @@ -191,16 +191,18 @@ public CompletableFuture start() { upda

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ascherbakoff commented on code in PR #3640: URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1576016843 ## modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java: ## @@ -242,7 +243,17 @@ public CompletableFuture> executeAsync( i

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ptupitsyn commented on code in PR #3640: URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1576009930 ## modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java: ## @@ -419,15 +435,21 @@ private CompletableFuture doSchemaOutInOpAsync(

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ascherbakoff commented on code in PR #3640: URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1575943518 ## modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java: ## @@ -419,15 +435,21 @@ private CompletableFuture doSchemaOutInOpAsync

Re: [PR] IGNITE-19681 Java thin: Add tx partition awareness (lazy tx start) [ignite-3]

2024-04-23 Thread via GitHub
ascherbakoff commented on code in PR #3640: URL: https://github.com/apache/ignite-3/pull/3640#discussion_r1575943518 ## modules/client/src/main/java/org/apache/ignite/internal/client/table/ClientTable.java: ## @@ -419,15 +435,21 @@ private CompletableFuture doSchemaOutInOpAsync

Re: [PR] IGNITE-21943: Cover SQL F561(Full value expressions) feature by tests [ignite-3]

2024-04-23 Thread via GitHub
ygerzhedovich merged PR #3641: URL: https://github.com/apache/ignite-3/pull/3641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-23 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1575792698 ## modules/transactions/src/testFixtures/java/org/apache/ignite/internal/tx/storage/state/test/TestTxStateStorage.java: ## @@ -108,10 +108,15 @@ public boolean co