Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579590642 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579578818 ## modules/client/src/test/java/org/apache/ignite/client/TestServer.java: ## @@ -315,10 +317,11 @@ public FakePlacementDriver placementDriver() { /** {@inheritDoc}

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] Bump org.threeten:threetenbp from 1.6.8 to 1.6.9 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3494: URL: https://github.com/apache/ignite-3/pull/3494#issuecomment-2077339983 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3648: URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077339817 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump com.github.johnrengelman.shadow from 7.1.2 to 8.1.1 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3397: URL: https://github.com/apache/ignite-3/pull/3397#issuecomment-2077338901 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579572557 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579528313 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -126,10 +124,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo merged PR #3659: URL: https://github.com/apache/ignite-3/pull/3659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
rpuch commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579525030 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -350,52 +352,66 @@ private ClusterSta

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579524843 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -91,11 +92,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579522019 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/BaseCatalogManagerTest.java: ## @@ -104,19 +102,16 @@ void setUp() { () ->

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579473233 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -350,52 +352,66 @@ private Cluste

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579471498 ## modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/raft/AbstractClusterStateStorageTest.java: ## @@ -371,11 +330,26 @@ void sn

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
rpuch commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579306454 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -350,52 +352,66 @@ private ClusterSta

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579468084 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest extend

Re: [PR] IGNITE-22095 Remove compute job jars from the repo [ignite-3]

2024-04-25 Thread via GitHub
PakhomovAlexander merged PR #3655: URL: https://github.com/apache/ignite-3/pull/3655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[PR] IGNITE-21953: Cover SQL E021-01(Character string types. CHARACTER data type) feature by tests [ignite-3]

2024-04-25 Thread via GitHub
ygerzhedovich opened a new pull request, #3660: URL: https://github.com/apache/ignite-3/pull/3660 https://issues.apache.org/jira/browse/IGNITE-21953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo opened a new pull request, #3659: URL: https://github.com/apache/ignite-3/pull/3659 https://issues.apache.org/jira/browse/IGNITE-22105 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-22093: Sql. Rename PlannerPhase::HEP_DECORRELATE [ignite-3]

2024-04-25 Thread via GitHub
ygerzhedovich merged PR #3652: URL: https://github.com/apache/ignite-3/pull/3652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-21938 Sql. Cover SQL F041-07 feature by tests [ignite-3]

2024-04-25 Thread via GitHub
ygerzhedovich commented on code in PR #3642: URL: https://github.com/apache/ignite-3/pull/3642#discussion_r1579147174 ## modules/sql-engine/src/integrationTest/sql/join/inner/test_table_from_outer_join_used_in_inner.test: ## @@ -0,0 +1,55 @@ +# name: sql/join/inner/test_table_fr

[PR] Custom Metrics : + LongValueMetric exampls [ignite]

2024-04-25 Thread via GitHub
Vladsz83 opened a new pull request, #11332: URL: https://github.com/apache/ignite/pull/11332 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579111608 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1748,19 +1754,12 @@ public void userFutureCompletesAfterClust

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579110626 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1719,14 +1728,11 @@ public void testColumnEvents() { @T

Re: [PR] IGNITE-22095 Remove compute job jars from the repo [ignite-3]

2024-04-25 Thread via GitHub
PakhomovAlexander commented on code in PR #3655: URL: https://github.com/apache/ignite-3/pull/3655#discussion_r1579100049 ## modules/compute/jobs.gradle: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreem

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579072271 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1748,19 +1754,12 @@ public void userFutureCompletesAfterClu

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579069437 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1167,14 +1180,9 @@ public void catalogActivationTime() throw

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579071207 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1719,14 +1728,11 @@ public void testColumnEvents() {

Re: [PR] IGNITE-21850 Enable LogSinkTest [ignite-3]

2024-04-25 Thread via GitHub
PakhomovAlexander merged PR #3646: URL: https://github.com/apache/ignite-3/pull/3646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579069437 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1167,14 +1180,9 @@ public void catalogActivationTime() throw

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1579037309 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java: ## @@ -0,0 +1,718 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-25 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1579029801 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTxResourcesVacuumTest.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Softw

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

2024-04-25 Thread via GitHub
alievmirza closed pull request #3422: IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys URL: https://github.com/apache/ignite-3/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-25 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1579026948 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionTestUtils.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-25 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1578374314 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/VolatileTxStateMetaStorage.java: ## @@ -118,35 +129,56 @@ public Collection states() {

Re: [PR] IGNITE-22075 GC doesn't wait for RO transactions [ignite-3]

2024-04-25 Thread via GitHub
tkalkirill merged PR #3650: URL: https://github.com/apache/ignite-3/pull/3650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

<    1   2