[GitHub] [ignite-3] ptupitsyn merged pull request #1525: IGNITE-18555 .NET: Enable Gradle daemon in tests

2023-01-16 Thread GitBox
ptupitsyn merged PR #1525: URL: https://github.com/apache/ignite-3/pull/1525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] Pochatkin commented on pull request #1525: IGNITE-18555 .NET: Thin 3.0: Enable Gradle daemon in tests

2023-01-16 Thread GitBox
Pochatkin commented on PR #1525: URL: https://github.com/apache/ignite-3/pull/1525#issuecomment-1383774083 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1502: IGNITE-18491: Add tests for completers

2023-01-16 Thread GitBox
PakhomovAlexander commented on code in PR #1502: URL: https://github.com/apache/ignite-3/pull/1502#discussion_r1071011567 ## modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/core/repl/executor/ItIgnitePicocliCommandsTest.java: ## @@ -356,6 +359,76 @@ void star

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071014604 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071014350 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071012059 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071009735 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071008197 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/AbstractConsistentCutMessagesBlockingTest.java: ## @@ -0,0 +1,173 @@ +/* + * L

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071005323 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-16 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1071005076 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/consistentcut/TransactionTestCase.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-extensions] shishkovilja commented on a diff in pull request #199: IGNITE-18209 Add check of a lag in a metadata topic

2023-01-16 Thread GitBox
shishkovilja commented on code in PR #199: URL: https://github.com/apache/ignite-extensions/pull/199#discussion_r1070906078 ## modules/cdc-ext/src/test/java/org/apache/ignite/cdc/kafka/CdcKafkaReplicationTest.java: ## @@ -72,8 +72,8 @@ public class CdcKafkaReplicationTest extend

[GitHub] [ignite-3] ptupitsyn merged pull request #1522: IGNITE-18509 .NET: Remove unused CompileMemberReader logic

2023-01-16 Thread GitBox
ptupitsyn merged PR #1522: URL: https://github.com/apache/ignite-3/pull/1522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1515: IGNITE-18522

2023-01-15 Thread GitBox
vldpyatkov commented on code in PR #1515: URL: https://github.com/apache/ignite-3/pull/1515#discussion_r1069121431 ## modules/transactions/README.md: ## @@ -12,7 +12,7 @@ like parallel commits from [1](#f1) # Transaction protocol design (first iteration) At a high level, we

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-15 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1070922231 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -101,23 +105,13 @@ public void rollback() throws TransactionExc

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-15 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1070922077 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -87,9 +82,18 @@ public void commit() throws TransactionExceptio

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-15 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1070908480 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItImplicitCastsTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [ignite-extensions] shishkovilja commented on pull request #199: IGNITE-18209 Add check of a lag in a metadata topic

2023-01-15 Thread GitBox
shishkovilja commented on PR #199: URL: https://github.com/apache/ignite-extensions/pull/199#issuecomment-1383597293 Actual test runs: [Extensions RunAllTets](https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_RunAllTests/7007707?buildTab=overview&hideProblemsFrom

[GitHub] [ignite-extensions] shishkovilja commented on a diff in pull request #199: IGNITE-18209 Add check of a lag in a metadata topic

2023-01-15 Thread GitBox
shishkovilja commented on code in PR #199: URL: https://github.com/apache/ignite-extensions/pull/199#discussion_r1070906078 ## modules/cdc-ext/src/test/java/org/apache/ignite/cdc/kafka/CdcKafkaReplicationTest.java: ## @@ -72,8 +72,8 @@ public class CdcKafkaReplicationTest extend

[GitHub] [ignite-3] zstan opened a new pull request, #1524: IGNITE-18464 Sql. Colocated sort aggregates need to compose a plans with additional sort

2023-01-15 Thread GitBox
zstan opened a new pull request, #1524: URL: https://github.com/apache/ignite-3/pull/1524 …ith additional sort -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-15 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1070897160 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-15 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1070891456 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache

[GitHub] [ignite] nizhikov merged pull request #10478: IGNITE-18533 Management API to kill client connection

2023-01-14 Thread GitBox
nizhikov merged PR #10478: URL: https://github.com/apache/ignite/pull/10478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-web-console] dependabot[bot] opened a new pull request, #22: Bump global-modules-path and webpack-cli in /modules/frontend

2023-01-13 Thread GitBox
dependabot[bot] opened a new pull request, #22: URL: https://github.com/apache/ignite-web-console/pull/22 Removes [global-modules-path](https://github.com/rosen-vladimirov/global-modules-path). It's no longer used after updating ancestor dependency [webpack-cli](https://github.com/webpack/

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069656604 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -47,6 +49,57 @@ public IgniteTypeCoercion(RelDataTypeFac

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069645394 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069613106 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Sof

[GitHub] [ignite-3] lowka commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
lowka commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069609710 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -47,6 +49,57 @@ public IgniteTypeCoercion(RelDataTypeFac

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069581125 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069574400 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/TypeCoercionTest.java: ## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069519179 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -47,6 +49,57 @@ public IgniteTypeCoercion(RelDataType

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1069516677 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java: ## @@ -3130,6 +3143,50 @@ public DistributedTransactionCo

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069514603 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -47,6 +49,57 @@ public IgniteTypeCoercion(RelDataType

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1069500134 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java: ## @@ -879,6 +898,33 @@ private IgniteInter

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1069491997 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java: ## @@ -3130,6 +3143,50 @@ public DistributedTransactionCo

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069490651 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1513: IGNITE-18163: Old-style join on different column types fails with ClassCastException

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1513: URL: https://github.com/apache/ignite-3/pull/1513#discussion_r1069486926 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/LeastRestrictiveTypesTest.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-13 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1069449286 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1931,19 +1944,19 @@ private HybridTimesta

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-13 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1069400175 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/BaseMvStoragesTest.java: ## @@ -102,23 +104,20 @@ static void afterAll() { kB

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1069352124 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxHandler.java: ## @@ -218,73 +222,151 @@ public IgniteTxHandler(GridCach

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-13 Thread GitBox
korlov42 commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1068293570 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/TableRowAndRowId.java: ## @@ -18,31 +18,32 @@ package org.apache.ignite.internal.storage;

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1069255142 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/serializer/RecordDataV1Serializer.java: ## @@ -1293,6 +1303,25 @@ WALRecord

[GitHub] [ignite] nizhikov commented on a diff in pull request #10314: IGNITE-17029 Consistent Cut for incremental snapshot

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10314: URL: https://github.com/apache/ignite/pull/10314#discussion_r1069251409 ## modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/record/ConsistentCutFinishRecord.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10478: IGNITE-18533 Management API to kill client connection

2023-01-13 Thread GitBox
timoninmaxim commented on code in PR #10478: URL: https://github.com/apache/ignite/pull/10478#discussion_r1069243003 ## modules/core/src/main/java/org/apache/ignite/internal/sql/command/SqlKillClientCommand.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [ignite-3] SammyVimes merged pull request #1514: IGNITE-17833 Implement partition destruction for volatile PageMemory

2023-01-13 Thread GitBox
SammyVimes merged PR #1514: URL: https://github.com/apache/ignite-3/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] tkalkirill merged pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-13 Thread GitBox
tkalkirill merged PR #1518: URL: https://github.com/apache/ignite-3/pull/1518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] ibessonov merged pull request #1520: IGNITE-18547 Fixed issue when IDEA would show NOTE messages as errors

2023-01-13 Thread GitBox
ibessonov merged PR #1520: URL: https://github.com/apache/ignite-3/pull/1520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-13 Thread GitBox
vldpyatkov commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1069181212 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -31,23 +32,17 @@ * Client transaction. */ public class Clien

[GitHub] [ignite] nizhikov commented on a diff in pull request #10478: IGNITE-18533 Management API to kill client connection

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10478: URL: https://github.com/apache/ignite/pull/10478#discussion_r1069196091 ## modules/indexing/src/test/java/org/apache/ignite/util/KillCommandsTests.java: ## @@ -472,6 +479,40 @@ public static void doTestCancelContinuousQuery(IgniteEx cli,

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-13 Thread GitBox
rpuch commented on code in PR #1518: URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069169335 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/SimpleCondition.java: ## @@ -20,46 +20,101 @@ /** * Represents a condition for a m

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-13 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1069161791 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -959,14 +959,20 @@ private Completable

[GitHub] [ignite-3] ptupitsyn merged pull request #1519: IGNITE-18395 .NET: Remove MessagePack library dependency

2023-01-13 Thread GitBox
ptupitsyn merged PR #1519: URL: https://github.com/apache/ignite-3/pull/1519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] nizhikov commented on a diff in pull request #10478: IGNITE-18533 Management API to kill client connection

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10478: URL: https://github.com/apache/ignite/pull/10478#discussion_r1069153360 ## docs/_docs/sql-reference/operational-commands.adoc: ## @@ -397,3 +397,30 @@ control.bat --kill CONSISTENCY -- +== KILL CLIENT operations + +The `KILL CLIE

[GitHub] [ignite] nizhikov commented on a diff in pull request #10478: IGNITE-18533 Management API to kill client connection

2023-01-13 Thread GitBox
nizhikov commented on code in PR #10478: URL: https://github.com/apache/ignite/pull/10478#discussion_r1069152269 ## modules/control-utility/src/test/java/org/apache/ignite/util/KillCommandsControlShTest.java: ## @@ -153,6 +154,18 @@ public void testCancelContinuousQuery() throws

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-13 Thread GitBox
sashapolo commented on code in PR #1518: URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069126579 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/Operation.java: ## @@ -17,158 +17,90 @@ package org.apache.ignite.internal.met

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-13 Thread GitBox
sashapolo commented on code in PR #1518: URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069126156 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/Entry.java: ## @@ -37,7 +35,7 @@ public interface Entry { * * @return The

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-13 Thread GitBox
sashapolo commented on code in PR #1518: URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069123280 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/watch/WatchAggregatorTest.java: ## @@ -274,8 +274,8 @@ private Entry entry(String key, St

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-13 Thread GitBox
sashapolo commented on code in PR #1518: URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069122823 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/EntryImpl.java: ## @@ -19,17 +19,32 @@ import java.util.Arrays; import org.apach

[GitHub] [ignite-3] ibessonov opened a new pull request, #1520: IGNITE-18547 Fixed issue when IDEA would show NOTE messages as errors

2023-01-13 Thread GitBox
ibessonov opened a new pull request, #1520: URL: https://github.com/apache/ignite-3/pull/1520 https://issues.apache.org/jira/browse/IGNITE-18547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite] timoninmaxim commented on a diff in pull request #10478: IGNITE-18533 Management API to kill client connection

2023-01-13 Thread GitBox
timoninmaxim commented on code in PR #10478: URL: https://github.com/apache/ignite/pull/10478#discussion_r1069040421 ## modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/query/KillCommand.java: ## @@ -212,6 +215,24 @@ public class KillCommand extends A

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-12 Thread GitBox
rpuch commented on code in PR #1518: URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1068984477 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/Operation.java: ## @@ -17,158 +17,90 @@ package org.apache.ignite.internal.metasto

[GitHub] [ignite] asfgit closed pull request #10467: IGNITE-18439 SQL Calcite: Take into account TTL of entries during scans

2023-01-12 Thread GitBox
asfgit closed pull request #10467: IGNITE-18439 SQL Calcite: Take into account TTL of entries during scans URL: https://github.com/apache/ignite/pull/10467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1514: IGNITE-17833 Implement partition destruction for volatile PageMemory

2023-01-12 Thread GitBox
rpuch commented on code in PR #1514: URL: https://github.com/apache/ignite-3/pull/1514#discussion_r1068971058 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/util/GradualTaskExecutor.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [ignite] rkondakov closed pull request #7645: Ignite 2.5.19 Release

2023-01-12 Thread GitBox
rkondakov closed pull request #7645: Ignite 2.5.19 Release URL: https://github.com/apache/ignite/pull/7645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [ignite] rkondakov closed pull request #7895: IGNITE-13070 SQL regressions detection framework

2023-01-12 Thread GitBox
rkondakov closed pull request #7895: IGNITE-13070 SQL regressions detection framework URL: https://github.com/apache/ignite/pull/7895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [ignite] ivandasch merged pull request #10476: IGNITE-18494 Fix ignoring near cache configuration while starting cache not from affinity node

2023-01-12 Thread GitBox
ivandasch merged PR #10476: URL: https://github.com/apache/ignite/pull/10476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] alex-plekhanov commented on a diff in pull request #10476: IGNITE-18494 Fix ignoring near cache configuration while starting cache not from affinity node

2023-01-12 Thread GitBox
alex-plekhanov commented on code in PR #10476: URL: https://github.com/apache/ignite/pull/10476#discussion_r1068262300 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/near/GridCacheNearDynamicStartTest.java: ## @@ -0,0 +1,157 @@ +/* + * Lice

[GitHub] [ignite-3] alievmirza commented on a diff in pull request #1508: IGNITE-18121 add scale up scheduler

2023-01-12 Thread GitBox
alievmirza commented on code in PR #1508: URL: https://github.com/apache/ignite-3/pull/1508#discussion_r1068476869 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -806,4 +866,230 @@ private static Throw

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1508: IGNITE-18121 add scale up scheduler

2023-01-12 Thread GitBox
sanpwc commented on code in PR #1508: URL: https://github.com/apache/ignite-3/pull/1508#discussion_r1067796294 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java: ## @@ -103,6 +123,14 @@ public class Distribution

[GitHub] [ignite] Vladsz83 opened a new pull request, #10480: IGNITE-18226 : [IEP-80] Remove CacheGroupMetricsMXBean legacy JMX metrics bean , v2 : remove the management too

2023-01-12 Thread GitBox
Vladsz83 opened a new pull request, #10480: URL: https://github.com/apache/ignite/pull/10480 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite-3] sashapolo opened a new pull request, #1518: IGNITE-18542 Remove some server-side MetaStorage classes

2023-01-12 Thread GitBox
sashapolo opened a new pull request, #1518: URL: https://github.com/apache/ignite-3/pull/1518 https://issues.apache.org/jira/browse/IGNITE-18542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1514: IGNITE-17833 Implement partition destruction for volatile PageMemory

2023-01-12 Thread GitBox
SammyVimes commented on code in PR #1514: URL: https://github.com/apache/ignite-3/pull/1514#discussion_r1068193800 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/util/GradualTaskExecutor.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite-3] ibessonov merged pull request #1517: IGNITE-18541 AbstractBplusTreePageMemoryTest "optimized".

2023-01-12 Thread GitBox
ibessonov merged PR #1517: URL: https://github.com/apache/ignite-3/pull/1517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] ibessonov merged pull request #1516: IGNITE-18543: Remove missed pom.xml

2023-01-12 Thread GitBox
ibessonov merged PR #1516: URL: https://github.com/apache/ignite-3/pull/1516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] ibessonov opened a new pull request, #1517: IGNITE-18541 AbstractBplusTreePageMemoryTest "optimized".

2023-01-12 Thread GitBox
ibessonov opened a new pull request, #1517: URL: https://github.com/apache/ignite-3/pull/1517 https://issues.apache.org/jira/browse/IGNITE-18541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-12 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1068092636 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18227: Make composite publisher is thread safe

2023-01-12 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1068092636 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18227: Make composite publisher is thread safe

2023-01-12 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1068051235 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [ignite-3] denis-chudov opened a new pull request, #1515: IGNITE-18522

2023-01-12 Thread GitBox
denis-chudov opened a new pull request, #1515: URL: https://github.com/apache/ignite-3/pull/1515 https://issues.apache.org/jira/browse/IGNITE-18522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [ignite-3] vldpyatkov merged pull request #1493: IGNITE-18456 Explain treading model in corresponding README.md file f…

2023-01-12 Thread GitBox
vldpyatkov merged PR #1493: URL: https://github.com/apache/ignite-3/pull/1493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-12 Thread GitBox
vldpyatkov commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1068001360 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -959,14 +959,20 @@ private CompletableFu

[GitHub] [ignite] ilhomu opened a new pull request, #10479: IGNITE-18511 Added details to Calcite parser exception

2023-01-12 Thread GitBox
ilhomu opened a new pull request, #10479: URL: https://github.com/apache/ignite/pull/10479 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The

[GitHub] [ignite-3] ibessonov merged pull request #1499: IGNITE-18508 Fix metastorage gradle publishing

2023-01-12 Thread GitBox
ibessonov merged PR #1499: URL: https://github.com/apache/ignite-3/pull/1499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] Pochatkin commented on pull request #1499: IGNITE-18508 Fix metastorage gradle publishing

2023-01-12 Thread GitBox
Pochatkin commented on PR #1499: URL: https://github.com/apache/ignite-3/pull/1499#issuecomment-1380146227 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [ignite-3] asfgit closed pull request #1421: IGNITE-17487: Remove maven project

2023-01-12 Thread GitBox
asfgit closed pull request #1421: IGNITE-17487: Remove maven project URL: https://github.com/apache/ignite-3/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [ignite-3] ptupitsyn merged pull request #1368: IGNITE-18230 Packaging: Add MSI installer for winget package

2023-01-11 Thread GitBox
ptupitsyn merged PR #1368: URL: https://github.com/apache/ignite-3/pull/1368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] ptupitsyn merged pull request #1512: IGNITE-18530 Fix integration test failures on Windows

2023-01-11 Thread GitBox
ptupitsyn merged PR #1512: URL: https://github.com/apache/ignite-3/pull/1512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] nizhikov closed pull request #10143: IGNITE-17327 New inspections added

2023-01-11 Thread GitBox
nizhikov closed pull request #10143: IGNITE-17327 New inspections added URL: https://github.com/apache/ignite/pull/10143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [ignite] nizhikov opened a new pull request, #10478: IGNITE-18533 Management API to kill client connection

2023-01-11 Thread GitBox
nizhikov opened a new pull request, #10478: URL: https://github.com/apache/ignite/pull/10478 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1493: IGNITE-18456 Explain treading model in corresponding README.md file f…

2023-01-11 Thread GitBox
vldpyatkov commented on code in PR #1493: URL: https://github.com/apache/ignite-3/pull/1493#discussion_r1067424114 ## modules/metastorage/README.md: ## @@ -0,0 +1,45 @@ +# Metastorage + +The module for storing and accessing metadata. This module is linked to another one: + +- m

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1493: IGNITE-18456 Explain treading model in corresponding README.md file f…

2023-01-11 Thread GitBox
vldpyatkov commented on code in PR #1493: URL: https://github.com/apache/ignite-3/pull/1493#discussion_r1067423291 ## modules/metastorage/README.md: ## @@ -0,0 +1,45 @@ +# Metastorage + +The module for storing and accessing metadata. This module is linked to another one: + +- m

[GitHub] [ignite] Vladsz83 opened a new pull request, #10477: IGNITE-18232 : Remove jmx bean

2023-01-11 Thread GitBox
Vladsz83 opened a new pull request, #10477: URL: https://github.com/apache/ignite/pull/10477 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #1493: IGNITE-18456 Explain treading model in corresponding README.md file f…

2023-01-11 Thread GitBox
denis-chudov commented on code in PR #1493: URL: https://github.com/apache/ignite-3/pull/1493#discussion_r1067125861 ## modules/metastorage/README.md: ## @@ -0,0 +1,45 @@ +# Metastorage + +The module for storing and accessing metadata. This module is linked to another one: + +-

[GitHub] [ignite] ivandasch opened a new pull request, #10476: IGNITE-18494 Fix ignoring near cache configuration while starting cache not from affinity node.

2023-01-11 Thread GitBox
ivandasch opened a new pull request, #10476: URL: https://github.com/apache/ignite/pull/10476 …he not from affinity node. Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-11 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1066963298 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientTransactionsTest.java: ## @@ -199,21 +200,23 @@ void testAcces

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-11 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1066963853 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -981,7 +989,7 @@ private CompletableFu

[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1503: IGNITE-18324 Calling tx.rollback() or tx.commit() is not failed for committed transaction.

2023-01-11 Thread GitBox
sergeyuttsel commented on code in PR #1503: URL: https://github.com/apache/ignite-3/pull/1503#discussion_r1066963011 ## modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java: ## @@ -34,11 +34,8 @@ public class ClientTransaction implements Trans

[GitHub] [ignite-3] rpuch opened a new pull request, #1514: IGNITE-17833 Implement partition destruction for volatile PageMemory

2023-01-11 Thread GitBox
rpuch opened a new pull request, #1514: URL: https://github.com/apache/ignite-3/pull/1514 https://issues.apache.org/jira/browse/IGNITE-17833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ignite] ptupitsyn merged pull request #10474: IGNITE-18519 Change parameter name in the SQL Query view docs

2023-01-11 Thread GitBox
ptupitsyn merged PR #10474: URL: https://github.com/apache/ignite/pull/10474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite-3] valepakh opened a new pull request, #1512: IGNITE-18530 Integration test failures on Windows

2023-01-11 Thread GitBox
valepakh opened a new pull request, #1512: URL: https://github.com/apache/ignite-3/pull/1512 https://issues.apache.org/jira/browse/IGNITE-18530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1511: IGNITE-18227: Make composite publisher is thread safe

2023-01-11 Thread GitBox
AMashenkov commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1066719998 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -107,14 +109,20 @@ public void subscribe(Subscriber

<    1   2   3   4   5   6   7   8   9   10   >