Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670522701 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean doBinaryComparisonCoer

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670511320 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean doBinaryComparisonCoer

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670510066 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -91,6 +95,34 @@ public boolean binaryComparisonCoercion(

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670260310 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -91,6 +95,34 @@ public boolean binaryComparisonCoercion(

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670222303 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/IndexSearchBoundsPlannerTest.java: ## @@ -314,14 +314,14 @@ public void testBoundsMaxCo

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669718857 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -116,6 +118,152 @@ public void testUnicodeStrings() {

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669718364 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -116,6 +118,152 @@ public void testUnicodeStrings() {

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669714984 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean doBinaryComparisonCoer

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669715421 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/IndexSearchBoundsPlannerTest.java: ## @@ -314,14 +314,14 @@ public void testBoundsMaxCo

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669700418 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -604,10 +611,71 @@ public RelDataType deriveType(SqlVali

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669698826 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -547,6 +590,11 @@ RelDataType syncAttributes(

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669619160 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -547,6 +590,11 @@ RelDataType syncAttributes(

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669630872 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean doBinaryComparisonCoer

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669630872 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean doBinaryComparisonCoer

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669629075 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -91,6 +95,34 @@ public boolean binaryComparisonCoercion(

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669623927 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -91,6 +95,34 @@ public boolean binaryComparisonCoercion(

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669619160 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -547,6 +590,11 @@ RelDataType syncAttributes(

[PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

zstan opened a new pull request, #4034: URL: https://github.com/apache/ignite-3/pull/4034 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###