[GitHub] [james-project] chibenwa commented on a diff in pull request #1525: Support `start-dev` argument when running Memory James server

2023-04-26 Thread via GitHub
chibenwa commented on code in PR #1525: URL: https://github.com/apache/james-project/pull/1525#discussion_r1178574698 ## server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPConfigurationStartUpCheck.java: ## @@ -69,8 +105,71 @@ private

[GitHub] [james-project] chibenwa commented on a diff in pull request #1525: Support `start-dev` argument when running Memory James server

2023-04-26 Thread via GitHub
chibenwa commented on code in PR #1525: URL: https://github.com/apache/james-project/pull/1525#discussion_r1178574571 ## server/apps/memory-app/README.md: ## @@ -32,6 +32,15 @@ keytool -genkey -alias james -keyalg RSA -keystore keystore docker run -v

[GitHub] [james-project] chibenwa commented on a diff in pull request #1525: Support `start-dev` argument when running Memory James server

2023-04-26 Thread via GitHub
chibenwa commented on code in PR #1525: URL: https://github.com/apache/james-project/pull/1525#discussion_r1178548861 ## server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/draft/JMAPConfigurationStartUpCheck.java: ## @@ -69,8 +105,71 @@ private

[GitHub] [james-project] chibenwa commented on a diff in pull request #1525: Support `start-dev` argument when running Memory James server

2023-04-21 Thread via GitHub
chibenwa commented on code in PR #1525: URL: https://github.com/apache/james-project/pull/1525#discussion_r1173467634 ## server/apps/memory-app/README.md: ## @@ -32,6 +32,14 @@ keytool -genkey -alias james -keyalg RSA -keystore keystore docker run -v

[GitHub] [james-project] chibenwa commented on a diff in pull request #1525: Support `start-dev` argument when running Memory James server

2023-04-17 Thread via GitHub
chibenwa commented on code in PR #1525: URL: https://github.com/apache/james-project/pull/1525#discussion_r1169413379 ## server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/crypto/SecurityKeyLoader.java: ## @@ -45,25 +67,48 @@ import