chibenwa commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1994648347
How about being clever and reworking `AttachmentId`?
We could have:
- An interface with a Factory for `AttachmentId`
- Current AttachmentId class be renamed as`
hungphan227 closed pull request #2048: JAMES-2586 Fix some jmap postgres
integration tests
URL: https://github.com/apache/james-project/pull/2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1993147029
The JMAP integration test part seems to take often 40 ~ 50 minutes to
complete which is too long (we consider less than 30 minutes ok)
@hungphan227 Can we investigate again?
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1990927785
Build was green (finally)
I squashed and rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1989922553
11:29:37,710 [INFO] Apache James :: Server :: JMAP RFC-8621 :: Postgres
Integration Testing FAILURE [46:53 min]
46 mins... Maybe unstable CI or maybe not. Will restart the
vttranlina commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1987633242
> Thanks.
>
> Can you test guys locally on those tests and make sure it passes with
those fixes? =>
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1987619546
Thanks.
Can you test guys locally on those tests and make sure it passes with those
fixes? =>
vttranlina commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1987593874
> fixup! JAMES-2586 Optimize AttachmentLoader
Fixed
https://github.com/apache/james-project/pull/2048/commits/144ac90c6483eda966301297afcf9c5cc73e55d6
Reason:
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1985339243
@hungphan227 @vttranlina I'm going on my PR to test back without the last
commit, could not fix it.
Feel free to fix it yourselves if you want it back
For example
Arsnael commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1517293461
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
Arsnael commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1517293461
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1983105836
@quantranhong1999 => https://github.com/apache/james-project/pull/2095
My 50 cents, let's see :)
--
This is an automated message from the Apache Git Service.
To respond to
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1983038335
No I don't think so... I think I have a clue, and maybe we are a bit unlucky
on some of our builds... let me try something and open an other PR, I noticed a
pattern when such thing
quantranhong1999 commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1982954684
> I'm suspecting something being potentially unstable on our side as all the
timeout builds have occured on different workers in the last few days
Any chance it is
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1982919726
```
03:25:25.251 [INFO ] o.a.j.b.p.DockerPostgresSingleton - 2024-03-07
03:25:25.250 UTC [62] LOG: checkpoint starting: time
03:27:57.599 [INFO ]
vttranlina commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1980085869
> Related to the ci failed
bodyStructureShouldSupportSpecificHeaders(GuiceJamesServer)
we can cherry-pick fixup commit:
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513805508
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513797407
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
vttranlina commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1980061620
Related to the ci failed
```
bodyStructureShouldSupportSpecificHeaders(GuiceJamesServer) –
org.apache.james.jmap.rfc8621.postgres.PostgresEmailGetMethodTest
JSON
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513787434
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513757850
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresAttachmentDAO.java:
##
@@ -80,9 +83,20 @@ public Mono>
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513738873
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513733102
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1513733102
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresMessageIdMapper.java:
##
@@ -130,18 +142,44 @@ public Publisher
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1512598925
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresAttachmentDAO.java:
##
@@ -80,9 +83,20 @@ public Mono>
Arsnael commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1975924591
Please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
quantranhong1999 commented on PR #2048:
URL: https://github.com/apache/james-project/pull/2048#issuecomment-1970391358
org.apache.james.events.PostgresEventDeadLettersTest
Related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502284797
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresAttachmentDAO.java:
##
@@ -80,9 +84,21 @@ public Mono>
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502284352
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresAttachmentModule.java:
##
@@ -35,20 +35,22 @@ public interface
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502211561
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresAttachmentDAO.java:
##
@@ -80,9 +84,21 @@ public Mono>
vttranlina commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502032559
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresAttachmentDAO.java:
##
@@ -80,9 +84,21 @@ public Mono>
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502017082
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresAttachmentModule.java:
##
@@ -35,20 +35,22 @@ public interface
Arsnael commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502013047
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresAttachmentModule.java:
##
@@ -35,20 +35,22 @@ public interface
hungphan227 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1502005171
##
quantranhong1999 commented on code in PR #2048:
URL: https://github.com/apache/james-project/pull/2048#discussion_r1501987659
##
35 matches
Mail list logo
