Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds-pull-requests #965](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/965/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-48007875

Jenkins build is back to normal : jclouds » jclouds-labs-openstack #1375

See

Jenkins build is back to normal : jclouds » jclouds-labs-google #1095

See

Jenkins build is back to normal : jclouds » jclouds-chef #1149

See

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds » jclouds #1330](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1330/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomme

Jenkins build is back to normal : jclouds » jclouds #1330

See

[jira] [Resolved] (JCLOUDS-112) Jclouds fails with Keystone V3 API Token

[ https://issues.apache.org/jira/browse/JCLOUDS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-112. Resolution: Not a Problem Assignee: Jeremy Daggett > Jclouds fails with Keystone V3

[jira] [Commented] (JCLOUDS-112) Jclouds fails with Keystone V3 API Token

[ https://issues.apache.org/jira/browse/JCLOUDS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052097#comment-14052097 ] Jeremy Daggett commented on JCLOUDS-112: jclouds fails because the Keystone v3 AP

[jira] [Updated] (JCLOUDS-111) hpcloud-compute - Error while setting strRegion - region-b.geo-1 (a new region)

[ https://issues.apache.org/jira/browse/JCLOUDS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-111: --- Assignee: Chris Custine > hpcloud-compute - Error while setting strRegion - region-b.geo-1 (

[jira] [Updated] (JCLOUDS-238) api/openstack-compute supports only a per AZ deployment model

[ https://issues.apache.org/jira/browse/JCLOUDS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-238: --- Assignee: Chris Custine > api/openstack-compute supports only a per AZ deployment model > --

Re: [jclouds-labs-aws] JCLOUDS-457: uploadPart return type fix (#35)

[jclouds-labs-aws-pull-requests #72](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/72/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/35#issuecomment-47996276

Re: [jclouds-labs-aws] JCLOUDS-457: uploadPart return type fix (#35)

[jclouds » jclouds-labs-aws #1103](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1103/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-

[jclouds-labs-aws] JCLOUDS-457: uploadPart return type fix (#35)

The uploadPart method now returns HashCode instead of String. You can merge this Pull Request by running: git pull https://github.com/rcoedo/jclouds-labs-aws hashcodefix Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-aws/pull/35 -- Commit Summ

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

@demobox clicking that link above gives this exception: [ERROR] /scratch/jenkins/workspace/jclouds-java-7-pull-requests/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/strategy/ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet.java:[157,118] canno

[jira] [Resolved] (JCLOUDS-555) Duplicate bouncycastle resources when depending on MockWebServer

[ https://issues.apache.org/jira/browse/JCLOUDS-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul resolved JCLOUDS-555. - Resolution: Fixed Addressed by https://github.com/jclouds/jclouds/pull/413 . > Duplicate bouncy

[jira] [Assigned] (JCLOUDS-555) Duplicate bouncycastle resources when depending on MockWebServer

[ https://issues.apache.org/jira/browse/JCLOUDS-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul reassigned JCLOUDS-555: --- Assignee: Andrew Gaul (was: Everett Toews) > Duplicate bouncycastle resources when dependin

Re: [jclouds] Consistently use Square's mockwebserver (#413)

Let's skip backporting to 1.7.x. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/413#issuecomment-47994211

Re: [jclouds-labs-aws] JCLOUDS-457: Using assertj assertions (#34)

> @@ -99,15 +92,10 @@ public void testListMultipartUploads() throws Exception { >long partSizeInMb = 1; >String uploadId = api.initiateMultipartUpload(VAULT_NAME1, > partSizeInMb); >try { > - assertNotNull(api.uploadPart(VAULT_NAME1, uploadId, > - Cont

[jira] [Resolved] (JCLOUDS-584) Update HP Cloud object storage provider

[ https://issues.apache.org/jira/browse/JCLOUDS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett resolved JCLOUDS-584. Resolution: Done > Update HP Cloud object storage provider > -

[jira] [Updated] (JCLOUDS-584) Update HP Cloud object storage provider

[ https://issues.apache.org/jira/browse/JCLOUDS-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Daggett updated JCLOUDS-584: --- Assignee: Chris Custine > Update HP Cloud object storage provider >

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds-java-7-pull-requests #1435](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1435/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47990078

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds-pull-requests #964](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/964/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47989800

Re: [jclouds-labs-aws] Using assertj assertions (#34)

[jclouds-labs-aws-pull-requests #71](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/71/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/34#issuecomment-47989506

Re: [jclouds-labs-aws] Using assertj assertions (#34)

[jclouds » jclouds-labs-aws #1101](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/1101/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-

Build failed in Jenkins: jclouds » jclouds #1329

See Changes: [dancc] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPApi.create() [dancc] Code cleanup. No functionalty added or removed [dancc] AllocateAndAddFloatingIpToNode gained private method '

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds » jclouds #1329](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1329/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> IMO this is a reasonable tradeoff. OK, then let's keep as-is. > Also I see jenkins/cloudbees failing due to checkstyle issues. Checkstyle should never cause these builds to fail red. [This one](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1434/console) looks like a compi

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

Also I see jenkins/cloudbees failing due to checkstyle issues. I'm using the below checkstyle command on my code base and it's running fine. mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain --- Reply to this email directly or view it on Gi

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

@demobox looking over things I'm actually going to argue FOR keeping the AtomicReferences inside NodeAndNovaTemplateOptions. The reason being is that we are constantly passing around AtomicReference and so it makes things immensely easier to retrieve it rather than constantly unpacking/packing

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

It was easier to keep the wrapped version inside ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet which is why I did so. Let me see if I can clean things up a bit --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecommen

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> > + floatingIpApi.addToServer(ip.get().getIp(), node.getProviderId()); > + > input.get().getNodeMetadata().set(NodeMetadataBuilder.fromNodeMetadata(node).publicAddresses(ImmutableSet.of(ip.get().getIp())).build()); > + floatingIpCache.invalidate(ZoneAndId.fromSlashEncoded(node.g

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds-java-7-pull-requests #1434](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1434/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47982995

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds-pull-requests #963](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/963/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47982976

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> } > - > + on it --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425/files#r14537102

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> @@ -184,13 +207,25 @@ public boolean shouldAutoAssignFloatingIp() { > } > > /** > +* The floating IP pool name(s) to use when allocating a FloatingIP. > Applicable > +* only if If #shouldGenerateKeyPair() returns true. If not set will > attempt to Yes and yes. Fixing now ;)

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

Just to verify: from what I can see in the code, we now have three possible branches for assigning IPs: find from pool, create, find fixed unused (or something like that). Are all three scenarios covered by tests? Thanks for the update, @cdancy! --- Reply to this email directly or view it on Gi

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> @@ -184,13 +207,25 @@ public boolean shouldAutoAssignFloatingIp() { > } > > /** > +* The floating IP pool name(s) to use when allocating a FloatingIP. > Applicable > +* only if If #shouldGenerateKeyPair() returns true. If not set will > attempt to [minor] "if If"? --- Reply

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> > + floatingIpApi.addToServer(ip.get().getIp(), node.getProviderId()); > + > input.get().getNodeMetadata().set(NodeMetadataBuilder.fromNodeMetadata(node).publicAddresses(ImmutableSet.of(ip.get().getIp())).build()); > + floatingIpCache.invalidate(ZoneAndId.fromSlashEncoded(node.g

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

>// node's location is a host >String zoneId = node.getLocation().getParent().getId(); >FloatingIPApi floatingIpApi = > novaApi.getFloatingIPExtensionForZone(zoneId).get(); > + Optional> poolNames = > input.get().getNovaTemplateOptions().get().getFloatingIpPoolNames()

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> @@ -68,41 +71,83 @@ public > AllocateAndAddFloatingIpToNode(@Named(TIMEOUT_NODE_RUNNING) Predicate } > > @Override > - public AtomicReference apply(AtomicReference > input) { > - checkState(nodeRunning.apply(input), "node never achieved state > running %s", input.get()); > -

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

Is `NodeAndNovaTemplateOptions` missing from the PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47981723

Build failed in Jenkins: jclouds » jclouds #1328

See Changes: [dancc] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPApi.create() [dancc] Code cleanup. No functionalty added or removed [dancc] AllocateAndAddFloatingIpToNode gained private method '

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

[jclouds » jclouds #1328](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1328/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> } > - > + [minor] Remove the whitespace here? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425/files#r14536596

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

> * Specifies the keypair used to run instances with > * @return the keypair to be used > */ > public String getKeyPairName() { >return keyPairName; > } > - > + [minor] Remove the whitespace here? --- Reply to this email directly or view it on GitHub: https://git

Re: [jclouds] JCLOUDS-607: ComputeService.createNodesInGroup throws NPE on FloatingIPA... (#425)

I'd love some feedback on latest commit. Instead of pushing off the second PR noted above I've included those proposed changed here as it's the proper way to solve the problem instead of pushing it off to some later date. This will allow us to do the following: NovaTemplateOptions

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

@demobox Thanks for reviewing, I would make the necessary changes in a separate PR --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/31#issuecomment-47977274

Re: [jclouds] Removes legacy Google MWS dependency (#434)

[jclouds-java-7-pull-requests #1433](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1433/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/434#issuecomment-47975217

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

Overall, nice work! A couple of comments: * In the domain objects, we have many nullable fields. Sometimes they're `@Nullable` in the constructor, usually not. Either way works for me, but we should try to be consistent both in this PR and with jclouds usage elsewhere? * In some domain objects,

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > +import javax.ws.rs.Consumes; > +import javax.ws.rs.core.MediaType; > + > +import org.jclouds.date.internal.SimpleDateFormatDateService; > +import org.jclouds.googlecloudstorage.domain.Bucket; > +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.Location; > +import >

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +import org.jclouds.date.internal.SimpleDateFormatDateService; > +import org.jclouds.googlecloudstorage.domain.BucketAccessControls; > +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.Location; > +import > org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > + Iterator pageIterator = bucket.iterator(); > + assertTrue(pageIterator.hasNext()); > + > + Bucket singlePageIterator = pageIterator.next(); > + List bucketAsList = Lists.newArrayList(singlePageIterator); > + > + assertNotNull(singlePageIterator); > + assertSame

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + GetBucketOptions options = new > GetBucketOptions().ifMetagenerationMatch(metageneration); > + Bucket response = api().getBuckets(BUCKET_NAME_WITHOPTIONS, options); > + > + assertNotNull(response); > + assertEquals(response.getName(), BUCKET_NAME_WITHOPTIONS); > + asse

Re: [jclouds] Removes legacy Google MWS dependency (#434)

[jclouds-pull-requests #962](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/962/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/434#issuecomment-47974544

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + BucketAccessControls bucketacl = > BucketAccessControls.builder().bucket(BUCKET_NAME) > + .entity("allAuthenticatedUsers").role(Role.OWNER).build(); > + BucketTemplate template = new > BucketTemplate().name(BUCKET_NAME).addAcl(bucketacl); > + Bucket response = api

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + assertEquals(response.getKind(), Kind.BUCKET); > + assertEquals(response.getName(), BUCKET_NAME); > + assertEquals(response.getLocation(), Location.US_CENTRAL2); > + assertTrue(response.getVersioning().isEnabled()); > + } > + > + @Test(groups = "live") > + public void

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > + Bucket response = api().createBuckets(PROJECT_NUMBER, template, > options); > + > + assertNotNull(response); > + assertNotNull(response.getCors()); > + assertEquals(response.getKind(), Kind.BUCKET); > + assertEquals(response.getName(), BUCKET_NAME_WITHOPTIONS); > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + private static final String BUCKET_NAME = "jcloudtestbucket" + (int) > (Math.random() * 1); > + > + private static final String BUCKET_NAME_WITHOPTIONS = > "jcloudtestbucketoptions" + (int) (Math.random() * 1); > + > + private static final String LOG_BUCKET_NAME = "jcloudtestbuc

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @Test(groups = "live", dependsOnMethods = { "testListBucket", > "testGetBucket", "testUpdateBucket" }) > + public void testDeleteBucket() { > + HttpResponse response = api().deleteBuckets(BUCKET_NAME); > + HttpResponse response2 = api().deleteBuckets(LOG_BUCKET_NAME); > + > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + assertEquals(response.getName(), BUCKET_NAME_WITHOPTIONS); > + assertNotNull(response.getAcl()); > + } > + > + @Test(groups = "live", dependsOnMethods = "testCreateBucket") > + public void testGetBucket() { > + Bucket response = api().getBuckets(BUCKET_NAME); > + > + a

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > + BucketTemplate logTemplate = new > BucketTemplate().name(LOG_BUCKET_NAME); > + Bucket logResponse = api().createBuckets(PROJECT_NUMBER, logTemplate); > + assertNotNull(logResponse); > + > + BucketAccessControls acl = > BucketAccessControls.builder().bucket(BUCKET_NAME)

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + } > + > + @Test(groups = "live") > + public void testCreateBucketWithOptions() { > + > + DefaultObjectAccessControls oac = > DefaultObjectAccessControls.builder().bucket(BUCKET_NAME_WITHOPTIONS) > + .entity("allUsers").role(ObjectRole.OWNER).build(); > + BucketCor

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + DefaultObjectAccessControls oac = > DefaultObjectAccessControls.builder().bucket(BUCKET_NAME).entity("allUsers") > + .role(ObjectRole.OWNER).build(); > + BucketCors bucketCors = > BucketCors.builder().addOrigin("http://example.appspot.com";).addMethod("GET").addMethod(

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > +import javax.inject.Inject; > + > +import org.jclouds.googlecloudstorage.domain.BucketTemplate; > +import org.jclouds.http.HttpRequest; > +import org.jclouds.rest.MapBinder; > +import org.jclouds.rest.binders.BindToJsonPayload; > + > +public class BucketBinder implements MapBinder { > + > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* In the request body, supply the relevant portions of a > bucket resource > +* @param options > +* Supply {@link UpdateBucketOptions} with optional query > parameters > +* > +* @return If successful, this method returns a {@link Bucket} resource > in

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* @param bucketName > +* In the request body, supply a bucket resource with list of > {@link BucketAccessControls} (acl[]) > +* @param bucketTemplate > +* In the request body, supply the relevant portions of a > bucket resource > +* > +* @return If

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + Bucket updateBuckets(@PathParam("bucket") String bucketName, > +@BinderParam(BindToJsonPayload.class) BucketTemplate > bucketTemplate, UpdateBucketOptions options); > + > + /** > +* Upd

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* @param bucketName > +* In the request body, supply a bucket resource with list of > {@link BucketAccessControls} (acl[]) > +* @param options > +* Supply {@link UpdateBucketOptions} with optional query > parameters > +* > +* @return If successful,t

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* > +* @return If successful,this method returns a {@link Bucket} resource in > the response body > +*/ > + > + @Named("Bucket:update") > + @PUT > + @Consumes(MediaType.APPLICATION_JSON) > + @Produces(MediaType.APPLICATION_JSON) > + @Path("/b/{bucket}") > + @OAuthScopes

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + ListPage listBuckets(@QueryParam("project") String project, > ListOptions options); > + > + /** > +* Updates a bucket > +* > +* @param bucketName > +* Name of

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @Produces(MediaType.APPLICATION_JSON) > + @Path("/b") > + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + ListPage listBuckets(@QueryParam("project") String project, > ListOptions options); > + > + /** > +* Updates a bucket >

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* @param bucketName > +* Name of the bucket > +* @param bucket > +* In the request body, supply a bucket resource with list of > {@link BucketAccessControls} > +* > +* @return If successful, this method returns a {@link Bucket} resource > in the res

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + /** > +* Retrieves a list of buckets for a given project > +* > +* @param project > +* Name of the project to retrieve the buckets > +* > +* @return a {@link ListPage} > +*/ > + > + @Named("Bucket:list") > + @GET > + @Consumes(MediaType.APPLICATIO

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* Name of the project to retrieve the buckets > +* @param options > +* Supply {@link ListOptions} with optional query parameters > +* > +* > +*/ > + > + @Named("Bucket:list") > + @GET > + @Consumes(MediaType.APPLICATION_JSON) > + @Produces(Me

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* @param bucketName > +* Name of the bucket > +* @param options > +* Supply {@link DeleteBucketOptions} with optional query > parameters > +* > +* @return If successful, this method returns an empty response body. > +*/ > + > + @Named("Bucket:d

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @Consumes(MediaType.APPLICATION_JSON) > + @Path("/b/{bucket}") > + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + HttpResponse deleteBuckets(@PathParam("bucket") String bucketName, > DeleteBucketOptions options); > + > + /** > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* Supply {@link InsertBucketOptions} with optional query > parameters > +* > +* @return If successful, this method returns a {@link Bucket} resource > in the response body > +*/ > + > + @Named("Bucket:insert") > + @POST > + @Consumes(MediaType.APPLICATION_JSON)

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @Consumes(MediaType.APPLICATION_JSON) > + @Path("/b") > + @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > + @MapBinder(BucketBinder.class) > + Bucket createBuckets(@QueryParam("project") String projectNumber, > +@PayloadParam("template") BucketTemplate bucketTemplate, > InsertB

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* Permanently deletes an empty Bucket > +* > +* @param bucketName > +* Name of the bucket > +* > +* @return If successful, this method returns an empty response body > +*/ > + > + @Named("Bucket:delete") > + @DELETE > + @Consumes(MediaType.APPLICATIO

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* > +* @param projectId > +* A valid API project identifier > +* @param bucketTemplate > +* In the request body, supply a bucket resource > +* > +* @return If successful, this method returns a {@link Bucket} resource > in the response body > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* > +* @param bucketTemplate > +* In the request body, supply a {@link Bucket} resource > +* @param options > +* Supply {@link InsertBucketOptions} with optional query > parameters > +* > +* @return If successful, this method returns a {@link Bu

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* Name of the bucket > +* @param options > +* Supply {@link GetBucketOptions} with optional query > parameters > +* > +* @return a {@link Bucket} resource > +*/ > + > + @Named("Bucket:get") > + @GET > + @Consumes(MediaType.APPLICATION_JSON) > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + @OAuthScopes(STORAGE_READONLY_SCOPE) > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + Bucket getBuckets(@PathParam("bucket") String bucketName, > GetBucketOptions options); > + > + /** > +* Creates a new bucket > +* > +* @param projectId > +* A va

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +* > +* @param bucketName > +* Name of the bucket > +* > +* @return a {@link Bucket} resource > +*/ > + > + @Named("Bucket:get") > + @GET > + @Consumes(MediaType.APPLICATION_JSON) > + @Produces(MediaType.APPLICATION_JSON) > + @Path("/b/{bucket}") > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + * @see https://developers.google.com/storage/docs/json_api/v1/buckets"/> > + */ > + > +@SkipEncoding({ '/', '=' }) > +@RequestFilters(OAuthAuthenticator.class) > +public interface BucketApi { > + > + /** > +* Returns metadata for the specified bucket. > +* > +* @param bucketName

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +import org.jclouds.rest.annotations.RequestFilters; > +import org.jclouds.rest.annotations.SkipEncoding; > +import org.jclouds.rest.binders.BindToJsonPayload; > + > +/** > + * Provides access to Bucket entities via their REST API. > + * > + * @see https://developers.google.com/storage/docs/json

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > +import com.google.common.base.Objects; > + > +/** > + * This is a internal object in bucket resource > + * > + * @see "https://developers.google.com/storage/docs/website-configuration"; /> > + */ > + > +public class Website { > + > + private final String mainPageSuffix; > + private fin

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +import static com.google.common.base.Objects.equal; > +import static com.google.common.base.Objects.toStringHelper; > + > +import java.beans.ConstructorProperties; > + > +import com.google.common.base.Objects; > + > +/** > + * The bucket's logging configuration, which defines the destination buc

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +import static com.google.common.base.Objects.equal; > +import static com.google.common.base.Objects.toStringHelper; > + > +import com.google.common.base.Objects; > + > +/** > + * This is an internal object used in both Bucket and Object representation > + */ > + > +public final class Owner { > +

Re: [jclouds] Removes legacy Google MWS dependency (#434)

[jclouds » jclouds #1326](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1326/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/434#issuecomme

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > +import java.util.Date; > + > +import com.google.common.base.Objects; > + > +/** > + * This is an Internal Object used in BucketLifeCycles/Rules. > + */ > + > +public class Condition { > + private final Integer age; > + private final Date createdBefore; > + private final Boolean isLive;

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + public int hashCode() { > + return Objects.hashCode(entity, entityId); > + } > + > + @Override > + public boolean equals(Object obj) { > + if (this == obj) > + return true; > + if (obj == null || getClass() != obj.getClass()) > + return false; > + Own

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > +import com.google.common.base.Objects; > + > +/** > + * The bucket's logging configuration, which defines the destination bucket > and optional name prefix for the current > + * bucket's logs. > + * > + * @see https://developers.google.com/storage/docs/accesslogs"; /> > + */ > + > +public

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + > +import com.google.common.base.Objects; > +import com.google.common.collect.ImmutableSet; > + > +/** > + * The bucket's lifecycle configuration. > + * > + * @see https://developers.google.com/storage/docs/lifecycle"; /> > + */ > + > +public class BucketLifeCycle { > + > + > + private fi

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + public Builder addMethod(String method) { > + this.methods.add(method); > + return this; > + } > + > + public Builder method(Set method) { > + this.methods.addAll(method); > + return this; > + } > + > + public Builder addResponseHeader(St

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + return string().toString(); > + } > + > + public static Builder builder() { > + return new Builder(); > + } > + > + public static class Builder { > + ImmutableSet.Builder rules = ImmutableSet.builder(); > + > + public Builder addRule(Rule rule) { > + this.rul

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +/** > + * The bucket's lifecycle configuration. > + * > + * @see https://developers.google.com/storage/docs/lifecycle"; /> > + */ > + > +public class BucketLifeCycle { > + > + > + private final Set rules; > + > + public BucketLifeCycle(Set rule) { > + this.rules = rule == null ? Imm

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + public Builder responseHeader(Set responseHeader) { > + this.reponseHeaders.addAll(responseHeader); > + return this; > + } > + > + public Builder maxAgeSeconds(Integer maxAgeSeconds) { > + this.maxAgeSeconds = maxAgeSeconds; > + return this; > +

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> + } > + > + @Override > + public String toString() { > + return string().toString(); > + } > + > + public static Builder builder() { > + return new Builder(); > + } > + > + public static final class Builder { > + > + private ImmutableSet.Builder origins = ImmutableSet

Re: [jclouds-labs-google] JCLOUD-458:Added Bucket Operation with live tests (#31)

> +/** > + * The bucket's Cross-Origin Resource Sharing (CORS) configuration. > + * > + * @see https://developers.google.com/storage/docs/cross-origin"; /> > + */ > + > +public final class BucketCors { > + private final Set origins; > + private final Set methods; > + private final Set respon

  1   2   >