Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

@jdaggett : Comments should be addressed. Thanks for the review! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53521162

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds » jclouds #1555](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1555/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53520895

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> + public T id(String id) { > + this.id = id; > + return self(); > + } > + > + public TokenCredentials build() { > + return new TokenCredentials(id); > + } > + > + public T fromTokenCredentials(TokenCredentials in) { > + return this > +

Re: [jclouds-labs-openstack] Ignore jEnv files (#136)

[jclouds-labs-openstack-pull-requests #386](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/386/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/136#issuecomment-53519565

Re: [jclouds-labs-openstack] Ignore jEnv files (#136)

[jclouds » jclouds-labs-openstack #1625](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1625/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

[jclouds-labs-openstack] Ignore jEnv files (#136)

This is the equivalent of [jclouds PR 495](https://github.com/jclouds/jclouds/pull/495) for the `jclouds-labs-openstack` project. You can merge this Pull Request by running: git pull https://github.com/rackerlabs/jclouds-labs-openstack git/ignore-jenv-files Or you can view, comment on it, or

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

Closed #496. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#event-157641545

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

Converted a few other interfaces into proper utility classes and pushed to master as 1b824afbfc9b55b6f8f23b76bebcc92ba75d4699 and 92d5091845efad00c3ed6a843c140d1c89f93c1e. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#issuecomment-53514905

Jenkins build is back to stable : jclouds » jclouds-labs-openstack #1622

See

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds » jclouds-labs-openstack #1623](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1623/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests-java-6 #28](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/28/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53511101

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

> > +assertTrue(foundIt, "Failed to find the attachment we set in > listAttachments() response"); > + > + > volumeAttachmentApi.get().detachVolumeFromServer(testVolume.getId(), > serverId); > +assertTrue(retry(new Predicate() { > + public boolea

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests #1116](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1116/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53510826

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds-labs-openstack-pull-requests #385](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/385/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53510718

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds-labs-openstack-pull-requests #384](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/384/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53510654

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds » jclouds-labs-openstack #1622](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1622/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds-labs-openstack-pull-requests #383](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/383/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/1

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

Good point on the json files - I think I might have kept the original openstack doc formatting this time --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/135#issuecomment-53510123

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

> > +assertTrue(foundIt, "Failed to find the attachment we set in > listAttachments() response"); > + > + > volumeAttachmentApi.get().detachVolumeFromServer(testVolume.getId(), > serverId); Not sure I agree with that. For me this is clearer as it tests the whole fea/pr

Jenkins build is still unstable: jclouds » jclouds-labs-openstack #1621

See

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds » jclouds-labs-openstack #1621](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1621/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] JCLOUDS-514: Add ability to attach block volumes at boot through the Nova ServerApi (#326)

[jclouds-pull-requests-java-6 #27](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/27/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/326#issuecomment-53505930

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

> + public void testCreateSecurityGroupFail() throws IOException, > InterruptedException, URISyntaxException { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(stringFromResource("/access.json"; > + server.enqu

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

Then it will have to be rebased... (Stripping out the /2.0 in the paths). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53505087

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

This will probably fail until https://github.com/jclouds/jclouds-labs-openstack/pull/134 is merged. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/132#issuecomment-53505036

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds-labs-openstack-pull-requests #382](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/382/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/1

Jenkins build became unstable: jclouds » jclouds-labs-openstack #1620

See

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

[jclouds » jclouds-labs-openstack #1620](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1620/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Ignore jEnv files (#495)

As a side node, it sucks to have to manually add all git-ignored files to the RAT plugin exclusions. I looked for a way to automatically doing that but didn't find anything. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/495#issuecomment-53503763

Re: [jclouds] Ignore jEnv files (#495)

Pushed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=b2cb89812368b797375407482f06dc8f5ae270c4). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/495#issuecomment-53503605

Re: [jclouds] Ignore jEnv files (#495)

Closed #495. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/495#event-157600316

Re: [jclouds-labs] Add vSphere support (#61)

@igreenfield I'm not familiar with the vSphere SOAP API, but in the next days I'll try to build some base classes that help building SOAP payloads, as long as an implementation of a single API call using that, with the corresponding tests. That hopefully will show how things should be done and

Re: [jclouds-site] add softlayer cloudlayer quickstart (#49)

> Is it time to revisit this PR, now that the SoftLayer PR is merged? @andreaturli Thoughts on this? It'll need at least a rebase, I guess ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/49#issuecomment-53502357

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> + public T id(String id) { > + this.id = id; > + return self(); > + } > + > + public TokenCredentials build() { > + return new TokenCredentials(id); > + } > + > + public T fromTokenCredentials(TokenCredentials in) { > + return this > +

Re: [jclouds-labs] Add vSphere support (#61)

> I'll do my best to help you in this process. If I can help, of course I'll be glad to assist to. Although @nacx is much more of a domain expert in compute providers than I am ;-) Thanks for sticking with this @igreenfield! --- Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

> + public void testCreateSecurityGroupFail() throws IOException, > InterruptedException, URISyntaxException { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(stringFromResource("/access.json"; > + server.enqu

Re: [jclouds] Ignore jEnv files (#495)

+1 also from me. Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/495#issuecomment-53500552

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + * limitations under the License. > + */ > +package org.jclouds.openstack.neutron.v2.domain; > + > +import java.beans.ConstructorProperties; > +import javax.inject.Named; > + > +import org.jclouds.javax.annotation.Nullable; > +import com.google.common.base.MoreObjects; > +import com.google.commo

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

[jclouds » jclouds #1553](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1553/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#issuecomme

Jenkins build is back to normal : jclouds-labs-openstack » jclouds openstack-neutron api #438

See

Jenkins build is back to normal : jclouds-labs-openstack #438

See

Jenkins build is back to normal : jclouds-labs-aws #194

See

Jenkins build is back to normal : jclouds » jclouds-labs-openstack #1615

See

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

+1, looks good to me. Thanks, @andrewgaul! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#issuecomment-53498496

[jira] [Created] (JCLOUDS-686) Remove OpenStack PaginationOptions.changesSince()

Jeremy Daggett created JCLOUDS-686: -- Summary: Remove OpenStack PaginationOptions.changesSince() Key: JCLOUDS-686 URL: https://issues.apache.org/jira/browse/JCLOUDS-686 Project: jclouds Issue

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1611

See Changes: [shrinand] Add live test for signPutBlob. -- [...truncated 1008 lines...] Test suite progress: tests succeeded: 129, failed: 0, skipped: 0. Starting test t

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

> @@ -83,13 +101,65 @@ public void testSignBlob() throws InterruptedException, > ExecutionException { > continue; > } > String containerName = Iterables.getLast(containers).getName(); > - PageSet blobs = > region.list(containerName); > - if (blobs.

Jenkins build is back to normal : jclouds » jclouds-labs-openstack #1612

See

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

Not sure what to make of the failures above. The checkstyle violations are not in my commit. Apparently they are in the neutron-api that I have not touched. Any ideas? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#issuecomment-53

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

[jclouds-pull-requests #1115](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1115/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#issuecomment-53488763

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

[jclouds-labs-openstack-pull-requests #381](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/381/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#issuecomment-53488674

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

[jclouds » jclouds-labs-openstack #1616](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1616/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclo

Jenkins build is back to normal : jclouds-labs-aws » jcloud elb api #194

See

Jenkins build is back to normal : jclouds-labs-aws #194

See

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

> + public void testCreateSecurityGroupFail() throws IOException, > InterruptedException, URISyntaxException { > + MockWebServer server = mockOpenStackServer(); > + server.enqueue(addCommonHeaders(new > MockResponse().setBody(stringFromResource("/access.json"; > + server.enqu

Build failed in Jenkins: jclouds » jclouds-labs-openstack #1614

See Changes: [shrinand] Add live test for signPutBlob. -- [...truncated 1041 lines...] [JENKINS] Recording test results [INFO] [INFO] --- maven-bundle-plugin:2.3.7:bun

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

Also can you remove all the trailing whitespace from this commit? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/45#issuecomment-53480930

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

[jclouds » jclouds-labs-openstack #1614](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1614/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

[jclouds-labs-openstack-pull-requests #380](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/380/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94

Jenkins build is back to stable : jclouds » jclouds #1551

See

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @POST > + @SelectJson("floatingip") > + FloatingIP create(@WrapWith("floatingip") FloatingIP.CreateOptions > floatingIP); > + > + /** > +* Update a floatingip > +* > +* @param id the id of the floatingip to update > +* @param floatingIP Contains only the attributes to u

Re: [jclouds-labs-openstack] Adds support for the Security Group extension to neutron (#132)

> +import org.jclouds.collect.IterableWithMarker; > +import org.jclouds.collect.internal.Arg0ToPagedIterable; > +import org.jclouds.openstack.neutron.v2.NeutronApi; > +import org.jclouds.openstack.neutron.v2.domain.SecurityGroupRule; > +import org.jclouds.openstack.neutron.v2.extensions.SecurityGro

Jenkins build became unstable: jclouds » jclouds #1550

See

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

[jclouds-pull-requests-java-6 #26](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/26/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#issuecomment-53476207

Re: [jclouds] Enforce no redundant modifiers via Checkstyle (#496)

Circulating for feedback. Some of these interfaces should be classes but we abuse inheritance of them. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/496#issuecomment-53475994

[jclouds] Enforce no redundant modifiers via Checkstyle (#496)

You can merge this Pull Request by running: git pull https://github.com/andrewgaul/jclouds redundant-modifier Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/496 -- Commit Summary -- * Remove redundant modifiers from interfaces * Enforce

Re: [jclouds-labs-openstack] Strip hardcoded v2.0 in Neutron APIs (#134)

[jclouds-labs-openstack-pull-requests #379](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/379/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/134#issuecomment-53472594

Re: [jclouds-labs-openstack] Strip hardcoded v2.0 in Neutron APIs (#134)

[jclouds-labs-openstack-pull-requests #378](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/378/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/134#issuecomment-53471066

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

[jclouds-labs-openstack-pull-requests #377](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/377/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

> } > - String blobName = Iterables.getLast(blobs).getName(); > - HttpRequest request = > ctx.getSigner(regionId).signGetBlob(containerName, blobName); It looks like the `getSigner(regionId)` was used here, but removed! --- Reply to this email directly or view it on Git

Re: [jclouds-labs-openstack] Strip hardcoded v2.0 in Neutron APIs (#134)

Reopened #134. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/134#event-157481769

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

[jclouds » jclouds-labs-openstack #1611](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1611/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

@shrinandj Just closed and reopened to kick the build again. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#issuecomment-53468326

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + } > + > + private abstract static class Builder { > + protected FloatingIP floatingIP; > + > + /** > + * No-parameters constructor used when updating. > + * */ > + private Builder() { > + floatingIP = new FloatingIP(); > + } > + > + protected abs

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

Closed #94. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#event-157475729

Re: [jclouds-labs-openstack] Add live test for signPutBlob. (#94)

Reopened #94. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/94#event-157475754

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Path("/{id}") > + @SelectJson("floatingip") > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + FloatingIP get(@PathParam("id") String id); > + > + /** > +* This operation creates a floating IP. > +* > +* @param floatingIP Options for creating a floatingip > +

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

> + } > + > + public Date getTimeDeleted() { > + return timeDeleted; > + } > + > + public StorageClass getStorageClass() { > + return storageClass; > + } > + > + public Long getSize() { > + return size; > + } > + > + /**return the base64 encoded String of md5*/ > +

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

> + } > + > + public Date getTimeDeleted() { > + return timeDeleted; > + } > + > + public StorageClass getStorageClass() { > + return storageClass; > + } > + > + public Long getSize() { > + return size; > + } > + > + /**return the base64 encoded String of md5*/ > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

@zack-shoylev Looking good! A few comments, and could you also please [reformat](http://jsonlint.com/) the json files? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/135#issuecomment-53454551

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

Please look at `HashCode` which can replace `String` and `byte[]` with something more clear and immutable. I need to spend some time testing this and might have more comments afterwards. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/4

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

> + return owner; > + } > + > + /**return the base64 encoded String of crc32c*/ > + public String getCrc32c() { > + return crc32c; > + } > + > + public byte[] getCrc32cAsByteArray() { > + return reverse(BaseEncoding.base64().decode(crc32c)); > + } > + > + private byt

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

(I can't seem to comment inline on `jcloudslogo.jpg`.) Can you use `TestUtils.randomByteSource` instead of adding an arbitrary file? This is more succinct, consistent, and has less overhead than real IO. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-l

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Path("/{id}") > + @SelectJson("floatingip") > + @Fallback(NullOnNotFoundOr404.class) > + @Nullable > + FloatingIP get(@PathParam("id") String id); > + > + /** > +* This operation creates a floating IP. > +* > +* @param floatingIP Options for creating a floatingip > +

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

> + private Date updated; > + private Date timeDeleted; > + private StorageClass storageClass; > + private Long size; > + private String md5Hash; > + private URI mediaLink; > + private ImmutableMap.Builder metadata = > ImmutableMap.builder(); > + private Str

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

> + > + public String getCacheControl() { > + return cacheControl; > + } > + > + public Set getAcl() { > + return acl; > + } > + > + public Owner getOwner() { > + return owner; > + } > + > + /**return the base64 encoded String of crc32c*/ > + public String getCrc32c()

Re: [jclouds-labs-google] JCLOUDS-458: Basic Object operations with live tests (#45)

> + } > + > + public Date getTimeDeleted() { > + return timeDeleted; > + } > + > + public StorageClass getStorageClass() { > + return storageClass; > + } > + > + public Long getSize() { > + return size; > + } > + > + /**return the base64 encoded String of md5*/ > +

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + /** > +* The operation returns a list of floating IPs to which the tenant has > access. Default policy settings return only > +* those floating IPs that are owned by the tenant who submits the > request, unless the request is submitted by an > +* user with administrative rights.

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> +* @return the list of all floatingIP references configured for the > tenant. > +*/ > + @Named("floatingip:list") > + @GET > + @Transform(FloatingIPsToPagedIterable.class) > + @ResponseParser(ParseFloatingIPs.class) > + @Fallback(EmptyPagedIterableOnNotFoundOr404.class) > + P

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + } > + > + private abstract static class Builder { > + protected FloatingIP floatingIP; > + > + /** > + * No-parameters constructor used when updating. > + * */ > + private Builder() { > + floatingIP = new FloatingIP(); > + } > + > + protected abs

Re: [jclouds-labs-openstack] Adds support for Floating IP (#135)

> + @Named("tenant_id") > + private String tenantId; > + // Only mandatory attribute when creating > + @Named("floating_network_id") > + private String floatingNetworkId; > + @Named("fixed_ip_address") > + private String fixedIpAddress; > + @Named("floating_ip_address") > + privat

Re: [jclouds] Token based authentication in openstack-keystone (#433)

@pimenas Hi! There are a few comments that need to be addressed, but overall the PR looks good. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-53450915

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> @@ -42,6 +42,18 @@ public void testGetApiMetaData() { >assertEquals(metadata, new ParseRackspaceApiMetadataTest().expected()); > } > > + public void testGetApiMetaDataWithTokenCredentialsAuth() { > + KeystoneApi api = requestsSendResponses( > +keystoneAuthWithToke

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> @@ -42,6 +42,18 @@ public void testGetApiMetaData() { >assertEquals(metadata, new ParseRackspaceApiMetadataTest().expected()); > } > > + public void testGetApiMetaDataWithTokenCredentialsAuth() { > + KeystoneApi api = requestsSendResponses( > +keystoneAuthWithToke

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> @@ -87,6 +87,41 @@ public HttpRequest > initialAuthWithAccessKeyAndSecretKeyAndTenantId(String access > accessKey, secretKey, > getTenantId()), "application/json")).build(); > } > > + public HttpRequest initialAuthWithTokenAndTenantName(

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> @@ -87,6 +87,41 @@ public HttpRequest > initialAuthWithAccessKeyAndSecretKeyAndTenantId(String access > accessKey, secretKey, > getTenantId()), "application/json")).build(); > } > > + public HttpRequest initialAuthWithTokenAndTenantName(

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> + > + @Override > + public int hashCode() { > + return Objects.hashCode(id); > + } > + > + @Override > + public boolean equals(Object obj) { > + if (this == obj) return true; > + if (obj == null || getClass() != obj.getClass()) return false; > + TokenCredentials that

Re: [jclouds] Token based authentication in openstack-keystone (#433)

> + > + /** > + * @see TokenCredentials#getId() > + */ > + public T id(String id) { > + this.id = id; > + return self(); > + } > + > + public TokenCredentials build() { > + return new TokenCredentials(id); > + } > + > + public T from

  1   2   >