Thanks @bostko
I'm going through this in more detail, and will contribute some changes that
make it conform more to "the jclouds way". Here are a few pointers:
* See jclouds best practices:
https://cwiki.apache.org/confluence/display/JCLOUDS/Writing+jclouds+Code
* Include clear TODO/FIXME comme
@jasminSPC
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/251
-- Commit Summary --
* Profitbricks REST - LAN API
-- File Changes --
M
profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/ProfitBricksApi.jav
bump @nacx, @andreaturli
Let me know if anything else needed for a review.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-203009249
A couple of unit tests missing, but will be easy to add if everything else is
good to go.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/160#issuecomment-203009569
Per discussion with @nacx regarding jclouds-labs PR
https://github.com/jclouds/jclouds-labs/pull/250, isolating Azure AD Oauth
changes into the JClouds oauth module.
Per README, tested as follows:
```
mvn clean install -Plive \
-Dtest.oauth.identity= \
-Dtest.oauth.credential= \
-Dtest.oauth.
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
> +this.tokenDuration = tokenDuration;
> +// since the session interval is also the token expiration time
> requested to the server make the token expire a
> +// bit before the deadline to make sure there aren't session
> expiration exceptions
> +long cacheExpirati
> +
> +import javax.inject.Inject;
> +import javax.inject.Named;
> +
> +import static java.util.concurrent.TimeUnit.SECONDS;
> +import static org.jclouds.Constants.PROPERTY_SESSION_INTERVAL;
> +import static org.jclouds.oauth.v2.config.OAuthProperties.RESOURCE;
> +
> +/**
> + * Authorizes new Beare
> +assertNotNull(token, "no token when authorizing password based
> credential");
> +}
> +
> +/** OAuth isn't registered as a provider intentionally, so we fake one.
> */
> +@Override protected ProviderMetadata createProviderMetadata() {
> +return forApiOnEndpoint(Auth
> +}
> +
> +/** OAuth isn't registered as a provider intentionally, so we fake one.
> */
> +@Override protected ProviderMetadata createProviderMetadata() {
> +return forApiOnEndpoint(AuthorizationApi.class,
> endpoint).toBuilder().id("oauth").build();
> +}
> +
> +@Over
> +scope = resource;
> +return props;
> +}
> +
> +@Override protected Iterable setupModules() {
> +return ImmutableList.builder() //
> +.add(new OAuthModule()) //
> +.add(new Module() {
> +@Override public void conf
@jmspring Thanks for opening the OAuth PR! I've commented there.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/250#issuecomment-203153096
> +import org.jclouds.rest.annotations.MapBinder;
> +import org.jclouds.rest.annotations.PayloadParam;
> +import org.jclouds.rest.annotations.PATCH;
> +import org.jclouds.rest.annotations.ResponseParser;
> +
> +
> +import org.jclouds.rest.binders.BindToJsonPayload;
> +
> +/**
> + * The Azure Resour
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
BTW, tests that depend on OAuth seem to be failing because they can't build the
context because they're missing the `jclouds.oauth.resource` property:
No implementation for java.lang.String annotated with
@com.google.inject.name.Named(value=jclouds.oauth.resource)
This is because the
Thanks for the contribution @jmspring!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/941#issuecomment-203155420
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
> +*/
> + public static final String AZURE_CREDENTIAL = "oauth.azure-credential";
> +
> + /**
> +* When using oauth with Azure Active Direction and Client Credentials,
> an "azure-identity"
> +* is the GUID associated with an application given permssion to perform
> operations in
22 matches
Mail list logo
