Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

@nacx No worries! > I think splitting the PR will help you focus and also advance in other areas > while the compute service is a WIP. That makes sense to me. I will go ahead and split this PR into two as you suggested and address some of these comments for the APIs. --- You are receiving

Build failed in Jenkins: jclouds-guava-guice-compat » 19.0-rc1,3.0,OpenJDK 7 (latest) #152

See Changes: [Ignasi Barrera] JCLOUDS-1114: Adding support for "Placement.Tenancy" and [Ignasi Barrera] client credentials JWT support

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> bump We have folks who are waiting to test this in few days. Would be awesome > if we could get this merged soon since we have couple of more PRs left. Thank > you so much for all your feedback!!! Apologies for the delay. I'm just back from ApacheCon in Vancouver and was still going through

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + this.locations = checkNotNull(locations, "locations"); > + this.imageReferenceToImage = imageReferenceToImage; > + this.vmSizeToHardware = vmSizeToHardware; > + this.credentialStore = credentialStore; > + this.api = api; > + } > + > + @Override > + public

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + VMSizeToHardware vmSizeToHardware, Map > credentialStore) { > + > + this.nodeNamingConvention = namingConvention.createWithoutPrefix(); > + this.locations = checkNotNull(locations, "locations"); > + this.imageReferenceToImage =

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + GroupNamingConvention.Factory namingConvention, > ImageReferenceToImage imageReferenceToImage, > + VMSizeToHardware vmSizeToHardware, Map > credentialStore) { > + > + this.nodeNamingConvention = namingConvention.createWithoutPrefix(); > +

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + > + private final ImageReferenceToImage imageReferenceToImage; > + > + private final VMSizeToHardware vmSizeToHardware; > + > + private final Map credentialStore; > + > + @Inject > + DeploymentToNodeMetadata( > + AzureComputeApi api, > +

Re: [jclouds/jclouds] client credentials JWT support (#952)

Closed #952. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/952#event-666493032

Re: [jclouds/jclouds] client credentials JWT support (#952)

Build failure was unrelated. Merged to master as [f46b38dd](http://git-wip-us.apache.org/repos/asf/jclouds/commit/f46b38dd). Thanks @jmspring! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Support for "Placement.Tenancy" and "Placement.HostId" AWS EC2 parameters (#954)

Squashed, amended commit message to include the JIRA issue, and pushed to master as [ccd1ef2b](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ccd1ef2b).Thanks @storgashov! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Support for "Placement.Tenancy" and "Placement.HostId" AWS EC2 parameters (#954)

Closed #954. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/954#event-666488147

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + List vmDeployments = new ArrayList(); > + > + for (Deployment d : deployments){ > + VMDeployment vmDeployment = new VMDeployment(); > + vmDeployment.deployment = d; > + vmDeployment.vm = > api.getVirtualMachineApi(getGroupId()).getInstanceDetails(d.name()); >

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + for (int e = 0; e < dependsOn.size(); e++) { > + if > (dependsOn.get(e).resourceType().equals("Microsoft.Network/publicIPAddresses")) > { > + String resourceName = dependsOn.get(e).resourceName(); > + PublicIPAddress ip =

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + if (jobDone) { > +// Delete storage account > + > api.getStorageAccountApi(getGroupId()).delete(storageAccountName); > + > +// Delete NIC > +uri = api.getNetworkInterfaceCardApi(getGroupId()).delete(id + > "nic"); > +if (uri

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + } > + > + @Override > + public ImageReference getImage(final String id) { > + Iterable images = listImages(); > + for (ImageReference image : images) { > + if (id.contains(image.offer()) && id.contains(image.sku())) { > +return image; > + } > +

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + } > + } > + } > + > + @Override > + public Iterable listImages() { > + final List osImages = Lists.newArrayList(); > + getImagesFromPublisher("Microsoft.WindowsAzure.Compute", osImages); > + getImagesFromPublisher("MicrosoftWindowsServer", osImages); > +

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + OSImageApi osImageApi = api.getOSImageApi(getLocation()); > + Iterable offerList = osImageApi.listOffers(publisherName); > + for (Offer offer : offerList) { > + Iterable skuList = osImageApi.listSKUs(publisherName, > offer.name()); > + for (SKU sku : skuList) {

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + name, azureComputeConstants.operationTimeout()); > + logger.warn(illegalStateExceptionMessage); > + > + throw new IllegalStateException(illegalStateExceptionMessage); > + } > + > + final VMDeployment deployment = deployments.iterator().next(); > + > +

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> +} > +return !deployments.isEmpty(); > + } > + }, azureComputeConstants.operationTimeout(), 1, SECONDS).apply(name)) { > + final String illegalStateExceptionMessage = format("Deployment %s > was not created within %sms so it will be destroyed.", > +

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + final String deploymentTemplate = > UrlEscapers.urlFormParameterEscaper().escape(json.toJson(properties)); > + > + logger.debug("Deployment created with name: %s", name); > + > + final Set deployments = Sets.newHashSet(); > + if (!retry(new Predicate() { > +

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> + Gson gson = new GsonBuilder().disableHtmlEscaping().create(); > + org.jclouds.json.Json json = new GsonWrapper(gson); > + > + final String deploymentTemplate = > UrlEscapers.urlFormParameterEscaper().escape(json.toJson(properties)); > + > + logger.debug("Deployment created

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

> +import org.jclouds.domain.LoginCredentials; > +import org.jclouds.json.internal.GsonWrapper; > +import org.jclouds.logging.Logger; > + > +import com.google.common.base.Predicate; > +import com.google.common.collect.Iterables; > +import com.google.common.collect.Lists; > +import

[jira] [Updated] (JCLOUDS-1114) Support AWS EC2 "Placement.Tenancy" and "Placement.HostId" parameters for the "RunInstances" action

[ https://issues.apache.org/jira/browse/JCLOUDS-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1114: Labels: aws-ec2 (was: ) > Support AWS EC2 "Placement.Tenancy" and "Placement.HostId"

[jira] [Commented] (JCLOUDS-1114) Support AWS EC2 "Placement.Tenancy" and "Placement.HostId" parameters for the "RunInstances" action

[ https://issues.apache.org/jira/browse/JCLOUDS-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292271#comment-15292271 ] ASF subversion and git services commented on JCLOUDS-1114: -- Commit

Re: [jclouds/jclouds-labs] JCLOUDS-664 Azurecompute-arm DeploymentApi OSImageApi VMSizeApi Bindings (#267)

_bump_ @nacx We have folks who are waiting to test this in few days. Would be awesome if we could get this merged soon since we have couple of more PRs left. Thank you so much for all your feedback!!! --- You are receiving this because you are subscribed to this thread. Reply to this email

Jenkins build is back to normal : jclouds-guava-guice-compat » 19.0-rc1,4.0,OpenJDK 7 (latest) #151

See

Re: [jclouds/jclouds] client credentials JWT support (#952)

@nacx -- all edits should be in place. local build completing successfully. Will check PR build in a bit. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/952#issuecomment-220393228

Re: [jclouds/jclouds] Support for "Placement.Tenancy" and "Placement.HostId" AWS EC2 parameters (#954)

@nacx, thanks for your review! I've updated the patch according to your comments, please take a look. Also please confirm, if the ``Tenancy`` enum name and package I've selected is ok. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Fix cleanup when the security group extension is not available. (#955)

Closed #955. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/955#event-666104027

Re: [jclouds/jclouds] Fix cleanup when the security group extension is not available. (#955)

merged --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/955#issuecomment-220390129

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

Lgtm --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220382602

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220373462

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220351986

Re: [jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/269#issuecomment-220332247

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

Closed #958. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#event-665833402

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

Merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7016b040) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220332030

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

thanks @duncangrant --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220332124

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

ok build is happy, merging now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220331954

[jira] [Commented] (JCLOUDS-1044) MapTypeAdapter and IterableTypeAdapter doesn't handle NULL values correctly

[ https://issues.apache.org/jira/browse/JCLOUDS-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291130#comment-15291130 ] ASF subversion and git services commented on JCLOUDS-1044: -- Commit

[jclouds/jclouds-labs] JCLOUDS-1041: Fix NPE when deserializing Port in Docker 1.9.1 (#269)

This backports this change (46aec3aa2bdb362d7ba9a17cb1c3c9b0509b30ef) from 2.0.0 to 1.9.x. Needed to fix issue where ip is null in json returned from Docker REST API. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/269 -- Commit

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

Sorry @grkvlt I've been notified just now about this PR by github, looks like @nacx already reviewed it: thanks @nacx ! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

@nacx thanks --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220327819

Re: [jclouds/jclouds] Fix cleanup when the security group extension is not available. (#955)

+1! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/955#issuecomment-220293929

Re: [jclouds/jclouds] update CloudstackTemplateOptions pattern (#957)

> } > > - public CloudStackTemplateOptions setupStaticNat(boolean setupStaticNat) { > - this.setupStaticNat = setupStaticNat; > + public CloudStackTemplateOptions userData(URL userDataUrl) throws > IOException { > + this.userData = Resources.toString(checkNotNull(userDataUrl,

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

LGTM! Let's merge it once the build finishes and is green. Thanks @duncangrant @grkvlt! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/958#issuecomment-220291027

Re: [jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

@andreaturli Can you take a look, please? We need this for the jclouds-labs Docker provider, to fix behaviour where JSON maps returned by the Docker REST API have entries with null values, instead of empty lists. --- You are receiving this because you are subscribed to this thread. Reply to

[jclouds/jclouds] JCLOUDS-1044 fix handling NULL JsonTokens in adapters under NullFilte… (#958)

…ringTypeAdapterFactories class This PR backports this fix (0fb1b459a607f21f6a8ebd7492879d02553c4b88) from 2.0.0 to 1.9.x. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/958 -- Commit Summary -- * JCLOUDS-1044 fix handling NULL

[jclouds/jclouds] update CloudstackTemplateOptions pattern (#957)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/957 -- Commit Summary -- * update CloudstackTemplateOptions pattern -- File Changes -- M

[jclouds/jclouds] update CloudstackTemplateOptions pattern (#956)

You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/956 -- Commit Summary -- * update CloudstackTemplateOptions pattern -- File Changes -- M