Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2016-09-23 Thread Olivier Lemasle
@nacx You're right, and I've added a commit to address that. It still binds to `retryOnRenew` (we still have to use it for HTTP 408 errors), but I've modified this RetryHandler to skip retrying in the case of a token-based authentication. @zack-shoylev I've added some basic unit tests. Please

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2016-09-23 Thread Olivier Lemasle
@olivierlemasle pushed 1 commit. 8679f28 Disable retry for keystone token auth + unit tests -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-23 Thread arvindn05
in that case, should we also remove the check for maximum file path size being 255 bytes? I left that in because that is not configurable in openstack. checkArgument( path.getBytes().length < 255, String.format("maximum length of path is 255 bytes. Path specified

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-23 Thread Zack Shoylev
This is a good change. We should be moving toward server-side validation in general. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1012#issuecomment-249228831

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-23 Thread Andrea Turli
New results ``` Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-23 Thread Andrea Turli
@andreaturli pushed 1 commit. 388177a fix some live tests more -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317/files/342666fe60a3c1ec24919a99cde90b6d27dcc9ad..388177aa18ed03c633a3216f7dbc15be2c51

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > - properties.setProperty(PROPERTY_ZONE + ".FRA." + ISO3166_CODES, > "DE-HE"); - properties.setProperty(PROPERTY_ZONE + ".LAS." + ISO3166_CODES, "US-NV"); - properties.setProperty(PROPERTY_ZONE + ".LASDEV." + ISO3166_CODES, "US-NV");

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > - properties.setProperty(PROPERTY_ZONE + ".FRA." + ISO3166_CODES, > "DE-HE"); - properties.setProperty(PROPERTY_ZONE + ".LAS." + ISO3166_CODES, "US-NV"); - properties.setProperty(PROPERTY_ZONE + ".LASDEV." + ISO3166_CODES, "US-NV"); -

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > + logger.trace(">> provisioning complete for server. returned > id='%s'", serverId); + + } catch (Exception ex) { + logger.error(ex, ">> failed to provision server. rollbacking.."); + destroyVolumes(volumeIds,

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > + logger.trace(">> provisioning complete for server. returned > id='%s'", serverId); + + } catch (Exception ex) { + logger.error(ex, ">> failed to provision server. rollbacking.."); + destroyVolumes(volumeIds,

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
@alibazlamit pushed 1 commit. 12a9a95 Fixed formatting issue -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/d133573b659d3e5461b23f1ed37aaee75bd852da..12a9a959ffc4343e260c4123091b9d5de5d972ea

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > + public List call() throws Exception { +logger.trace("<< fetching snapshots"); +List remoteSnapshots = api.snapshotApi().list(new DepthOptions().depth(1)); +logger.trace(">> snapshots feched."); + +

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId")

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-23 Thread Ignasi Barrera
nacx commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId") String

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > + logger.trace(">> provisioning complete for server. returned > id='%s'", serverId); + + } catch (Exception ex) { + logger.error(ex, ">> failed to provision server. rollbacking.."); + destroyVolumes(volumeIds,

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > + @GET + @Fallback(Fallbacks.EmptyListOnNotFoundOr404.class) + List getList(GenericQueryOptions options); + + @Named("vpn:get") + @GET + @Path("/{vpnId}") + @Fallback(Fallbacks.NullOnNotFoundOr404.class) + Vpn get(@PathParam("vpnId")

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > + public List call() throws Exception { +logger.trace("<< fetching snapshots"); +List remoteSnapshots = api.snapshotApi().list(new DepthOptions().depth(1)); +logger.trace(">> snapshots feched."); + +

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-23 Thread alibazlamit
@alibazlamit pushed 1 commit. 4f275a8 Review changes applied -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319/files/057a2df15be24f6d76029394e39493c08738639e..4f275a8ce0ed1e4738587b3ed6a9e410cf70a259

Jenkins build is back to normal : jclouds-karaf » jclouds :: Karaf :: Core #1946

2016-09-23 Thread jenkins-no-reply
See

Jenkins build is back to normal : jclouds-karaf #1946

2016-09-23 Thread jenkins-no-reply
See

Build failed in Jenkins: jclouds-karaf #1945

2016-09-23 Thread jenkins-no-reply
See -- [...truncated 1311 lines...] Downloading: http://repo.cloudbees.com/content/repositories/central/org/slf4j/slf4j-api/1.5.8/slf4j-api-1.5.8.jar Downloaded:

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-23 Thread Ignasi Barrera
nacx requested changes on this pull request. Thanks @alibazlamit! > +import org.jclouds.rest.annotations.Fallback; +import org.jclouds.rest.annotations.MapBinder; +import org.jclouds.rest.annotations.RequestFilters; +import org.jclouds.rest.annotations.SelectJson; +import

Build failed in Jenkins: jclouds-karaf » jclouds :: Karaf :: Core #1944

2016-09-23 Thread jenkins-no-reply
See -- [...truncated 52 lines...] Downloading:

Build failed in Jenkins: jclouds-karaf #1944

2016-09-23 Thread jenkins-no-reply
See -- [...truncated 1876 lines...] Downloaded: http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-settings/2.0.9/maven-settings-2.0.9.pom (3 KB at 143.6 KB/sec)

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

2016-09-23 Thread Ignasi Barrera
They take some time, so I'd recommend that you just run the class where you add the new tests :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1006#issuecomment-249135944

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

2016-09-23 Thread Ignasi Barrera
> How do I configure my local machine to run the live tests The better options is to download your credentials as a JSON file. Once you have them, you can run all live tests as follows: mvn clean install -Plive -Dtest.google-cloud.json-key=/path/to/your/credentials.json Or if you want to

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

2016-09-23 Thread Ignasi Barrera
nacx commented on this pull request. > /** * This must be within the range specified by IPv4Range, and is typically the first usable address in that range. * If not specified, the default value is the first usable address in IPv4Range. */ @Nullable public abstract

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2016-09-23 Thread Ignasi Barrera
> Yes, I'm aware that the retry mechanisms will not work if the authentication > is performed with a token. In that case, we should better configure [this

Re: [jclouds/jclouds] Better predicate signature for node operations (#1011)

2016-09-23 Thread Ignasi Barrera
Pushed to master as [d98348d5](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d98348d5). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1011#issuecomment-249132317

Re: [jclouds/jclouds] Better predicate signature for node operations (#1011)

2016-09-23 Thread Ignasi Barrera
Closed #1011. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1011#event-800050823

[jira] [Resolved] (JCLOUDS-1175) Remove hardcoded limitation of content size in Openstack Nova CreateServerOptions API

2016-09-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1175. - Resolution: Fixed Fix Version/s: 2.0.0 > Remove hardcoded limitation of content

[jira] [Updated] (JCLOUDS-1175) Remove hardcoded limitation of content size in Openstack Nova CreateServerOptions API

2016-09-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1175: Labels: easyfix openstack-nova (was: easyfix) > Remove hardcoded limitation of content

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-23 Thread Ignasi Barrera
Closed #1012. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1012#event-800048297

[jira] [Commented] (JCLOUDS-1175) Remove hardcoded limitation of content size in Openstack Nova CreateServerOptions API

2016-09-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515775#comment-15515775 ] ASF subversion and git services commented on JCLOUDS-1175: -- Commit