Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-28 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#pullrequestreview-1891528

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-28 Thread Ignasi Barrera
nacx commented on this pull request. > +import com.google.inject.TypeLiteral; +import java.io.ByteArrayInputStream; +import java.util.logging.Level; +import java.util.logging.Logger; +import java.util.zip.ZipInputStream; +import javax.inject.Inject; +import javax.inject.Singleton; +import org.ap

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-28 Thread Ignasi Barrera
Mind squashing the commits so I can cleanly merge it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#issuecomment-250109508

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2016-09-28 Thread Olivier Lemasle
olivierlemasle commented on this pull request. > @@ -234,6 +234,13 @@ public String get() { return authenticationMethods.get(credentialType); } + @Provides + @Singleton + @Named("credentialsRetryable") + protected final boolean credentialsRetryable(Function getAccess) { @n

Re: [jclouds/jclouds] Add keystone authentication with an existing token (#1009)

2016-09-28 Thread Ignasi Barrera
Thanks! Changes LGTM. Just pending to add the rests for the `KeystonApiExpectTest` and its base class as @zack-shoylev suggested. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1009#i

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-28 Thread alibazlamit
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-250140544

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-28 Thread alibazlamit
Squashed. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#issuecomment-250150406

[jira] [Updated] (JCLOUDS-1181) oneandone-vpn-api

2016-09-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1181: Labels: oneandone (was: ) > oneandone-vpn-api > - > > Key

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-28 Thread Ignasi Barrera
Pushed to master as [4e397202](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/4e397202). Thanks @alibazlamit! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#issu

Re: [jclouds/jclouds-labs] JCLOUDS-1181 oneandone-vpn-api (#319)

2016-09-28 Thread Ignasi Barrera
Closed #319. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/319#event-805473797

[jira] [Resolved] (JCLOUDS-1181) oneandone-vpn-api

2016-09-28 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1181. - Resolution: Fixed Fix Version/s: 2.0.0 > oneandone-vpn-api > - >

[jira] [Commented] (JCLOUDS-1181) oneandone-vpn-api

2016-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529693#comment-15529693 ] ASF subversion and git services commented on JCLOUDS-1181: -- Com

[jira] [Created] (JCLOUDS-1183) oneandone-monitoringcenter-api

2016-09-28 Thread Ali Bazlamit (JIRA)
Ali Bazlamit created JCLOUDS-1183: - Summary: oneandone-monitoringcenter-api Key: JCLOUDS-1183 URL: https://issues.apache.org/jira/browse/JCLOUDS-1183 Project: jclouds Issue Type: Task

[jclouds/jclouds-labs] JCLOUDS-1183 - oneandone-monitoringcenter-api (#322)

2016-09-28 Thread alibazlamit
@nacx Ready for review, Thanks. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/322 -- Commit Summary -- * JCLOUDS-1183 - oneandone-monitoringcenter-api -- File Changes -- M oneandone/src/main/java/org/apache/jclouds/oneando

[jclouds/jclouds-labs] [DO NOT MERGE] wip (#323)

2016-09-28 Thread Andrea Turli
For review only @nacx I'd appreciate if you could have a look at it Still something wrong ``` java.lang.AssertionError: expected [[user=foo, passwordPresent=true, privateKeyPresent=false, shouldAuthenticateSudo=true]] but found [[user=jclouds, passwordPresent=true, privateKeyPresent=false, sh

Re: [jclouds/jclouds-labs] [DO NOT MERGE] wip (#323)

2016-09-28 Thread Andrea Turli
@andreaturli pushed 1 commit. f8c20ab remove default creds for all images -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/a7f6f2ce7c97bd639c2554710224ac9432b739a6..f8c20ab09dfadf10a3419d4a824397a7956