Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)

2018-02-15 Thread William L Thomson Jr
Sure I didn't catch that, guess the compiler doesn't care. I am making the [changes on the fly](https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/jclouds-core/jclouds-core-.ebuild#L55) at build time so kinda moot to me. But that hopefully explains the failure. Its nasty co

[jira] [Resolved] (JCLOUDS-1381) NullPointerException provisioning VM in GCE: could not find image for disk

2018-02-15 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1381. - Resolution: Fixed Fix Version/s: 2.0.4 2.1.0 > NullPointerExce

Re: [jclouds/jclouds] JCLOUDS-1381: Fix NPE in GCE DiskURIToImage (#1179)

2018-02-15 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7aed4bc8) and [2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/06e10864). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.

Re: [jclouds/jclouds] JCLOUDS-1381: Fix NPE in GCE DiskURIToImage (#1179)

2018-02-15 Thread Ignasi Barrera
Closed #1179. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1179#event-1477382676

[jira] [Commented] (JCLOUDS-1381) NullPointerException provisioning VM in GCE: could not find image for disk

2018-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366676#comment-16366676 ] ASF subversion and git services commented on JCLOUDS-1381: -- Com

[jira] [Commented] (JCLOUDS-1381) NullPointerException provisioning VM in GCE: could not find image for disk

2018-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366677#comment-16366677 ] ASF subversion and git services commented on JCLOUDS-1381: -- Com

[jira] [Commented] (JCLOUDS-1333) Cannot compile jclouds with Guava 21+

2018-02-15 Thread William L Thomson Jr (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366674#comment-16366674 ] William L Thomson Jr commented on JCLOUDS-1333: --- Finally figured out what

Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)

2018-02-15 Thread Ignasi Barrera
I think it failed due to `checkstyle`. Can you add an space before `Functions` at lines 102 and 189? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1180#issuecomment-366162733

Re: [jclouds/jclouds] core: Update method argument changes for lastest gson presently 2.8.2 (#1181)

2018-02-15 Thread William L Thomson Jr
No problem, it was minor. I was addressing it for my own needs so figured I would pass it along. But I am not using maven, so did not test that out... I may look into that, though not super familiar with OSGi. Though not sure the issue relates to that as much as what is made available in gson. T

Re: [jclouds/jclouds] core: Update method argument changes for lastest gson presently 2.8.2 (#1181)

2018-02-15 Thread Ignasi Barrera
Thanks for looking at this! There is a limitation that prevents us from using gson >= 2.7. See: https://issues.apache.org/jira/browse/JCLOUDS-1166 Unless that is addressed too, we can't upgrade gson as we would break jclouds-karaf and our OSGi compatibility. Would you like to have a look at thi

[jclouds/jclouds] core: Update method argument changes for lastest gson presently 2.8.2 (#1181)

2018-02-15 Thread William L Thomson Jr
Minor changes to update to latest gson. Seems passing null is save. The underlying class does null checks. Though may require further modifications. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1181 -- Commit Summary -- * core: Upda

Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)

2018-02-15 Thread William L Thomson Jr
Not sure why its showing it failed. It seemed to pass all tests and created a jar. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1180#issuecomment-366151593

[jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)

2018-02-15 Thread William L Thomson Jr
Fixes the following issue https://issues.apache.org/jira/browse/JCLOUDS-1333 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1180 -- Commit Summary -- * core: Fix compile issue under Java 8+ -- File Changes -- M core/src/main/java

[jira] [Comment Edited] (JCLOUDS-1333) Cannot compile jclouds with Guava 21+

2018-02-15 Thread William L Thomson Jr (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366585#comment-16366585 ] William L Thomson Jr edited comment on JCLOUDS-1333 at 2/16/18 5:28 AM: --

[jira] [Comment Edited] (JCLOUDS-1333) Cannot compile jclouds with Guava 21+

2018-02-15 Thread William L Thomson Jr (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366585#comment-16366585 ] William L Thomson Jr edited comment on JCLOUDS-1333 at 2/16/18 3:55 AM: --

[jira] [Commented] (JCLOUDS-1333) Cannot compile jclouds with Guava 21+

2018-02-15 Thread William L Thomson Jr (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366585#comment-16366585 ] William L Thomson Jr commented on JCLOUDS-1333: --- I am presently working on

Jenkins build is back to normal : jclouds #3721

2018-02-15 Thread jenkins-no-reply
See

Build failed in Jenkins: jclouds #3720

2018-02-15 Thread jenkins-no-reply
See Changes: [Andrea Turli] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova -- [...truncated 3.65 MB...] [INFO] Exclude: **/.checkstyle [INFO] Exclude: nb-con

[jira] [Resolved] (JCLOUDS-1382) Improve Neutron usage from Nova

2018-02-15 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Turli resolved JCLOUDS-1382. --- Resolution: Fixed > Improve Neutron usage from Nova > --- > >

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
Closed #1178. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#event-1476352774

Re: [jclouds/jclouds] JCLOUDS-1381: Fix NPE in GCE DiskURIToImage (#1179)

2018-02-15 Thread Andrea Turli
lgtm -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1179#issuecomment-365995927

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
Merged at [master](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=50ae6828) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#issuecomment-365995753

[jira] [Commented] (JCLOUDS-1382) Improve Neutron usage from Nova

2018-02-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365946#comment-16365946 ] ASF subversion and git services commented on JCLOUDS-1382: -- Com

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#issuecomment-365995432

[jira] [Commented] (JCLOUDS-1380) Multiple IT/Live test failures with Openstack Swift

2018-02-15 Thread Cservenak, Tamas (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365905#comment-16365905 ] Cservenak, Tamas commented on JCLOUDS-1380: --- [~gaul] Completely agree and than

[jira] [Resolved] (JCLOUDS-1380) Multiple IT/Live test failures with Openstack Swift

2018-02-15 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul resolved JCLOUDS-1380. -- Resolution: Not A Problem Assignee: Andrew Gaul Just to emphasize my earlier point, Ceph

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#pullrequestreview-96909129

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
@andreaturli pushed 1 commit. ef03157 more comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1178/files/a0aee8e86c6d22322992e471ebc9ab031984a804..ef03157a14a20991a1f8bc1d69896edf58b9f8f7

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -275,15 +258,24 @@ public boolean apply(Network input) { } - private List getNetworksFromPoolNames(String regionId, final Optional> poolNames) { - return getNetworkApi(regionId).list().concat().filter(new Predicate() { - @

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx requested changes on this pull request. > @@ -275,15 +258,24 @@ public boolean apply(Network input) { } - private List getNetworksFromPoolNames(String regionId, final Optional> poolNames) { - return getNetworkApi(regionId).list().concat().filter(new Predicate() { -

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
@andreaturli pushed 1 commit. a0aee8e more comments addressed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1178/files/f5c484c40ad35720edd621bfe6b031e5b3e107bc..a0aee8e86c6d22322992e471ebc9ab031984a804

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > public NovaComputeServiceLiveTest() { provider = "openstack-nova"; - - Properties overrides = setupProperties(); - neutronApiContext = ContextBuilder.newBuilder("openstack-neutron") - .endpoint(setIfTestSystemPropert

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx commented on this pull request. >return floatingIP; } + + private List getNetworksFromPoolNames(String regionId, final Optional> poolNames) { + return getNetworkApi(regionId).list().concat().filter(new Predicate() { if the pool name set is absent or empty, just retur

[jira] [Commented] (JCLOUDS-1380) Multiple IT/Live test failures with Openstack Swift

2018-02-15 Thread Cservenak, Tamas (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365545#comment-16365545 ] Cservenak, Tamas commented on JCLOUDS-1380: --- [~gaul] Thanks for advice, am new

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
@andreaturli pushed 1 commit. f5c484c comments addressed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1178/files/99f434fa292950f7cff2560c6b5881627962d7ff..f5c484c40ad35720edd621bfe6b031e5b3e107bc

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx commented on this pull request. > + } + }); + return floatingIPOptional; + } + + private org.jclouds.openstack.neutron.v2.domain.FloatingIP createFloatingIpUsingNeutron(org.jclouds.openstack.neutron.v2.features.FloatingIPApi neutronFloatingApi, NodeMetadata node, fin

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + } + }); + return floatingIPOptional; + } + + private org.jclouds.openstack.neutron.v2.domain.FloatingIP createFloatingIpUsingNeutron(org.jclouds.openstack.neutron.v2.features.FloatingIPApi neutronFloatingApi, NodeMetadata no

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -51,7 +78,66 @@ protected LoggingModule getLoggingModule() { @Override protected Iterable setupModules() { - return ImmutableSet.of(getLoggingModule(), credentialStoreModule, getSshModule()); + return ImmutableSet. of( +

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx commented on this pull request. > + Optional > floatingIPOptional = tryFindExistingFloatingIp(neutronFloatingApi, > availabilityZone); + org.jclouds.openstack.neutron.v2.domain.FloatingIP floatingIP; + if (floatingIPOptional.isPresent()) { +

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + } + + private final Location location; + + @Inject + public NeutronFloatingIpToFloatingIp(@Assisted Location location) { + this.location = location; + } + + @Override + public FloatingIP apply(@Nullable org.jclouds.openstack.neu

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + Optional > floatingIPOptional = tryFindExistingFloatingIp(neutronFloatingApi, > availabilityZone); + org.jclouds.openstack.neutron.v2.domain.FloatingIP floatingIP; + if (floatingIPOptional.isPresent()) {

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx commented on this pull request. > + Optional networkOptional = > getNetworkApi(regionId).list().concat().firstMatch(new Predicate() { + @Override + public boolean apply(@Nullable Network input) { +return input.getExternal() && input.getAvailabilityZone().e

[jclouds/jclouds] JCLOUDS-1381: Fix NPE in GCE DiskURIToImage (#1179)

2018-02-15 Thread Ignasi Barrera
https://issues.apache.org/jira/browse/JCLOUDS-1381 /cc @aledsage You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1179 -- Commit Summary -- * JCLOUDS-1381: Fix NPE in GCE DiskURIToImage -- File Changes -- M providers/google-compu

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + Optional networkOptional = > getNetworkApi(regionId).list().concat().firstMatch(new Predicate() { + @Override + public boolean apply(@Nullable Network input) { +return input.getExternal() && input.getAvailabilityZ

[jira] [Updated] (JCLOUDS-1381) NullPointerException provisioning VM in GCE: could not find image for disk

2018-02-15 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1381: Labels: google-compute-engine (was: ) > NullPointerException provisioning VM in GCE: coul

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > try { -network = networkApi.create( - Network.createBuilder("jclouds-network-test").external(true).networkType(NetworkType.LOCAL).build()); -assertNotNull(network); - -ipv4SubnetId =

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @andreaturli! > try { -network = networkApi.create( - Network.createBuilder("jclouds-network-test").external(true).networkType(NetworkType.LOCAL).build()); -assertNotNull(network); - -ipv

[jira] [Commented] (JCLOUDS-1382) Improve Neutron usage from Nova

2018-02-15 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365290#comment-16365290 ] Andrea Turli commented on JCLOUDS-1382: --- see [https://github.com/jclouds/jclouds/p

[jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
- move Neutron FloatingIP API from extension to feature - introduce FloatingIpForServer as abstract domain object to represents Nova and Neutron objects - manage floating ip cache and its invalidation --- cc @nacx You can view, comment on, or merge this pull request online at: https://github

[jira] [Created] (JCLOUDS-1382) Improve Neutron usage from Nova

2018-02-15 Thread Andrea Turli (JIRA)
Andrea Turli created JCLOUDS-1382: - Summary: Improve Neutron usage from Nova Key: JCLOUDS-1382 URL: https://issues.apache.org/jira/browse/JCLOUDS-1382 Project: jclouds Issue Type: Improvement