[jira] [Resolved] (JCLOUDS-1443) unable to resolve URI with complex host

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1443. - Resolution: Fixed > unable to resolve URI with complex host >

[jira] [Updated] (JCLOUDS-1443) unable to resolve URI with complex host

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1443: Fix Version/s: 2.1.2 2.2.0 > unable to resolve URI with complex host

[jira] [Resolved] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1339. - Resolution: Fixed > Support launching an x1 EC2 instance >

[jira] [Updated] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1339: Fix Version/s: 2.1.2 2.2.0 > Support launching an x1 EC2 instance >

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Ignasi Barrera
Closed #1235. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1235#event-1806022560

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/88f44a6d) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ca063d8b). Thanks @lemmy! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] [JCLOUDS-1443] - Fix resolution uri (#1234)

2018-08-23 Thread Ignasi Barrera
Closed #1234. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1234#event-1806020959

Re: [jclouds/jclouds] [JCLOUDS-1443] - Fix resolution uri (#1234)

2018-08-23 Thread Ignasi Barrera
Amended the commit message to include the JIRA issue ref and merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bcc6a264) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/591fe84d). Thanks @tormath1! -- You are receiving this because you are subscribed

[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590652#comment-16590652 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit

[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590651#comment-16590651 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit

[jira] [Commented] (JCLOUDS-1443) unable to resolve URI with complex host

2018-08-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590650#comment-16590650 ] ASF subversion and git services commented on JCLOUDS-1443: -- Commit

[jira] [Commented] (JCLOUDS-1443) unable to resolve URI with complex host

2018-08-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590643#comment-16590643 ] ASF subversion and git services commented on JCLOUDS-1443: -- Commit

[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590645#comment-16590645 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit

[jira] [Commented] (JCLOUDS-1339) Support launching an x1 EC2 instance

2018-08-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590644#comment-16590644 ] ASF subversion and git services commented on JCLOUDS-1339: -- Commit

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1235#pullrequestreview-149036803

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() { virtualizationTypes(VirtualizationType.HVM, VirtualizationType.PARAVIRTUAL); return this; } + + private EC2HardwareBuilder x1() { +

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Markus Alexander Kuppe
lemmy commented on this pull request. > @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() { virtualizationTypes(VirtualizationType.HVM, VirtualizationType.PARAVIRTUAL); return this; } + + private EC2HardwareBuilder x1() { +

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() { virtualizationTypes(VirtualizationType.HVM, VirtualizationType.PARAVIRTUAL); return this; } + + private EC2HardwareBuilder x1() { +

Re: [jclouds/jclouds] JCLOUDS-1339: Support launching an x1 EC2 instance (#1235)

2018-08-23 Thread Markus Alexander Kuppe
lemmy commented on this pull request. > @@ -290,6 +290,19 @@ private EC2HardwareBuilder hs1() { virtualizationTypes(VirtualizationType.HVM, VirtualizationType.PARAVIRTUAL); return this; } + + private EC2HardwareBuilder x1() { +

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
@alibazlamit pushed 2 commits. c7b21e6 minor build fixes d17319e minor changes -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
@alibazlamit pushed 8 commits. 202b03e Baremetal update dd664e0 updates f5b715d Baremetal update a4dfa41 Add baremetal logic to ComputeServiceAdapter ba010cc test fix 5a027df Update code for review 9f41453 JCLOUDS-1386 1&1 Baremetal servers e4dd572 Merge branch

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > @@ -78,26 +81,43 @@ public ServerToNodeMetadata(Function > fnVolume, @Override public NodeMetadata apply(final Server server) { checkNotNull(server, "Null server"); + String hardwareId = null; DataCenter dataCenter =

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > } } - // provision server - Server server = null; - Double cores = ComputeServiceUtils.getCores(hardware); - Double ram = (double) hardware.getRam(); - if (ram < 1024) { - ram = 0.5; - } else

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > - SingleServerAppliance appliance = > api.serverApplianceApi().get(image.getId()); - if (appliance.minHddSize() > volume.getSize()) { - minHddSize = appliance.minHddSize(); - } -

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > @@ -179,9 +179,46 @@ return new NodeAndInitialCredentials(updateServer, updateServer.id(), serverCredentials); } + private ServerAppliance findWorkingImage(String imageId, Types.ServerTypeCompatibility serverType) { changed --

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > @@ -253,7 +253,7 @@ public static ApplianceType fromValue(String v) { } public enum OSImageType { - Standard, Minimal, Personal, ISO_OS, ISO_TOOL, NULL, UNRECOGNIZED; + STANDARD, MINIMAL, Personal, ISO_OS, ISO_TOOL, NULL,

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > @@ -283,4 +283,22 @@ public String toString() { return value; } } + + public enum ServerType { + cloud, baremetal, UNRECOGNIZED; done -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > @@ -283,4 +283,22 @@ public String toString() { return value; } } + + public enum ServerType { + cloud, baremetal, UNRECOGNIZED; + + public static ServerType fromValue(String v) { + return

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
@andreaturli a few of your comments do make sense about this PR, i will address those issues so we can move on. I don't see why i would separate Recovery Images it is a very small feature and i am not sure that will really affect reviewing the PR. In my opinion i think that most of the things

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > } @Override public void suspendNode(String id) { waitServerUntilAvailable.apply(getNode(id)); - api.serverApi().updateStatus(id, Server.UpdateStatus.create(Types.ServerAction.POWER_OFF,

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-23 Thread Ali Bazlamit
alibazlamit commented on this pull request. > } @Override public void resumeNode(String id) { - api.serverApi().updateStatus(id, Server.UpdateStatus.create(Types.ServerAction.POWER_ON, Types.ServerActionMethod.HARDWARE)); + api.serverApi().updateStatus(id,

[jira] [Comment Edited] (JCLOUDS-1444) Outage on any endpoint in catalog blocks usage of other endpoints

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589805#comment-16589805 ] Ignasi Barrera edited comment on JCLOUDS-1444 at 8/23/18 8:44 AM: -- As

[jira] [Commented] (JCLOUDS-1444) Outage on any endpoint in catalog blocks usage of other endpoints

2018-08-23 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589805#comment-16589805 ] Ignasi Barrera commented on JCLOUDS-1444: - As a workaround you can configure the {{jclouds