Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-10-04 Thread Andrea Turli
@andreaturli pushed 3 commits. 21403be refactor from Deployment to VirtualMachine 84ed11f fix Cleanup resources e450fd4 some more fixes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/9456ad1468e8c

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-09-30 Thread Andrea Turli
@andreaturli pushed 1 commit. 9456ad1 revert VirtualMachineApi -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/358aa82d9bf70a870c1abe89ca1ae4d5939adf5e..9456ad1468e8c13e3f9935876fbecf00fb29323c

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest and AzureComputeServiceLiveTest (#323)

2016-09-30 Thread Andrea Turli
@andreaturli pushed 2 commits. 1b958fc fixing createNodeWithGroupEncodedIntoName 358aa82 improvements to solve AzureComputeServiceLiveTest -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/e5035aaad80

Re: [jclouds/jclouds-labs] Fix AzureTemplateBuilderLiveTest (#323)

2016-09-29 Thread Andrea Turli
Thx @nacx! Not got to the bottom of it, but if I specify the default creds for the images, the test that tries to override them fail! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pu

Re: [jclouds/jclouds-labs] [DO NOT MERGE] wip (#323)

2016-09-28 Thread Andrea Turli
@andreaturli pushed 1 commit. f8c20ab remove default creds for all images -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/323/files/a7f6f2ce7c97bd639c2554710224ac9432b739a6..f8c20ab09dfadf10a3419d4a824397a7956

[jclouds/jclouds-labs] [DO NOT MERGE] wip (#323)

2016-09-28 Thread Andrea Turli
For review only @nacx I'd appreciate if you could have a look at it Still something wrong ``` java.lang.AssertionError: expected [[user=foo, passwordPresent=true, privateKeyPresent=false, shouldAuthenticateSudo=true]] but found [[user=jclouds, passwordPresent=true, privateKeyPresent=false, sh

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-27 Thread Andrea Turli
Closed #317. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317#event-803805178

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-27 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c458bafd) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317#issuecomment-249864763

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-27 Thread Andrea Turli
@andreaturli pushed 1 commit. 1bf9d27 fix VirtualMachineLiveTest -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317/files/071c533908fc8e908074f0bd6fc6deb75d325782..1bf9d272b61efae7ab5d2b9a18674a43898d73b8

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-27 Thread Andrea Turli
@nacx I think we are good to merge this ``` Results : Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->Bas

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-27 Thread Andrea Turli
@nacx I think we are good to merge this ``` Results : Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->Bas

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-26 Thread Andrea Turli
@andreaturli pushed 1 commit. 071c533 fix checkstyle -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317/files/388177aa18ed03c633a3216f7dbc15be2c51..071c533908fc8e908074f0bd6fc6deb75d325782

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-26 Thread Andrea Turli
``` Results : Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->BaseComputeServiceLiveTest.createAndRunASer

Re: [jclouds/jclouds] GCE live test fixes (#1015)

2016-09-26 Thread Andrea Turli
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1015#issuecomment-249585667

Re: [jclouds/jclouds] GCE live test fixes (#1015)

2016-09-26 Thread Andrea Turli
great! you want to continue on this PR or prefer merging it and work on the last failing test on a different PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1015#issuecomment-24958

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
thx @nacx for the explanation! I'll close the pr as not needed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1014#issuecomment-249579672

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
Closed #1014. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1014#event-802329941

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
because I thought it was jclouds's convention, thinking about stuff like ``` public static final String AUTO_ALLOCATE_FLOATING_IPS = "jclouds.openstack-nova.auto-create-floating-ips"; ``` so for simmetry I'd have expected that for oauth things as well, no? -- You are receiving this because you a

Re: [jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
thanks @nacx but I don't follow completely. For example, to run tests in `jclouds-labs/azurecompute-arm` I need to specify: ``` mvn clean install -Plive -Dtest.azurecompute-arm.identity="identity" -Dtest.azurecompute-arm.credential="password" -Dtest.azurecompute-arm.endpoint="https://management.

[jclouds/jclouds] rename oauth properties (#1014)

2016-09-26 Thread Andrea Turli
- oauth.{endpoint.identity, credential} to jclouds.oauth.{endpoint, identity, credential} @nacx what do you think? I think it is more homogenous this way You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1014 -- Commit Summary -- * ren

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-23 Thread Andrea Turli
New results ``` Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->BaseComputeServiceLiveTest.createAndRunASe

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-23 Thread Andrea Turli
@andreaturli pushed 1 commit. 388177a fix some live tests more -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317/files/342666fe60a3c1ec24919a99cde90b6d27dcc9ad..388177aa18ed03c633a3216f7dbc15be2c51

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-22 Thread Andrea Turli
@andreaturli pushed 1 commit. 342666f fix create network card interface -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/317/files/e1e3a687b13f90ca133ac69ea46c0499d92d63ff..342666fe60a3c1ec24919a99cde90b6d27dcc

Re: [jclouds/jclouds-labs] Use the existing region suppliers to filter (#321)

2016-09-21 Thread Andrea Turli
looks so clean, thx @nacx ! Merge it right away! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/321#issuecomment-248651612

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-21 Thread Andrea Turli
``` Failed tests: AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCompareSizes:887->BaseComputeServiceLiveTest.doCompareSizes:891 » Provision AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:733->BaseComputeServiceLiveTest.createAndRunAServiceInGroup

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Andrea Turli
thx @nacx, merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/28c56e06) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248632037

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Andrea Turli
Closed #320. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/320#event-797411872

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-20 Thread Andrea Turli
@andreaturli pushed 1 commit. 7b35424 fix Deployment -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/320/files/817350313452bc7227c25deb0db60f0602821b68..7b354241feeb74af24199b75527b4ccb731a1a6d

[jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-20 Thread Andrea Turli
- refactor logback-test.xml - change jsonBall to Value You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/320 -- Commit Summary -- * separate the DeploymentToVMDeployment to a function -- File Changes -- M azurecompute-arm/src/

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-20 Thread Andrea Turli
merged at (master)[http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/89cb6f0f] -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-248317509

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-20 Thread Andrea Turli
Closed #308. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308#event-795734646

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-20 Thread Andrea Turli
@andreaturli pushed 1 commit. 07007d9 refactor logback-test.xml -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308/files/8f403aa5cc1c711496a670c3fbf3e03eadca969e..07007d994a33b1cc3c62a6294e8760141014758e

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-20 Thread Andrea Turli
@andreaturli pushed 2 commits. 12f49f2 add parser module 8f403aa separate the DeploymentToVMDeployment to a function -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308/files/aaae68457526b198a2b30d7f648b4ef0b

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-19 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties > properties) { properties.put("oauth.credential", "password"); properties.put("oauth.endpoint", "https://login.microsoftonline.com/oauth2/token";); pro

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-19 Thread Andrea Turli
andreaturli commented on this pull request. > @Inject AzureComputeServiceAdapter(final AzureComputeApi api, final AzureComputeConstants azureComputeConstants, - CleanupResources cleanupResources) { + CleanupResources cleanupResou

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-15 Thread Andrea Turli
@nacx happy to share the live tests results, **but** it would be useful to merge first https://github.com/jclouds/jclouds-labs/pull/308 as it speed up the live tests significantely -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on Gi

Re: [jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-15 Thread Andrea Turli
@andreaturli pushed 3 commits. 79c8f32 add image publishers filter to AzureComputeServiceLiveTest eefa3bd add parser module to provider de2d18b fix checkstyle -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-14 Thread Andrea Turli
> @@ -46,9 +44,9 @@ protected void bindErrorHandlers() { > @Override > protected void installLocations() { >super.installLocations(); > - bind(ImplicitLocationSupplier.class). > - to(OnlyLocationOrFirstRegionOptionallyMatchingRegionId.class). I think `FirstRegion`

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-14 Thread Andrea Turli
@andreaturli pushed 1 commit. aaae684 revert ZONES to REGIONS -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308/files/961db5c145342971726063e25776e0011ab8ed36..aaae68457526b198a2b30d7f648b4ef0b46ec359

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-14 Thread Andrea Turli
> @@ -46,9 +44,9 @@ protected void bindErrorHandlers() { > @Override > protected void installLocations() { >super.installLocations(); > - bind(ImplicitLocationSupplier.class). > - to(OnlyLocationOrFirstRegionOptionallyMatchingRegionId.class). @nacx I'm having issu

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-14 Thread Andrea Turli
ok thanks, I guess this one confused me https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-239163128 :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308#issuecomment

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-09-14 Thread Andrea Turli
@nacx good to merge? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308#issuecomment-246959604

[jclouds/jclouds-labs] fix azure-arm features live tests (#317)

2016-09-13 Thread Andrea Turli
When running in isolation the *LiveTests are working fine, they fail when running all together from maven. (see https://gist.github.com/andreaturli/2725723193ee1a8362f175e8e8c76ee8) You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/31

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

2016-09-12 Thread Andrea Turli
thanks @neykov -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-246346027

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

2016-09-12 Thread Andrea Turli
Merged #81. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#event-785928303

Re: [jclouds/jclouds-karaf] Use same bundle version as in jclouds/project/java-xmlbuilder.verison (#81)

2016-09-12 Thread Andrea Turli
@demobox lgtm too -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/81#issuecomment-246342026

Re: [jclouds/jclouds-labs] [JCLOUDS-1157] fix networks in DockerComputeServiceAdapterLiveTest (#311)

2016-08-19 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/970250d3) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/311#issuecomment-241056693

Re: [jclouds/jclouds-labs] Update Docker README.md (#312)

2016-08-19 Thread Andrea Turli
thanks @kwart looks useful. merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/312#issuecomment-241055430

Re: [jclouds/jclouds-labs] [JCLOUDS-1157] fix networks in DockerComputeServiceAdapterLiveTest (#311)

2016-08-19 Thread Andrea Turli
Closed #311. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/311#event-761447093

Re: [jclouds/jclouds-labs] [JCLOUDS-1157] fix networks in DockerComputeServiceAdapterLiveTest (#311)

2016-08-19 Thread Andrea Turli
thx @kwart merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/311#issuecomment-241056394

Re: [jclouds/jclouds-labs] Update Docker README.md (#312)

2016-08-19 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/acd382e5) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/312#issuecomment-241056161

Re: [jclouds/jclouds-labs] Update Docker README.md (#312)

2016-08-19 Thread Andrea Turli
Closed #312. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/312#event-761444507

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @Inject > AzureComputeServiceAdapter(final AzureComputeApi api, final > AzureComputeConstants azureComputeConstants, > - CleanupResources cleanupResources) { > + CleanupResources cleanupResources, > ProviderMetadata providerMetad

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @Inject > AzureComputeServiceAdapter(final AzureComputeApi api, final > AzureComputeConstants azureComputeConstants, > - CleanupResources cleanupResources) { > + CleanupResources cleanupResources, > ProviderMetadata providerMetad

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties > properties) { > properties.put("oauth.credential", "password"); > properties.put("oauth.endpoint", > "https://login.microsoftonline.com/oauth2/token";); > properties.put(CREDENTIAL_TYPE, CLIENT_CRE

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-12 Thread Andrea Turli
> @Inject > AzureComputeServiceAdapter(final AzureComputeApi api, final > AzureComputeConstants azureComputeConstants, > - CleanupResources cleanupResources) { > + CleanupResources cleanupResources, > ProviderMetadata providerMetad

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-11 Thread Andrea Turli
> @@ -28,6 +30,7 @@ public static Properties defaultProperties(Properties > properties) { > properties.put("oauth.credential", "password"); > properties.put("oauth.endpoint", > "https://login.microsoftonline.com/oauth2/token";); > properties.put(CREDENTIAL_TYPE, CLIENT_CRE

Re: [jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-11 Thread Andrea Turli
@andreaturli pushed 1 commit. 961db5c address initial comments from @nacx -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/308/files/bea9005a1dbad01499584a1932c4445b64a60659..961db5c145342971726063e25776e0011ab

[jclouds/jclouds-labs] add support for whitelisting locations (#308)

2016-08-11 Thread Andrea Turli
- change location scope to ZONE vs REGION - edit the README - fix Region.byName - add more Regions in Region class You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/308 -- Commit Summary -- * add support for whitelisting locations -

[jira] [Created] (JCLOUDS-1152) Update README

2016-08-10 Thread Andrea Turli (JIRA)
Andrea Turli created JCLOUDS-1152: - Summary: Update README Key: JCLOUDS-1152 URL: https://issues.apache.org/jira/browse/JCLOUDS-1152 Project: jclouds Issue Type: Bug Components

[jira] [Updated] (JCLOUDS-1150) Resource not ready error deploying to gce location

2016-08-08 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Turli updated JCLOUDS-1150: -- Assignee: Andrea Turli Fix Version/s: 1.9. 2.0.0 > Resource

Re: [jclouds/jclouds] Cleanup imports in google-compute-engine project. (#989)

2016-08-07 Thread Andrea Turli
Thx @nelsonjr could you please avoid to reorder the imports and remove only the unused? It's a bit hard to review this PR otherwise. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/9

Re: [jclouds/jclouds] adding attache detach interface to nova api (#697)

2016-08-06 Thread Andrea Turli
hi @limorbortman, can you address the last comment from @limorbortman so that we can finally merge this one? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/697#issuecomment-238022635

Re: [jclouds/jclouds] Fix InitScriptConfigurationForTasks.initScriptPattern on Windows hosts (#677)

2016-08-06 Thread Andrea Turli
@rdowner can you please address the 2 minor comments from @nacx so that we can merge it? Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/677#issuecomment-238022564

Re: [jclouds/jclouds] [1.9.x] update CloudstackTemplateOptions pattern (#956)

2016-08-06 Thread Andrea Turli
I think this is a straightforward improvements to the CloudstackTemplateOptions to be in line with the other `*TemplateOptions` which we also tested in a real env. @nacx good to merge? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-08-06 Thread Andrea Turli
I'm gonna close it as it doesn't need to be really useful as-is. We'll come back to it later if needed --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/951#issuecomment-238022343

Re: [jclouds/jclouds] [JCLOUDS-1108]: shorten hardwareId (#951)

2016-08-06 Thread Andrea Turli
Closed #951. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/951#event-747434271

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/d0b07a66) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-238022091

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
Closed #301. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#event-747433245

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-08-06 Thread Andrea Turli
thx @ritazh merging it now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-238021534

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
https://jclouds.ci.cloudbees.com/job/jclouds/org.apache.jclouds.provider$google-compute-engine/3458/changes --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-237006693

[jclouds/jclouds] GCE: fix tags order (#987)

2016-08-02 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/987 -- Commit Summary -- * GCE: fix tags order -- File Changes -- M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateNodesWithGr

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
Sorry I will asap --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236976728

Re: [jclouds/jclouds-examples] refactor maven structure (#88)

2016-08-02 Thread Andrea Turli
Agreed @andrewgaul, jclouds-examples as-is is not useful. I'll try to open several subsequent PR to fix the project, maybe one maven module for each PR? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jcl

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
Closed #985. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#event-742543308

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
Merged *only* at [master](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=deeedd55) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236936275

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
the [error](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/2368/console) doesn't seem related to this PR --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-2

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
rebuild please --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236935183

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
ah! it is not easy to backport it as in 1.9.x it was on jclouds-labs, so I need to open another PR referencing this review. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issueco

Re: [jclouds/jclouds] update CloudstackTemplateOptions pattern (#957)

2016-08-02 Thread Andrea Turli
Closed #957. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/957#event-742493469

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
thanks @nacx, can't see the cosmetic comment btw - is it fine to backport this to 1.9.x ? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/985#issuecomment-236921560

Re: [jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
@andreaturli pushed 1 commit. 03058e3 adress @nacx comments --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/985/files/4f26ab699a95a625f91b135bd7cd9eb3203417e3..03058e39d402d3fe692564a0cf9a1f071240ffe6

[jclouds/jclouds] add support for security groups (#985)

2016-08-02 Thread Andrea Turli
if ok, I'd like to backport it to 1.9.x You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/985 -- Commit Summary -- * add support for security groups -- File Changes -- M providers/google-compute-engine/src/main/java/org/jclouds/goo

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-02 Thread Andrea Turli
Closed #172. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/172#event-742064063

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-02 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if (template

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-02 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if (template

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-01 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if (template

Re: [jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-08-01 Thread Andrea Turli
>Network network = getOrCreateNetwork(templateOptions, > sharedResourceName); > - getOrCreateFirewalls(templateOptions, network, > firewallTagNamingConvention.get(group)); > + // add firewalls *only* if the template options don't contain explicit > network > + if (template

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-29 Thread Andrea Turli
@ritazh can you have a look at this PR? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301#issuecomment-236138370

Re: [jclouds/jclouds-examples] refactor maven structure (#88)

2016-07-29 Thread Andrea Turli
thx @demobox I didn't know about the original intention. Although I think it is a good idea, I think it doesn't work terribly well long term, most of the examples are referencing very old jclouds releases and they are not really helpful for new users. I think a half way solution can be to try to

[jclouds/jclouds-examples] refactor maven structure (#88)

2016-07-26 Thread Andrea Turli
first stab at the maven structure You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-examples/pull/88 -- Commit Summary -- * refactor maven structure -- File Changes -- M blobstore-basics/pom.xml (18) M blobstore-basics/src/main/java

[jclouds/jclouds-labs-google] add firewalls conditionally (#172)

2016-07-25 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/172 -- Commit Summary -- * add firewalls conditionally -- File Changes -- M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/strategy/CreateN

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-15 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/b975be5e) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300#issuecomment-232909926

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-15 Thread Andrea Turli
Closed #300. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300#event-724149884

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-15 Thread Andrea Turli
thanks @nacx, merging now --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300#issuecomment-232898315

Re: [jclouds/jclouds-labs] [azure-arm] add supports to port ranges to addNetworkSecurityGroup (#300)

2016-07-14 Thread Andrea Turli
@andreaturli pushed 1 commit. fbe58c1 add unit tests --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/300/files/bbfa9982d1d1f2674fa45fd24ba89db1f39f0831..fbe58c1aad4aab0126a117154d3479cc9ff779f5

Re: [jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-14 Thread Andrea Turli
@andreaturli pushed 1 commit. 1a2193f add unit test for storage account name generation --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/301/files/a34066c4331d7552669ed4fb005feec2374c442e..1a2193f8d6c767e668d67

Re: [jclouds/jclouds] Change line endings on files recursively (#981)

2016-07-13 Thread Andrea Turli
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a515ce2f) and backported at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c10d7a65) --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: h

Re: [jclouds/jclouds] Change line endings on files recursively (#981)

2016-07-13 Thread Andrea Turli
Closed #981. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/981#event-722264425

[jclouds/jclouds-labs] [azure-arm] add controlled storage account name generation (#301)

2016-07-13 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/301 -- Commit Summary -- * [azure-arm] add controlled storage account name generation -- File Changes -- M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/util/Dep

<    5   6   7   8   9   10   11   12   13   14   >