[
https://issues.apache.org/jira/browse/JCLOUDS-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine resolved JCLOUDS-1026.
Resolution: Fixed
Fix Version/s: 2.0.0
5d82b40d JCLOUDS-1026: Remove public HP
[
https://issues.apache.org/jira/browse/JCLOUDS-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine reassigned JCLOUDS-1026:
--
Assignee: Chris Custine
> Remove public HP cloud compute provid
@nacx This is a great addition and this is quality code. I haven't had time to
test but the code looks great and this should be highly useful for DO users.
Thanks for doing this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/212#issuecomment
:+1: Tests run fine for me in several regions and the change looks good.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/183#issuecomment-117297454
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604465#comment-14604465
]
Chris Custine commented on JCLOUDS-613:
---
[~nacx] I rebased on master and merg
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604463#comment-14604463
]
Chris Custine commented on JCLOUDS-613:
---
PR Submitted [here|https://github
Thanks to @nacx for pagination, many tests, fixes, and improvements to help
push this over the finish line!
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/182
-- Commit Summary --
* JCLOUDS-613: Implement the DigitalOcean v2 API
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604429#comment-14604429
]
Chris Custine commented on JCLOUDS-613:
---
That would make sense. I was able to
I'm going to try these out in a few hours after some sleep. Either way I'll
try to get this pr created tomorrow.
--
Sent from my Android phone
On Jun 26, 2015 2:39 AM, "Ignasi Barrera (JIRA)" wrote:
>
> [
> https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.syst
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602547#comment-14602547
]
Chris Custine commented on JCLOUDS-613:
---
[~nacx]: I have run the live tests
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561763#comment-14561763
]
Chris Custine commented on JCLOUDS-613:
---
I'll take a look at this over th
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553726#comment-14553726
]
Chris Custine commented on JCLOUDS-613:
---
[~nacx] I pulled and tested your
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529527#comment-14529527
]
Chris Custine commented on JCLOUDS-613:
---
This sounds like a great plan. I
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527043#comment-14527043
]
Chris Custine commented on JCLOUDS-613:
---
[~nacx] I have about 99% of this
@nacx @everett-toews @zack-shoylev I am delivering a project this week so I
have been heads down crunching on that, but to be honest I don't totally
understand the issue as it related to HP Cloud. HPs nova supports os-volumes
extension and IIRC cinder already has the attachment support baked in
:+1: HP provider has full Cinder support and is well tested.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/708#issuecomment-83618242
[
https://issues.apache.org/jira/browse/JCLOUDS-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-408.
-
Resolution: Fixed
Fix Version/s: 1.8.0
Assignee: Chris Custine
This was fixed in
[
https://issues.apache.org/jira/browse/JCLOUDS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-407.
-
Resolution: Fixed
Fix Version/s: 1.8.0
Assignee: Chris Custine
I'm closing
[
https://issues.apache.org/jira/browse/JCLOUDS-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-673.
-
Resolution: Fixed
Fixed by upgrading Karaf to 2.3.9 (latest 2.3.x available) and syncing
[
https://issues.apache.org/jira/browse/JCLOUDS-674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-674.
-
Resolution: Fixed
Fixed by upgrading Karaf to 2.3.9 (latest 2.3.x available) and syncing
[
https://issues.apache.org/jira/browse/JCLOUDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-809.
-
Resolution: Fixed
Fixed by upgrading Karaf to 2.3.9 (latest 2.3.x available) and syncing
[
https://issues.apache.org/jira/browse/JCLOUDS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine resolved JCLOUDS-675.
---
Resolution: Won't Fix
According to my testing, later versions of Karaf 2.3 work fine
[
https://issues.apache.org/jira/browse/JCLOUDS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-675.
-
> Upgrade CLI to Karaf 3.0
>
>
> Key:
[
https://issues.apache.org/jira/browse/JCLOUDS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine reassigned JCLOUDS-809:
-
Assignee: Chris Custine
> Launching jclouds interactive CLI does not display out
[
https://issues.apache.org/jira/browse/JCLOUDS-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine reassigned JCLOUDS-790:
-
Assignee: Chris Custine
> hpcloud-objectstorage to use openstack-sw
[
https://issues.apache.org/jira/browse/JCLOUDS-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215575#comment-14215575
]
Chris Custine commented on JCLOUDS-518:
---
Since each instance gets a new token
[
https://issues.apache.org/jira/browse/JCLOUDS-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-238.
-
Resolution: Fixed
Fix Version/s: 1.8.0
As of 1.8.0 (fixed in issue JCLOUDS-647) you
[
https://issues.apache.org/jira/browse/JCLOUDS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-111.
-
Resolution: Fixed
Fix Version/s: 1.8.0
> hpcloud-compute - Error while setting strReg
> @@ -196,7 +229,7 @@ public void testResetInstance() {
>assertOperationDoneSuccessfully(api().reset(INSTANCE_NAME));
> }
>
> - @Test(groups = "live", dependsOnMethods = "testResetInstance")
> + @Test(groups = "live", dependsOnMethods = {"testSetDiskAutoDelete",
> "testResetInsta
+1 Tested with Digital Ocean v2 with no issues.
@demobox Do you mean add another annotation to the API classes :-) This case
(GCS full control scope) seems enough of a special case that I think it is
easier to track the config without being annotation based IMHO.
---
Reply to this email directly
+1 Its been a bit of a moving target anyway :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/90#issuecomment-62635337
+1 @adriancole I missed where/what the default project name is set. I assume
it is empty but I couldn't find it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/88#issuecomment-62417142
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds-labs-google features/fixes
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/85
-- Commit Summary --
* Fix support for bearer tokens
-- File
Closed #84.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/84#event-190228524
You are right about the file io. Part of this is still necessary to use oauth
bearer tokens outside of the google providers so I will kill this and start
another PR with this code whittled down.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-googl
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds-labs-google features/fixes
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/84
-- Commit Summary --
* Misc fixes to support file based key a
I checked this all out last night but forgot to +1 it. LGTM, and I will take a
look at these last 3 tests today when I get a chance.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/83#issuecomment-62173651
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/108#issuecomment-61378465
+1 This will make things much better :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/596#issuecomment-61376316
@nacx This should solve the test issues you are seeing in #58
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/59#issuecomment-61062448
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds-karaf fixes/guava16
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-karaf/pull/59
-- Commit Summary --
* Downgrade guava to be in sync with 2.0.0-SNAPSHOT b
+1 I haven't tested with WIP such as the DO v2 API but the code looks good.
After seeing some of this Autovalue stuff, I am going to switch the DO v2
provider to use it ASAP :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issueco
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/579#issuecomment-60432107
+1 LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/63#issuecomment-60411474
+1 btw, what are we waiting on before using autovalue? A specific issue or
feature?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59810657
[
https://issues.apache.org/jira/browse/JCLOUDS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine updated JCLOUDS-613:
--
Assignee: Chris Custine (was: Ignasi Barrera)
> Implement the DigitalOcean v2
@danbroudy Aside from the comment from @nacx about the System.out in that test,
everything LGTM. I think if you fix that, rebase and squash to a single
commit, I will +1 and merge this in.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull
[
https://issues.apache.org/jira/browse/JCLOUDS-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173833#comment-14173833
]
Chris Custine commented on JCLOUDS-495:
---
[~broudy] Yeah this is was resolve
[
https://issues.apache.org/jira/browse/JCLOUDS-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine resolved JCLOUDS-495.
---
Resolution: Fixed
Fix Version/s: 1.8.0
2.0.0
> GCE provi
@danbroudy Yeah it is perfectly fine to change the return type here in a labs
project. If we had released this before the PR, then we would have to wait
until 2.0, so this worked out nicely. I don't have time to review this in
detail but I'll be back with a review in a couple of hours.
---
Re
:+1: LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/568#issuecomment-59127997
[
https://issues.apache.org/jira/browse/JCLOUDS-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168851#comment-14168851
]
Chris Custine commented on JCLOUDS-747:
---
I agree that we should at least stop
[
https://issues.apache.org/jira/browse/JCLOUDS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine closed JCLOUDS-703.
-
Resolution: Fixed
Thanks for the patch Stuart.
> Google Hardware no longer supports ima
Thanks @stuarthendren , rebased and merged as below.
Merged to master
[here](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=65ac580)
Backported to 1.8.x
[here](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=4e068d5)
---
Reply to this email directly or vi
[
https://issues.apache.org/jira/browse/JCLOUDS-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine reassigned JCLOUDS-703:
-
Assignee: Chris Custine
> Google Hardware no longer supports ima
+1 I'm going to merge this in after confirming with Google that imageSpaceGb is
going to be missing for now, but may return later. Only safe thing to do is
ignore it for image selection.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/49
+1 LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/55#issuecomment-58097415
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/554#issuecomment-58025904
:+1: on merging this anyway.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/50#issuecomment-57871826
+1 With the above osgi import fix and the fix for #537.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/536#issuecomment-57835484
> +../../project/pom.xml
> +
> + org.apache.jclouds.api
> + chef
> + bundle
> + jclouds Chef api
> + jclouds components to access Chef
> +
> +
> +http://localhost:4000
> +
> +
> +chef-webui
> +${user.home}/.chef/webui.pem
> +
> + org.project.version=${proje
[
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145316#comment-14145316
]
Chris Custine commented on JCLOUDS-172:
---
[~gaul]: I had thought that 1.8.1 was
I spoke to @andreaturli today and he is hoping to work on finalizing this next
week so that we can merge this and #38 before graduating to jclouds/jclouds.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/22#issuecomment-56577803
[
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144940#comment-14144940
]
Chris Custine commented on JCLOUDS-172:
---
This is going to take a few days to
[
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143490#comment-14143490
]
Chris Custine commented on JCLOUDS-172:
---
Hi [~erjohnso] It looks like there
[
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143392#comment-14143392
]
Chris Custine commented on JCLOUDS-172:
---
[~everett-toews] Working on this t
I starred and commented on the ticket as well. I'm not sure if we should
pre-emptively apply this PR until we get some comment from Google on the
ticket. If we remove this property and it comes back as a bug in GCE that they
fix, we will have to track the resolution manually as it won't be obv
I can also confirm this. I tested using curl for get, list, and aggregatedList
varieties and none of them returned imageSpaceGb.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/49#issuecomment-55471368
:+1: I am not able to test thoroughly at the moment, but LGTM.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/129#issuecomment-52972076
> * @return The {@link Account} object.
> */
> @Named("account:get")
> @HEAD
> @ResponseParser(ParseAccountFromHeaders.class)
> - @Path("/")
Ok, thanks for pointing out that UriBuilder magic.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds
:+1: and I'll repeat that if any servicemix bundle stuff comes up again let me
know and I can get it in quickly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/53#issuecomment-52969565
> @@ -202,6 +202,7 @@ limitations under the License.
> 2.1
> 0.1.44_2
> 0.0.7
> +
> ${jsch.agentproxy.version}_2
...and I stand corrected, it IS used elsewhere so disregard my statement :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jcloud
> @@ -202,6 +202,7 @@ limitations under the License.
> 2.1
> 0.1.44_2
> 0.0.7
> +
> ${jsch.agentproxy.version}_2
+1 with the following caveat: This could bite you later if someone doesn't
understand the relationship between the version for the plain jar file and the
servicemix
> @@ -24,6 +24,7 @@
> org.apache.jclouds
> jclouds-project
> 2.0.0-SNAPSHOT
> +
@demobox Yeah, you have the gist of it now. There is a long running debate
about this but I doubt it will ever be resolved:
https://jira.codehaus.org/browse/MNG-5146
In the mean time, I just reli
After looking at this Karaf stuff for a few days, I am going to close this out
without merging, and create separate PRs for 1.8.x and master. master should
be updated to Karaf 3.0.x before the jclouds 2.0 release and 1.8.x just needs
these basic dependency updates to 2.3.6. There is also anoth
> @@ -24,6 +24,7 @@
> org.apache.jclouds
> jclouds-project
> 2.0.0-SNAPSHOT
> +
@demobox Did you mean it should NOT be linked with a relativePath? The problem
is that maven always looks at ../pom.xml first if there is no relativePath
specified and spits out these:
```
[WARNI
> * @return The {@link Account} object.
> */
> @Named("account:get")
> @HEAD
> @ResponseParser(ParseAccountFromHeaders.class)
> - @Path("/")
I'm assuming "/" is default with no @Path annotation? (I looked but couldn't
quickly confirm that).
---
Reply to this email directl
Pushed to Apache
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=192785dbaedc16eeec87ce7783fb8fbb136e7055)
Backported to Apache
[1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=d3234b7299f38785b9ddd4a71ef6799d678ee3de)
---
Reply to this email dir
Backported to
[1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=59dcf2474fea950887fa061325c865610463d754)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/476#issuecomment-52579050
Backported to
[1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=d3234b7299f38785b9ddd4a71ef6799d678ee3de)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/472#issuecomment-52578914
I can confirm that this patch also works properly when building on windows.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/492#issuecomment-52577153
@demobox Good question, I will test that out.
@andrewgaul I missed the two references in project/pom.xml, I've removed them
now.
I will check Windows as that would be a blocker.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/492#issuecomment-525625
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds features/checkstyleheader
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/492
-- Commit Summary --
* Move checkstyle copyright header into checkstyle.x
+1 There is also a way to do this with macros that will use the maven project
version as a basis for this range. I will put that in my generic PR for
updating the karaf and cli projects, as it will automatically set these ranges
along the lines of semver such as [2,3) if you maven project is 2.
Just a thought... an alternative could be to remove them from the default build
and add a -Plegacy profile build, leaving them where they are. If the concern
from Jeremy is that moving say, openstack-swift and rackspace-cloudfiles* to
the main jclouds project will cause confusion on which one t
Chris Custine created JCLOUDS-675:
-
Summary: Upgrade CLI to Karaf 3.0
Key: JCLOUDS-675
URL: https://issues.apache.org/jira/browse/JCLOUDS-675
Project: jclouds
Issue Type: Improvement
I'll update jclouds-karaf to match and see how little we can get by with in
1.8.x. I think what was happening is that one of the 3rd party jclouds
dependencies had a bundle version constraint requiring a newer osgi framework
version. The Karaf version 2.2.7 was over 2 years old at this point,
[
https://issues.apache.org/jira/browse/JCLOUDS-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099412#comment-14099412
]
Chris Custine commented on JCLOUDS-673:
---
Possibly solved here: https://github
@andrewgaul This solves those issues for me on both master and 1.8.x builds. I
think this fixes several other imminent issues with bit rot from
outdated/missing osgi bundles. I might take a stab at updating master to Karaf
3.0.1 this weekend, but at least this brings the dependencies up to more
Hopefully fixing:
https://issues.apache.org/jira/browse/JCLOUDS-673
https://issues.apache.org/jira/browse/JCLOUDS-674
You can merge this Pull Request by running:
git pull https://github.com/ccustine/jclouds-cli features/karafupdate
Or you can view, comment on it, or merge it online at:
https
Fixed, and thanks for the heads up. I am REALLY going to figure out how to get
IDEA to make this more obvious before I check in... I promise :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/34#issuecomment-52342497
@demobox Actually it is :-( Is it ok to just fix these directly on Apache?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/34#issuecomment-52341042
Oh heck yeah, +1!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/488#issuecomment-52340226
Backported to [Apache
1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=6fa3651)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/477#issuecomment-52243085
I took the liberty of backporting this to [Apache
1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=2f92f1c)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/39#issuecomment-52242952
Basically there are unit tests for the layer above
(GoogleComputeEngineServiceExpectTest), and the layer below
(FirewallApiExpectTest), but nothing specific for the SecurityGroupExtension.
The FirewallApi already has the ability to specify a single port (and already
has tests for that) and this
+1
I merged jclouds/jclouds-labs-google#37 and tested this PR along with
jclouds/jclouds-labs-google#39 and all tests pass now so everything looks good
to me at this point. I'll let @demobox have final say on this one.
---
Reply to this email directly or view it on GitHub:
https://github.com/jc
[
https://issues.apache.org/jira/browse/JCLOUDS-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Custine resolved JCLOUDS-633.
---
Resolution: Fixed
Fix Version/s: 2.0.0
1.8.1
Assignee
Pushed to [Apache
master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=2717e8e)
Backported to [Apache
1.8.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=bee9898)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclou
Closed #34.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/34#event-152625315
1 - 100 of 230 matches
Mail list logo
