nacx commented on this pull request.
> + client = view.unwrapApi(AWSEC2Api.class).getVPCApi().get();
+ }
+
+ @Test
+ public void testCreate() {
+ vpc = client.createVpc(null, "10.0.0.0/16", CreateVpcOptions.NONE);
+ assertNotNull(vpc);
+ }
+
+ @Test(dependsOnMethods =
Squashed and merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8649c3ff)
backported at
[1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7158b94b)
thanks @nacx for the review!
--
You are receiving this because you are subscribed to this thread.
Reply to this
Closed #1032.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1032#event-841950796
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1032#pullrequestreview-6435963
@andreaturli pushed 1 commit.
77ef915 address comments for PR 1032
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1032/files/55c205a2c08959e97ce079f9c2f2d901d57ea524..77ef91522940ee4b60cddea5286e08ba8b1aafbf
andreaturli commented on this pull request.
> + client = view.unwrapApi(AWSEC2Api.class).getVPCApi().get();
+ }
+
+ @Test
+ public void testCreate() {
+ vpc = client.createVpc(null, "10.0.0.0/16", CreateVpcOptions.NONE);
+ assertNotNull(vpc);
+ }
+
+
andreaturli commented on this pull request.
> + VPC() {}
+
+ public static Builder builder() {
+ return new AutoValue_VPC.Builder();
+ }
+
+ @AutoValue.Builder
+ public abstract static class Builder {
+
+ public abstract Builder id(String id);
+ public abstract Builder
nacx commented on this pull request.
> + }
+ }
+ }
+
+ @Nullable
+ public abstract String id();
+ @Nullable
+ public abstract State state();
+ @Nullable
+ public abstract String cidrBlock();
+ @Nullable
+ public abstract String dhcpOptionsId();
+ @Nullable
+
nacx commented on this pull request.
> + VPC() {}
+
+ public static Builder builder() {
+ return new AutoValue_VPC.Builder();
+ }
+
+ @AutoValue.Builder
+ public abstract static class Builder {
+
+ public abstract Builder id(String id);
+ public abstract Builder
andreaturli commented on this pull request.
> + VPC() {}
+
+ public static Builder builder() {
+ return new AutoValue_VPC.Builder();
+ }
+
+ @AutoValue.Builder
+ public abstract static class Builder {
+
+ public abstract Builder id(String id);
+ public abstract Builder
andreaturli commented on this pull request.
> + }
+ }
+ }
+
+ @Nullable
+ public abstract String id();
+ @Nullable
+ public abstract State state();
+ @Nullable
+ public abstract String cidrBlock();
+ @Nullable
+ public abstract String dhcpOptionsId();
+
nacx requested changes on this pull request.
Thanks @andreaturli!
> + VPC() {}
+
+ public static Builder builder() {
+ return new AutoValue_VPC.Builder();
+ }
+
+ @AutoValue.Builder
+ public abstract static class Builder {
+
+ public abstract Builder id(String id);
+
/cc @nacx
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1032
-- Commit Summary --
* [aws-ec2] Add CRUD for VPC
-- File Changes --
M providers/aws-ec2/pom.xml (5)
M
13 matches
Mail list logo
