Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-06-17 Thread Ignasi Barrera
Closed #947. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/947#event-696441596

Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-06-17 Thread Ignasi Barrera
Pushed to master as [bde70457](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bde70457). Thanks everyone! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-05-26 Thread Ignasi Barrera
@marcocast Expect it to be merged this week. I running the live test in my backlog. I'll try to run them today. In any case, if you can run the live tests and share the results in a gist or pastie, that would be great :) There are some that are already failing, but I just want to run the entire

Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-05-26 Thread Marco Castigliego
Hi Guys, any idea on when this patch will be merged? We have the same problem and we would love to have the fix as soon as possible. Thanks!! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-05-02 Thread Andrea Turli
@nacx code looks sensible +1 I will keep this PR in mind if we need to revert/change the implementation later on, ok? Thanks! --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-04-25 Thread Andras Nemes
Thanks for your quick reaction and feedback. I think it the code looks good. //Andras --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/947#issuecomment-214205585

[jclouds/jclouds] JCLOUDS-1105: Do not create the default security group if custom groups are specified (#947)

2016-04-21 Thread Ignasi Barrera
https://issues.apache.org/jira/browse/JCLOUDS-1105 I'm still not sure about the impact of this change. I'd rather play a bit with this and get feedback from users. I haven't been able to test it live yet, so this PR just relies on the unit tests. I plan to do some testing later today but I'd