New PR created (https://github.com/jclouds/jclouds-labs/pull/448) instead of
this one as DatacenterToLocation was removed
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #423.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/423#event-1886777860
> Wow, something went wrong during synchronization with master, a lot of
> commits here that are not supposed to be part of PR. Should I recreate branch
> and PR maybe?
I think it might be the best thing to do @btrishkin, especially since the scope
of the changes has reduced since the original
Wow, something went wrong during synchronization with master, a lot of commits
here that are not supposed to be part of PR. Should I recreate branch and PR
maybe?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@btrishkin pushed 6 commits.
b551857 JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, do not expect 404 when
assets not found
19819cb Firewall Improvements
8773d5c [JCLOUDS-1430] - add more features
25894fb [JCLOUDS-1430] Aliyun ECS
2b60c03 JCLOUDS-1406 - Add default location configuration to
@btrishkin pushed 19 commits.
27a69bb Implement GetOrCreateNetworkDomainThenCreateNodes Strategy.
9f2aee7 Add Azure KeyVault support
77995e2 JCLOUDS-1362: Proper password generation with custom constraints for
each cloud
de54267 Promoted Azure ARM to the main repo
43548d7 Apache jclouds
nacx commented on this pull request.
> +@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public DatacenterToLocation(JustProvider justProvider) {
+ this.justProvider =
trevorflanagan commented on this pull request.
> +import static com.google.inject.internal.util.$Preconditions.checkNotNull;
+
+@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public
trevorflanagan commented on this pull request.
> +@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public DatacenterToLocation(JustProvider justProvider) {
+ this.justProvider =
trevorflanagan commented on this pull request.
> +import static com.google.inject.internal.util.$Preconditions.checkNotNull;
+
+@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public
nacx commented on this pull request.
> +import static com.google.inject.internal.util.$Preconditions.checkNotNull;
+
+@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public
trevorflanagan commented on this pull request.
> +@Singleton
+public class DatacenterToLocation implements Function {
+
+ private final JustProvider justProvider;
+
+ @Inject
+ public DatacenterToLocation(JustProvider justProvider) {
+ this.justProvider =
nacx commented on this pull request.
> +import org.jclouds.domain.LocationScope;
+import org.jclouds.location.suppliers.all.JustProvider;
+
+import javax.inject.Inject;
+import javax.inject.Singleton;
+
+import static com.google.inject.internal.util.$Iterables.getOnlyElement;
+import static
@andreaturli - pushed some fixes here, squashed commits and synced branch with
master
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-353111849
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-348616664
Sure @btrishkin no problem
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-348267012
> you mention https://issues.apache.org/jira/browse/JCLOUDS-72 and
> https://issues.apache.org/jira/browse/JCLOUDS-75 but they are not related to
> dimensiondata, are they?
Sorry @andreaturli , that's our internal tickets numbers. Gonna clear them from
commits and PR along with implementation
17 matches
Mail list logo