Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-05 Thread Boris Trishkin
New PR created (https://github.com/jclouds/jclouds-labs/pull/448) instead of this one as DatacenterToLocation was removed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-05 Thread Boris Trishkin
Closed #423. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#event-1886777860

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-02 Thread Trevor Flanagan
> Wow, something went wrong during synchronization with master, a lot of > commits here that are not supposed to be part of PR. Should I recreate branch > and PR maybe? I think it might be the best thing to do @btrishkin, especially since the scope of the changes has reduced since the original

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-01 Thread Boris Trishkin
Wow, something went wrong during synchronization with master, a lot of commits here that are not supposed to be part of PR. Should I recreate branch and PR maybe? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-01 Thread Boris Trishkin
@btrishkin pushed 6 commits. b551857 JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, do not expect 404 when assets not found 19819cb Firewall Improvements 8773d5c [JCLOUDS-1430] - add more features 25894fb [JCLOUDS-1430] Aliyun ECS 2b60c03 JCLOUDS-1406 - Add default location configuration to

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-01 Thread Boris Trishkin
@btrishkin pushed 19 commits. 27a69bb Implement GetOrCreateNetworkDomainThenCreateNodes Strategy. 9f2aee7 Add Azure KeyVault support 77995e2 JCLOUDS-1362: Proper password generation with custom constraints for each cloud de54267 Promoted Azure ARM to the main repo 43548d7 Apache jclouds

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-04-20 Thread Ignasi Barrera
nacx commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider =

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-04-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-04-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider =

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Ignasi Barrera
nacx commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider =

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Ignasi Barrera
nacx commented on this pull request. > +import org.jclouds.domain.LocationScope; +import org.jclouds.location.suppliers.all.JustProvider; + +import javax.inject.Inject; +import javax.inject.Singleton; + +import static com.google.inject.internal.util.$Iterables.getOnlyElement; +import static

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-20 Thread Boris Trishkin
@andreaturli - pushed some fixes here, squashed commits and synced branch with master -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-353111849

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-01 Thread Trevor Flanagan
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-348616664

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-11-30 Thread Andrea Turli
Sure @btrishkin no problem -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-348267012

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-11-30 Thread Boris Trishkin
> you mention https://issues.apache.org/jira/browse/JCLOUDS-72 and > https://issues.apache.org/jira/browse/JCLOUDS-75 but they are not related to > dimensiondata, are they? Sorry @andreaturli , that's our internal tickets numbers. Gonna clear them from commits and PR along with implementation