Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread Ignasi Barrera
Closed #292. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#event-814592487

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread Ignasi Barrera
Squashed and pushed to master as [5742745e](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5742745e). Thanks @alibazlamit @devcsrj! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclo

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread alibazlamit
alibazlamit commented on this pull request. > + .build() + ); + } +})); + +logger.trace(">> volume connected."); + } catch (Exception ex) { +try { + // delete unconnected volume +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread alibazlamit
@alibazlamit pushed 1 commit. 92cd5b7 Minor change to logger -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/fc4bdc2635bf28d061886e4520b1526f144bb76d..92cd5b7102f3c9146ebae2772fbf38c8bc470157

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread alibazlamit
alibazlamit commented on this pull request. > + .build() + ); + } +})); + +logger.trace(">> volume connected."); + } catch (Exception ex) { +try { + // delete unconnected volume +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread alibazlamit
Updated to the latest just let me know if you need me to squash this, Thanks for the review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-251908880

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-06 Thread Ignasi Barrera
nacx commented on this pull request. Just one minor comment on my side regarding the logger. Once it is amended, I'm happy to finally merge this! Great work @alibazlamit, and apologies for the late review! It is quite difficult to review big PRs like this. > + .build()

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-04 Thread alibazlamit
Reopened #292. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#event-811844281

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-04 Thread alibazlamit
@devcsrj this is the gist including the arbitrary support tests [here ](https://gist.github.com/alibazlamit/0dcbdcf91009c0fc4c54b2878ed6b512), all the nitpicks have been changed and pushed, i hope we will be able to close this one soon as you said its long overdue. Thanks. -- You are receivin

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-04 Thread alibazlamit
Closed #292. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#event-811585869

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-04 Thread alibazlamit
@alibazlamit pushed 1 commit. b1964a4 Arbitrary CPU/RAM support, is now supported. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/9ecf22eec6ee480a81f989007465edbe872c19f7..b1964a4717f2d46aa761087193

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-10-03 Thread Reijhanniel Jearl Campos
Hello! > How close would you say we are to closing this PR I'd say it's long overdue! Seeing your live tests passing from your gist, I'd say the impl addresses the contract required by the `ComputeService`. Just some last nitpicks like that [overriden toString](https://github.com/jclouds/jclo

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-29 Thread Matt Baldwin
@devcsrj *nudge* ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-250526210

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-29 Thread alibazlamit
please rebuild -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-250452726

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-29 Thread alibazlamit
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-250452632

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-28 Thread alibazlamit
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-250140544

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-26 Thread alibazlamit
@devcsrj How close would you say we are to closing this PR? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-249547764

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-26 Thread alibazlamit
@alibazlamit pushed 1 commit. 9ecf22e minor fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/12a9a959ffc4343e260c4123091b9d5de5d972ea..9ecf22eec6ee480a81f989007465edbe872c19f7

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > - properties.setProperty(PROPERTY_ZONE + ".FRA." + ISO3166_CODES, > "DE-HE"); - properties.setProperty(PROPERTY_ZONE + ".LAS." + ISO3166_CODES, "US-NV"); - properties.setProperty(PROPERTY_ZONE + ".LASDEV." + ISO3166_CODES, "US-NV");

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > - properties.setProperty(PROPERTY_ZONE + ".FRA." + ISO3166_CODES, > "DE-HE"); - properties.setProperty(PROPERTY_ZONE + ".LAS." + ISO3166_CODES, "US-NV"); - properties.setProperty(PROPERTY_ZONE + ".LASDEV." + ISO3166_CODES, "US-NV"); -

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > + logger.trace(">> provisioning complete for server. returned > id='%s'", serverId); + + } catch (Exception ex) { + logger.error(ex, ">> failed to provision server. rollbacking.."); + destroyVolumes(volumeIds, dataCenterId);

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > + logger.trace(">> provisioning complete for server. returned > id='%s'", serverId); + + } catch (Exception ex) { + logger.error(ex, ">> failed to provision server. rollbacking.."); + destroyVolumes(volumeIds, dataCenter

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
@alibazlamit pushed 1 commit. 12a9a95 Fixed formatting issue -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/d133573b659d3e5461b23f1ed37aaee75bd852da..12a9a959ffc4343e260c4123091b9d5de5d972ea

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread alibazlamit
alibazlamit commented on this pull request. > + public List call() throws Exception { +logger.trace("<< fetching snapshots"); +List remoteSnapshots = api.snapshotApi().list(new DepthOptions().depth(1)); +logger.trace(">> snapshots feched."); + +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > + logger.trace(">> provisioning complete for server. returned > id='%s'", serverId); + + } catch (Exception ex) { + logger.error(ex, ">> failed to provision server. rollbacking.."); + destroyVolumes(volumeIds, dataCenterId);

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-23 Thread Reijhanniel Jearl Campos
devcsrj commented on this pull request. > + public List call() throws Exception { +logger.trace("<< fetching snapshots"); +List remoteSnapshots = api.snapshotApi().list(new DepthOptions().depth(1)); +logger.trace(">> snapshots feched."); + +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-22 Thread alibazlamit
@alibazlamit pushed 1 commit. d133573 Changed from the review applied -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/c3f28d9abcde2a559db575133ff3486296b28fec..d133573b659d3e5461b23f1ed37aaee75bd852d

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-22 Thread alibazlamit
@devcsrj the gist results [here](https://gist.github.com/alibazlamit/c09d8fc26af8d615bf7f48c710a65254) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-248996349

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-21 Thread alibazlamit
alibazlamit commented on this pull request. > + public List call() throws Exception { +logger.trace("<< fetching snapshots"); +List remoteSnapshots = api.snapshotApi().list(new DepthOptions().depth(1)); +logger.trace(">> snapshots feched."); + +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-20 Thread Reijhanniel Jearl Campos
devcsrj requested changes on this pull request. Also, could you post a copy of your the build results of this module in a gist, or a pastie? P.S.: Take care, and make sure **not** to include your credentials! > + TemplateOptions options = template.getOptions(); + final String loginUse

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-16 Thread alibazlamit
@devcsrj I removed all the formatting changes, i agree lets focus on the compute changes, all the changes in the commit are related to the Compute API . -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclo

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-16 Thread alibazlamit
@alibazlamit pushed 1 commit. 2707084 commit -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/aaeb697c0e5d81667841e3f626a5ae15bb56dda9..27070843b4bd7b1932a423d6a692d0edf4064717

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-16 Thread alibazlamit
@alibazlamit pushed 1 commit. 25ab6d0 minor fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/23c285072ed22918cbdc374429e49ed60cfb5e91..25ab6d02d2f493b2488a32c21625f9f82586f6e9

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread Reijhanniel Jearl Campos
Now that's a **LOT** of formatting noise, even GitHub couldn't render. :( ![](https://cloud.githubusercontent.com/assets/3963900/18572062/51bd9a1c-7bea-11e6-9d97-1a92f8b94a9f.png) Assuming you used the IDE formatting profiles, then the formatting noise is most probably caused by earlier PB-relat

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@devcsrj the support for arbitrary CPU, RAM and Storage was done something was not right with the branch i pushed, now i have updated it to the upstream and squashed all the changes in one commit, one issue i noticed is that its diffing white spaces and eol, i have configure eol to be lf but st

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@alibazlamit pushed 1 commit. 61bee69 pb-compute-api -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/db0fb685f13c614e3ad02f0032fe85ac286ef848..61bee693c3361a42764f3480798f9606bd89ac7c

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@alibazlamit pushed 1 commit. 3e79df9 pb-compute-api -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/b5805fcfebc1593117510dde5134a8482afb8d4c..3e79df9c8d1d358fa8d4b6b11e59b587213d6099

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@alibazlamit pushed 1 commit. d32fb3c fixed license text -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/e108738c448cd76a519e62127b85e23dec454aa4..d32fb3c68b03bb5a28527a9f1402aa584e9601cf

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@alibazlamit pushed 1 commit. e108738 fix build -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/9d66ce5e8f044953082dec3934f2ef35a0c666ea..e108738c448cd76a519e62127b85e23dec454aa4

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@alibazlamit pushed 1 commit. 9d66ce5 reverted deletion of file -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/0e73461ab465e08e012f9a266d8c3fed0d3d72a2..9d66ce5e8f044953082dec3934f2ef35a0c666ea

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
@alibazlamit pushed 2 commits. f597512 pb-compue-api fix 0e73461 Merge branch 'pb-compute-api' of https://github.com/StackPointCloud/jclouds-labs into pb-compute-api -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-lab

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-15 Thread alibazlamit
alibazlamit commented on this pull request. > +import org.jclouds.compute.domain.Hardware; +import org.jclouds.compute.domain.Image; +import org.jclouds.compute.domain.NodeMetadata; +import org.jclouds.compute.domain.Volume; +import org.jclouds.domain.Location; +import org.jclouds.functions.Iden

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-08 Thread Reijhanniel Jearl Campos
> +import org.jclouds.compute.domain.Hardware; > +import org.jclouds.compute.domain.Image; > +import org.jclouds.compute.domain.NodeMetadata; > +import org.jclouds.compute.domain.Volume; > +import org.jclouds.domain.Location; > +import org.jclouds.functions.IdentityFunction; > +import org.jclouds.l

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> + > +@Override > +public DataCenter get() { > +DataCenter dataCenter = api.create(TEST_DC_NAME, "desc,,,", > Location.US_LAS.getId()); > +predicate.apply(dataCenter.id()); > + > +return api.getDataCenter(dataCenter.id()); >

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +@Test(groups = "live", singleThreaded = true, testName = > "ProfitBricksComputeServiceLiveTest") > +public class ProfitBricksComputeServiceLiveTest extends > BaseComputeServiceLiveTest { > + > +//private static final String TEST_DC_NAME = "computeServiceLiveTest" + > System.currentTimeMil

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +import org.jclouds.scriptbuilder.statements.java.InstallJDK; > +import org.jclouds.scriptbuilder.statements.login.AdminAccess; > +import org.jclouds.ssh.SshClient; > +import org.jclouds.ssh.SshException; > +import static org.jclouds.util.Predicates2.retry; > +import static org.testng.Assert.asse

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +destroyVolume(volumeId, dataCenterId); > +} > +} > +// Last paranoid check > +waitDcUntilAvailable.apply(dataCenterId); > + > +LoginCredentials serverCredentials = LoginCredentials.builder() > +.user(loginUser) > +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +} > +// Last paranoid check > +waitDcUntilAvailable.apply(dataCenterId); > + > +LoginCredentials serverCredentials = LoginCredentials.builder() > +.user(loginUser) > +.password(password) > +.build(); > +Strin

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +return api.serverApi().attachVolume( > +Server.Request.attachVolumeBuilder() > +.dataCenterId(dataCenterId) > +.serverId(serverId) > +.volumeId(

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +final String password = "LTbAHNbcMt"; > + > +//final org.jclouds.compute.domain.Image image = template.getImage(); > + > +// provision all volumes based on hardware > +List volumes = hardware.getVolumes(); > +List volumeIds = > Lists.newArrayListWithExpec

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
> +this.provisioningManager = provisioningManager; > +} > + > +private void SetDataCenterId(String id) { > +dataCenterId = id; > +} > + > +@Override > +public NodeAndInitialCredentials > createNodeWithGroupEncodedIntoName(String group, String name, Template > t

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-09-06 Thread Reijhanniel Jearl Campos
Hi @alibazlamit ! The initial comments on this PR haven't been addressed yet; see [Files Changed](https://github.com/jclouds/jclouds-labs/pull/292/files) tab of this PR, most notably style-checks. The diff made it looked like that this PR changed *everything* due to the formatting changes. Whil

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-31 Thread alibazlamit
@alibazlamit pushed 1 commit. 7b4fcf2 Added CpuFamily for servers option and SSD option for volumes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/a3fd971a6328c48f6a6024f88e9c6ab38b6ddc23..7b4fcf216

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-31 Thread alibazlamit
@nacx i have applied the changes above please take a look. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-243755473

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-31 Thread alibazlamit
@alibazlamit pushed 1 commit. a3fd971 Uncommented live compute tests -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/e98ea68598b5cafff0bdc7d54a6b03142b6d31f6..a3fd971a6328c48f6a6024f88e9c6ab38b6ddc23

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-31 Thread alibazlamit
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-243745073

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-31 Thread alibazlamit
@alibazlamit pushed 1 commit. e98ea68 Missing two files added -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/b7314b1685ab64f3135c3e5a7bae190b05ba3e3d..e98ea68598b5cafff0bdc7d54a6b03142b6d31f6

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-31 Thread alibazlamit
@alibazlamit pushed 1 commit. b7314b1 Changed to take locations from metadata configurations -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/9251ab7434bcafb1dcbec5a718acc3c24517c94d..b7314b1685ab64f3

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-30 Thread Ignasi Barrera
> +if (image != null) { > +logger.trace(">> found image [%s].", image.properties().name()); > +return image; > +} > +// try search snapshots > +logger.trace("<< not found from images. searching for snapshot with > id=%s", id); > +Snap

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-30 Thread alibazlamit
> +if (image != null) { > +logger.trace(">> found image [%s].", image.properties().name()); > +return image; > +} > +// try search snapshots > +logger.trace("<< not found from images. searching for snapshot with > id=%s", id); > +Snap

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-29 Thread Ignasi Barrera
> should i be following this apply those changes ? Yes. I just added a comment before having read this one :) I've tried to summarise the intent of the important bits in that commit, but feel free to ask for help/clarification, etc! -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-29 Thread Ignasi Barrera
> +if (image != null) { > +logger.trace(">> found image [%s].", image.properties().name()); > +return image; > +} > +// try search snapshots > +logger.trace("<< not found from images. searching for snapshot with > id=%s", id); > +Snap

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-29 Thread alibazlamit
@nacx should i be following [this ](https://github.com/jclouds/jclouds/commit/7202e0557f620c272feaca3e9a49b6e45a77a791) apply those changes ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jcloud

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-29 Thread alibazlamit
> +if (image != null) { > +logger.trace(">> found image [%s].", image.properties().name()); > +return image; > +} > +// try search snapshots > +logger.trace("<< not found from images. searching for snapshot with > id=%s", id); > +Snap

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +return match; > +} > +}).orNull(); > +} > +if (lan == null) { > +logger.warn("Could not find an existing lan Creating one"); > +lan = api.lanApi().create(Lan.Request.creatingBuilder() > +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> @@ -38,6 +38,7 @@ > > > 2.0.0-SNAPSHOT > + true This needs to be removed --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/9251ab7434bcafb1dcbec5a718acc3c

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +.volumeId(bootVolume.id()) > +.build()); > + > +waitServerUntilAvailable.apply(ServerRef.create(dataCenterId, > serverId)); > +waitDcUntilAvailable.apply(dataCenterId); > + > +//fetch an existing lan and creat if non was found > +L

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
Apologies for the delay @alibazlamit @jasminSPC, I've been on vacation. @devcsrj Could you help reviewing this? I can mostly review syntax, etc, but you have a better knowledge of how the provider works for a proper functional review. --- You are receiving this because you are subscribed to thi

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> @@ -108,6 +121,13 @@ > logback-classic > test > > + > +org.apache.jclouds.driver > +jclouds-log4j > +2.0.0-SNAPSHOT Use `${jclouds.version}` --- You are receiving this because you are subscribed to this thread. Repl

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> + > +import org.jclouds.collect.Memoized; > +import org.jclouds.compute.domain.Hardware; > +import org.jclouds.compute.domain.HardwareBuilder; > +import org.jclouds.compute.domain.NodeMetadata; > +import org.jclouds.compute.domain.NodeMetadataBuilder; > +import org.jclouds.compute.domain.Operatin

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +return api.serverApi().attachVolume( > +Server.Request.attachVolumeBuilder() > +.dataCenterId(dataCenterId) > +.serverId(serverId) > +.volumeId(

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.apache.jclouds.profitbricks.rest.compute.function; > + > +import com.google.common.base

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +import org.jclouds.domain.Location; > +import org.jclouds.functions.IdentityFunction; > +import org.jclouds.lifecycle.Closer; > +import org.jclouds.location.suppliers.ImplicitLocationSupplier; > +import org.jclouds.location.suppliers.implicit.OnlyLocationOrFirstZone; > +import static org.jclouds

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> + > + > bind(ImplicitLocationSupplier.class).to(OnlyLocationOrFirstZone.class).in(Singleton.class); > + > +bind(new TypeLiteral Hardware, Provisionable, DataCenter>>() { > +}).to(ProfitBricksComputeServiceAdapter.class); > + > +bind(new > TypeLiteral Location>>()

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> @@ -36,6 +36,7 @@ > > FIXME > > FIXME > > 1.3 > +true This needs to be removed --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/92

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +import org.testng.annotations.Test; > + > +@Test(groups = "live", testName = "ProfitBricksTemplateBuilderLiveTest") > +public class ProfitBricksTemplateBuilderLiveTest extends > BaseTemplateBuilderLiveTest { > + > +private static final String TEST_DC_NAME = "templateBuilderLiveTest-" + > S

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +if (image != null) { > +logger.trace(">> found image [%s].", image.properties().name()); > +return image; > +} > +// try search snapshots > +logger.trace("<< not found from images. searching for snapshot with > id=%s", id); > +Snap

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +destroyVolume(volumeId, dataCenterId); > +} > +} > +waitDcUntilAvailable.apply(dataCenterId); > +waitServerUntilAvailable.apply(ServerRef.create(dataCenterId, > serverId)); > + > +LoginCredentials serverCredentials = LoginCredentials.b

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.apache.jclouds.

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> +@Override > +protected void configure() { > +super.configure(); > + > +install(new > LocationsFromComputeServiceAdapterModule Provisionable, DataCenter>() { > +}); > + > +install(new > FactoryModuleBuilder().build(ProvisioningJob.Factory.class)); > + > +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-08-03 Thread Ignasi Barrera
> + > +//add a NIC to the server > +waitDcUntilAvailable.apply(dataCenterId); > +waitServerUntilAvailable.apply(ServerRef.create(dataCenterId, > serverId)); > +int lanId = DEFAULT_LAN_ID; > +if (options.getNetworks() != null) { > +try { > +

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-31 Thread jasminSPC
@nacx what is the status of this PR? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-236443618

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-22 Thread alibazlamit
@nacx All tests passed except for testWeCanCancelTasks with the same error mentioned above --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-234660679

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-22 Thread alibazlamit
@alibazlamit pushed 6 commits. 68a7157 Added the creation of Lan if does not exist 7930af3 Removed Dev code 8785a5d Added TemplateBuilderLIveTest Implementation bb561f4 Ready for final review 6ac2aee Merge branch 'master' of https://github.com/jclouds/jclouds-labs into pb-compute-api 9251ab7

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-13 Thread Ignasi Barrera
> but anyways i tried to look for that branch, should build the same master > branch or switch to another one? You can build the branch on my fork. But anyway, I plan to merge the PR tomorrow. I just need some time to run some live tests with that change (the ProfitBricks SOAP ones) and verify

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-12 Thread alibazlamit
@nacx its not preventing other tests from running, but anyways i tried to look for that branch, should build the same master branch or switch to another one? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-11 Thread Ignasi Barrera
@alibazlamit I've just opened https://github.com/jclouds/jclouds/pull/979 to isolate the task cancellation in a specific test, so it does not prevent other tests from running. Could you try building that branch and run the live tests again with that change, to se the *real* state of them? --- Y

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-07 Thread jasminSPC
@nacx is the issue above blocking this PR? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-231145295

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-07 Thread alibazlamit
@nacx All compute tests pass now except for the one above,could you please do a general review and check the state of this PR and give me back your feedback. Thanks --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://git

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-07 Thread alibazlamit
@alibazlamit pushed 1 commit. bb561f4 Ready for final review --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/8785a5d0f20860cef5597f84054f3e3802ee233d..bb561f466097bdb7b189241896454616fa04eb69

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-05 Thread Reijhanniel Jearl Campos
Hmm. Now this kinda sucks. I was under the impression before that this exception [only occurred](https://github.com/jclouds/jclouds-labs/pull/224#issuecomment-172719660) for the SOAP version of the API (that maybe the REST API did a few more stuff in the PB backend to prevent this). --- You a

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-04 Thread Ignasi Barrera
> I was able to debug the test and it fails when reaching this line Ok, then you're hitting [JCLOUDS-1058](https://issues.apache.org/jira/browse/JCLOUDS-1058). I'll add a change to the base test class to isolate the "wait" thing in a test so it does not block the other ones. This will help havi

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-04 Thread alibazlamit
@alibazlamit pushed 1 commit. 8785a5d Added TemplateBuilderLIveTest Implementation --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/7930af3e52bdf19e29c29dbc045231a91cfe3d4f..8785a5d0f20860cef5597f8405

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-04 Thread alibazlamit
Full Stack trace ``` (foo:rsa[fingerprint(34:3e:d9:0d:4f:c2:78:ed:e2:60:7e:6f:1c:42:c3:88),sha1(65:81:a8:37:1c:f5:c6:70:b0:d2:d5:60:05:eb:8b:ef:53:92:d9:57)]@158.222.103.136:22) (foo:rsa[fingerprint(34:3e:d9:0d:4f:c2:78:ed:e2:60:7e:6f:1c:42:c3:88),sha1(65:81:a8:37:1c:f5:c6:70:b0:d2:d5:60:05:eb:8

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-04 Thread alibazlamit
` loginUser=foo, ssh=445447871` its passing the credentials as you see in the log meesage. I was able to debug the test and it fails when reaching this line https://github.com/jclouds/jclouds/blob/master/compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java#L305 --

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-03 Thread Ignasi Barrera
This might be because the create node method in the adapter or the function that transforms a server into a jclouds node don't properly populate the node credentials. jclouds uses those to access the node. Could you have a look at that? --- You are receiving this because you are subscribed to t

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-03 Thread alibazlamit
Changing to the ubuntu 15 made it work, all the test pass now except for one `testAScriptExecutionAfterBootWithBasicTemplate `with this error message, it seems like it cannot login with the user foo, i have tried to add a wait of two minutes after server creation but no luck any thoughts? ``` (

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-01 Thread alibazlamit
@alibazlamit pushed 1 commit. 7930af3 Removed Dev code --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/68a7157f67bb281aaeb06a4c2259649edad65782..7930af3e52bdf19e29c29dbc045231a91cfe3d4f

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-07-01 Thread alibazlamit
@alibazlamit pushed 1 commit. 68a7157 Added the creation of Lan if does not exist --- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292/files/1533bf29a80f2c87834f501abd91ea399debd688..68a7157f67bb281aaeb06a4c225

Re: [jclouds/jclouds-labs] Pb compute api (#292)

2016-06-30 Thread alibazlamit
Ticket here https://issues.apache.org/jira/browse/JCLOUDS-1133 --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/292#issuecomment-229722276

  1   2   >