> I will do it in a // PR (this one merged) after feedback on my remarks.
Thanks for taking a look! I should add that I think most of my comments are
minor, and it's also fine to leave things as they are unless we feel there's
really a good reason for a follow-up PR.
And thanks for helping
@demobox : Thanks for the review. I will do it in a // PR (this one merged)
after feedback on my remarks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
axel3rd commented on this pull request.
> +{% highlight java %}
+final Properties overrides = new Properties();
+overrides.put(KeystoneProperties.KEYSTONE_VERSION, "2");
+overrides.put(KeystoneProperties.TENANT_NAME, "myTenant");
+
+ContextBuilder.newBuilder("openstack-nova")
+
axel3rd commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
demobox commented on this pull request.
> @@ -146,6 +361,7 @@ public class JCloudsNova implements Closeable {
String identity = "demo:demo"; // tenantName:userName
String credential = "devstack";
+// Please refer to 'Keystone v2-v3 authentication' chapter for
demobox commented on this pull request.
> +{% highlight java %}
+final Properties overrides = new Properties();
+overrides.put(KeystoneProperties.KEYSTONE_VERSION, "2");
+overrides.put(KeystoneProperties.TENANT_NAME, "myTenant");
+
+ContextBuilder.newBuilder("openstack-nova")
+
demobox commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
demobox commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
demobox commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
Often these tiny PRs get more review comments and change requests than thousand
lines ones! :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-388175880
So very valuable *2 characters* PR ^^ : #215
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-388060585
We can change that. As long as the feature does not break backward compat, I
see no problem in adding it in the next bugfix release. It will help adoption
and facilitate early testing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
@nacx : As a "new feature", I didn't thought it was could be integrated in
v2.1.x, I will be attentive to the roadmap because this PR doc is perhaps not
true: : [Keystone v2-v3
authentication](https://jclouds.apache.org/guides/openstack/#keystone) (*v3:
Project-scoped*)
Closed #214.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#event-1619360327
Changes merged and published to the website. Thanks @axel3rd!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387996647
> Yes ... and perhaps some minor change on properties name in progress ...
Done, 1 line changed:
overrides.put(KeystoneProperties.PROJECT_DOMAIN_NAME, "default"); // Since
jclouds v2.2.0 (see PROJECT_DOMAIN_ID as complement)
Linked with
Go to
http://ad99be29f1570e3a80bb-ec8c9f9fa769d9cd6f2ad277a7469fe8.r48.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
thanks @axel3rd
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387117770
andreaturli approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#pullrequestreview-118055261
> Since you reference a new keystone property I'd hold this and merge once the
> changes in Keystone are merged and the new property exists.
Yes ... and perhaps some minor change on properties name in progress ...
--
You are receiving this because you are subscribed to this thread.
Reply to
nacx approved this pull request.
Thanks! LGTM.
Since you reference a new keystone property I'd hold this and merge once the
changes in Keystone are merged and the new property exists.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
> Perhaps a consensus could be to add a comment before ContextBuilder like
> [...]:
> One minor comment, but it would help readability if you format the generated
> json auth example.
Done (without new-line-comma for json, to reduce lines number). Last proposal:
[Keystone v2-v3 authentication
Go to
http://eb3572d47d95412306ae-9ba5d3580b14e830c75c09652bfd2f59.r53.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Go to
http://ae4404efef77109c76ca-bf5e3651b7ed971bf54720901bab17d5.r49.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
One minor comment, but it would help readability if you format the generated
json auth example.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387061588
nacx commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
> pointing maybe the reader to the authentication section above instead of using
I have hesitate to do that ... but the current snippet explicits how to
retrieve an API (nova, swift, ...) even if v2 is deprecated (v3 needs more
code).
So keystone considerations was writted before (hoping that
Actually @axel3rd I think we should somehow edit `List Servers` and `Swift: Use
Containers` paragraphs as well pointing maybe the reader to the authentication
section above instead of using
```
novaApi = ContextBuilder.newBuilder(provider)
@andreaturli : Thanks for grammar fix & suggestions. Fixed in [Keystone v2-v3
authentication](https://393f4caa8037a748294f-756fd4e7d22e69a6f0ff4346cb78ae2b.ssl.cf5.rackcdn.com/guides/openstack/#keystone).
Except about `KeystoneProperties.KEYSTONE_VERSION` ... not sure about that.
--
You are
andreaturli commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
Go to
http://393f4caa8037a748294f-756fd4e7d22e69a6f0ff4346cb78ae2b.r35.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
axel3rd commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
andreaturli requested changes on this pull request.
thanks @axel3rd it is super useful!
I've left some comments mainly on the snippets: please address them and edit
the document accordingly, i.e. if you replace `Some.class` with
`NovaApi.class` make sure you do it all over the places.
Thanks
Some tries about code & list typo, the last looks fine: Openstack [Keystone
v2-v3
authentication](https://d6762342ecf65bd47950-3e336ecb7f68d8dda5e5d435de17b0ef.ssl.cf5.rackcdn.com/guides/openstack/#keystone)
--
You are receiving this because you are subscribed to this thread.
Reply to this
Go to
http://d6762342ecf65bd47950-3e336ecb7f68d8dda5e5d435de17b0ef.r3.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Go to
http://4c17ddefb1e1845a6081-9bb6552a57750bbb30de030b38a1ebcc.r36.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Go to
http://e8a2320cb8ee7328bc9a-98112aaa434232edc359e0c94cafc2fa.r90.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Go to
http://44ce6b87f08c84c4a336-587a4214cfc62e403204a0b0eced474e.r98.cf5.rackcdn.com/
to review your changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
See [JCLOUDS-1414](https://issues.apache.org/jira/browse/JCLOUDS-1414),
documentation about Openstack keystone v2/v3 usage
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/214
-- Commit Summary --
* #JCLOUDS-1414: Documentation
39 matches
Mail list logo
