Thanks a lot for the update and the PR @trainman419! I'll close this as a
duplicate and we'll move forward with #303.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-37375486
Closed #290.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290
I think the intent here was to hit the keystone v2 OS-KSADM extensions, so this
probably duplicates #303
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-37334197
@pnavarro has a point. I'm not seeing POST /users and DELETE /users/{userId}
methods in the [Identity Service admin API
v2.0](http://api.openstack.org/api-ref-identity.html#identity-admin-v2)
However, I do see POST /users and DELETE /users/{userId} methods in the
[Identity Service API
v3](http
Any update on this? (@everett-toews?) It would be great to know the better way
to proceed with these two PRs.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-36489381
> since these actions are just exposed by Keystone API through an extension
Ah, like that. Thanks for explaining. Thoughts on that, @everett-toews?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-36014198
@demobox I think the implementation is incorrect, since these actions are just
exposed by Keystone API trough an extension, so depending on the deployments It
may be disabled. That's why It should not be implemented in the UserApi, that
matches the default actions in the default API, but in a AP
> I'm not OK with this PR. The POST and DELETE operations are included in
> OS-KASDM extension:
@pnavarro: is the problem simply the duplication of functionality, or do you
think the implementation is incorrect?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/
I'm not OK with this PR. The POST and DELETE operations are included in
OS-KASDM extension:
https://github.com/openstack/keystone/blob/master/keystone/contrib/admin_crud/core.py#L84.
This is way it's been addressed in the OS-KSADM PR:
https://github.com/jclouds/jclouds/pull/303
---
Reply to
> @demobox Is this good to go for you?
There are a couple of comments (e.g. [this
one](https://github.com/jclouds/jclouds/pull/290/files#r9715343)) about whether
the "silent failure" logic in this PR is what we want.
If you're OK with that, then yes - good to go for me, too. The remaining
comm
The live test runs for me now.
@demobox Is this good to go for you?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35442523
[jclouds-java-7-pull-requests
#1079](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1079/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35422072
[jclouds-pull-requests
#608](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/608/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35421995
[jclouds » jclouds
#851](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/851/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment
Reopened #290.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290
Closed #290.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290
All you have to do is close and reopen.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35414823
It looks like those test failures were on 7f5cf17 ; is there any way to re-kick
the build farm to build the latest commit ( d3eb72e )?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35414700
> jclouds » jclouds #845 UNSTABLE
"Real" [test
failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds.api$openstack-keystone/845/testReport/junit/org.jclouds.openstack.keystone.v2_0.features/UserApiExpectTest/testCreateUser/)
here.
---
Reply to this email directly
[jclouds » jclouds
#845](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/845/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclou
Thanks! I'll give that a try from here and see if I can get the live tests
working.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35120286
> @@ -81,4 +81,21 @@
> */
> Set listRolesOfUserOnTenant(String userId, String
> tenantId);
>
> + /**
> +* Creates a new user in keystone.
> +*
> +* @param userName the name for the new user
> +* @param userEmail the email address for the new user
> +* @param enabl
@trainman419 The live test is failing for me. It's running against Keystone v2
API in Havana. I'm running it with the following command in the
`apis/openstack-keystone` dir.
mvn clean test -Plive
-Dtest.openstack-keystone.endpoint=http://162.242.219.27:5000/v2.0/
-Dtest.openstack-keystone.
[jclouds-java-7-pull-requests
#1072](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1072/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35023639
[jclouds-pull-requests
#601](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/601/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-35023554
[jclouds » jclouds
#842](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/842/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment
> @@ -86,4 +88,37 @@ public void testUsersByName() {
>}
>
> }
> +
> + public void testAddDeleteUser() {
> + UserApi userApi = api.getUserApi().get();
> + Set initialUsers = userApi.list().concat().toSet();
> +
> + // generate credentials for a random new use
> @@ -86,4 +88,37 @@ public void testUsersByName() {
>}
>
> }
> +
> + public void testAddDeleteUser() {
> We should be able to figure out which operation failed by looking at which
> assert failed.
Sure, but if you're looking at test results in Jenkins or whatever, it's nice
> @@ -86,4 +88,37 @@ public void testUsersByName() {
>}
>
> }
> +
> + public void testAddDeleteUser() {
I wrote this as one test because the test for the delete operation requires
that the add operation succeed, and that we know the ID of the user that was
created.
We should
Fixed javadoc style comments.
I'm not particularly tied to the fallback behavior on user deletion; I'm open
to other options. Once we figure out what behavior we want, I'll update the
javadoc so that it better describes the behavior.
---
Reply to this email directly or view it on GitHub:
https:
> +
> + User newUser = userApi.add(randUser, email, true, password);
> +
> + // validate that our new user exists
> + Set newUsers = userApi.list().concat().toSet();
> + assertTrue(newUsers.contains(newUser));
> +
> + // validate that we can delete our use
> @@ -86,4 +88,37 @@ public void testUsersByName() {
>}
>
> }
> +
> + public void testAddDeleteUser() {
Split this out into two tests, one depending on the other? Like this, if the
test fails, we don't know which of the operations broke...
---
Reply to this email directly or v
> + @Path("/users")
> + @RequestFilters(AuthenticateRequest.class)
> + @Fallback(NullOnNotFoundOr404.class)
> + ListenableFuture add(@PayloadParam("username") String
> userName,
> +@PayloadParam("email") String
> userEmail,
> +
> @@ -81,4 +81,21 @@
> */
> Set listRolesOfUserOnTenant(String userId, String
> tenantId);
>
> + /**
> +* Create a new user in keystone.
"Creates" (per Javadoc style guide - descriptive over imperative)
---
Reply to this email directly or view it on GitHub:
https://github.com/jc
> @@ -81,4 +81,21 @@
> */
> Set listRolesOfUserOnTenant(String userId, String
> tenantId);
>
> + /**
> +* Create a new user in keystone.
> +*
> +* @param userName the name for the new user
> +* @param userEmail the email address for the new user
> +* @param enable
> @@ -123,4 +137,29 @@
> @Fallback(EmptySetOnNotFoundOr404.class)
> ListenableFuture>
> listRolesOfUserOnTenant(@PathParam("userId") String userId,
> @PathParam("tenantId") String tenantId);
> +
> + /**
> +* @see UserApi#add(String, String, Boolean, String)
> +*/
[jclouds » jclouds
#841](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/841/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment
[jclouds-pull-requests
#600](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/600/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34943805
[jclouds-java-7-pull-requests
#1071](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1071/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34943803
[jclouds » jclouds
#840](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/840/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment
[jclouds-java-7-pull-requests
#1070](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1070/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34942385
[jclouds-pull-requests
#599](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/599/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34942022
[jclouds-java-7-pull-requests
#1069](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1069/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34941403
[jclouds-pull-requests
#598](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/598/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34941409
Added live tests.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34941215
[jclouds » jclouds
#839](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/839/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment
Addressed javadoc issue. I reformatted the existing comments as well to keep
things consistent.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/290#issuecomment-34939055
The code looks good but we really do need at least a couple of live tests
before we can accept this. When the live tests are ready I'll test them against
[DevStack with
Havana](http://blog.phymata.com/2013/12/18/devstack-havana-on-the-rackspace-cloud/).
---
Reply to this email directly or view
> @@ -123,4 +127,25 @@
> @Fallback(EmptySetOnNotFoundOr404.class)
> ListenableFuture>
> listRolesOfUserOnTenant(@PathParam("userId") String userId,
> @PathParam("tenantId") String tenantId);
> +
> + /** @see UserApi#add(String, String, Boolean, String) */
Needs proper Ja
> @@ -123,4 +127,25 @@
> @Fallback(EmptySetOnNotFoundOr404.class)
> ListenableFuture>
> listRolesOfUserOnTenant(@PathParam("userId") String userId,
> @PathParam("tenantId") String tenantId);
> +
> + /** @see UserApi#add(String, String, Boolean, String) */
> + @Named("us
Add support for the keystone user add and delete API.
I have NOT yet tested this against a live environment.
You can merge this Pull Request by running:
git pull https://github.com/trainman419/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/j
51 matches
Mail list logo
