@jdaggett Sounds good and consistent with `ComputeServiceConstants`.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-49949896
@everett-toews I would remove `BlobStoreProperties` in commit 11d351c and put
the constants in `BlobStoreConstants`. @andrewgaul Would you agree with that?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-49920964
> jclouds-pull-requests #925 FAILURE
> jclouds » jclouds #1273 FAILURE
Compilation failures:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project swift: Compilation failure: Compilation failure:
[ERROR]
/scratch/jenkins/works
[jclouds » jclouds
#1273](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1273/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclo
[jclouds-pull-requests
#925](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/925/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-46904789
[jclouds-java-7-pull-requests
#1396](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1396/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-46904753
I'd rather not commit this to a place where we know isn't its permanent home.
That just means a backwards incompatible change down the road. At the very
least we need to get the names and place right.
I honestly don't know what a better word for magnitude is in this case. I'll
take whatever sug
:+1: improves the state of the world. I agree with the suggestions of other
reviewers that magnitude is a funny word, that `BlobStoreConstants` might be
more appropriate in a subsequent commit, and that we could do a better job in
terms of what retries mean for MPU, but all these scope outside
@jdaggett @andrewgaul @shri Is `BlobStoreConstants` really the right place for
these?
I see over on the compute side that it's split into `ComputeServiceConstants`
and `ComputeServiceProperties`. If this was to be consistent with that, I would
need to create a `BlobStoreProperties` interface fo
[jclouds » jclouds
#1212](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1212/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomme
[jclouds-java-7-pull-requests
#1349](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1349/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-45793082
[jclouds-pull-requests
#878](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/878/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-45793039
@demobox has a point about some possible confusion in the javadocs. More info
would be good.
Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-45790324
@everett-toews Awesome! I have been meaning on refactoring these into the
`BlobStoreContants` class. I believe that they would be more appropriate there,
rather than in the core `Constants` class. cc @andrewgaul @shri
---
Reply to this email directly or view it on GitHub:
https://github.com/jclo
Pending PR builders, this change looks +1 - good to go for me. Just curious
about the meaning of some of those properties, actually.
Thanks, @everett-toews!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/402#issuecomment-45788690
> +* The magnitude of object parts being uploaded in parallel.
> +*/
> + public static final String PROPERTY_MPU_PARTS_MAGNITUDE =
> "jclouds.mpu.parts.magnitude";
> +
> + /**
> +* The number of object parts being uploaded in parallel.
> +*/
> + public static final String PRO
> @@ -303,6 +303,31 @@
> */
> public static final String PROPERTY_MAX_PARALLEL_DELETES =
> "jclouds.max-parallel-deletes";
>
> + /**
> +* The size (in bytes) of object parts being uploaded in parallel.
> +*/
> + public static final String PROPERTY_MPU_PARTS_SIZE =
> "jcloud
You can merge this Pull Request by running:
git pull https://github.com/rackspace/jclouds factored-out-constants
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/402
-- Commit Summary --
* Factored out some constants
-- File Changes --
18 matches
Mail list logo
