Re: [jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-18 Thread Ignasi Barrera
Live tests are passing again. Pushed to master as [04b6]( http://git-wip-us.apache.org/repos/asf/jclouds/commit/04b6). Thanks @danbroudy! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/854#issuecomment-141379905

Re: [jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-18 Thread Ignasi Barrera
Closed #854. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/854#event-412982094

Re: [jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-17 Thread danbroudy
LGTM pending passing tests. Thanks for doing this! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/854#issuecomment-141230817

Re: [jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-16 Thread Ignasi Barrera
Just updated the PR to change the test instead of using dummy volumes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/854#issuecomment-140912431

Re: [jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-15 Thread Ignasi Barrera
In most providers the volumes are just read only values to inform the user of what will be created when provisioning the VMs. In AWS-EC2 you have very detailed information on the type of the disks, etc, and users may want to pick a hardware profile or another based on that information. I agree

Re: [jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-14 Thread danbroudy
I would lean towards overriding the test and removing the disks size assertion. It seems potentially confusing to me that we would add a dummy volume. What are hardware profile volumes used for in practice? Why does a Jclouds user need these values? --- Reply to this email directly or view it o

[jclouds] Take into account that hardware profiles may not have scratch disks (#854)

2015-09-08 Thread Ignasi Barrera
The `GoogleComputeEngineServiceLiveTest#testListSizes` live test has started failing recently. I've observed that the API is no longer returning the [scratchDisks](https://github.com/jclouds/jclouds/blob/master/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/M