@andreaturli Thanks
@nacx Let me know when the image changes are ready, and I'll update the
provider to use the cache properly
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-59559351
@nacx @demobox @andreaturli Suggest ready to merge?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-59496509
@demobox The test change required was to modify a JSON file to use an array of
Strings for Entrypoint instead of null. This would have failed the test by
crashing the JSON parser, but it now passes. I think documenting the DTOs is
not strictly necessary, they're not created by users, rather fill
> public static class Builder {
>
> - /**
> - * @see DockerTemplateOptions#volumes(java.util.Map)
> - */
> - public static DockerTemplateOptions volumes(Map
> volumes) {
> - DockerTemplateOptions options = new DockerTemplateOptions();
> - return DockerTe
>@grkvlt Do you think it makes sense to wait for the image cache @nacx talks
>about?
I think there is no need to block this PR until the image cache is refactored.
The refactor will mitigate the side-effects that appear now when listing
images, but I don't see these side-effects as blockers for
[jclouds » jclouds-labs
#1679](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1679/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
@grkvlt Do you think it makes sense to wait for the image cache @nacx talks
about? If not, do we still need some tests here before merging?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58770177
> @@ -194,7 +194,7 @@ public String getWorkingDir() {
>return workingDir;
> }
>
> - public String getEntrypoint() {
> + public List getEntrypoint() {
Do we have/need some documentation to describe what is expected here? Reading
"entrypoint" but seeing a _list_ being required, it
> public static class Builder {
>
> - /**
> - * @see DockerTemplateOptions#volumes(java.util.Map)
> - */
> - public static DockerTemplateOptions volumes(Map
> volumes) {
> - DockerTemplateOptions options = new DockerTemplateOptions();
> - return DockerTe
[jclouds-labs-pull-requests
#313](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/313/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58769976
@nacx The image cache change sounds useful, and would definitely help in the
Docker situation with frequent commits happening. Look forward to it...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58769884
I updated one of the test JSON files with some `Entrypoint` data to test the
parser for `Config` objects, so this ought to be mergeable now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58769862
[jclouds » jclouds-labs
#1675](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1675/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
[jclouds-labs-pull-requests
#309](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/309/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58757278
[jclouds » jclouds-labs
#1674](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1674/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/
[jclouds-labs-pull-requests
#308](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/308/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58754717
Thanks for the explanation, @grkvlt! Glad to see we're able to help weave out...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58751426
Regarding the image ID thing, it is caused by the current image cache. I
started working on
[JCLOUDS-512](https://issues.apache.org/jira/browse/JCLOUDS-512) to fix that,
but it is a bit complex as there are providers, such as AWS, that cache images
differently. I can't give an ETA, but I hope w
Hi @demobox
These are just things I discovered while writing an integration with
github.com/zettio/weave which auto-creates containers that have no SSH daemon,
hence no inbound port 22, and jclouds still wants to enumerate them.
The image ID issue happens because jclouds is cacheing image data
This is labs so I'm +1 with merging this straight away, but just wanted to ask:
do we need to add/update any tests for this? Also, could you just explain the
background a bit, @grkvlt? Are these bugfixes or changes to accommodate new
features in Docker or..?
Thanks!
---
Reply to this email dir
[jclouds » jclouds-labs
#1671](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1671/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
[jclouds-labs-pull-requests
#307](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/307/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58711613
> @@ -121,6 +125,6 @@ protected static int getLoginPort(Container container) {
> }
> }
>}
> - throw new IllegalStateException("Cannot determine the login port for "
> + container.getId());
> + return -1;
yeah i figured, hence the pre-emptive +1
doc sounds
> @@ -121,6 +125,6 @@ protected static int getLoginPort(Container container) {
> }
> }
>}
> - throw new IllegalStateException("Cannot determine the login port for "
> + container.getId());
> + return -1;
Nope, it looks like the ripple effect of changes is
> @@ -121,6 +125,6 @@ protected static int getLoginPort(Container container) {
> }
> }
>}
> - throw new IllegalStateException("Cannot determine the login port for "
> + container.getId());
> + return -1;
Good point, will fix.
---
Reply to this email direc
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58700075
> @@ -121,6 +125,6 @@ protected static int getLoginPort(Container container) {
> }
> }
>}
> - throw new IllegalStateException("Cannot determine the login port for "
> + container.getId());
> + return -1;
Hmm Optional is probably better than -1 these days.
[jclouds » jclouds-labs
#1670](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1670/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
[jclouds » jclouds-labs
#1669](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1669/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
[jclouds-labs-pull-requests
#306](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/306/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58694955
[jclouds-labs-pull-requests
#305](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/305/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/89#issuecomment-58693688
Fix some minor issues in the Docker driver
You can merge this Pull Request by running:
git pull https://github.com/grkvlt/jclouds-labs grkvlt/docker
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/89
-- Commit Summary --
* Entrypoint sh
32 matches
Mail list logo
