andreaturli commented on this pull request.
> +Apache jclouds 2.1.0 features include:
+
+* Modernize Openstack support
+* Graduate Microsoft Azure Resource Manager to core
+* Better support for AWS EC2 in terms of network capabilities and regions
+* Graduate Google Cloud Storage (GCS) and Backbl
@andreaturli pushed 1 commit.
78d5c13 address comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210/files/7f1c12de8d0feee6adcf95a1ffb5f07c04b10190..78d5c13a33f27447824047b265aaeaadea92cf48
@nacx are you happy with the changes?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367365343
thanks @gaul I've updated the release notes with your suggestions
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367394512
are we happy with that?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367397179
@andreaturli pushed 1 commit.
a7fa3bc address demobox comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210/files/33b9bac3ef73d44e6cb4f977706c7920fff3aa07..a7fa3bc8b9ec4d2dc9db4b825486554303f4d069
andreaturli commented on this pull request.
> @@ -6,6 +6,7 @@ permalink: /releasenotes/
The Release Notes and Javadocs for every major release of Apache jclouds are
listed chronologically below.
+* [2.1.0](/releasenotes/2.1.0) | [Javadoc](/reference/javadoc/2.1.x/)
yes @demobox I think I'
thanks @demobox for your review!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367948008
andreaturli commented on this pull request.
> @@ -6,6 +6,7 @@ permalink: /releasenotes/
The Release Notes and Javadocs for every major release of Apache jclouds are
listed chronologically below.
+* [2.1.0](/releasenotes/2.1.0) | [Javadoc](/reference/javadoc/2.1.x/)
@demobox I think you ar
@andreaturli pushed 1 commit.
d8099f0 fix deploy-javadoc
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210/files/a7fa3bc8b9ec4d2dc9db4b825486554303f4d069..d8099f098b651fcb279095176369ec5152254c91
is it ok to merge @nacx ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#issuecomment-368341886
andreaturli commented on this pull request.
> +title: Release Notes for Version 2.1.0
+date: 2018-02-21 12:00:00
+release_notes: true
+permalink: /releasenotes/2.1.0/
+---
+
+1. [Introduction](#intro)
+1. [Release Highlights](#highlights)
+1. [Compute Improvements](#computeimprovements)
+1. [Blo
andreaturli commented on this pull request.
> +
+## Credits
+
+jclouds would like to thank everyone who contributed time and effort in order
to make this release happen:
+
+* [Jim Micheal Spring](https://twitter.com/jmspring) for his contributions to
the Microsoft Azure ARM provider and the OA
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-site/commit/314f3b56)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#issuecomment-368419667
Closed #210.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/210#event-1491432530
andreaturli commented on this pull request.
> +title: Release Notes for Version 2.1.0
+date: 2018-02-21 12:00:00
+release_notes: true
+permalink: /releasenotes/2.1.0/
+---
+
+1. [Introduction](#intro)
+1. [Release Highlights](#highlights)
+1. [Compute Improvements](#computeimprovements)
+1. [Blo
Closed #88.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#event-1527961463
closing as https://github.com/jclouds/jclouds-examples/pull/92 supercedes it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-374141186
based on discussion at https://github.com/jclouds/jclouds-examples/pull/88
---
I think next step would be to get rid of `jclouds.version` as you may end up
having multiple jclouds versions on `jclouds-examples` classpath
Also, I think we should make a decision on the following modules:
```
@andreaturli pushed 1 commit.
2fb50fc fix README.md
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/92/files/7576e3a4065c5574688dd9481b2b6fe4d93f6690..2fb50fc2ae34bf417ffd62bceb3d7e75e93063a5
@andreaturli pushed 1 commit.
bd8a7a5 clean up pom.xml
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/92/files/2fb50fc2ae34bf417ffd62bceb3d7e75e93063a5..bd8a7a58a854436f33acb42395cf7a1ab6b9227e
Thanks @alibazlamit, we'll have asap. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-374544641
andreaturli requested changes on this pull request.
great start @alibazlamit! I've only some comments, feel free to ask for
clarification!
As I don't have access to oneandone it would be nice if you could attach the
results of live tests before merging this. Thanks
> @@ -65,6 +66,7 @@
priv
thanks guys, merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/92#issuecomment-375344523
Closed #92.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/92#event-1535860638
merged at
[master](https://git1-us-west.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=0168a3998effd336f610dd8261ae8f6fb09af2fd)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-exam
lgtm
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1190#issuecomment-376176881
andreaturli requested changes on this pull request.
Hi @alibazlamit thanks for the effort!
There are still some comments unaddressed but more importantly looks like bare
metal and VM have a too different work path so worth considering 2 different
jclouds APIs, one for 1&1 VM and one for 1&1 bar
FYI using the same @nacx's mvn command I get
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 10:00 min
[INFO] Finished at: 2018-04-10T11:12:55+
Thanks @nacx, I've started a PR to promote apachacon but you've been quicker.
Actually I ended up trying to revamp the entire website, bumping jekyll version
and so on ... let's see what I can do
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly o
andreaturli approved this pull request.
looks good to me and very useful! Thanks!
`AzureRetryableErrorHandlerTest` suite is ok too
Please update https://issues.apache.org/jira/browse/JCLOUDS-1294 accordingly.
> + if (response.getStatusCode() != 429 || isRateLimitError(response)) {
+
andreaturli approved this pull request.
+1
thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1203#pullrequestreview-117528611
andreaturli requested changes on this pull request.
thanks @axel3rd it is super useful!
I've left some comments mainly on the snippets: please address them and edit
the document accordingly, i.e. if you replace `Some.class` with
`NovaApi.class` make sure you do it all over the places.
Thanks
andreaturli commented on this pull request.
> +
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has major changes
between v2 and v3 (detail. [Identity API v2.0 and v3
History](https://docs.openstack.org/keystone/latest/contributor/http-api.
Actually @axel3rd I think we should somehow edit `List Servers` and `Swift: Use
Containers` paragraphs as well pointing maybe the reader to the authentication
section above instead of using
```
novaApi = ContextBuilder.newBuilder(provider)
.endpoint("http://xxx.xxx.xxx.xx
andreaturli approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#pullrequestreview-118055261
thanks @axel3rd
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387117770
Haven't tested myself but lgtm, thanks @danielestevez
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1205#issuecomment-388466244
@nacx that sounds like a decent amount of work, I think we should file a jira
issue and properly track the change in the next release notes (ideally with a
blog post!) - wdyt?
didn't have time yet to review the PR, I'll do asap!
--
You are receiving this because you are subscribed to this thre
andreaturli approved this pull request.
lgtm, thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1210#pullrequestreview-121530457
I'm trying to build jclouds-karaf but it requires some other additional changes
on top of yours above
I'll try to make it work and open a PR to jclouds-karaf connected to this one
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on Git
- bump guava version to 21.0
- fix DimensionData test
this is required for https://github.com/jclouds/jclouds/pull/1197
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/436
-- Commit Summary --
* Upgrade to java8
-- File Changes -
- bump guava version to 21
- bump karaf version to 4.2.0 to support java 8/9/10
- fix karaf-maven-plugin to use javase 1.8
this is required for https://github.com/jclouds/jclouds-labs/pull/436
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-kar
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-390401266
@nacx I'd appreciate your test as the ASF builder is reporting a weird problem
I cannot reproduce locally, thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#issuecomme
see also https://github.com/jclouds/jclouds-karaf/pull/108
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-390654763
cool, thanks @nacx and @gaul merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391014797
Closed #436.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#event-1639523209
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/1b5dd9fe)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391017677
I think `maven-enforcer-plugin` config comes from jclouds/jclouds, do we want
to override only for `jclouds/jclouds-jaraf` ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/108#
pre-validation PR waiting for a new jclouds release based on jdk8
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/93
-- Commit Summary --
* bump to jdk8
-- File Changes --
M blobstore-basics/pom.xml (9)
M blobstore-la
andreaturli commented on this pull request.
> @@ -40,7 +40,7 @@
import java.util.Properties;
import java.util.Set;
-import static
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor;
+import static
com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService;
@d
@demobox I think guava21 updates are incidentally required as we updated
guava21 in jclouds/jclouds, so technically the PR doesn't bump guava version
for jclouds-labs in its pom.xml but it happens because of the upstream changes.
makes sense?
--
You are receiving this because you are subscribe
sure thanks for double-checking it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391117526
andreaturli approved this pull request.
lgtm, some minor changes
> @@ -138,7 +138,7 @@ public void deleteAvailabilitySet() throws
> InterruptedException {
assertSent(server, "DELETE", path);
}
- public void deleteSubnetResourceDoesNotExist() throws InterruptedException {
+ publi
- add ApiMetadata and ProviderMetadata
- add skeleton for ECSComputeApi with ImageApi only
- add `FormSign` filter
- add HttpApiModule and ParserModule
- add `ImageApi` feature with Mock and Live Tests
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jcl
andreaturli commented on this pull request.
> +distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the L
andreaturli commented on this pull request.
> +org.apache.felix
+maven-bundle-plugin
+3.5.0
+true
+
+NONE
+
+
+
${project.artif
andreaturli commented on this pull request.
> +import org.jclouds.http.HttpErrorHandler;
+import org.jclouds.http.annotation.ClientError;
+import org.jclouds.http.annotation.Redirection;
+import org.jclouds.http.annotation.ServerError;
+import org.jclouds.location.suppliers.ImplicitLocationSuppl
andreaturli commented on this pull request.
> +import static org.jclouds.reflect.Reflection2.typeToken;
+
+public class ECSServiceApiMetadata extends
BaseHttpApiMetadata {
+
+ public ECSServiceApiMetadata() {
+ this(new Builder());
+ }
+
+ protected ECSServiceApiMetadata(Builder buil
andreaturli commented on this pull request.
> +
+ /**
+* Returns a region enum corresponding to the given region name.
+*
+* @param regionName
+*The name of the region. Ex.: eu-west-1
+* @return Region enum representing the given region name.
+*/
+ public
andreaturli commented on this pull request.
> +
+ public abstract String status();
+
+ public abstract String imageName();
+
+ public abstract Boolean isSupportIoOptimizeds();
+
+ public abstract Boolean isSelfShared();
+
+ public abstract Boolean isCopied();
+
+ public abstract Bool
andreaturli commented on this pull request.
> + AP_NORTHEAST_1("ap-northeast-1", "Japan (Tokyo)"),
+ AP_SOUTH_1("ap-south-1", "India (Mumbai)"),
+ AP_SOUTHEAST_1("ap-southeast-1", "Singapore"),
+ AP_SOUTHEAST_2("ap-southeast-2", "Australia (Sydney)"),
+ AP_SOUTHEAST_3("ap-southeast-3",
andreaturli commented on this pull request.
> + * limitations under the License.
+ */
+package org.jclouds.aliyun.ecs.domain.options;
+
+import org.jclouds.http.options.BaseHttpRequestOptions;
+
+import static com.google.common.base.Preconditions.checkState;
+
+public class PaginationOptions ext
andreaturli commented on this pull request.
> + * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.aliyun.ecs.domain.options;
+
+import org.jclouds.http.options.BaseHttpRequestOptions;
+
+import static com.google.com
andreaturli commented on this pull request.
> +
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import javax.ws.rs.Consumes;
+import javax.ws.rs.GET;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.core.MediaType;
+
+/**
+ *
https://www.alibabacloud
andreaturli commented on this pull request.
> + * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS
@andreaturli pushed 1 commit.
93c8cb9 address nacx comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438/files/4dd54bcb3640c37c7df19e8ffb31ad8cb42d9b8f..93c8cb9bb449c108a3dae22415d72ad7bcbffa9d
@andreaturli pushed 1 commit.
5f5f0ff fix ISOCODES
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438/files/93c8cb9bb449c108a3dae22415d72ad7bcbffa9d..5f5f0ff267225c36885ea2bc3899cc17cb08137d
@andreaturli pushed 1 commit.
cc9caf9 remove unused class, replaced by jclouds crypto
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438/files/5f5f0ff267225c36885ea2bc3899cc17cb08137d..cc9caf994662bf4f1f03b56
andreaturli approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1223#pullrequestreview-134390899
andreaturli commented on this pull request.
> @@ -52,15 +52,15 @@
@Consumes(MediaType.APPLICATION_JSON)
@RequestFilters(FormSign.class)
@QueryParams(keys = {"Version", "Format", "SignatureVersion", "ServiceCode",
"SignatureMethod"},
-values = {"2014-05-26", "JSON", "1.0", "ecs", "HMA
@andreaturli pushed 1 commit.
99057d5 more comments addressed
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438/files/cc9caf994662bf4f1f03b56f4372c09f190d1999..99057d5101294fbfee489357b3217f1678c8f2ee
Thanks @nacx squashed and merging if builder is happy
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#issuecomment-402678453
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/5bd2a80f)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#issuecomment-402682152
Closed #438.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/438#event-1717762779
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/440
-- Commit Summary --
* [JCLOUDS-1430] - add region and zone API
-- File Changes --
M aliyun-ecs/src/main/java/org/jclouds/aliyun/ecs/ECSComputeServiceApi.java
(4)
M
a
Hi @alibazlamit thanks for your perseverance
I really need to encourage you to open smaller PR: 75 files bring in a huge
amount of changes and it is impossible to review all of them carefully. Can you
take the time to close this PR and open up small incremental PRs maybe?
I think the first one c
andreaturli commented on this pull request.
> + Map> networkTypes)
> {
+ return new AutoValue_ResourceInfo(ioOptimized, systemDiskCategories ==
null ?
+ImmutableMap.>of() :
+ImmutableMap.copyOf(systemDiskCategories),
+
andreaturli commented on this pull request.
> +package org.jclouds.aliyun.ecs.compute.features;
+
+import com.google.common.base.Predicate;
+import com.google.common.collect.Iterables;
+import
org.jclouds.aliyun.ecs.compute.internal.BaseECSComputeServiceApiLiveTest;
+import org.jclouds.aliyun.e
andreaturli commented on this pull request.
> + *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the
andreaturli commented on this pull request.
> + assertSent(server, "GET", "DescribeRegions");
+ }
+
+ public void testListRegionsReturns404() {
+ server.enqueue(response404());
+ List regions = api.regionAndZoneApi().describeRegions();
+ assertTrue(isEmpty(regions));
+
andreaturli commented on this pull request.
> + assertEquals(server.getRequestCount(), 1);
+ }
+
+ public void testListZones() throws InterruptedException {
+ server.enqueue(jsonResponse("/zones.json"));
+ List zones =
api.regionAndZoneApi().describeZones(Regions.EU_CENTRAL_1
andreaturli commented on this pull request.
> + assertSent(server, "GET", "DescribeRegions");
+ }
+
+ public void testListRegionsReturns404() {
+ server.enqueue(response404());
+ List regions = api.regionAndZoneApi().describeRegions();
+ assertTrue(isEmpty(regions));
+
@andreaturli pushed 1 commit.
5dc166e address comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440/files/f2e15c37bbc7ff71f7ebdc992d9387b7ba41b816..5dc166e56659bae37f57601c55d4073c13e25fc9
andreaturli commented on this pull request.
>RecordedRequest request = server.takeRequest();
assertEquals(request.getMethod(), method);
Map queryParameters =
Splitter.on('&').trimResults().withKeyValueSeparator("=").split(request.getPath());
assertEquals(queryParame
@andreaturli pushed 1 commit.
c3e6c8c better assertSent
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440/files/5dc166e56659bae37f57601c55d4073c13e25fc9..c3e6c8ce7bcac795620cfebaf93898eef52692dd
any better @nacx ? thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-402994493
@andreaturli pushed 1 commit.
753df7f more improvements
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440/files/c3e6c8ce7bcac795620cfebaf93898eef52692dd..753df7f3e6853d008aa290ce6f185c193f728d5f
squashed and merging
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-403008358
andreaturli requested changes on this pull request.
some minor changes, but good overall. Thanks @alibazlamit
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeabl
merged at
[mater](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f38f8045)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-403009890
Closed #440.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#event-1720091784
thanks @nacx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/440#issuecomment-403009918
andreaturli commented on this pull request.
> +import org.apache.jclouds.oneandone.rest.internal.BaseOneAndOneApiMockTest;
+import org.testng.annotations.Test;
+
+import java.util.List;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
+
+@Test(grou
andreaturli commented on this pull request.
> +import org.apache.jclouds.oneandone.rest.internal.BaseOneAndOneApiMockTest;
+import org.testng.annotations.Test;
+
+import java.util.List;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
+
+@Test(grou
andreaturli commented on this pull request.
> +@Test(groups = "live", testName = "SshKeyApiLiveTest")
+public class SshKeyApiLiveTest extends BaseOneAndOneLiveTest {
+
+ private SshKey currentSshKey;
+ private List sshKeys;
+
+ private SshKeyApi sshKeyApi() {
+ return api.sshKeyApi();
- add securitygroup-api
- add keypair-api
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/441
-- Commit Summary --
* [JCLOUDS-1430] - add more features
-- File Changes --
M aliyun-ecs/src/main/java/org/jclouds/aliyun/ecs/ECSC
andreaturli commented on this pull request.
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeable {
+
+ @Named("blockstorages:list")
+ @GET
+ @Fallback(Fall
andreaturli commented on this pull request.
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeable {
+
+ @Named("blockstorages:list")
+ @GET
+ @Fallback(Fall
101 - 200 of 1680 matches
Mail list logo
