Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-07 Thread Andrea Turli
thanks @axel3rd -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387117770

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-07 Thread Andrea Turli
andreaturli approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/214#pullrequestreview-118055261

Re: [jclouds/jclouds] JCLOUDS-1294: Attempt to retry RetryableErrors in Azure ARM (#1203)

2018-05-04 Thread Andrea Turli
andreaturli approved this pull request. +1 thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1203#pullrequestreview-117528611

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

2018-05-19 Thread Andrea Turli
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-390401266

[jclouds/jclouds-karaf] upgrade to java 8 (#108)

2018-05-19 Thread Andrea Turli
- bump guava version to 21 - bump karaf version to 4.2.0 to support java 8/9/10 - fix karaf-maven-plugin to use javase 1.8 this is required for https://github.com/jclouds/jclouds-labs/pull/436 You can view, comment on, or merge this pull request online at:

[jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-19 Thread Andrea Turli
- bump guava version to 21.0 - fix DimensionData test this is required for https://github.com/jclouds/jclouds/pull/1197 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/436 -- Commit Summary -- * Upgrade to java8 -- File Changes

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

2018-05-20 Thread Andrea Turli
@nacx I'd appreciate your test as the ASF builder is reporting a weird problem I cannot reproduce locally, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Andrea Turli
@nacx that sounds like a decent amount of work, I think we should file a jira issue and properly track the change in the next release notes (ideally with a blog post!) - wdyt? didn't have time yet to review the PR, I'll do asap! -- You are receiving this because you are subscribed to this

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-21 Thread Andrea Turli
see also https://github.com/jclouds/jclouds-karaf/pull/108 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1197#issuecomment-390654763

[jclouds/jclouds-examples] [do not merge] bump to jdk8 (#93)

2018-05-22 Thread Andrea Turli
pre-validation PR waiting for a new jclouds release based on jdk8 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-examples/pull/93 -- Commit Summary -- * bump to jdk8 -- File Changes -- M blobstore-basics/pom.xml (9) M

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Andrea Turli
cool, thanks @nacx and @gaul merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391014797

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/1b5dd9fe) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391017677

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Andrea Turli
Closed #436. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/436#event-1639523209

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Andrea Turli
@demobox I think guava21 updates are incidentally required as we updated guava21 in jclouds/jclouds, so technically the PR doesn't bump guava version for jclouds-labs in its pom.xml but it happens because of the upstream changes. makes sense? -- You are receiving this because you are

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Andrea Turli
sure thanks for double-checking it -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391117526

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -40,7 +40,7 @@ import java.util.Properties; import java.util.Set; -import static com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor; +import static com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService;

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-18 Thread Andrea Turli
I'm trying to build jclouds-karaf but it requires some other additional changes on top of yours above I'll try to make it work and open a PR to jclouds-karaf connected to this one -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-18 Thread Andrea Turli
andreaturli approved this pull request. lgtm, thanks @nacx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1210#pullrequestreview-121530457

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

2018-05-22 Thread Andrea Turli
I think `maven-enforcer-plugin` config comes from jclouds/jclouds, do we want to override only for `jclouds/jclouds-jaraf` ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-12 Thread Andrea Turli
andreaturli approved this pull request. lgtm, some minor changes > @@ -138,7 +138,7 @@ public void deleteAvailabilitySet() throws > InterruptedException { assertSent(server, "DELETE", path); } - public void deleteSubnetResourceDoesNotExist() throws InterruptedException { +

[jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS initial skeleton (#438)

2018-07-03 Thread Andrea Turli
- add ApiMetadata and ProviderMetadata - add skeleton for ECSComputeApi with ImageApi only - add `FormSign` filter - add HttpApiModule and ParserModule - add `ImageApi` feature with Mock and Live Tests You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds-labs] fix domain object (#414)

2017-10-23 Thread Andrea Turli
@andreaturli pushed 1 commit. 5abac36 fix VirtuaMachineMockTest -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/414/files/11b5cea9ff702e34ddf24864dc862daf9ef96b4c..5abac365cf54aabb52a9f9a4e03732f24726aa69

[jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-19 Thread Andrea Turli
cc @nacx You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1175 -- Commit Summary -- * [JCLOUDS-1377] add support for injectable Neutron Context into Nova -- File Changes -- M apis/openstack-nova/pom.xml (5) M

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-19 Thread Andrea Turli
@nacx I think I've addressed most of your comments and now the duplication of `Find/Create` SecurityGroup is gone. I still have some expected tests to fix but please let me know if the code is more readable now. Thanks -- You are receiving this because you are subscribed to this thread.

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-19 Thread Andrea Turli
@nacx thanks for the review Main reason I have 2 couples of `Create/FindSecurityGroup` now (I want to remove them before merging this PR) is because of `NovaSecurityGroupExtension` and `NeutronSecurityGroupExtension` `NovaSecurityGroupExtension` needs to use `NovaApi` to create security groups,

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-19 Thread Andrea Turli
@andreaturli pushed 1 commit. 0bdbdbf addressing Nacx comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1175/files/7846a2ddf32ed07e6fc394a43d954fc6fe039d28..0bdbdbf29214504f4e676e0afd6fb43f83275e4e

Re: [jclouds/jclouds] Add Keystone V3 support (#1170)

2018-01-16 Thread Andrea Turli
Excellent work @nacx, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1170#issuecomment-357952628

Re: [jclouds/jclouds-site] Blog post for Keystone V3 (#206)

2018-01-12 Thread Andrea Turli
looks very good to me, @nacx! thanks for the awesome contribution! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/206#issuecomment-357268139

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-30 Thread Andrea Turli
here's my live tests results: - for `NovaSecurityGroupExtension` ``` --- T E S T S --- Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-30 Thread Andrea Turli
@andreaturli pushed 1 commit. 4e0b06b fix removal from security group cache -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-02-01 Thread Andrea Turli
@andreaturli pushed 1 commit. ff4a725 simplify securitygroup cache -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1175/files/753638f986a376e6abd94ccc57ea35bad91a79af..ff4a7257f537a28788cfdf3d0956808a4115c4c2

[jclouds/jclouds-karaf] [DO-NOT-MERGE] Add openstack-neutron to feature.xml (#107)

2018-02-02 Thread Andrea Turli
depends on https://github.com/jclouds/jclouds/pull/1175 cc @nacx You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/107 -- Commit Summary -- * Add openstack-neutron to feature.xml -- File Changes -- M

Re: [jclouds/jclouds-karaf] Add openstack-neutron to feature.xml (#107)

2018-02-02 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/c117ed39) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/107#issuecomment-362619387

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-02-02 Thread Andrea Turli
merging it -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1175#issuecomment-362617035

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-02-02 Thread Andrea Turli
Closed #1175. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1175#event-1455308130

Re: [jclouds/jclouds-karaf] Add openstack-neutron to feature.xml (#107)

2018-02-02 Thread Andrea Turli
Closed #107. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/107#event-1455311406

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-02-02 Thread Andrea Turli
merged at [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=09936b5) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1175#issuecomment-362618900

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-02-02 Thread Andrea Turli
thanks @nacx for your help and review -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1175#issuecomment-362618718

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-27 Thread Andrea Turli
thx @swaqos it looks like a great PR: jira issue, good tests (with live tests results) and use of jclouds best practices! Thanks, Ill review it properly asap -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] [JCLOUDS-1374]This is the first commit of Softlayer LoadBalancer API (#1176)

2018-01-28 Thread Andrea Turli
andreaturli requested changes on this pull request. > + @BeforeClass(groups = {"integration", "live"}) + @Override + public void setup() { + super.setup(); + + loadBalancerApi = api.getLoadBalancerApi(); + + datacenter =

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-31 Thread Andrea Turli
@andreaturli pushed 1 commit. 753638f fix listSecurityGroupsForNode -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1175/files/4e0b06b2510001ccd9a83f3166989d6119255f46..753638f986a376e6abd94ccc57ea35bad91a79af

[jclouds/jclouds] add centos and rhel 7.* to ComputeServiceConstants (#1177)

2018-02-05 Thread Andrea Turli
if ok I think we should backport it to 2.0.x You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1177 -- Commit Summary -- * add centos and rhel 7.* to ComputeServiceConstants -- File Changes -- M

Re: [jclouds/jclouds] add centos and rhel 7.* to ComputeServiceConstants (#1177)

2018-02-05 Thread Andrea Turli
thanks @nacx, merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1177#issuecomment-36311

Re: [jclouds/jclouds] add centos and rhel 7.* to ComputeServiceConstants (#1177)

2018-02-05 Thread Andrea Turli
Closed #1177. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1177#event-1458103067

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-31 Thread Andrea Turli
andreaturli commented on this pull request. > + return ImmutableSet.of(); + } + return getSecurityGroupApi(region).listSecurityGroups().concat().transform(neutronSecurityGroupToSecurityGroup.create(location)).toSet(); + } + + @Override + public Set

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-31 Thread Andrea Turli
@nacx here's the result of `NeutronSecurityGroupExtensionLiveTest` against a provider with keystone v3 and Neutron support ``` --- T E S T S --- Running

Re: [jclouds/jclouds] [JCLOUDS-1377] add support for injectable Neutron Context into Nova (#1175)

2018-01-31 Thread Andrea Turli
andreaturli commented on this pull request. > + return ImmutableSet.of(); + } + return getSecurityGroupApi(region).listSecurityGroups().concat().transform(neutronSecurityGroupToSecurityGroup.create(location)).toSet(); + } + + @Override + public Set

Re: [jclouds/jclouds-site] Blog post about linking Nova and Neutron (#209)

2018-02-12 Thread Andrea Turli
andreaturli commented on this pull request. > + .overrides(neutronProperties) + .modules(ImmutableSet.of(new SLF4JLoggingModule())) + .build(); + +// Create the connection to OpenStack nova and link it to Neutron +NovaApi nova = ContextBuilder.newBuilder("openstack-nova") +

Re: [jclouds/jclouds-site] Blog post about linking Nova and Neutron (#209)

2018-02-12 Thread Andrea Turli
@nacx thank you for your help with the blog post! Looks good to me Do we want to publish it together with the 2.1.0 release or before? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] Blog post about linking Nova and Neutron (#209)

2018-02-12 Thread Andrea Turli
andreaturli approved this pull request. +1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/209#pullrequestreview-95818166

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Andrea Turli
thanks @alibazlamit could you please open a jira issue that describes the rationale for this PR? Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365676093

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Andrea Turli
Not familiar with the oneandone API but looks like `baremetal` is another servertype for server creation. If this is correct, then we could either introduce a OneAndOneTemplateOption for serverType or try to infer it from hardwareProfiles if this additional flag is available. Makes sense? --

Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)

2018-02-14 Thread Andrea Turli
Thanks @alibazlamit for the summary. Would you mind to copy that into a jira issue as described at point 2 at https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute Ideally you can rename the PR using the jira issue I'd. That would hugely help us to manage the project.Thanks --

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + } + + private final Location location; + + @Inject + public NeutronFloatingIpToFloatingIp(@Assisted Location location) { + this.location = location; + } + + @Override + public FloatingIP apply(@Nullable

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + Optional > floatingIPOptional = tryFindExistingFloatingIp(neutronFloatingApi, > availabilityZone); + org.jclouds.openstack.neutron.v2.domain.FloatingIP floatingIP; + if (floatingIPOptional.isPresent()) {

[jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
- move Neutron FloatingIP API from extension to feature - introduce FloatingIpForServer as abstract domain object to represents Nova and Neutron objects - manage floating ip cache and its invalidation --- cc @nacx You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + } + }); + return floatingIPOptional; + } + + private org.jclouds.openstack.neutron.v2.domain.FloatingIP createFloatingIpUsingNeutron(org.jclouds.openstack.neutron.v2.features.FloatingIPApi neutronFloatingApi, NodeMetadata

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > + Optional networkOptional = > getNetworkApi(regionId).list().concat().firstMatch(new Predicate() { + @Override + public boolean apply(@Nullable Network input) { +return input.getExternal() &&

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > try { -network = networkApi.create( - Network.createBuilder("jclouds-network-test").external(true).networkType(NetworkType.LOCAL).build()); -assertNotNull(network); - -ipv4SubnetId =

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -51,7 +78,66 @@ protected LoggingModule getLoggingModule() { @Override protected Iterable setupModules() { - return ImmutableSet.of(getLoggingModule(), credentialStoreModule, getSshModule()); + return ImmutableSet. of( +

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -275,15 +258,24 @@ public boolean apply(Network input) { } - private List getNetworksFromPoolNames(String regionId, final Optional poolNames) { - return getNetworkApi(regionId).list().concat().filter(new Predicate() { -

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
andreaturli commented on this pull request. > public NovaComputeServiceLiveTest() { provider = "openstack-nova"; - - Properties overrides = setupProperties(); - neutronApiContext = ContextBuilder.newBuilder("openstack-neutron") -

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
@andreaturli pushed 1 commit. f5c484c comments addressed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1178/files/99f434fa292950f7cff2560c6b5881627962d7ff..f5c484c40ad35720edd621bfe6b031e5b3e107bc

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
@andreaturli pushed 1 commit. a0aee8e more comments addressed -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1178/files/f5c484c40ad35720edd621bfe6b031e5b3e107bc..a0aee8e86c6d22322992e471ebc9ab031984a804

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#issuecomment-365995432

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
Merged at [master](https://git1-us-west.apache.org/repos/asf?p=jclouds.git;a=commit;h=50ae6828) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#issuecomment-365995753

Re: [jclouds/jclouds] JCLOUDS-1381: Fix NPE in GCE DiskURIToImage (#1179)

2018-02-15 Thread Andrea Turli
lgtm -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1179#issuecomment-365995927

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
Closed #1178. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1178#event-1476352774

Re: [jclouds/jclouds] [JCLOUDS-1382] improve usage of Neutron capabilities from Nova (#1178)

2018-02-15 Thread Andrea Turli
@andreaturli pushed 1 commit. ef03157 more comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1178/files/a0aee8e86c6d22322992e471ebc9ab031984a804..ef03157a14a20991a1f8bc1d69896edf58b9f8f7

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
andreaturli commented on this pull request. > +* Modernize Openstack support +* Graduate Microsoft Azure Resource Manager to core +* Better support for AWS EC2 in terms of network capabilities and regions +* Graduate Google Cloud Storage (GCS) and Backblaze B2 to core +* Better integration with

[jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/210 -- Commit Summary -- * draft release notes for 2.1.0 -- File Changes -- A releasenotes/2.1.0.md (85) -- Patch Links --

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
andreaturli commented on this pull request. > +Apache jclouds 2.1.0 features include: + +* Modernize Openstack support +* Graduate Microsoft Azure Resource Manager to core +* Better support for AWS EC2 in terms of network capabilities and regions +* Graduate Google Cloud Storage (GCS) and

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
andreaturli commented on this pull request. > +* Support GCS temporary signed URLs +* Add Azure Cool Blob Storage + +## Credits + +jclouds would like to thank everyone who contributed time and effort in order to make this release happen: + +* [Jim Micheal Spring](https://twitter.com/jmspring)

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
andreaturli commented on this pull request. > +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Compute Improvements](#computeimprovements) +1. [BlobStore Improvements](#blobstoreimprovements) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
andreaturli commented on this pull request. > +## Release Highlights + +Apache jclouds 2.1.0 features include: + +* Modernize Openstack support +* Graduate Microsoft Azure Resource Manager to core +* Better support for AWS EC2 in terms of network capabilities and regions +* Graduate Google

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
@andreaturli pushed 1 commit. 78d5c13 address comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/210/files/7f1c12de8d0feee6adcf95a1ffb5f07c04b10190..78d5c13a33f27447824047b265aaeaadea92cf48

Re: [jclouds/jclouds] core: Fix compile issue under Java 8+ (#1180)

2018-02-20 Thread Andrea Turli
Thanks @wltjr for your help with that! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1180#issuecomment-367092362

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-24 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -6,6 +6,7 @@ permalink: /releasenotes/ The Release Notes and Javadocs for every major release of Apache jclouds are listed chronologically below. +* [2.1.0](/releasenotes/2.1.0) | [Javadoc](/reference/javadoc/2.1.x/) @demobox I think you

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-24 Thread Andrea Turli
@andreaturli pushed 1 commit. d8099f0 fix deploy-javadoc -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/210/files/a7fa3bc8b9ec4d2dc9db4b825486554303f4d069..d8099f098b651fcb279095176369ec5152254c91

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-23 Thread Andrea Turli
thanks @demobox for your review! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367948008

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-23 Thread Andrea Turli
@andreaturli pushed 1 commit. a7fa3bc address demobox comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/210/files/33b9bac3ef73d44e6cb4f977706c7920fff3aa07..a7fa3bc8b9ec4d2dc9db4b825486554303f4d069

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
thanks @gaul I've updated the release notes with your suggestions -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367394512

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
@nacx are you happy with the changes? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367365343

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
thanks @nacx not sure why you were seeing all those references to 2.0.0 but I think they are now ok -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367303420

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
@andreaturli pushed 1 commit. 5db90e1 wip -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/210/files/0d6b419b90132af988a3eeaf76ee3f7477e669e0..5db90e129a6bcb377e94cc3f2f3f0749c69fb1a5

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-21 Thread Andrea Turli
are we happy with that? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-367397179

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-25 Thread Andrea Turli
is it ok to merge @nacx ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-368341886

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-25 Thread Andrea Turli
andreaturli commented on this pull request. > + +## Credits + +jclouds would like to thank everyone who contributed time and effort in order to make this release happen: + +* [Jim Micheal Spring](https://twitter.com/jmspring) for his contributions to the Microsoft Azure ARM provider and the

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-25 Thread Andrea Turli
andreaturli commented on this pull request. > +title: Release Notes for Version 2.1.0 +date: 2018-02-21 12:00:00 +release_notes: true +permalink: /releasenotes/2.1.0/ +--- + +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Compute Improvements](#computeimprovements) +1.

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-26 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-site/commit/314f3b56) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#issuecomment-368419667

Re: [jclouds/jclouds-site] draft release notes for 2.1.0 (#210)

2018-02-26 Thread Andrea Turli
Closed #210. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/210#event-1491432530

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-02 Thread Andrea Turli
andreaturli commented on this pull request. > + vSwitchId = setIfTestSystemPropertyPresent(properties, provider + > ".vSwitchId"); + return properties; + } + + @Override + protected TemplateBuilder templateBuilder() { + return super.templateBuilder() +

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-01 Thread Andrea Turli
andreaturli commented on this pull request. > @@ -125,4 +126,28 @@ public boolean apply(Server server) { || server.status().percent() != 0); } } + + @Provides + @Singleton + @Named(POLL_PREDICATE_SERVER_SUSPENDED) @alibazlamit why do we need this

Re: [jclouds/jclouds-labs] JCLOUDS-1386 1&1 Baremetal servers (#431)

2018-08-01 Thread Andrea Turli
@alibazlamit I've added a question to help the discussion. Can we start from there? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-409595895

[jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-01 Thread Andrea Turli
- add instance API - add compute abstraction You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/443 -- Commit Summary -- * [JCLOUDS-1430] Aliyun ECS -- File Changes -- A aliyun-ecs/README.md (47) M

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)

2018-07-30 Thread Andrea Turli
andreaturli commented on this pull request. > +import com.google.common.collect.Iterables; + +import javax.inject.Singleton; +import java.util.Arrays; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkNotNull; + +/** +

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)

2018-07-30 Thread Andrea Turli
@andreaturli pushed 1 commit. f2e09f7 wip -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441/files/03b707362be9d648ab9bdb89a409837f4a7ac748..f2e09f774d0d5236589bb1d2c075a887f2afaf43

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)

2018-07-31 Thread Andrea Turli
merging now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409340097

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)

2018-07-31 Thread Andrea Turli
Closed #441. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#event-1763661946

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] - add more features (#441)

2018-07-31 Thread Andrea Turli
merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/a5dbf006) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/441#issuecomment-409351737

<    7   8   9   10   11   12   13   14   15   16   >