JnRouvignac opened a new pull request #93:
URL: https://github.com/apache/jclouds/pull/93
- animal sniffer should be on java18, just like ``
- Only use elem() and text() to have similar looking code
- Remove unnecessary call to up() because the returned value is never used
-
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-739508043
@gaul I provided two merge requests, one for the aws, and the other for the
openstack lab project. The changes should be straightforward, it just aligns
the OSGi handling we do
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-739497367
@gaul I have a small problem with the maven-site-plugin in the base project
pom file. I use IntelliJ and its complaining that report-plugins within the
configuration section
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-739496620
Yeah sorry I forgot to mention this. All the labs variants was a poor
engineering decision in retrospect that we will hopefully unwind some day...
gurkerl83 opened a new pull request #1:
URL: https://github.com/apache/jclouds-labs-aws/pull/1
This project, the aws-lab version of Apache JClouds, share the exact build
instructions as the primary Apache JClouds project with all its modules.
Apache JClouds is shifting its strategy in
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-739446053
@gurkerl83 Could you investigate this build failure:
https://ci-builds.apache.org/job/JClouds/job/jclouds-labs-aws/7/
I think the changes you made to jclouds-labs need to
gurkerl83 edited a comment on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-739497367
@gaul I have a small problem with the maven-site-plugin in the base project
pom file. I use IntelliJ and its complaining that report-plugins within the
configuration
gurkerl83 opened a new pull request #2:
URL: https://github.com/apache/jclouds-labs-openstack/pull/2
This project, the openstack-lab version of Apache JClouds, share the exact
build instructions as the primary Apache JClouds project with all its modules.
Apache JClouds is shifting its
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-739479364
@gaul The build error is related to the chances. I make the required
changes, didn’t know the project’s existed, respectively get pulled into the
build. Thx!
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-739479364
@gaul The build error is related to the chances. Should be an easy fix, I
make the required changes, didn’t know the project’s existed, respectively get
pulled into the
gurkerl83 edited a comment on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-739497367
@gaul I have a small problem with the maven-site-plugin in the base project
pom file. I use IntelliJ and its complaining that report-plugins within the
configuration
gurkerl83 opened a new pull request #91:
URL: https://github.com/apache/jclouds/pull/91
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gaul commented on pull request #1:
URL: https://github.com/apache/jclouds-labs-aws/pull/1#issuecomment-739595718
Thanks for fixing this @gurkerl83!
This is an automated message from the Apache Git Service.
To respond to the
gaul commented on pull request #2:
URL:
https://github.com/apache/jclouds-labs-openstack/pull/2#issuecomment-739595730
Thanks for fixing this @gurkerl83!
This is an automated message from the Apache Git Service.
To respond
gaul merged pull request #1:
URL: https://github.com/apache/jclouds-labs-aws/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gaul merged pull request #2:
URL: https://github.com/apache/jclouds-labs-openstack/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
davidsloan commented on pull request #88:
URL: https://github.com/apache/jclouds/pull/88#issuecomment-739998437
> Please make sure Azure integration tests pass:
>
> ```
> mvn integration-test -pl :azureblob -Plive
-Dtest.azureblob.identity="${JCLOUDS_IDENTITY}"
davidsloan commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r537592491
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-739219540
@gaul Yes, I will do this next week
This is an automated message from the Apache Git Service.
To respond to the
gaul commented on pull request #90:
URL: https://github.com/apache/jclouds/pull/90#issuecomment-739189499
Could you correct the commit message to JCLOUDS-1559?
This is an automated message from the Apache Git Service.
To
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-739216868
@gurkerl83 We plan to release 2.3.0 later this month. Do you think you can
finish this PR soon?
This is an automated
gaul commented on pull request #88:
URL: https://github.com/apache/jclouds/pull/88#issuecomment-739216189
@davidsloan We plan to release 2.3.0 later this month. Do you think you can
finish this PR soon?
This is an
roded commented on pull request #64:
URL: https://github.com/apache/jclouds/pull/64#issuecomment-739233601
@gaul I won't be able to complete this PR for 2.3.0.
Would you have me close this PR and keep the issue open?
Sorry for leaving this open for so long.
roded commented on pull request #90:
URL: https://github.com/apache/jclouds/pull/90#issuecomment-739235317
@gaul fixed the commit message.
This is an automated message from the Apache Git Service.
To respond to the message,
gaul commented on pull request #90:
URL: https://github.com/apache/jclouds/pull/90#issuecomment-739240554
Thank you for your contribution @roded!
This is an automated message from the Apache Git Service.
To respond to the
gaul merged pull request #90:
URL: https://github.com/apache/jclouds/pull/90
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-739377214
@gaul The feature is basically ready for a review and a second opinion. The
most important change in this feature is probably due to a Guice / Guava
conflict. The limitation of
gaul commented on pull request #63:
URL: https://github.com/apache/jclouds/pull/63#issuecomment-741541900
I am not sure I understand this PR. Do you want an option to configure the
TLS level or to change the default? In either case, please open a JIRA issue.
gaul merged pull request #88:
URL: https://github.com/apache/jclouds/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul commented on pull request #88:
URL: https://github.com/apache/jclouds/pull/88#issuecomment-740314613
Thank you for your contribution and testing @davidsloan!
This is an automated message from the Apache Git Service.
To
gaul edited a comment on pull request #47:
URL: https://github.com/apache/jclouds/pull/47#issuecomment-740616788
@didixith Sorry I overlooked this. You need to write something similar to:
```java
public void testCreateBucketNonDefaultRegion() throws Exception {
gaul commented on pull request #47:
URL: https://github.com/apache/jclouds/pull/47#issuecomment-740616788
@didixith Sorry I overlooked this. You need to write something similar to:
```java
MockWebServer server = new MockWebServer();
server.enqueue(new
didixith edited a comment on pull request #47:
URL: https://github.com/apache/jclouds/pull/47#issuecomment-543144142
Let me know how to mock webserver response? Please check the below code and
let me know your views on this.
```java
public void testCreateBucketNonDefaultRegion()
didixith edited a comment on pull request #47:
URL: https://github.com/apache/jclouds/pull/47#issuecomment-543144142
Let me know how to mock webserver response? Please check the below code and
let me know your views on this.
```java
public void testCreateBucketNonDefaultRegion()
roded commented on pull request #43:
URL: https://github.com/apache/jclouds/pull/43#issuecomment-737690192
I'll close this PR as I don't think I'll be able to reattempt it anytime
soon.
This is an automated message from the
roded closed pull request #43:
URL: https://github.com/apache/jclouds/pull/43
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
radito3 opened a new pull request #89:
URL: https://github.com/apache/jclouds/pull/89
Removed `MultipartUploadSlicingAlgorithm` and its unit test class as it's
unused after this change.
Removed `PayloadSlicer` from the BlobStores' constructors as it's unused
after the change.
radito3 commented on a change in pull request #89:
URL: https://github.com/apache/jclouds/pull/89#discussion_r533368106
##
File path:
blobstore/src/main/java/org/jclouds/blobstore/internal/BaseBlobStore.java
##
@@ -354,48 +350,22 @@ protected String putMultipartBlob(String
gurkerl83 edited a comment on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-744570168
@nacx Thx for the link.
The build runs without using the following declaration.
```
org.apache
apache
14
```
I
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-744570168
@nacx Thx for the link.
The build runs without using the following declaration.
```
org.apache
apache
14
```
I have a
roded commented on a change in pull request #92:
URL: https://github.com/apache/jclouds/pull/92#discussion_r542432587
##
File path: core/src/main/java/org/jclouds/proxy/ProxyExcludePatterns.java
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nacx commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-744549388
You can find the release process here:
https://cwiki.apache.org/confluence/display/JCLOUDS/Releasing+jclouds
We don't use the maven release plugin to update the poms. We do it
zhwang-amad opened a new pull request #87:
URL: https://github.com/apache/jclouds/pull/87
According to RFC 2616 there cannot be a response body. Trying to parse
it results in a spurious error being logged.
This is an
zhwang-amad commented on pull request #87:
URL: https://github.com/apache/jclouds/pull/87#issuecomment-724275864
Already fixed by #82 . My bad.
This is an automated message from the Apache Git Service.
To respond to the
zhwang-amad closed pull request #87:
URL: https://github.com/apache/jclouds/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nacx commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r522283581
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache
davidsloan commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r522306620
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the
davidsloan commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r522430914
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the
davidsloan commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r522441065
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the
nacx commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r522435377
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache
nacx commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r522217861
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache
davidsloan commented on a change in pull request #88:
URL: https://github.com/apache/jclouds/pull/88#discussion_r58624
##
File path:
providers/azureblob/src/test/java/org/jclouds/azure/storage/util/StorageUrlDelegateTest.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the
ahgittin commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714696642
Seems to me like this PR is introducing two significant changes:
* use `bnd` instead of `jclouds.osgi.{im,ex}port` maven properties
* change how `gson` is
geomacy commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-714704006
> Should I do a rebase and squash?
Just a suggestion, I think it's easier to follow the history and comments if
it is just left as-is. But I don't know what the conventions
geomacy commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-754526687
@gurkerl83 what did you have in mind when you added that TODO comment in
7b5c2ae? Do you know of a way to support a range of package-import versions in
downstream projects using
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in this branch.
Different versions of Guava
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in the current branch.
Different versions of
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in this branch.
Different versions of Guava
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in this branch.
Different versions of Guava were
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in the current branch.
Different versions of
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in this branch.
Different versions of Guava
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in this branch.
Different versions of Guava
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in this branch.
Different versions of Guava
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi all,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in the current branch.
Different versions of
geomacy commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757559706
Thanks for the extensive notes @gurkerl83. I'm not sure what that means we
need to do, but we can continue the conversation in #86 (or perhaps simply on
the jclouds mailing list)
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757561619
@geomacy Already done in the commit
https://github.com/apache/jclouds/pull/86/commits/625e54d2028a456d15bd142fda77196019ce6f3f
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757561619
@geomacy Already done in the commit
https://github.com/apache/jclouds/pull/86/commits/625e54d2028a456d15bd142fda77196019ce6f3f
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757595782
Is there anything we can do to improve this in the short-term? I would like
to release jclouds 2.3.0.
This is an
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757345535
Hi @ahgittin @gaul @nacx @geomacy,
The Guava version fixed to 22.0 in the master branch was already set before
the refactoring performed in the current branch.
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757673641
@gaul What do you mean, is the min version of guava, which is set to 27.1 to
high? If everyone is fine please go ahead and review the mentioned feature. A
release shouldn’t be a
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-757814524
No, unfortunately I do not have an AWS account, so I can't directly test
myself :(
This is an automated
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757694086
`project/pom.xml` shows Guava the minimum version as 22.0 and the OSGi
version range as [22.0,30.0.0).
This is an
nacx commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-757762909
LGTM. Have you been able to run the live tests against aws-s3?
This is an automated message from the Apache Git
JnRouvignac edited a comment on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-762705311
BTW are you interested in removing the dependency on `XMLBuilder`?
This adds a dependency to the `com.jamesmurty.utils:java-xmlbuilder` jar and
a transitive
gaul commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764625057
Successfully ran the integration tests against aws-s3. We are interested in
any OSGi improvements, if they remove dependencies or otherwise. Thank you for
your contribution
gaul merged pull request #93:
URL: https://github.com/apache/jclouds/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764754029
Excellent! Thank you very much!
I'll write to the mailing list when I'll have a little more time to work on
removing these dependencies.
gaul commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764625057
Successfully ran the integration tests against aws-s3. We are interested in
any OSGi improvements, if they remove dependencies or otherwise. Thank you for
your contribution
gaul merged pull request #93:
URL: https://github.com/apache/jclouds/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764754029
Excellent! Thank you very much!
I'll write to the mailing list when I'll have a little more time to work on
removing these dependencies.
gurkerl83 edited a comment on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-760491818
@geomacy
> Does the com.google.common.*;version="[27.1,30.1.0)" declaration mean that
downstream consumers such as Apache Brooklyn will be able to use a range of
geomacy commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-760494893
> Yes it does! Downstream consumers can use versions of guava between
27.1-jre and 30.1-jre in their projects.
Marvellous, I am glad to hear it. Thanks!
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-760491818
@geomacy
> Does the com.google.common.*;version="[27.1,30.1.0)" declaration mean that
downstream consumers such as Apache Brooklyn will be able to use a range of
Guava
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-762705311
BTW are you interested in removing the dependency to `XMLBuilder`?
This adds a dependency to the `com.jamesmurty.utils:java-xmlbuilder` jar and
a transitive dependency to
gaul commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-753996103
@ahgittin I feared that this would impact downstream consumers.
Unfortunately our team lacks the resources to maintain OSGi compatibility. We
will happily accepts PRs that plausibly
gaul merged pull request #94:
URL: https://github.com/apache/jclouds/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770378779
@gaul, thanks for some feedback,
about Guice, the current version in master is 4.2.3; previous to this
version, Guice 3.0 was used.
Guice 3.0 did not use guava as a
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770379549
Thank you for your contribution and patience @gurkerl83!
This is an automated message from the Apache Git Service.
To
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770379503
Let's merge this as-is. While I have concerns about Guava, this PR is
overwhelmingly a step in the right direction. I will send a message to
jclouds-user and see if we can get some
gaul merged pull request #86:
URL: https://github.com/apache/jclouds/pull/86
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gurkerl83 edited a comment on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770378779
@gaul, thanks for some feedback,
about Guice, the current version in master is 4.2.3; previous to this
version, Guice 3.0 was used.
Guice 3.0 did not use
gaul commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-770380475
@korlov42 any chance you could rebase and revisit this PR?
This is an automated message from the Apache Git Service.
gaul opened a new pull request #94:
URL: https://github.com/apache/jclouds/pull/94
This addresses a race condition with filesystem users.
This is an automated message from the Apache Git Service.
To respond to the message,
gurkerl83 edited a comment on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-772592595
@gaul @korlov42 I have rebased the branch and made a pull request here
https://github.com/apache/jclouds/pull/95. I made the respective changes in
labs, lab-aws, and
gurkerl83 edited a comment on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-772862747
@nacx @gaul
This branch is ready for review. Please see the the last two commits
especially. I made the following three PRs for the labs, aws-lab and
lab-openstack
gurkerl83 edited a comment on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-772862747
@nacx @gaul This branch is ready for review. Please see the the last two
commits especially. I made the following three PRs for the labs, aws-lab and
lab-openstack
gurkerl83 commented on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-772862747
@gaul
This branch is ready for review. Please see the the last two commits
especially. I made the following three PRs for the labs, aws-lab and
lab-openstack projects
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-773149658
@gaul this PR is ready for review. It is the first step of a major maven
cleanup, maybe we can provide this for the upcoming release.
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770364529
Sorry about my delayed response. I appreciate breaking out the commits and
I follow the logic from the detailed messages. However I am concerned with
upgrading the Guava version:
601 - 700 of 1083 matches
Mail list logo
