JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-757814524
No, unfortunately I do not have an AWS account, so I can't directly test
myself :(
This is an automated message
gurkerl83 commented on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757946905
@gaul Those things are cleaned up in the following open merge request
https://github.com/project-millipede/jclouds/tree/Maven-Configuration-Cleanup
Please review and merge, thx
gurkerl83 edited a comment on pull request #78:
URL: https://github.com/apache/jclouds/pull/78#issuecomment-757946905
@gaul Those things are cleaned up in the following open merge request
https://github.com/apache/jclouds/pull/86 Please review and merge, thx
-
nacx commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-758507979
@gaul any chance you could run the aws-s3 tests for this PR? I think the
change is safe, but I'm wondering why this very old code manually copied the
ACL objects.
---
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-760491818
@geomacy
> Does the com.google.common.*;version="[27.1,30.1.0)" declaration mean that
downstream consumers such as Apache Brooklyn will be able to use a range of
Guava ver
gurkerl83 edited a comment on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-760491818
@geomacy
> Does the com.google.common.*;version="[27.1,30.1.0)" declaration mean that
downstream consumers such as Apache Brooklyn will be able to use a range of
Gu
geomacy commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-760494893
> Yes it does! Downstream consumers can use versions of guava between
27.1-jre and 30.1-jre in their projects.
Marvellous, I am glad to hear it. Thanks!
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-762705311
BTW are you interested in removing the dependency to `XMLBuilder`?
This adds a dependency to the `com.jamesmurty.utils:java-xmlbuilder` jar and
a transitive dependency to
JnRouvignac edited a comment on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-762705311
BTW are you interested in removing the dependency on `XMLBuilder`?
This adds a dependency to the `com.jamesmurty.utils:java-xmlbuilder` jar and
a transitive depende
gaul merged pull request #93:
URL: https://github.com/apache/jclouds/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaul commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764625057
Successfully ran the integration tests against aws-s3. We are interested in
any OSGi improvements, if they remove dependencies or otherwise. Thank you for
your contribution @JnRouvig
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764754029
Excellent! Thank you very much!
I'll write to the mailing list when I'll have a little more time to work on
removing these dependencies.
gaul merged pull request #93:
URL: https://github.com/apache/jclouds/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaul commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764625057
Successfully ran the integration tests against aws-s3. We are interested in
any OSGi improvements, if they remove dependencies or otherwise. Thank you for
your contribution @JnRouvig
JnRouvignac commented on pull request #93:
URL: https://github.com/apache/jclouds/pull/93#issuecomment-764754029
Excellent! Thank you very much!
I'll write to the mailing list when I'll have a little more time to work on
removing these dependencies.
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770364529
Sorry about my delayed response. I appreciate breaking out the commits and
I follow the logic from the detailed messages. However I am concerned with
upgrading the Guava version:
gurkerl83 commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770378779
@gaul, thanks for some feedback,
about Guice, the current version in master is 4.2.3; previous to this
version, Guice 3.0 was used.
Guice 3.0 did not use guava as a d
gurkerl83 edited a comment on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770378779
@gaul, thanks for some feedback,
about Guice, the current version in master is 4.2.3; previous to this
version, Guice 3.0 was used.
Guice 3.0 did not use guava
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770379549
Thank you for your contribution and patience @gurkerl83!
This is an automated message from the Apache Git Service.
To r
gaul commented on pull request #86:
URL: https://github.com/apache/jclouds/pull/86#issuecomment-770379503
Let's merge this as-is. While I have concerns about Guava, this PR is
overwhelmingly a step in the right direction. I will send a message to
jclouds-user and see if we can get some t
gaul merged pull request #86:
URL: https://github.com/apache/jclouds/pull/86
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaul commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-770380475
@korlov42 any chance you could rebase and revisit this PR?
This is an automated message from the Apache Git Service.
To
gaul opened a new pull request #94:
URL: https://github.com/apache/jclouds/pull/94
This addresses a race condition with filesystem users.
This is an automated message from the Apache Git Service.
To respond to the message, pl
gaul merged pull request #94:
URL: https://github.com/apache/jclouds/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gurkerl83 opened a new pull request #95:
URL: https://github.com/apache/jclouds/pull/95
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaul opened a new pull request #96:
URL: https://github.com/apache/jclouds/pull/96
Paths created by Files.createParentDirs lack extended attributes and
thus Content-Type for directories.
This is an automated message from t
gurkerl83 opened a new pull request #6:
URL: https://github.com/apache/jclouds-labs/pull/6
The JClouds project module upgrades the okhttp server library and related
dependencies such as mockwebserver from 2.2.0 to 3.14.9. The vendor switched
the groupId declaration from com.squareup.okhttp
gurkerl83 opened a new pull request #2:
URL: https://github.com/apache/jclouds-labs-aws/pull/2
The JClouds project module upgrades the okhttp server library and related
dependencies such as mockwebserver from 2.2.0 to 3.14.9. The vendor switched
the groupId declaration from com.squareup.ok
gurkerl83 opened a new pull request #3:
URL: https://github.com/apache/jclouds-labs-openstack/pull/3
The JClouds project module upgrades the okhttp server library and related
dependencies such as mockwebserver from 2.2.0 to 3.14.9. The vendor switched
the groupId declaration from com.squar
gaul merged pull request #96:
URL: https://github.com/apache/jclouds/pull/96
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gurkerl83 commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-772592595
@gaul @korlov42 I have rebased the branch and made a pull request here
https://github.com/apache/jclouds/pull/95. I made the respective changes in
labs, lab-aws, and lab-opencore.
gurkerl83 edited a comment on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-772592595
@gaul @korlov42 I have rebased the branch and made a pull request here
https://github.com/apache/jclouds/pull/95. I made the respective changes in
labs, lab-aws, and lab-op
gurkerl83 commented on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-772862747
@gaul
This branch is ready for review. Please see the the last two commits
especially. I made the following three PRs for the labs, aws-lab and
lab-openstack projects whic
gurkerl83 edited a comment on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-772862747
@nacx @gaul
This branch is ready for review. Please see the the last two commits
especially. I made the following three PRs for the labs, aws-lab and
lab-openstack proj
gurkerl83 edited a comment on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-772862747
@nacx @gaul This branch is ready for review. Please see the the last two
commits especially. I made the following three PRs for the labs, aws-lab and
lab-openstack projects
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-773149658
@gaul this PR is ready for review. It is the first step of a major maven
cleanup, maybe we can provide this for the upcoming release.
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-773149658
@gaul this PR is ready for review. It is the first step of a major maven
cleanup, maybe we can provide this for the upcoming release.
gurkerl83 commented on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-775108641
@gau Is it possible that you can review this anytime soon, do you have a
data in mind when you want to build the release?
gurkerl83 edited a comment on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-775108641
@gau Is it possible that you can review this anytime soon, do you have a
specific date in mind when you want to build the release?
gurkerl83 commented on pull request #84:
URL: https://github.com/apache/jclouds/pull/84#issuecomment-776624557
@gaul A few days ago I made all required changes. Please see all available
merge requests first because the current merge request is outdated. Thx!
--
gaul closed pull request #84:
URL: https://github.com/apache/jclouds/pull/84
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaul merged pull request #2:
URL: https://github.com/apache/jclouds-labs-aws/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gaul merged pull request #6:
URL: https://github.com/apache/jclouds-labs/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gaul merged pull request #3:
URL: https://github.com/apache/jclouds-labs-openstack/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gaul merged pull request #95:
URL: https://github.com/apache/jclouds/pull/95
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gaul commented on pull request #95:
URL: https://github.com/apache/jclouds/pull/95#issuecomment-778096989
@gurkerl83 Thanks for your contributions and continued patience -- I hope to
start the release after merging a few more outstanding PRs.
--
gaul commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778098753
@nacx Any comments on this PR?
This is an automated message from the Apache Git Service.
To respond to the message, ple
nacx commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778117050
This LGTM from the peanut gallery, but we need to make sure the Jenkins
builds (which we use to run the release) get back to green:
https://ci-builds.apache.org/job/JClouds/
--
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778124116
@nacx @gaul The jenkin builds for jclouds is green, for lab lab-aws and
lab-openstack they are not right now. The reason is the merge order. Okhttp was
updated in the project modu
gurkerl83 edited a comment on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778124116
@nacx @gaul The jenkins builds for jclouds is green, for labs, lab-aws and
lab-openstack they are not right now. The reason is the merge order. Okhttp was
updated in the pr
gurkerl83 edited a comment on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778124116
@nacx @gaul The jenkins builds for jclouds is green, for labs, lab-aws and
lab-openstack they are not right now. The reason is the merge order. Okhttp was
updated in the pr
nacx commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778157607
The labs builds are triggered automatically after the main one completes,
and they're back to green :)
BTW, given that you're here, the [compact
build](https://ci-builds.apache.
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778192955
One commit made in this pull request removed the maven jenkins profile
https://github.com/apache/jclouds/pull/91/commits/1d40dd974fe49f85afb0b5407e81b90087f898db.
I was pretty sur
nacx edited a comment on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778157607
The labs builds are triggered automatically after the main one completes,
and they're back to green :)
BTW, given that you're here, the [compat
build](https://ci-builds.a
nacx commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778199015
Ok, I've updated the build matrix to reflect this:
https://ci-builds.apache.org/job/JClouds/job/jclouds-compat/
This i
gurkerl83 commented on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778223772
It seems the build is only successful with JDK 8. During my work in JClouds
I have not compiled it with a higher version locally. Maybe JDK 9 and higher do
not work because the JC
gurkerl83 edited a comment on pull request #91:
URL: https://github.com/apache/jclouds/pull/91#issuecomment-778223772
@nacx @gaul It seems the build is successful with JDK 8. During my work in
JClouds, I have not compiled it with a higher version locally. Maybee JDK 9 and
higher do not wor
gaul merged pull request #91:
URL: https://github.com/apache/jclouds/pull/91
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
radito3 commented on pull request #89:
URL: https://github.com/apache/jclouds/pull/89#issuecomment-784260577
@gaul Could you take another look at the updated changes?
This is an automated message from the Apache Git Service.
gaul commented on pull request #89:
URL: https://github.com/apache/jclouds/pull/89#issuecomment-787423235
Have you run the integration tests? When testing against azureblob I see:
```
$ mvn integration-test -pl :azureblob -Plive
-Dtest.azureblob.identity="${JCLOUDS_IDENTITY}"
-D
gaul commented on a change in pull request #89:
URL: https://github.com/apache/jclouds/pull/89#discussion_r584266806
##
File path:
apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java
##
@@ -638,22 +639,45 @@ protected Str
JnRouvignac opened a new pull request #97:
URL: https://github.com/apache/jclouds/pull/97
BindBucketLoggingToXmlPayloadTest.java:
Avoid using the guice injector which triggers an NPE
This is an automated message from the A
JnRouvignac opened a new pull request #98:
URL: https://github.com/apache/jclouds/pull/98
XMLBuilder is a very nice fluent API for building XML documents.
However, it is only used by a tiny portion of jclouds: the s3 api. The
use of the XMLBuilder class requires a dependency to
com.
nacx commented on pull request #97:
URL: https://github.com/apache/jclouds/pull/97#issuecomment-787852179
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
nacx merged pull request #97:
URL: https://github.com/apache/jclouds/pull/97
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
nacx commented on pull request #98:
URL: https://github.com/apache/jclouds/pull/98#issuecomment-787857147
LGTM. Thanks! Can you rebase so the build runs including your change in
https://github.com/apache/jclouds/pull/97, which introduces the test for the
ACL binder?
-
JnRouvignac commented on pull request #98:
URL: https://github.com/apache/jclouds/pull/98#issuecomment-787883512
Of course! Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log
nacx commented on pull request #98:
URL: https://github.com/apache/jclouds/pull/98#issuecomment-787970966
Thx!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
nacx merged pull request #98:
URL: https://github.com/apache/jclouds/pull/98
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
radito3 commented on a change in pull request #89:
URL: https://github.com/apache/jclouds/pull/89#discussion_r585333994
##
File path:
apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java
##
@@ -638,22 +639,45 @@ protected
nacx opened a new pull request #16:
URL: https://github.com/apache/jclouds-site/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nacx merged pull request #16:
URL: https://github.com/apache/jclouds-site/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
JnRouvignac opened a new pull request #99:
URL: https://github.com/apache/jclouds/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gurkerl83 commented on pull request #99:
URL: https://github.com/apache/jclouds/pull/99#issuecomment-792720481
@JnRouvignac We should not do this right now. In
https://github.com/apache/jclouds/pull/78 we agreed we pin the version of GSON
to 2.8.5. To identify the related parts in the merg
JnRouvignac closed pull request #99:
URL: https://github.com/apache/jclouds/pull/99
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JnRouvignac commented on pull request #99:
URL: https://github.com/apache/jclouds/pull/99#issuecomment-792736219
Oops, sorry I did not know about it.
Thanks for the heads-up!
This is an automated message from the Apache Gi
nacx commented on pull request #99:
URL: https://github.com/apache/jclouds/pull/99#issuecomment-792803485
@gurkerl83 could you add a small comment in the `pom.xml` next to the gson
version explaining the current constraints and why we're pinning it to that
version? That could help readers
radito3 commented on pull request #89:
URL: https://github.com/apache/jclouds/pull/89#issuecomment-796749819
@gaul I had a mistake that introduced those failures in the tests. The
`Payload` that was created for each slice of the content didn't include its
part size in the metadata. I added
JnRouvignac opened a new pull request #100:
URL: https://github.com/apache/jclouds/pull/100
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
gaul opened a new pull request #101:
URL: https://github.com/apache/jclouds/pull/101
This addresses issues seen with more recent Java and Maven versions.
Enabled by requiring Java 8. Also suppress several new warnings and
remove stale ones. This commit also adds the missing jaxb and
gaul commented on pull request #101:
URL: https://github.com/apache/jclouds/pull/101#issuecomment-803514740
This need some more investigation. The intent is to make modern Java and
Maven versions work by default since otherwise I need to specify older ones on
my desktop. I believe that e
gaul commented on pull request #101:
URL: https://github.com/apache/jclouds/pull/101#issuecomment-803521723
Alternatively we can just specify openjdk11 for travis.yml. Note that this
would not change any of the user requirements for jclouds.
--
This is an automated message from the Apac
gaul commented on pull request #100:
URL: https://github.com/apache/jclouds/pull/100#issuecomment-803522311
Did you make these changes in some automated fashion? I am not sure how I
would review this in any sane way.
I would also caution that these kinds of formatting changes are ha
JnRouvignac commented on pull request #100:
URL: https://github.com/apache/jclouds/pull/100#issuecomment-803525261
Ok. I wondered if that was too much to take. Apparently it is.
What I can do is submit one PR per commit and make sure to only submit
changes that are 100% automated and exp
JnRouvignac closed pull request #100:
URL: https://github.com/apache/jclouds/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
gurkerl83 commented on pull request #101:
URL: https://github.com/apache/jclouds/pull/101#issuecomment-803575347
I am open to using source code quality assurance tools; however, I have a
few requirements for integrating and configured them into a project.
The following points relate
JnRouvignac opened a new pull request #102:
URL: https://github.com/apache/jclouds/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
Mahir92 commented on pull request #63:
URL: https://github.com/apache/jclouds/pull/63#issuecomment-808488282
Hi @gaul , a JIRA issue has been created at -
https://issues.apache.org/jira/browse/JCLOUDS-1570 . Please let us know your
feedback.
--
This is an automated message from the Apac
timuralp opened a new pull request #103:
URL: https://github.com/apache/jclouds/pull/103
When parsing S3 ListBuckets responses, jclouds should not implicitly
assume that the owner ID comes first when parsing the XML document. The
assumption triggers NullPointerException against Digital
gaul commented on a change in pull request #103:
URL: https://github.com/apache/jclouds/pull/103#discussion_r606733441
##
File path: apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java
##
@@ -56,9 +57,18 @@ public ListAllMyBucketsHandler(DateService dateParser
gaul commented on a change in pull request #103:
URL: https://github.com/apache/jclouds/pull/103#discussion_r606733441
##
File path: apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java
##
@@ -56,9 +57,18 @@ public ListAllMyBucketsHandler(DateService dateParser
timuralp commented on a change in pull request #103:
URL: https://github.com/apache/jclouds/pull/103#discussion_r606745485
##
File path: apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java
##
@@ -56,9 +57,18 @@ public ListAllMyBucketsHandler(DateService datePa
timuralp commented on a change in pull request #103:
URL: https://github.com/apache/jclouds/pull/103#discussion_r606745485
##
File path: apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java
##
@@ -56,9 +57,18 @@ public ListAllMyBucketsHandler(DateService datePa
timuralp commented on a change in pull request #103:
URL: https://github.com/apache/jclouds/pull/103#discussion_r606752482
##
File path: apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java
##
@@ -56,9 +57,18 @@ public ListAllMyBucketsHandler(DateService datePa
gaul commented on pull request #103:
URL: https://github.com/apache/jclouds/pull/103#issuecomment-813014357
Thank you for your contribution @timuralp!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
gaul merged pull request #103:
URL: https://github.com/apache/jclouds/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
gaul opened a new pull request #104:
URL: https://github.com/apache/jclouds/pull/104
This does strange things with the java compiler which makes it
incompatible with more modern Java versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
gaul commented on pull request #104:
URL: https://github.com/apache/jclouds/pull/104#issuecomment-819571228
@gurkerl83 jclouds needs some more work with javax.annotation and
javax.xml.bind to compile with Java 11 but this is a step in the right
direction.
--
This is an automated message
gurkerl83 commented on pull request #104:
URL: https://github.com/apache/jclouds/pull/104#issuecomment-819574678
@gaul I totally agree with the decision to remove error-prone, it makes
things simpler. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the mes
gaul commented on pull request #101:
URL: https://github.com/apache/jclouds/pull/101#issuecomment-819574768
Let's revisit this after fixing the Java compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
701 - 800 of 1112 matches
Mail list logo
