HaoYang670 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1711098104
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContex
pan3793 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1711064538
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContext
HaoYang670 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1710994235
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContex
HaoYang670 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1710992272
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContex
pan3793 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1710980527
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContext
HaoYang670 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1710962039
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -286,24 +288,38 @@ private[v1] class AdminResource extends ApiRequestContex
pan3793 commented on PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#issuecomment-2186496427
Please don't forget to update the RESTful API docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
pan3793 commented on PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#issuecomment-2186494924
the failed UTs are related, because this PR appends a new configuration to
the engine launch command, they should be easy to debug.
--
This is an automated message from the Apache Git Se
pan3793 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1650968520
##
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/AdminResource.scala:
##
@@ -277,7 +278,8 @@ private[v1] class AdminResource extends ApiRequestContext
wi
pan3793 commented on code in PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#discussion_r1650966184
##
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##
@@ -3544,7 +3544,12 @@ object KyuubiConf {
.version("1.8.0")
.stringConf
pan3793 commented on PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#issuecomment-2182045326
@turboFei @zhaohehuhu Sorry for forgetting this one, the new approach lgtm,
let fix the UT the get it in.
--
This is an automated message from the Apache Git Service.
To respond to the m
turboFei commented on PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#issuecomment-2094912825
How about register the app mgr into to discovery service?
https://github.com/apache/kyuubi/pull/6360/commits/4cf2852ebb2343a47c7e5a182a58832076c0255b
--
This is an automated mess
pan3793 commented on PR #6008:
URL: https://github.com/apache/kyuubi/pull/6008#issuecomment-2065659264
a little bit concern about the design, which exposed too many details to end
users, let me think this weekend
--
This is an automated message from the Apache Git Service.
To respond to t
13 matches
Mail list logo
