[I] LoggerContext.selector sometimes not working (logging-log4j2)

2023-12-20 Thread via GitHub
onlinee opened a new issue, #2116: URL: https://github.com/apache/logging-log4j2/issues/2116 I have set System.setProperty(Log4jPropertyKey.CONTEXT_SELECTOR_CLASS_NAME.getSystemKey(), AsyncLoggerContextSelector.class.getCanonicalName()); before LogManager.getLogger. sometimes it wo

Re: [PR] Recycler API (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on PR #1401: URL: https://github.com/apache/logging-log4j2/pull/1401#issuecomment-1865764460 > Since we are introducing new interfaces and static register classes in `log4j-api`, I think we should take some time to choose were to "hide" those classes to minimize the disruption

Re: [PR] Workaround Coursier/Ivy dependency resolution bug (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on PR #2113: URL: https://github.com/apache/logging-log4j2/pull/2113#issuecomment-1865753485 > To test this solution I used... @ppkarwasz, I wasn't questioning whether your solution fixes the user-reported problem or not. I have no doubts you did your due diligence for t

Re: [PR] Bump jakarta.inject:jakarta.inject-api from 1.0.5 to 2.0.1 [logging-log4j-tools]

2023-12-20 Thread via GitHub
dependabot[bot] commented on PR #94: URL: https://github.com/apache/logging-log4j-tools/pull/94#issuecomment-1865704348 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ver

Re: [PR] Bump jakarta.inject:jakarta.inject-api from 1.0.5 to 2.0.1 [logging-log4j-tools]

2023-12-20 Thread via GitHub
github-actions[bot] commented on PR #94: URL: https://github.com/apache/logging-log4j-tools/pull/94#issuecomment-1865704194 Changes are applied by CI in 736bc4bacefdc67fccada6530d523371097e4d6a -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump jakarta.inject:jakarta.inject-api from 1.0.5 to 2.0.1 [logging-log4j-tools]

2023-12-20 Thread via GitHub
github-actions[bot] closed pull request #94: Bump jakarta.inject:jakarta.inject-api from 1.0.5 to 2.0.1 URL: https://github.com/apache/logging-log4j-tools/pull/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Bump jakarta.inject:jakarta.inject-api from 1.0.5 to 2.0.1 [logging-log4j-tools]

2023-12-20 Thread via GitHub
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/logging-log4j-tools/pull/94 Bumps [jakarta.inject:jakarta.inject-api](https://github.com/eclipse-ee4j/injection-api) from 1.0.5 to 2.0.1. Release notes Sourced from https://github.com/eclipse-ee4j/injec

Re: [I] The `immediateFlush` option in both rolling file appenders is ignored (logging-log4j2)

2023-12-20 Thread via GitHub
tcmot commented on issue #2025: URL: https://github.com/apache/logging-log4j2/issues/2025#issuecomment-1865683467 Hi, ``` RandomAccessFile FileChannel channel = randomAccessFile.getChannel(); randomAccessFile.write(); channel.force(true); ``` Use the force method,t

[PR] Improve benchmark test descriptions and simplify code [logging-log4cxx]

2023-12-20 Thread via GitHub
swebb2066 opened a new pull request, #317: URL: https://github.com/apache/logging-log4cxx/pull/317 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] Fix Scala 3 macros for Message [logging-log4j-scala]

2023-12-20 Thread via GitHub
kojunho7 opened a new pull request, #40: URL: https://github.com/apache/logging-log4j-scala/pull/40 Without the delegate, it causes a recursive inline method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] Add committer to changelog entry structure [logging-log4j-tools]

2023-12-20 Thread via GitHub
ppkarwasz commented on issue #69: URL: https://github.com/apache/logging-log4j-tools/issues/69#issuecomment-1865155254 Since even `` became optional in version 0.1.2 of the schema, we can close this. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Add committer to changelog entry structure [logging-log4j-tools]

2023-12-20 Thread via GitHub
ppkarwasz closed issue #69: Add committer to changelog entry structure URL: https://github.com/apache/logging-log4j-tools/issues/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Generate reference documentation and XSD from metadata (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on issue #1955: URL: https://github.com/apache/logging-log4j2/issues/1955#issuecomment-1865137086 With the submission of the PRs above, I consider this subtask complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Generate reference documentation and XSD from metadata (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz closed issue #1955: Generate reference documentation and XSD from metadata URL: https://github.com/apache/logging-log4j2/issues/1955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Add FreeMarker documentation generator [logging-log4j-tools]

2023-12-20 Thread via GitHub
ppkarwasz opened a new pull request, #93: URL: https://github.com/apache/logging-log4j-tools/pull/93 Adds an documentation generator that uses - an XML metadata file as input (cf. `log4j-docgen/src/test/resources/META-INF/log4j/plugins-sample.xml` as example), - a set of FreeMark

[PR] Add an XML schema generator [logging-log4j-tools]

2023-12-20 Thread via GitHub
ppkarwasz opened a new pull request, #92: URL: https://github.com/apache/logging-log4j-tools/pull/92 Adds an XML schema generator that uses an XML metadata file as input (cf. `log4j-docgen/src/test/resources/META-INF/log4j/plugins-sample.xml` as example) and output an XML schema. ##

Re: [PR] Fix NPE caused by MDCContextMap (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on PR #2115: URL: https://github.com/apache/logging-log4j2/pull/2115#issuecomment-1865090948 Closes #1426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Fix NPE caused by MDCContextMap (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz opened a new pull request, #2115: URL: https://github.com/apache/logging-log4j2/pull/2115 Fixes an NPE caused by `MDCContextMap`: the [`MDC#getCopyOfContextMap`](https://www.slf4j.org/api/org/slf4j/MDC.html#getCopyOfContextMap--) method can return `null`, but [`ThreadContextMap#g

Re: [PR] Workaround Coursier/Ivy dependency resolution bug (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on PR #2113: URL: https://github.com/apache/logging-log4j2/pull/2113#issuecomment-1864883848 To test this solution I used a micro SBT project with `build.sbt` file: ```scala val scala3Version = "3.3.1" lazy val root = project .in(file(".")) .sett

[jira] [Resolved] (LOG4J2-3093) Nashorn-based plugins no longer supported in Java 15+ due to JEP 372

2023-12-20 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3093. --- Resolution: Not A Problem > Nashorn-based plugins no longer supported in Java 15+ due to JEP

[jira] [Closed] (LOG4J2-3093) Nashorn-based plugins no longer supported in Java 15+ due to JEP 372

2023-12-20 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3093. - > Nashorn-based plugins no longer supported in Java 15+ due to JEP 372 > ---

Re: [PR] Workaround Coursier/Ivy dependency resolution bug (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on PR #2113: URL: https://github.com/apache/logging-log4j2/pull/2113#issuecomment-1864732831 I have doubts about this fix @ppkarwasz. It is not even reported to the source AFAIK. I am also curious how can we be certain that our solution is exhaustive? Maybe dumb, but an

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432890483 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundati

Re: [I] MDCContextMap::getCopy can return null causing an NPE in CloseableThreadContext (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on issue #1426: URL: https://github.com/apache/logging-log4j2/issues/1426#issuecomment-1864270470 @benkeil, Can you provide a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432552916 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerDisruptor.java: ## @@ -122,7 +122,7 @@ public Thread newThread(final Runnable r) {

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432552233 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler.java: ## @@ -26,59 +25,12 @@ * controlled by the {@code Executor} p

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432544750 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software F

[PR] Fix NPE in `RollingFileManger` (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz opened a new pull request, #2114: URL: https://github.com/apache/logging-log4j2/pull/2114 This PR fixes a `NullPointerException` in `RollingFileManager#createParentDir`. Closes #1645 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432448005 ## log4j-jpl/pom.xml: ## @@ -65,29 +65,26 @@ - - - java8-tests - - - env.CI - true - - -

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432444182 ## log4j-core-test/pom.xml: ## @@ -371,6 +375,32 @@ + +org.apache.maven.plugins +maven-surefire-plugin + +

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432378086 ## log4j-core-test/pom.xml: ## @@ -371,6 +375,32 @@ + +org.apache.maven.plugins +maven-surefire-plugin + +

[PR] Workaround Coursier/Ivy dependency resolution bug (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz opened a new pull request, #2113: URL: https://github.com/apache/logging-log4j2/pull/2113 Workaround a Coursier/Ivy dependency resolution bug that affects `log4j-slf4j-impl` and `log4j-mongodb3`. This bug also affects popular sites like MvnRepository (cf. [`log4j-mongodb3:2