[GitHub] [logging-log4j2] yueki1993 commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

2022-06-11 Thread GitBox
yueki1993 commented on code in PR #924: URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894992070 ## log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/LevelRangeFilterBuilder.java: ## @@ -83,19 +86,23 @@ public Filter parse(PropertiesConfiguration

[GitHub] [logging-log4j2] yueki1993 commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

2022-06-10 Thread GitBox
yueki1993 commented on code in PR #924: URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894062873 ## log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java: ## @@ -129,6 +129,28 @@ public void

[GitHub] [logging-log4j2] yueki1993 commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

2022-06-10 Thread GitBox
yueki1993 commented on code in PR #924: URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894211536 ## log4j-1.2-api/src/main/java/org/apache/log4j/builders/filter/LevelRangeFilterBuilder.java: ## @@ -83,19 +86,23 @@ public Filter parse(PropertiesConfiguration

[GitHub] [logging-log4j2] yueki1993 commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

2022-06-09 Thread GitBox
yueki1993 commented on code in PR #924: URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894062873 ## log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java: ## @@ -129,6 +129,28 @@ public void

[GitHub] [logging-log4j2] yueki1993 commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

2022-06-09 Thread GitBox
yueki1993 commented on code in PR #924: URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r894062873 ## log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java: ## @@ -129,6 +129,28 @@ public void

[GitHub] [logging-log4j2] yueki1993 commented on a diff in pull request #924: [LOG4J2-3534] Fix LevelRangeFilterBuilder to align with log4j1's behavior

2022-06-09 Thread GitBox
yueki1993 commented on code in PR #924: URL: https://github.com/apache/logging-log4j2/pull/924#discussion_r893542193 ## log4j-1.2-api/src/test/java/org/apache/log4j/config/PropertiesConfigurationTest.java: ## @@ -326,4 +326,9 @@ public void testEnhancedRollingFileAppender()