Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-10-29 Thread via GitHub
grgrzybek commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1784573202 > @grgrzybek, > > Thank You for your detailed comment. > > > I have two things. > > > > 1. [[2.2.x] Upgrade to Log4j2 2.21.0 ops4j/org.ops4j.pax.logging#535](

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-10-25 Thread via GitHub
ppkarwasz commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1778889957 @grgrzybek, Thank You for your detailed comment. > I have two things. > > 1. [[2.2.x] Upgrade to Log4j2 2.21.0 ops4j/org.ops4j.pax.logging#535](https://github

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-10-20 Thread via GitHub
grgrzybek commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1772312957 The problem with OSGi headers generated into bundles' `META-INF/MANIFEST.MF` is that we can't simply verify them by looking at them ;) In my experience I had a lot of problems

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-10-03 Thread via GitHub
grgrzybek commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1744353509 Sure sure, I remember - I have this tab opened to comment at some point, but I have very tight schedule recently... -- This is an automated message from the Apache Git Service.

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-10-02 Thread via GitHub
ppkarwasz commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1743022699 @grgrzybek @HannesWell, I have merged these changes into the `bnd` branch (#1819), which offers a more global view of all modules. However please feel free to add co

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-10-02 Thread via GitHub
ppkarwasz merged PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-28 Thread via GitHub
HannesWell commented on code in PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#discussion_r1340132628 ## log4j-to-slf4j/pom.xml: ## @@ -89,19 +89,5 @@ test - - - -org.apache.felix -maven-bundle-plugin - -

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-28 Thread via GitHub
ppkarwasz commented on code in PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#discussion_r1340083671 ## log4j-to-slf4j/pom.xml: ## @@ -89,19 +89,5 @@ test - - - -org.apache.felix -maven-bundle-plugin - -

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-28 Thread via GitHub
ppkarwasz commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1739071252 > ``` > osgi.serviceloader;filter:="(osgi.serviceloader=org.apache.logging.log4j.message.ThreadDumpMessage$ThreadInfoFactory)";osgi.serviceloader="org.apache.logging.log4j.mess

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-28 Thread via GitHub
HannesWell commented on code in PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#discussion_r1340007931 ## log4j-to-slf4j/pom.xml: ## @@ -89,19 +89,5 @@ test - - - -org.apache.felix -maven-bundle-plugin - -

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-26 Thread via GitHub
ppkarwasz commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1736300529 > I assume the annotations are source-only or at least optional in general (as annotations tend to be when the interpreter for said annotations isn't available). The have

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-26 Thread via GitHub
grgrzybek commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1735870194 I'll have a look soon. Please give me some time to check and comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-26 Thread via GitHub
HannesWell commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1735774495 > > You didn't mention the exports in the initial message, but I assume `org.apache.logging.log4j.internal` is exported from log4j-api's MANIFEST.MF, isn't it? Is that intention

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-26 Thread via GitHub
ppkarwasz commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1735629835 @HannesWell , > You didn't mention the exports in the initial message, but I assume `org.apache.logging.log4j.internal` is exported from log4j-api's MANIFEST.MF, isn't it?

Re: [PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-26 Thread via GitHub
HannesWell commented on PR #1820: URL: https://github.com/apache/logging-log4j2/pull/1820#issuecomment-1735573097 > Differences in the OSGi descriptor: > * the import statement on `sun.reflect` disappears, > * an import statement on `org.apache.logging.log4j.internal` appears. Yo

[PR] Add BND configuration for `log4j-api` (logging-log4j2)

2023-09-26 Thread via GitHub
ppkarwasz opened a new pull request, #1820: URL: https://github.com/apache/logging-log4j2/pull/1820 This PR performs the necessary changes to switch `log4j-api` from `maven-bundle-plugin` and a manually written `module-info.java` to `bnd-maven-plugin`. ## Before In version 2.2