Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2024-01-24 Thread via GitHub
ppkarwasz commented on PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#issuecomment-1907892530 @Alanoudj, The `log4j-api` version 2.23.0 artifact will be used by both Log4j Core 2.23.0 and Log4j Core 3.0.0-beta2, so the ETA for 2.23.0 is around end of February. --

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2024-01-24 Thread via GitHub
Alanoudj commented on PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#issuecomment-1907866862 Do you have any deadline for 2.23.0 version release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2024-01-23 Thread via GitHub
vy commented on PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#issuecomment-1905838256 @Alanoudj, this will be made available in `2.23.0`. Log4j 3 will use Disruptor 4, there Disruptor 3 is completely removed. -- This is an automated message from the Apache Git Se

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2024-01-23 Thread via GitHub
Alanoudj commented on PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#issuecomment-1905758351 Hi @ppkarwasz, thank you for fixing this but I can't see the new version in the released notes? https://logging.apache.org/log4j/2.x/release-notes.html Or we should wait

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-27 Thread via GitHub
ppkarwasz merged PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432890483 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432552916 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerDisruptor.java: ## @@ -122,7 +122,7 @@ public Thread newThread(final Runnable r) {

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432552233 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler.java: ## @@ -26,59 +25,12 @@ * controlled by the {@code Executor} p

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432544750 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/RingBufferLogEventHandler4.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432448005 ## log4j-jpl/pom.xml: ## @@ -65,29 +65,26 @@ - - - java8-tests - - - env.CI - true - - -

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
ppkarwasz commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432444182 ## log4j-core-test/pom.xml: ## @@ -371,6 +375,32 @@ + +org.apache.maven.plugins +maven-surefire-plugin + +

Re: [PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-20 Thread via GitHub
vy commented on code in PR #2112: URL: https://github.com/apache/logging-log4j2/pull/2112#discussion_r1432378086 ## log4j-core-test/pom.xml: ## @@ -371,6 +375,32 @@ + +org.apache.maven.plugins +maven-surefire-plugin + +

[PR] Add support for LMAX Disruptor 4.x (logging-log4j2)

2023-12-19 Thread via GitHub
ppkarwasz opened a new pull request, #2112: URL: https://github.com/apache/logging-log4j2/pull/2112 This PR is based on #1937 and adds support for LMAX Disruptor 4.x by: - splitting our `EventHandler` classes into two versions: one for 3.x and 4.x, - using the original `TimeoutBloc