Re: [PR] Open `FileExtension` accessors (#1365) (logging-log4j2)

2023-10-11 Thread via GitHub
vy merged PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Open `FileExtension` accessors (#1365) (logging-log4j2)

2023-10-11 Thread via GitHub
vy commented on PR #1683: URL: https://github.com/apache/logging-log4j2/pull/1683#issuecomment-1757031463 @Karthi1711, I am fine with these changes; except the `length()`. Let's keep the opened up methods to minimum: `createCompressAction()` and `getExtension()` are fine, but we don't need