[jira] [Commented] (MYNEWT-858) Test package lflags ignored by `newt test`
[
https://issues.apache.org/jira/browse/MYNEWT-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349710#comment-16349710
]
ASF GitHub Bot commented on MYNEWT-858:
---
ccollins476ad opened a new pull request #133: MYNEWT-858 Collect all package
lflags during link.
URL: https://github.com/apache/mynewt-newt/pull/133
If you add the following to a test package:
```
pkg.lflags:
- "-foo"
```
and then test the package with `newt test`, the flag does not get passed to
gcc during linking.
Newt currently only reads lflags from the following package types:
* target
* app
* bsp
* compiler
Now, all packages' lflags are collected and specified during linking.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Test package lflags ignored by `newt test`
> --
>
> Key: MYNEWT-858
> URL: https://issues.apache.org/jira/browse/MYNEWT-858
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
>Reporter: Christopher Collins
>Assignee: Sterling Hughes
>Priority: Major
> Fix For: v1_4_0_rel
>
>
> If you add the following to a test package:
> {noformat}
> pkg.lflags:
> - "-foo"
> {noformat}
> and then test the package with `newt test`, the flag does not get passed to
> gcc during linking.
> Newt currently only reads lflags from the following package types:
> * target
> * app
> * bsp
> * compiler
> At the very least, the test package's lflags should be used when a unit test
> is linked via {{newt test}}. Alternatively, it may make more sense to gather
> the lflags from all constituent packages during the link phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (MYNEWT-843) BLE Host - Missing local IRK functionality
[ https://issues.apache.org/jira/browse/MYNEWT-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Collins resolved MYNEWT-843. Resolution: Fixed Fixed in https://github.com/apache/mynewt-core/pull/593 > BLE Host - Missing local IRK functionality > -- > > Key: MYNEWT-843 > URL: https://issues.apache.org/jira/browse/MYNEWT-843 > Project: Mynewt > Issue Type: Bug > Security Level: Public(Viewable by anyone) > Components: Nimble >Reporter: Christopher Collins >Priority: Major > > The host needs a few improvements involving the local identity resolving key > (IRK): > 1. Expose function to set the local IRK to a specified value > (`ble_hs_test_util_set_our_irk()` is currently private). > 2. Create a function to randomly generate a new IRK. > 3. When a new local IRK is created, automatically persist it to the store. > 4. On startup, restore the persisted IRK from the store. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MYNEWT-873) newt crashes during 'newt install'
[ https://issues.apache.org/jira/browse/MYNEWT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Collins resolved MYNEWT-873. Resolution: Fixed > newt crashes during 'newt install' > -- > > Key: MYNEWT-873 > URL: https://issues.apache.org/jira/browse/MYNEWT-873 > Project: Mynewt > Issue Type: Bug > Security Level: Public(Viewable by anyone) > Components: Newt >Affects Versions: v1_3_0_rel >Reporter: Marko Kiiskila >Assignee: Sterling Hughes >Priority: Major > > There might, or might not have been, an attempt to run 'newt install' before > for this project. > Network was slow, so they might've stopped the fetch in the middle. But I'm > not certain > of that. > nu@mc-117:~/myproj$ newt install > panic: runtime error: invalid memory address or nil pointer dereference > [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x75d4ce] > goroutine 1 [running]: > mynewt.apache.org/newt/newt/repo.(*Version).ToNuVersion(...) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/version.go:162 > mynewt.apache.org/newt/newt/repo.(*Repo).CheckNewtCompatibility(0xc420094e10, > 0x0, 0x1, 0x2, 0x0, 0x0, 0x0, 0x1) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/repo.go:796 > +0x5e > mynewt.apache.org/newt/newt/project.(*Project).loadRepo(0xc420064ae0, > 0xc4200157a0, 0x12, 0xc4200cc0e0, 0x1, 0x1) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:427 > +0x51c > mynewt.apache.org/newt/newt/project.(*Project).loadConfig(0xc420064ae0, 0x0, > 0xc42007dbc0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:505 > +0x421 > mynewt.apache.org/newt/newt/project.(*Project).Init(0xc420064ae0, > 0xc420014184, 0x10, 0x1c, 0x8363c0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:544 > +0xed > mynewt.apache.org/newt/newt/project.NewProject(0xc420014184, 0x10, > 0xc420014184, 0x10, 0x0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:135 > +0x58 > mynewt.apache.org/newt/newt/project.LoadProject(0xc420014184, 0x10, > 0xc420057bd8, 0xc420062080, 0xc42180) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:719 > +0x7d > mynewt.apache.org/newt/newt/project.initProject(0xc420014184, 0x10, > 0xc420014184, 0x10) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:74 > +0x39 > mynewt.apache.org/newt/newt/project.initialize(0x4, 0xc420057c90) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:92 > +0x89 > mynewt.apache.org/newt/newt/project.TryGetProject(0x4, 0xc420019138, 0x4) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:100 > +0x22 > mynewt.apache.org/newt/newt/cli.TryGetProject(0x0) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/cli/util.go:208 > +0x26 > mynewt.apache.org/newt/newt/cli.installRunCmd(0xc420161200, 0xb6fcf8, 0x0, > 0x0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/cli/project_cmds.go:76 > +0x26 > mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra.(*Command).execute(0xc420161200, > 0xb6fcf8, 0x0, 0x0, 0xc420161200, 0xb6fcf8) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra/command.go:636 > +0x234 > mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc4200ced80, > 0xc42016e000, 0xc42016e900, 0xc42016e6c0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra/command.go:722 > +0x2fe > mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4200ced80, > 0xc42007d290, 0xc420057f10) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra/command.go:681 > +0x2b > main.main() > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/newt.go:170 +0x1ac > gnu@mc-117:~/myproj$ cd .. > gnu@mc-117:~$ cd adafruit/ > gnu@mc-117:~/adafruit$ cd myproj/ > gnu@mc-117:~/adafruit/myproj$ newt install > panic: runtime error: invalid memory address or nil pointer dereference > [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x75d4ce] > goroutine 1 [running]: > mynewt.apache.org/newt/newt/repo.(*Version).ToNuVersion(...) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/version.go:162 > mynewt.apache.org/newt/newt/repo.(*Repo).CheckNewtCompatibility(0xc4200aae10, > 0x0, 0x1, 0x2, 0x0, 0x0, 0x0, 0x1) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/repo.go:796 > +0x5e > mynewt.apache.org/newt/newt/project.(*Project).loadRepo(0xc42009ea80, > 0xc4200a71a0, 0x12, 0xc4200e20e0, 0x1, 0x1) > >
[jira] [Reopened] (MYNEWT-873) newt crashes during 'newt install'
[ https://issues.apache.org/jira/browse/MYNEWT-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Collins reopened MYNEWT-873: > newt crashes during 'newt install' > -- > > Key: MYNEWT-873 > URL: https://issues.apache.org/jira/browse/MYNEWT-873 > Project: Mynewt > Issue Type: Bug > Security Level: Public(Viewable by anyone) > Components: Newt >Affects Versions: v1_3_0_rel >Reporter: Marko Kiiskila >Assignee: Sterling Hughes >Priority: Major > > There might, or might not have been, an attempt to run 'newt install' before > for this project. > Network was slow, so they might've stopped the fetch in the middle. But I'm > not certain > of that. > nu@mc-117:~/myproj$ newt install > panic: runtime error: invalid memory address or nil pointer dereference > [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x75d4ce] > goroutine 1 [running]: > mynewt.apache.org/newt/newt/repo.(*Version).ToNuVersion(...) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/version.go:162 > mynewt.apache.org/newt/newt/repo.(*Repo).CheckNewtCompatibility(0xc420094e10, > 0x0, 0x1, 0x2, 0x0, 0x0, 0x0, 0x1) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/repo.go:796 > +0x5e > mynewt.apache.org/newt/newt/project.(*Project).loadRepo(0xc420064ae0, > 0xc4200157a0, 0x12, 0xc4200cc0e0, 0x1, 0x1) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:427 > +0x51c > mynewt.apache.org/newt/newt/project.(*Project).loadConfig(0xc420064ae0, 0x0, > 0xc42007dbc0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:505 > +0x421 > mynewt.apache.org/newt/newt/project.(*Project).Init(0xc420064ae0, > 0xc420014184, 0x10, 0x1c, 0x8363c0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:544 > +0xed > mynewt.apache.org/newt/newt/project.NewProject(0xc420014184, 0x10, > 0xc420014184, 0x10, 0x0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:135 > +0x58 > mynewt.apache.org/newt/newt/project.LoadProject(0xc420014184, 0x10, > 0xc420057bd8, 0xc420062080, 0xc42180) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:719 > +0x7d > mynewt.apache.org/newt/newt/project.initProject(0xc420014184, 0x10, > 0xc420014184, 0x10) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:74 > +0x39 > mynewt.apache.org/newt/newt/project.initialize(0x4, 0xc420057c90) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:92 > +0x89 > mynewt.apache.org/newt/newt/project.TryGetProject(0x4, 0xc420019138, 0x4) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/project/project.go:100 > +0x22 > mynewt.apache.org/newt/newt/cli.TryGetProject(0x0) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/cli/util.go:208 > +0x26 > mynewt.apache.org/newt/newt/cli.installRunCmd(0xc420161200, 0xb6fcf8, 0x0, > 0x0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/cli/project_cmds.go:76 > +0x26 > mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra.(*Command).execute(0xc420161200, > 0xb6fcf8, 0x0, 0x0, 0xc420161200, 0xb6fcf8) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra/command.go:636 > +0x234 > mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc4200ced80, > 0xc42016e000, 0xc42016e900, 0xc42016e6c0) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra/command.go:722 > +0x2fe > mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4200ced80, > 0xc42007d290, 0xc420057f10) > > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/vendor/github.com/spf13/cobra/command.go:681 > +0x2b > main.main() > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/newt.go:170 +0x1ac > gnu@mc-117:~/myproj$ cd .. > gnu@mc-117:~$ cd adafruit/ > gnu@mc-117:~/adafruit$ cd myproj/ > gnu@mc-117:~/adafruit/myproj$ newt install > panic: runtime error: invalid memory address or nil pointer dereference > [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x75d4ce] > goroutine 1 [running]: > mynewt.apache.org/newt/newt/repo.(*Version).ToNuVersion(...) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/version.go:162 > mynewt.apache.org/newt/newt/repo.(*Repo).CheckNewtCompatibility(0xc4200aae10, > 0x0, 0x1, 0x2, 0x0, 0x0, 0x0, 0x1) > /tmp/mynewt.YXJAfVKhPc/src/mynewt.apache.org/newt/newt/repo/repo.go:796 > +0x5e > mynewt.apache.org/newt/newt/project.(*Project).loadRepo(0xc42009ea80, > 0xc4200a71a0, 0x12, 0xc4200e20e0, 0x1, 0x1) > >
[jira] [Commented] (MYNEWT-882) Newt - Problems with spaces in paths
[
https://issues.apache.org/jira/browse/MYNEWT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349645#comment-16349645
]
ASF GitHub Bot commented on MYNEWT-882:
---
ccollins476ad closed pull request #131: MYNEWT-882 Newt - Allow spaces in paths
URL: https://github.com/apache/mynewt-newt/pull/131
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/newt/toolchain/compiler.go b/newt/toolchain/compiler.go
index cc19968b..c2e1daab 100644
--- a/newt/toolchain/compiler.go
+++ b/newt/toolchain/compiler.go
@@ -347,7 +347,8 @@ func (c *Compiler) includesStrings() []string {
return nil
}
- includes := util.SortFields(c.info.Includes...)
+ includes := util.UniqueStrings(c.info.Includes)
+ sort.Strings(includes)
tokens := make([]string, len(includes))
for i, s := range includes {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Newt - Problems with spaces in paths
>
>
> Key: MYNEWT-882
> URL: https://issues.apache.org/jira/browse/MYNEWT-882
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
>Reporter: Christopher Collins
>Assignee: Christopher Collins
>Priority: Major
>
> A user from the #general slack channel (Anup) reported an issue involving
> spaces in path names.
> The summary is:
> {noformat}
> 2018/01/07 18:57:21.699 [DEBUG]
> o=repos/apache-mynewt-core/boot/bootutil/src/bootutil_misc.c:24:10: fatal
> error: syscfg/syscfg.h: No such file or directory
> {noformat}
> {noformat}
> -IBhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include
> {noformat}
> The full include path should be: {{C:/msys64/home/Anup
> Bhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include}}
> The full build log is here:
> https://mynewt.slack.com/files/U8P49MQ83/F8P7W856W/-.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MYNEWT-882) Newt - Problems with spaces in paths
[
https://issues.apache.org/jira/browse/MYNEWT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349644#comment-16349644
]
ASF GitHub Bot commented on MYNEWT-882:
---
ccollins476ad commented on issue #131: MYNEWT-882 Newt - Allow spaces in paths
URL: https://github.com/apache/mynewt-newt/pull/131#issuecomment-362461773
There is still an issue here. Newt fails to parse the generated `.d` files
that contain spaces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Newt - Problems with spaces in paths
>
>
> Key: MYNEWT-882
> URL: https://issues.apache.org/jira/browse/MYNEWT-882
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
>Reporter: Christopher Collins
>Assignee: Christopher Collins
>Priority: Major
>
> A user from the #general slack channel (Anup) reported an issue involving
> spaces in path names.
> The summary is:
> {noformat}
> 2018/01/07 18:57:21.699 [DEBUG]
> o=repos/apache-mynewt-core/boot/bootutil/src/bootutil_misc.c:24:10: fatal
> error: syscfg/syscfg.h: No such file or directory
> {noformat}
> {noformat}
> -IBhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include
> {noformat}
> The full include path should be: {{C:/msys64/home/Anup
> Bhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include}}
> The full build log is here:
> https://mynewt.slack.com/files/U8P49MQ83/F8P7W856W/-.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MYNEWT-882) Newt - Problems with spaces in paths
[
https://issues.apache.org/jira/browse/MYNEWT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Collins reassigned MYNEWT-882:
--
Assignee: Christopher Collins (was: Sterling Hughes)
> Newt - Problems with spaces in paths
>
>
> Key: MYNEWT-882
> URL: https://issues.apache.org/jira/browse/MYNEWT-882
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
>Reporter: Christopher Collins
>Assignee: Christopher Collins
>Priority: Major
>
> A user from the #general slack channel (Anup) reported an issue involving
> spaces in path names.
> The summary is:
> {noformat}
> 2018/01/07 18:57:21.699 [DEBUG]
> o=repos/apache-mynewt-core/boot/bootutil/src/bootutil_misc.c:24:10: fatal
> error: syscfg/syscfg.h: No such file or directory
> {noformat}
> {noformat}
> -IBhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include
> {noformat}
> The full include path should be: {{C:/msys64/home/Anup
> Bhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include}}
> The full build log is here:
> https://mynewt.slack.com/files/U8P49MQ83/F8P7W856W/-.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MYNEWT-882) Newt - Problems with spaces in paths
[
https://issues.apache.org/jira/browse/MYNEWT-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349617#comment-16349617
]
ASF GitHub Bot commented on MYNEWT-882:
---
ccollins476ad opened a new pull request #131: MYNEWT-882 Newt - Allow spaces in
paths
URL: https://github.com/apache/mynewt-newt/pull/131
Newt was interpreting each include path as a space-delimited list of
directories. If the project directory name contained a space, the path would
get split into two separate paths, causing an `#include` directive to fail.
Now, newt treats each entry as a single include path.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Newt - Problems with spaces in paths
>
>
> Key: MYNEWT-882
> URL: https://issues.apache.org/jira/browse/MYNEWT-882
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
>Reporter: Christopher Collins
>Assignee: Sterling Hughes
>Priority: Major
>
> A user from the #general slack channel (Anup) reported an issue involving
> spaces in path names.
> The summary is:
> {noformat}
> 2018/01/07 18:57:21.699 [DEBUG]
> o=repos/apache-mynewt-core/boot/bootutil/src/bootutil_misc.c:24:10: fatal
> error: syscfg/syscfg.h: No such file or directory
> {noformat}
> {noformat}
> -IBhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include
> {noformat}
> The full include path should be: {{C:/msys64/home/Anup
> Bhattacharjee/dev/myproj/bin/targets/nucleof401_boot/generated/include}}
> The full build log is here:
> https://mynewt.slack.com/files/U8P49MQ83/F8P7W856W/-.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
