[jira] [Assigned] (OFBIZ-12835) Support SSLHostConfig in CatalinaContainer

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12835: --- Assignee: Jacques Le Roux > Support SSLHostConfig in CatalinaContainer >

[jira] [Commented] (OFBIZ-12835) Support SSLHostConfig in CatalinaContainer

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748662#comment-17748662 ] Jacques Le Roux commented on OFBIZ-12835: - I did review and tested, sounds good to me. If nobody

[jira] [Commented] (OFBIZ-10194) ContentWrapper empty string result breaks simple FTL null check and default syntax

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748657#comment-17748657 ] Jacques Le Roux commented on OFBIZ-10194: - I did not review the patch but the description sounds

[jira] [Updated] (OFBIZ-10194) ContentWrapper empty string result breaks simple FTL null check and default syntax

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10194: Description: Since the changes to the ContentWrappers from Ticket OFBIZ-6701 the result

[jira] [Commented] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748656#comment-17748656 ] Jacques Le Roux commented on OFBIZ-12829: - +1 > Improvements for ContentWorker methods and

[jira] [Commented] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748650#comment-17748650 ] Jacques Le Roux commented on OFBIZ-12802: - +1 for pushing > Extending calculateProductPrice

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748640#comment-17748640 ] Michael Brohl commented on OFBIZ-12813: --- [~jleroux] [~deepak] we will work on this asap and also

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748636#comment-17748636 ] Jacques Le Roux commented on OFBIZ-12813: - The framework still contents: * The groovyScripts

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748634#comment-17748634 ] Jacques Le Roux commented on OFBIZ-12813: - I forgot to put the Jira number so here is manually

[jira] [Comment Edited] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748297#comment-17748297 ] Jacques Le Roux edited comment on OFBIZ-12828 at 7/28/23 10:34 AM: ---

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Deepak Dixit (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748523#comment-17748523 ] Deepak Dixit commented on OFBIZ-12813: -- Thanks [~mbrohl], Need to update the organize

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Deepak Dixit (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748516#comment-17748516 ] Deepak Dixit commented on OFBIZ-12836: -- Agree [~paulfoxworthy], Shared information just for

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748507#comment-17748507 ] Jacques Le Roux commented on OFBIZ-12836: - The patch works and loogks good to me, +1 for pushing

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748471#comment-17748471 ] Paul Foxworthy commented on OFBIZ-12836: [~deepak] I think we can't always rely on isAfterLast -

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748467#comment-17748467 ] Paul Foxworthy commented on OFBIZ-12836: [~jleroux] I did another lap, the space is there now.

[jira] [Comment Edited] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748442#comment-17748442 ] Paul Foxworthy edited comment on OFBIZ-12836 at 7/28/23 8:00 AM: -

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-4.patch

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: (was: EntitySQLProcessor-3.groovy) > Resource leaks in

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748465#comment-17748465 ] Jacques Le Roux commented on OFBIZ-12813: - plugins contains some more > Refactor groovy folder

[jira] [Comment Edited] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748442#comment-17748442 ] Paul Foxworthy edited comment on OFBIZ-12836 at 7/28/23 7:57 AM: -

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: (was: Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-4.patch) >

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748463#comment-17748463 ] Michael Brohl commented on OFBIZ-12813: --- Addition: if I do a search on GitHub with

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748464#comment-17748464 ] Jacques Le Roux commented on OFBIZ-12813: - OK, no problems > Refactor groovy folder structure

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748461#comment-17748461 ] Michael Brohl commented on OFBIZ-12813: --- We will organise to handle this even when Wiebke is on

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748458#comment-17748458 ] Jacques Le Roux commented on OFBIZ-12813: - Hi, We have still 487 occurences of /groovyScripts/

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Deepak Dixit (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748450#comment-17748450 ] Deepak Dixit commented on OFBIZ-12836: -- isAfterLast works well with mysql 5.7, mysql8 changed the

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748449#comment-17748449 ] Jacques Le Roux commented on OFBIZ-12836: - Thanks Paul, A new expression for me "to fuss about"

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Deepak Dixit (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748448#comment-17748448 ] Deepak Dixit commented on OFBIZ-12813: -- Thanks [~zhangwei] for reporting, this has been fixed under

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-4.patch

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: (was: EntitySQLProcessor-3.groovy) > Resource leaks in

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: (was: Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-4.patch) >

[jira] [Comment Edited] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Deepak Dixit (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748410#comment-17748410 ] Deepak Dixit edited comment on OFBIZ-12813 at 7/28/23 7:25 AM: --- Hi

[jira] [Comment Edited] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748442#comment-17748442 ] Paul Foxworthy edited comment on OFBIZ-12836 at 7/28/23 7:22 AM: -

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-4.patch

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-28 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748442#comment-17748442 ] Paul Foxworthy commented on OFBIZ-12836: [~jleroux] wrote: ??I get this message "The

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Wei Zhang (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748441#comment-17748441 ] Wei Zhang commented on OFBIZ-12813: --- Some script locations are incorrect now please search

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748440#comment-17748440 ] ASF subversion and git services commented on OFBIZ-12813: - Commit

[jira] [Reopened] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-28 Thread Deepak Dixit (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-12813: -- Assignee: Deepak Dixit (was: Wiebke Paetzold) Need to update the plugins reference as well