[
https://issues.apache.org/jira/browse/OFBIZ-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814224#comment-17814224
]
Daniel Watford commented on OFBIZ-12149:
The changes made under this ticket are no longer needed
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814222#comment-17814222
]
ASF subversion and git services commented on OFBIZ-12888:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814213#comment-17814213
]
ASF subversion and git services commented on OFBIZ-12888:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814214#comment-17814214
]
Daniel Watford commented on OFBIZ-12850:
Hi [~iwolf] - Any chance there are some plugins in
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814209#comment-17814209
]
Jacques Le Roux commented on OFBIZ-12888:
-
Michael, I revert my revert and commit the necessary
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814206#comment-17814206
]
Jacques Le Roux commented on OFBIZ-12888:
-
Thanks Daniel, it's all clear now :)
> Gradle
danwatford commented on PR #687:
URL: https://github.com/apache/ofbiz-framework/pull/687#issuecomment-1926387962
> It's only a matter of performance for the hook. I'd like to have
@danwatford's opinon about removing the compileGroovyScriptsGroovy Gradle
task...
Yes - the
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814204#comment-17814204
]
Daniel Watford commented on OFBIZ-12888:
[~jleroux] - regarding INFRA-25456:
Codenarc runs
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814198#comment-17814198
]
Daniel Watford commented on OFBIZ-12888:
Hello,
Summary: We should remove the groovyScripts
[
https://issues.apache.org/jira/browse/OFBIZ-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814122#comment-17814122
]
Jacques Le Roux commented on OFBIZ-12850:
-
This could be related to OFBIZ-12888
> Duplicate
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814116#comment-17814116
]
Michael Brohl commented on OFBIZ-12888:
---
I think we'll have to test the change...
> Gradle
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814115#comment-17814115
]
Jacques Le Roux commented on OFBIZ-12888:
-
But wait, what about BB and INFRA-25456?
> Gradle
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814109#comment-17814109
]
Jacques Le Roux edited comment on OFBIZ-12888 at 2/4/24 4:18 PM:
-
I have
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814109#comment-17814109
]
Jacques Le Roux commented on OFBIZ-12888:
-
I have no problems building with Eclipse 2023-06 on
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814099#comment-17814099
]
Michael Brohl commented on OFBIZ-12888:
---
A quick test shows there is no difference in the consumed
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814097#comment-17814097
]
Michael Brohl commented on OFBIZ-12888:
---
The question is, how significant the performance gap
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814080#comment-17814080
]
Jacques Le Roux edited comment on OFBIZ-12888 at 2/4/24 12:44 PM:
--
It's
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814080#comment-17814080
]
Jacques Le Roux commented on OFBIZ-12888:
-
It's only a matter of performance for the hook. I'd
JacquesLeRoux commented on PR #687:
URL: https://github.com/apache/ofbiz-framework/pull/687#issuecomment-1925734656
It's only a matter of performance for the hook. I'd like to have
@danwatford's opinon about removing the compileGroovyScriptsGroovy Gradle
task...
--
This is an automated
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814072#comment-17814072
]
Michael Brohl commented on OFBIZ-12888:
---
I see there is a commit message comment on that. Does it
sonarcloud[bot] commented on PR #687:
URL: https://github.com/apache/ofbiz-framework/pull/687#issuecomment-1925700901
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814070#comment-17814070
]
Jacques Le Roux commented on OFBIZ-12888:
-
Michael,
About
bq. Maybe someone can explain why we
mbrohl opened a new pull request, #687:
URL: https://github.com/apache/ofbiz-framework/pull/687
Removes the groovyScripts source set, the compileGroovyScriptsGroovy task
configuration and changes the pre-push hook to "checkstyleMain codenarcMain
codenarcTest" instead of "checkstyleMain
Michael Brohl created OFBIZ-12888:
-
Summary: Gradle eclipse target produces duplicate build path
entries in .classpath
Key: OFBIZ-12888
URL: https://issues.apache.org/jira/browse/OFBIZ-12888
Project:
[
https://issues.apache.org/jira/browse/OFBIZ-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12887.
---
Resolution: Done
> Normalize contextPath in hasBasePermission
>
[
https://issues.apache.org/jira/browse/OFBIZ-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814065#comment-17814065
]
ASF subversion and git services commented on OFBIZ-12887:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814064#comment-17814064
]
ASF subversion and git services commented on OFBIZ-12887:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814063#comment-17814063
]
ASF subversion and git services commented on OFBIZ-12887:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-12887:
Description: Better have a normalized contextPath in
LoginWorker::hasBasePermission
Jacques Le Roux created OFBIZ-12887:
---
Summary: Normalize contextPath in hasBasePermission
Key: OFBIZ-12887
URL: https://issues.apache.org/jira/browse/OFBIZ-12887
Project: OFBiz
Issue Type:
30 matches
Mail list logo