[GitHub] [ofbiz-framework] adityasharma7 commented on a change in pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2022-01-03 Thread GitBox
adityasharma7 commented on a change in pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r777850124 ## File path: themes/rainbowstone/webapp/rainbowstone/style.css ## @@ -1927,4 +1927,12 @@ html > /**/ body .jstree-default a { /* The custom

[jira] [Commented] (OFBIZ-9976) Introduce require.js to organise JavaScript files

2022-01-03 Thread Aditya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468380#comment-17468380 ] Aditya Sharma commented on OFBIZ-9976: -- I think we should stick to npm at max. I would suggest to

[jira] [Commented] (OFBIZ-12471) Gradle Wrapper is not downloaded with 18.12.03

2022-01-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468130#comment-17468130 ] ASF subversion and git services commented on OFBIZ-12471: - Commit

[jira] [Commented] (OFBIZ-12471) Gradle Wrapper is not downloaded with 18.12.03

2022-01-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468125#comment-17468125 ] ASF subversion and git services commented on OFBIZ-12471: - Commit

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
sonarcloud[bot] commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1004183329 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1004181685 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1004168681 SonarCloud Quality Gate failed. ![Quality Gate

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
sonarcloud[bot] commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1004181685 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
sonarcloud[bot] commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1004168681 SonarCloud Quality Gate failed. ![Quality Gate

[jira] [Commented] (OFBIZ-11774) Have a Menu in Catalog featuring actions to create the main objects

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468010#comment-17468010 ] Pierre Smits commented on OFBIZ-11774: -- Thanks Jacques. And I plan to look forward to see such

[GitHub] [ofbiz-framework] gilPts commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
gilPts commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1004068188 @mbrohl Yes nothing is enforced, the only impact for existing implementation is having the ${env: annotation in some config files, those can be replaced (or only the

[jira] [Commented] (OFBIZ-11774) Have a Menu in Catalog featuring actions to create the main objects

2022-01-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467953#comment-17467953 ] Jacques Le Roux commented on OFBIZ-11774: - I plan to push it if it's OK, as I did for similar in

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467951#comment-17467951 ] Pierre Smits commented on OFBIZ-9498: - HI [~marco_adeti] , First let me wish you a healthy, happy,

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Marco RODRIGUES (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467941#comment-17467941 ] Marco RODRIGUES commented on OFBIZ-9498: hi [~pierresmits], Your reasoning is correct if it was

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467923#comment-17467923 ] Michael Brohl commented on OFBIZ-9498: -- The contributors of the PR themselves (Gil/Marco) want to

[jira] [Comment Edited] (OFBIZ-11774) Have a Menu in Catalog featuring actions to create the main objects

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467896#comment-17467896 ] Pierre Smits edited comment on OFBIZ-11774 at 1/3/22, 10:36 AM: Hi

[jira] [Commented] (OFBIZ-11774) Have a Menu in Catalog featuring actions to create the main objects

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467896#comment-17467896 ] Pierre Smits commented on OFBIZ-11774: -- Hi Jacques, it is 'old' the day after the submission. And

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467893#comment-17467893 ] Pierre Smits commented on OFBIZ-9498: - Thanks [~marco_adeti] , Working on a 'more' complete version

[jira] [Updated] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12478: -- Affects Version/s: 18.12.05 (was: 18.12.06) > Screen Xml renderer

[jira] [Closed] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12478. - Fix Version/s: Upcoming Branch 18.12.06 Resolution: Fixed > Screen

[jira] [Comment Edited] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Marco RODRIGUES (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467888#comment-17467888 ] Marco RODRIGUES edited comment on OFBIZ-9498 at 1/3/22, 10:24 AM: -- We

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Marco RODRIGUES (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467888#comment-17467888 ] Marco RODRIGUES commented on OFBIZ-9498: We are working on a more complete version. We have to

[jira] [Commented] (OFBIZ-11774) Have a Menu in Catalog featuring actions to create the main objects

2022-01-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467886#comment-17467886 ] Jacques Le Roux commented on OFBIZ-11774: - Happy new year Pierre, As things changes, and it's

[GitHub] [ofbiz-framework] mbrohl commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
mbrohl commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003988681 > @mbrohl indeed, the idea is to make it optional, but defining variable name in entityengine and other place is needed to ease configuration via env variable. As

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467883#comment-17467883 ] Pierre Smits commented on OFBIZ-9498: - Hi Gil, What is missing in this PR? Can this 'enhancement'

[jira] [Updated] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12478: -- Affects Version/s: 18.12.06 > Screen Xml renderer failed on renderContainer[Begin,End] ftl

[jira] [Assigned] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12478: - Assignee: Nicolas Malin > Screen Xml renderer failed on renderContainer[Begin,End] ftl

[jira] [Updated] (OFBIZ-12476) README.PDF is not generated by BuildBot nor locally

2022-01-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12476: Description: There is no README.PDF file at

[jira] [Commented] (OFBIZ-10495) Rendering different HTML container types with ScreenRenderer

2022-01-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467868#comment-17467868 ] ASF subversion and git services commented on OFBIZ-10495: - Commit

[jira] [Commented] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467867#comment-17467867 ] ASF subversion and git services commented on OFBIZ-12478: - Commit

[jira] [Commented] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467865#comment-17467865 ] ASF subversion and git services commented on OFBIZ-12478: - Commit

[jira] [Commented] (OFBIZ-10495) Rendering different HTML container types with ScreenRenderer

2022-01-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467866#comment-17467866 ] ASF subversion and git services commented on OFBIZ-10495: - Commit

[jira] [Commented] (OFBIZ-10578) MIsc UI improvements in pages of ecommerce component

2022-01-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467863#comment-17467863 ] Jacques Le Roux commented on OFBIZ-10578: - Hi, Could a PR be created for what remains? > MIsc

[jira] [Created] (OFBIZ-12478) Screen Xml renderer failed on renderContainer[Begin,End] ftl macro

2022-01-03 Thread Nicolas Malin (Jira)
Nicolas Malin created OFBIZ-12478: - Summary: Screen Xml renderer failed on renderContainer[Begin,End] ftl macro Key: OFBIZ-12478 URL: https://issues.apache.org/jira/browse/OFBIZ-12478 Project: OFBiz

[GitHub] [ofbiz-framework] gilPts commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
gilPts commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003949110 @mbrohl , when I say he will introduce it, it means that he will explain the needs, and the improvements it will produce. Again let's wait for him to be ready, there is

[jira] [Commented] (OFBIZ-11774) Have a Menu in Catalog featuring actions to create the main objects

2022-01-03 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467857#comment-17467857 ] Pierre Smits commented on OFBIZ-11774: -- Bonjour Jacques, Bonne année. Tja. How did that happen?

[jira] [Updated] (OFBIZ-10093) Replace ELRTE plugin with Trumbowyg

2022-01-03 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10093: Summary: Replace ELRTE plugin with Trumbowyg (was: Replace ELRTE plugin with Quill.) >

[GitHub] [ofbiz-framework] mbrohl commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
mbrohl commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003923835 Hi @gilPts , we already have such a centralized configuration mechanism in production for several years now. Maybe we should share this and let him check if it fits the

[GitHub] [ofbiz-framework] gilPts commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2022-01-03 Thread GitBox
gilPts commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003921875 Hello @ieugen, I will take your remarks and update the pr soon, thanks. @mbrohl indeed, the idea is to make it optional, but defining variable name in