peng-yongsheng commented on a change in pull request #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292#discussion_r315531586
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/ttl/RecordTTLCalculator.java
###
wu-sheng commented on issue #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292#issuecomment-522878868
@peng-yongsheng Method rename done.
This is an automated message from the Apache Git Service.
To resp
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch record-ttl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 0877401 Fix issue.
add 901a948 Rename `getSecondTimeBucket` to `getRecordTimeBucket`.
No new revisio
peng-yongsheng commented on a change in pull request #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292#discussion_r315527164
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/ttl/RecordTTLCalculator.java
###
peng-yongsheng commented on a change in pull request #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292#discussion_r315524110
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/ttl/RecordTTLCalculator.java
###
wu-sheng commented on a change in pull request #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292#discussion_r315523181
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/ttl/RecordTTLCalculator.java
##
@
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch record-ttl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 27ca9e0 Fix TTL issue.
add 0877401 Fix issue.
No new revisions were added by this update.
Summary o
peng-yongsheng commented on a change in pull request #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292#discussion_r315521878
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/ttl/RecordTTLCalculator.java
###
wu-sheng commented on issue #3288: Is there any plan for the C++ client ?
URL: https://github.com/apache/skywalking/issues/3288#issuecomment-522867124
No, we don't have that. If you have C++ developer, I would recommend you to
use go2sky as a good example.
-
BinWu1989 commented on issue #3288: Is there any plan for the C++ client ?
URL: https://github.com/apache/skywalking/issues/3288#issuecomment-522866814
sorry ,I am a java developer, Just make confirmation if there any c++ client
in schedule ,As we need to choose a plan that need to take C++
wu-sheng commented on issue #3204: java.lang.ClassCircularityError:
java/util/LinkedHashMap$LinkedKeySet
URL: https://github.com/apache/skywalking/issues/3204#issuecomment-522866218
@maxiaolong Thanks for update. ByteBuddy upgraded in master branch already.
maxiaolong commented on issue #3204: java.lang.ClassCircularityError:
java/util/LinkedHashMap$LinkedKeySet
URL: https://github.com/apache/skywalking/issues/3204#issuecomment-522865770
when i upgrade byte-buddy to the lastest version, the question disappears
---
wayilau commented on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522862073
/run-ci
This is an automated message from the Apache Git Service.
To respond to the message, pleas
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522857624
/run e2e
This is an automated message from the Apache Git Service.
To respond to the message,
kezhenxu94 removed a comment on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522857624
/run e2e
This is an automated message from the Apache Git Service.
To respond to the m
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
discard b33f06f Update asf-site
new aab2232 Update asf-site
This update added new revisions after undo
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new f58c749 Update README.md
f58c749 i
kezhenxu94 removed a comment on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848882
/run e2e
This is an automated message from the Apache Git Service.
To respond to the m
kezhenxu94 removed a comment on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848699
/run e2e
This is an automated message from the Apache Git Service.
To respond to the m
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848882
/run e2e
This is an automated message from the Apache Git Service.
To respond to the message,
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522848699
/run e2e
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522843323
/run e2e
This is an automated message from the Apache Git Service.
To respond to the message, pl
wu-sheng commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522842261
Which xml file?
This is an automated message from the Apache Git Service.
To respond to the mes
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522841657
> @kezhenxu94 What happens in e2e?
Strange error saying "premature end of file", perhaps some xml files are
broken on some machines
---
wu-sheng commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522841468
Look like it keeps failing.
This is an automated message from the Apache Git Service.
To respond
kezhenxu94 removed a comment on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522840617
/run e2e
This is an automated message from the Apache Git Service.
To respond to the m
wu-sheng commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522840741
@kezhenxu94 What happens in e2e?
This is an automated message from the Apache Git Service.
To re
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522840617
/run e2e
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng opened a new pull request #3292: Fix TTL issue.
URL: https://github.com/apache/skywalking/pull/3292
Description in #3263, I am adding new TTL Calculators for record type, in ES
and MySQL storages.
W/ this, the TTL should work well in delete record.
-
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch record-ttl
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 27ca9e04c3f1a9ffee6c3d06cfa1bb484bb91979
Author: Wu Sheng
AuthorDate: Tue Aug 20 11:29:23 2019 +0800
Fix T
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch record-ttl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 27ca9e0 Fix TTL issue.
This branch includes the following new commits:
new 27ca9e0 Fix TTL issue.
kezhenxu94 removed a comment on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522836438
/run e2e
This is an automated message from the Apache Git Service.
To respond to the m
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522836438
/run e2e
This is an automated message from the Apache Git Service.
To respond to the message,
kezhenxu94 commented on issue #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291#issuecomment-522833591
Moving the log directory to `tmp` is necessary because the
`skywalking-api.log` may still be opened and cannot be deleted at the end of
test
kezhenxu94 opened a new pull request #3291: Stabilize unit test
URL: https://github.com/apache/skywalking/pull/3291
The FileWriterTest creates files in the source directory(failed to
delete them due to a bug in the `deleteDir` method), making
them being checked by checkstyle plugin and
wu-sheng closed issue #3289: ui doesn't show dashboard
URL: https://github.com/apache/skywalking/issues/3289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
wu-sheng commented on issue #3289: ui doesn't show dashboard
URL: https://github.com/apache/skywalking/issues/3289#issuecomment-522827968
This error log is not clear. This could be many things. Check all the thing
by following the quick start, and test locally.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new ca80e45 Add bootstrap-plugin/toolkit-activ
wu-sheng merged pull request #3290: Add bootstrap-plugin/toolkit-activation to
import check list
URL: https://github.com/apache/skywalking/pull/3290
This is an automated message from the Apache Git Service.
To respond to the
wayilau commented on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522818797
> > > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is
modifiable at runtime and the real writer may change, after your patch the
modification
kezhenxu94 edited a comment on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522817167
> > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is
modifiable at runtime and the real writer may change, after your patch the
modi
kezhenxu94 commented on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522817167
> > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is
modifiable at runtime and the real writer may change, after your patch the
modificatio
wayilau commented on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522816754
> `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is
modifiable at runtime and the real writer may change, after your patch the
modification of
kezhenxu94 removed a comment on issue #3290: Add
bootstrap-plugin/toolkit-activation to import check list
URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522815822
/run ci
This is an automated message from th
kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to
import check list
URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522815822
/run ci
This is an automated message from the Apache
wayilau commented on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522815442
> At today, provide a static writer pointer may be safe for now. I am not
sure about the future yet. Do you face any real issue about this?
Actually not. It
kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to
import check list
URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522814771
/run ci
This is an automated message from the Apache
kezhenxu94 removed a comment on issue #3290: Add
bootstrap-plugin/toolkit-activation to import check list
URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522814771
/run ci
This is an automated message from th
kezhenxu94 removed a comment on issue #3290: Add
bootstrap-plugin/toolkit-activation to import check list
URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522813284
/run ci
This is an automated message from th
kezhenxu94 commented on issue #3290: Add bootstrap-plugin/toolkit-activation to
import check list
URL: https://github.com/apache/skywalking/pull/3290#issuecomment-522813284
/run ci
This is an automated message from the Apache
kezhenxu94 opened a new pull request #3290: Add
bootstrap-plugin/toolkit-activation to import check list
URL: https://github.com/apache/skywalking/pull/3290
This is an automated message from the Apache Git Service.
To respon
liudingnet opened a new issue #3289: ui doesn't show dashboard
URL: https://github.com/apache/skywalking/issues/3289
skywalking6.2.0 & 6.3.0
ui doesn't show the dashaboard, seeing the screen capture.
![image](https://user-images.githubusercontent.com/48703465/63309137-411c6980-c3
zhaoyuguang commented on issue #2720: Provide plugin for kafka-v2-plugin
URL: https://github.com/apache/skywalking/issues/2720#issuecomment-522783474
I haven't do it yet. Welcome to contribute.
This is an automated message fro
wu-sheng commented on issue #2720: Provide plugin for kafka-v2-plugin
URL: https://github.com/apache/skywalking/issues/2720#issuecomment-522639844
I think he hasn't. Welcome to do. FYI @zhaoyuguang
This is an automated messag
dmsolr commented on issue #2720: Provide plugin for kafka-v2-plugin
URL: https://github.com/apache/skywalking/issues/2720#issuecomment-522636563
@zhaoyuguang Do you work in progress that? May I join in?
This is an automated me
dmsolr commented on a change in pull request #3284: Log4j2 support AsyncRoot
print tid. All versions above 2.0 supported
URL: https://github.com/apache/skywalking/pull/3284#discussion_r315261513
##
File path:
apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src/m
wu-sheng commented on issue #3207: Support play 2.x
URL: https://github.com/apache/skywalking/pull/3207#issuecomment-522617896
@aiyanbo Update?
This is an automated message from the Apache Git Service.
To respond to the messag
wu-sheng closed issue #3288: Is there any plan for the C++ client ?
URL: https://github.com/apache/skywalking/issues/3288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
wu-sheng commented on issue #3288: Is there any plan for the C++ client ?
URL: https://github.com/apache/skywalking/issues/3288#issuecomment-522604744
We don't have core maintainer in C++. Are you interested in this?
Duplicated #2443
--
wu-sheng commented on issue #3273: Support Zookeeper ACL
URL: https://github.com/apache/skywalking/pull/3273#issuecomment-522594992
@dmsolr One mode is good for me. Make sure it is clear at document.
This is an automated messa
kezhenxu94 commented on a change in pull request #3284: Log4j2 support
AsyncRoot print tid. All versions above 2.0 supported
URL: https://github.com/apache/skywalking/pull/3284#discussion_r315231688
##
File path:
apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/s
wu-sheng commented on a change in pull request #3284: Log4j2 support AsyncRoot
print tid. All versions above 2.0 supported
URL: https://github.com/apache/skywalking/pull/3284#discussion_r315229140
##
File path:
apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/src
wu-sheng commented on issue #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522588336
At today, provide a static writer pointer may be safe for now. I am not sure
about the future yet. Do you face any real issue about this?
---
kezhenxu94 merged pull request #3286: Add cluster etcd config to cluster.md.
URL: https://github.com/apache/skywalking/pull/3286
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 029 Module config set override is not working (#3283)
new 8024bea Add cluster etcd config to clust
BinWu1989 opened a new issue #3288: Is there any plan for the C++ client ?
URL: https://github.com/apache/skywalking/issues/3288
@wu-sheng Dear WuSheng ,
As the official document, currently skywalking doesn't have an client for
C++ ,Is there any plan to support C++ in the near furtur
kezhenxu94 commented on a change in pull request #3284: Log4j2 support
AsyncRoot print tid. All versions above 2.0 supported
URL: https://github.com/apache/skywalking/pull/3284#discussion_r315179642
##
File path:
apm-sniffer/apm-toolkit-activation/apm-toolkit-log4j-2.x-activation/s
kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522527542
/run ci
This is an automated message from the Apache Git Service.
To respon
kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to
cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522527542
/run ci
This is an automated message from the Apache Git Service.
kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to
cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522524368
/run ci
This is an automated message from the Apache Git Service.
kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522524368
/run ci
This is an automated message from the Apache Git Service.
To respon
spurtAndy commented on issue #3285: How to do agent hot loading
URL: https://github.com/apache/skywalking/issues/3285#issuecomment-522506904
3Q
This is an automated message from the Apache Git Service.
To respond to the messag
kezhenxu94 removed a comment on issue #3286: Add cluster etcd config to
cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522499651
/run ci
This is an automated message from the Apache Git Service.
kezhenxu94 commented on issue #3286: Add cluster etcd config to cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#issuecomment-522499651
/run ci
This is an automated message from the Apache Git Service.
To respon
wayilau opened a new pull request #3287: Add cached writer.
URL: https://github.com/apache/skywalking/pull/3287
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve performance
wayilau commented on a change in pull request #3286: Add cluster etcd config to
cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#discussion_r315094753
##
File path: docs/en/setup/backend/backend-cluster.md
##
@@ -90,4 +90,17 @@ cluster:
serviceName: ${S
wayilau commented on a change in pull request #3286: Add cluster etcd config to
cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#discussion_r315092504
##
File path: docs/en/setup/backend/backend-cluster.md
##
@@ -90,4 +90,17 @@ cluster:
serviceName: ${S
kezhenxu94 commented on a change in pull request #3286: Add cluster etcd config
to cluster.md.
URL: https://github.com/apache/skywalking/pull/3286#discussion_r315090002
##
File path: docs/en/setup/backend/backend-cluster.md
##
@@ -90,4 +90,17 @@ cluster:
serviceName:
kezhenxu94 closed issue #3285: How to do agent hot loading
URL: https://github.com/apache/skywalking/issues/3285
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kezhenxu94 commented on issue #3285: How to do agent hot loading
URL: https://github.com/apache/skywalking/issues/3285#issuecomment-522462980
We don't support this
This is an automated message from the Apache Git Service.
To r
wayilau opened a new pull request #3286: Add cluster etcd config to cluster.md.
URL: https://github.com/apache/skywalking/pull/3286
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Impr
81 matches
Mail list logo