[GitHub] [skywalking] wu-sheng commented on issue #3387: sync ui

2019-08-30 Thread GitBox
wu-sheng commented on issue #3387: sync ui URL: https://github.com/apache/skywalking/pull/3387#issuecomment-526802503 You should fork and clone the repo. Do submodule update. Then, go into skywalking-ui folder, pull the latest of UI master branch. At this point, you will notice, maim repo

[GitHub] [skywalking] wu-sheng commented on issue #3387: sync ui

2019-08-30 Thread GitBox
wu-sheng commented on issue #3387: sync ui URL: https://github.com/apache/skywalking/pull/3387#issuecomment-526802533 All these could be learn from any doc or blog talking about git submodule. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #3387: sync ui

2019-08-30 Thread GitBox
wu-sheng commented on issue #3387: sync ui URL: https://github.com/apache/skywalking/pull/3387#issuecomment-526802159 You should update to rocketbot latest commit id. What do you do? I am seeing conflicts. This is an

[GitHub] [skywalking] aeolusheath opened a new pull request #3387: sync ui

2019-08-30 Thread GitBox
aeolusheath opened a new pull request #3387: sync ui URL: https://github.com/apache/skywalking/pull/3387 synchronize skywalking-ui This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] qxo opened a new issue #3386: on the trace UI, shoud add a way for which user can copy the trace_id

2019-08-30 Thread GitBox
qxo opened a new issue #3386: on the trace UI, shoud add a way for which user can copy the trace_id URL: https://github.com/apache/skywalking/issues/3386 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion -

[GitHub] [skywalking] wu-sheng commented on issue #3386: on the trace UI, shoud add a way for which user can copy the trace_id

2019-08-30 Thread GitBox
wu-sheng commented on issue #3386: on the trace UI, shoud add a way for which user can copy the trace_id URL: https://github.com/apache/skywalking/issues/3386#issuecomment-526799763 Contribution is welcome. This is an

[GitHub] [skywalking] wu-sheng commented on issue #3385: fix springMVC4 noSuchMethod

2019-08-30 Thread GitBox
wu-sheng commented on issue #3385: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3385#issuecomment-526799429 You don't add it into config file, how it works? This is an automated message from the

[GitHub] [skywalking] SummerOfServenteen commented on issue #3385: fix springMVC4 noSuchMethod

2019-08-30 Thread GitBox
SummerOfServenteen commented on issue #3385: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3385#issuecomment-526799364 if the version of springMVC is lower than 4.2.0.release ,the ControllerForLowVersionInstrumentation will be used ,ohterwise the

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-526799119 If rpc happens, then two segments generated, which show as two rows. When you set two service codes at agent.config, at trace page and topology, you should see

[GitHub] [skywalking] tsuilouis commented on issue #3323: Add Light4j plugin

2019-08-30 Thread GitBox
tsuilouis commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-526795446 @kezhenxu94 I have made some commits that I think solve the broken trace problem. The UI shows two entries, but I see that the trace IDs are identical

[GitHub] [skywalking] SummerOfServenteen opened a new pull request #3385: fix springMVC4 noSuchMethod

2019-08-30 Thread GitBox
SummerOfServenteen opened a new pull request #3385: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3385 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - Related issues #2659 #3337

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526788836 @stone-wlg For async, in order to make sure exit span duration accuration. Besides intercepting callback and creating local span there, you should take a look

[GitHub] [skywalking] wu-sheng commented on issue #3384: storage choose mysql, startup no error but only register_lock table be created

2019-08-30 Thread GitBox
wu-sheng commented on issue #3384: storage choose mysql, startup no error but only register_lock table be created URL: https://github.com/apache/skywalking/issues/3384#issuecomment-526783316 Could you debug by yourself? There is no error in our side. Check your JDK is 8. And debug the

[GitHub] [skywalking] wu-sheng closed issue #3384: storage choose mysql, startup no error but only register_lock table be created

2019-08-30 Thread GitBox
wu-sheng closed issue #3384: storage choose mysql, startup no error but only register_lock table be created URL: https://github.com/apache/skywalking/issues/3384 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] mytimes opened a new issue #3384: storage choose mysql, startup no error but only register_lock table be created

2019-08-30 Thread GitBox
mytimes opened a new issue #3384: storage choose mysql, startup no error but only register_lock table be created URL: https://github.com/apache/skywalking/issues/3384 Please answer these questions before submitting your issue. - Why do you submit this issue? - [* ] Question or

[GitHub] [skywalking] stone-wlg commented on a change in pull request #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on a change in pull request #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#discussion_r319701018 ## File path: apm-sniffer/apm-sdk-plugin/cassandra-3.x-plugin/pom.xml ## @@ -0,0 +1,46 @@ + +

[GitHub] [skywalking] michaelsembwever commented on a change in pull request #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
michaelsembwever commented on a change in pull request #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#discussion_r319600177 ## File path:

[GitHub] [skywalking] michaelsembwever commented on a change in pull request #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
michaelsembwever commented on a change in pull request #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#discussion_r319589918 ## File path: apm-sniffer/apm-sdk-plugin/cassandra-3.x-plugin/pom.xml ## @@ -0,0 +1,46 @@ + +

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526656232 > > > but finally other execute will call executeAsync(Statement var1), so i only intercept this method. > > > > > > @stone-wlg It is absolutely OK

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526654576 > > but finally other execute will call executeAsync(Statement var1), so i only intercept this method. > > @stone-wlg It is absolutely OK to

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526654576 > > but finally other execute will call executeAsync(Statement var1), so i only intercept this method. > > @stone-wlg It is absolutely OK to intercept

[GitHub] [skywalking] kezhenxu94 merged pull request #3383: Avoid unnecessary resetting when service mapping id is already 0

2019-08-30 Thread GitBox
kezhenxu94 merged pull request #3383: Avoid unnecessary resetting when service mapping id is already 0 URL: https://github.com/apache/skywalking/pull/3383 This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] kezhenxu94 closed issue #3382: Gateway feature performance concern

2019-08-30 Thread GitBox
kezhenxu94 closed issue #3382: Gateway feature performance concern URL: https://github.com/apache/skywalking/issues/3382 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch master updated: Avoid unnecessary resetting when service mapping id is already 0 (#3383)

2019-08-30 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 6fd85c8 Avoid unnecessary resetting

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526647744 > I'm not familiar with Cassandra at all, but according to the API, you just intercept the method `SessionManager#executeAsync` and nothing more, which

[GitHub] [skywalking] kezhenxu94 commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
kezhenxu94 commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526647746 > but finally other execute will call executeAsync(Statement var1), so i only intercept this method. @stone-wlg It is absolutely OK to intercept just

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526642272 > I'm not familiar with Cassandra at all, but according to the API, you just intercept the method `SessionManager#executeAsync` and nothing more, which

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3383: Avoid unnecessary resetting when service mapping id is already 0

2019-08-30 Thread GitBox
kezhenxu94 opened a new pull request #3383: Avoid unnecessary resetting when service mapping id is already 0 URL: https://github.com/apache/skywalking/pull/3383 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New

[GitHub] [skywalking] wu-sheng opened a new issue #3382: Gateway feature performance concern

2019-08-30 Thread GitBox
wu-sheng opened a new issue #3382: Gateway feature performance concern URL: https://github.com/apache/skywalking/issues/3382 Hi @kezhenxu94 After I merged the PR, I noticed this

[GitHub] [skywalking] wu-sheng merged pull request #3381: okhttp OnFailureInterceptor should log exception info

2019-08-30 Thread GitBox
wu-sheng merged pull request #3381: okhttp OnFailureInterceptor should log exception info URL: https://github.com/apache/skywalking/pull/3381 This is an automated message from the Apache Git Service. To respond to the

[skywalking] branch master updated: okhttp OnFailureInterceptor should log exception info (#3381)

2019-08-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 77736c5 okhttp OnFailureInterceptor

[GitHub] [skywalking] wu-sheng commented on issue #3380: envoy grpc stream problem

2019-08-30 Thread GitBox
wu-sheng commented on issue #3380: envoy grpc stream problem URL: https://github.com/apache/skywalking/issues/3380#issuecomment-526626059 @artemsre I am pinging to Envoy maintainer to give some suggestions. Could you verify whether the metrics send? I tested this, it worked.

[GitHub] [skywalking] wu-sheng commented on issue #3380: envoy grpc stream problem

2019-08-30 Thread GitBox
wu-sheng commented on issue #3380: envoy grpc stream problem URL: https://github.com/apache/skywalking/issues/3380#issuecomment-526624185 @dio Do you know what is this error? This is an automated message from the Apache Git

[GitHub] [skywalking] dmsolr commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
dmsolr commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526619721 Yes. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] artemsre commented on issue #3380: envoy grpc stream problem

2019-08-30 Thread GitBox
artemsre commented on issue #3380: envoy grpc stream problem URL: https://github.com/apache/skywalking/issues/3380#issuecomment-526619448 I used config from https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/config.yaml No any other metric components configured.

[GitHub] [skywalking] wu-sheng commented on issue #3380: envoy grpc stream problem

2019-08-30 Thread GitBox
wu-sheng commented on issue #3380: envoy grpc stream problem URL: https://github.com/apache/skywalking/issues/3380#issuecomment-526616280 Do you just send metrics service to SkyWalking? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526614940 +1 for @kezhenxu94 's review. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526612045 > I got it. Usually, we don't subscribe too many topics by many different group.id in one agent. Otherwise, group.id is usuful for analysis. I think we

[GitHub] [skywalking] qxo opened a new pull request #3381: okhttp OnFailureInterceptor should log exception info

2019-08-30 Thread GitBox
qxo opened a new pull request #3381: okhttp OnFailureInterceptor should log exception info URL: https://github.com/apache/skywalking/pull/3381 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided

[GitHub] [skywalking] wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526577653 Operation name relate to endpoint metrics. Please consider carefully. We don't bring too many unnecessary endpoint id

[GitHub] [skywalking] wu-sheng commented on issue #3367: agent support custom properties.

2019-08-30 Thread GitBox
wu-sheng commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-526577026 I thought this is instance level, for service. Look like more complex This is an

[GitHub] [skywalking] wu-sheng commented on issue #3367: agent support custom properties.

2019-08-30 Thread GitBox
wu-sheng commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-526576667 One question, what happen when multiple agents of one service set properties different,

[GitHub] [skywalking-query-protocol] JaredTan95 opened a new pull request #14: add props in query service results.

2019-08-30 Thread GitBox
JaredTan95 opened a new pull request #14: add props in query service results. URL: https://github.com/apache/skywalking-query-protocol/pull/14 releated pr: https://github.com/apache/skywalking/pull/3367 This is an automated

[skywalking-query-protocol] branch service_props created (now 7f5b9b8)

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git. at 7f5b9b8 add props in query services. This branch includes the following new commits:

[skywalking-query-protocol] 01/01: add props in query services.

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git commit 7f5b9b8923354897fbddb12e0d990a0a3cd2efe3 Author: Jared.Tan AuthorDate: Fri Aug 30 19:30:20

[skywalking] branch service_props updated (06362ce -> 6e12a3f)

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 06362ce Merge branch 'master' into service_props add b2d8bf1 add props in service. add

[GitHub] [skywalking] JaredTan95 edited a comment on issue #3367: agent support custom properties.

2019-08-30 Thread GitBox
JaredTan95 edited a comment on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-526565887 Due to this feature needs query protocol and UI changes. And 6.4.0 milestone will be released soon, So, I move this to the next version.

[skywalking] branch service_props updated (6502b81 -> 06362ce)

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 6502b81 Merge branch 'master' into service_props add 95ceacf Fix the zookeeper plugin has many

[GitHub] [skywalking] JaredTan95 commented on issue #3367: agent support custom properties.

2019-08-30 Thread GitBox
JaredTan95 commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-526565887 Due to this feature invokes query protocol and UI changes. And 6.4.0 milestone will be released soon, So, I move this to the next version.

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526562279 I think we have already rumning in this way. Right? @zhaoyuguang This is an automated message

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526560564 > I think the key is running all cases once because that is the case they facing after merged. is there possible to run all cases one by one right now?

[GitHub] [skywalking] stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526559470 > MQ_QUEUE means topic? If so, it is contained in OperationName. and it is a tag as well. You are right.

[GitHub] [skywalking] dmsolr commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
dmsolr commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526557855 > Consumers changed from the original pollOnce to pollForFetches, so I need to modify getMethodsMatcher to make it compatibility, Yes, I think so.

[GitHub] [skywalking] wu-sheng commented on issue #3379: witnessClasses can support not including the specified class?

2019-08-30 Thread GitBox
wu-sheng commented on issue #3379: witnessClasses can support not including the specified class? URL: https://github.com/apache/skywalking/issues/3379#issuecomment-526547566 No such thing. Read how classloader works you will know why.

[GitHub] [skywalking] wu-sheng closed issue #3379: witnessClasses can support not including the specified class?

2019-08-30 Thread GitBox
wu-sheng closed issue #3379: witnessClasses can support not including the specified class? URL: https://github.com/apache/skywalking/issues/3379 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] stalary opened a new issue #3379: witnessClasses can support not including the specified class?

2019-08-30 Thread GitBox
stalary opened a new issue #3379: witnessClasses can support not including the specified class? URL: https://github.com/apache/skywalking/issues/3379 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ]

[GitHub] [skywalking] stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526542001 > Do you make sure kafka-v1-plugin support V2? @dmsolr Yes, I went through some local tests and the producers didn't find any problems.

[GitHub] [skywalking] dmsolr commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
dmsolr commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526539578 @stalary Do you make sure kafka-v1-plugin support V2? I work a little on this, I found V1 is basically compatible with V2 without COMSUMER. Maybe we just

[GitHub] [skywalking] wu-sheng closed issue #3352: How to get the traceId in logback's LogstashTcpSocketAppender

2019-08-30 Thread GitBox
wu-sheng closed issue #3352: How to get the traceId in logback's LogstashTcpSocketAppender URL: https://github.com/apache/skywalking/issues/3352 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3352: How to get the traceId in logback's LogstashTcpSocketAppender

2019-08-30 Thread GitBox
wu-sheng commented on issue #3352: How to get the traceId in logback's LogstashTcpSocketAppender URL: https://github.com/apache/skywalking/issues/3352#issuecomment-526527800 Added. This is an automated message from the

[GitHub] [skywalking] wu-sheng closed issue #3378: ServiceAndEndpointRegisterClient execute fail

2019-08-30 Thread GitBox
wu-sheng closed issue #3378: ServiceAndEndpointRegisterClient execute fail URL: https://github.com/apache/skywalking/issues/3378 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng commented on issue #3378: ServiceAndEndpointRegisterClient execute fail

2019-08-30 Thread GitBox
wu-sheng commented on issue #3378: ServiceAndEndpointRegisterClient execute fail URL: https://github.com/apache/skywalking/issues/3378#issuecomment-526527617 The log shows clear, timeout. The server side has no response in 10s.

[skywalking-website] branch asf-site updated (cad0866 -> 96ad22c)

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard cad0866 Update asf-site new 96ad22c Update asf-site This update added new revisions after

[GitHub] [skywalking] kanon123 opened a new issue #3378: ServiceAndEndpointRegisterClient execute fail

2019-08-30 Thread GitBox
kanon123 opened a new issue #3378: ServiceAndEndpointRegisterClient execute fail URL: https://github.com/apache/skywalking/issues/3378 Please answer these questions before submitting your issue. - Why do you submit this issue? - [√]Bug ___ ### Bug - Which version of

[skywalking-website] branch master updated: modify blog (#55)

2019-08-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new a6aa18d modify blog (#55) a6aa18d

[GitHub] [skywalking-website] wu-sheng merged pull request #55: modify blog

2019-08-30 Thread GitBox
wu-sheng merged pull request #55: modify blog URL: https://github.com/apache/skywalking-website/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526518172 > Ok, now I upgrade the kafka cluster to 0.11.0.1, and use kafka-clients-2.0.1 test. It seems that the kafka-v1 plugin only has problems with consumption

[GitHub] [skywalking] stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526515982 > @stalary This seems Spring Kafka is adding something new, so it breaks the type cast. Only the SkyWalking instrumented class implement `EnhancedInstance`

[GitHub] [skywalking-website] innerpeacez opened a new pull request #55: modify blog

2019-08-30 Thread GitBox
innerpeacez opened a new pull request #55: modify blog URL: https://github.com/apache/skywalking-website/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526511516 @stalary This seems Spring Kafka is adding something new, so it breaks the type cast. Only the SkyWalking instrumented class implement `EnhancedInstance`

[GitHub] [skywalking] stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin

2019-08-30 Thread GitBox
stalary commented on issue #3369: [WIP] ADD kafka-v2 plugin URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526508906 `ERROR 2019-08-30 16:15:14:501 http-nio-19930-exec-3 InstMethodsInter : class[class org.apache.kafka.clients.producer.KafkaProducer] before method[doSend]

[skywalking] branch mesh-doc updated (030ccbe -> 4924e98)

2019-08-30 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch mesh-doc in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 030ccbe Merge branch 'master' into mesh-doc add 54614a0 Support gateway without agent (#3308)

[GitHub] [skywalking] wu-sheng closed issue #3218: Support Gateway w/o agent

2019-08-30 Thread GitBox
wu-sheng closed issue #3218: Support Gateway w/o agent URL: https://github.com/apache/skywalking/issues/3218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] wu-sheng merged pull request #3308: Support gateway without agent

2019-08-30 Thread GitBox
wu-sheng merged pull request #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch master updated: Support gateway without agent (#3308)

2019-08-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 54614a0 Support gateway without agent

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526506594 I think the key is running all cases once because that is the case they facing after merged.

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526502186 > That VM is very powerful. 16U32G on GCP. How many resources do you need? We expect as little as possible, because every night, we run 700+ tests,

[GitHub] [skywalking] wu-sheng commented on issue #3218: Support Gateway w/o agent

2019-08-30 Thread GitBox
wu-sheng commented on issue #3218: Support Gateway w/o agent URL: https://github.com/apache/skywalking/issues/3218#issuecomment-526502560 Anyone watching here, #3308 is going to be merged soon, if you have interests, welcome to use the master branch to test.

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526502186 > That VM is very powerful. 16U32G on GCP. How many resources do you need? We expect as little as possible, because every night, we run 700+ tests, which

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526501598 > That VM is very powerful. 16U32G on GCP. How many resources do you need? We expect as little as possible, because every night, we run 700+ tests, which

[skywalking-website] branch asf-site updated (aed3249 -> cad0866)

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard aed3249 Update asf-site new cad0866 Update asf-site This update added new revisions after

[skywalking-website] branch master updated: Remove whitespace

2019-08-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new fe9e4c4 Remove whitespace fe9e4c4

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526495778 That VM is very powerful. 16U32G on GCP. How many resources do you need? We expect as little as possible, because every night, we run 700+ tests, which have

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526494830 > > > > > > improvement > > > > > > Ok, i have add healthcheck for cassandra-server in docker-compose.yml file. let's try. > > Ok

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3308: Support gateway without agent

2019-08-30 Thread GitBox
wu-sheng commented on a change in pull request #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308#discussion_r319389386 ## File path: docs/en/setup/backend/uninstrumented-gateways.md ## @@ -0,0 +1,22 @@ +# Uninstrumented

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
SkyWalkingRobot commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526492020 Here is the [test

[GitHub] [skywalking] kezhenxu94 commented on issue #3308: Support gateway without agent

2019-08-30 Thread GitBox
kezhenxu94 commented on issue #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308#issuecomment-526491859 I also increase the timeout to wait for ES's readiness, CI failed for no particular reason in the several previous builds because of timeout

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3308: Support gateway without agent

2019-08-30 Thread GitBox
wu-sheng commented on a change in pull request #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308#discussion_r319386161 ## File path: docs/en/setup/backend/static-gateways.md ## @@ -0,0 +1,22 @@ +# Static Gateways/Proxies + +The word

[skywalking-website] branch asf-site updated (6ff6d15 -> aed3249)

2019-08-30 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 6ff6d15 Update asf-site new aed3249 Update asf-site This update added new revisions after

[skywalking-website] branch master updated: how to use skywalking agent (#54)

2019-08-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 5a54aa2 how to use skywalking

[GitHub] [skywalking-website] wu-sheng merged pull request #54: how to use skywalking agent

2019-08-30 Thread GitBox
wu-sheng merged pull request #54: how to use skywalking agent URL: https://github.com/apache/skywalking-website/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3308: Support gateway without agent

2019-08-30 Thread GitBox
kezhenxu94 commented on a change in pull request #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308#discussion_r319385064 ## File path: docs/en/setup/backend/static-gateways.md ## @@ -0,0 +1,22 @@ +# Static Gateways/Proxies + +The

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3308: Support gateway without agent

2019-08-30 Thread GitBox
kezhenxu94 commented on a change in pull request #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308#discussion_r319384576 ## File path: docs/en/setup/backend/static-gateways.md ## @@ -0,0 +1,22 @@ +# Static Gateways/Proxies + +The

[GitHub] [skywalking] zhaoyuguang commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
zhaoyuguang commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526487306 > > > improvement > > Ok, i have add healthcheck for cassandra-server in docker-compose.yml file. let's try. Ok

[GitHub] [skywalking] wu-sheng closed issue #3377: org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2ServiceInventoryCacheDAO - 71 [pool-13-thread-1] ERROR [] - Table "SERVICE_INVENTORY" n

2019-08-30 Thread GitBox
wu-sheng closed issue #3377: org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2ServiceInventoryCacheDAO - 71 [pool-13-thread-1] ERROR [] - Table "SERVICE_INVENTORY" not found; SQL statement: URL: https://github.com/apache/skywalking/issues/3377

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526485011 > improvement Ok, i have add healthcheck for cassandra-server in docker-compose.yml file. let's try.

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-08-30 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526483862 @stone-wlg CI improvement is in #3308. Don't worry about that. Have you figured out why integration test breaks?

[skywalking] branch mesh-doc updated (7c53d7b -> 030ccbe)

2019-08-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch mesh-doc in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 7c53d7b Enable ALS document add b3a2c64 Update powered-by.md (#3375) add 030ccbe Merge branch

[GitHub] [skywalking] wu-sheng merged pull request #3375: Update powered-by.md

2019-08-30 Thread GitBox
wu-sheng merged pull request #3375: Update powered-by.md URL: https://github.com/apache/skywalking/pull/3375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3308: Support gateway without agent

2019-08-30 Thread GitBox
wu-sheng commented on a change in pull request #3308: Support gateway without agent URL: https://github.com/apache/skywalking/pull/3308#discussion_r319368960 ## File path: docs/en/setup/backend/static-gateways.md ## @@ -0,0 +1,22 @@ +# Static Gateways/Proxies + +The word

  1   2   >